https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33332 --- Comment #1 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 148662 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=148662&action=edit Bug 33332: Fix formatting of TT comments to improve translations This patch reformats some Template::Toolkit multi-line comments in html_helpers.inc so that each line is commented separately. This seems to prevent the translation tool from putting the comments into the po file. To test, apply the patch and confirm that pages which use the breadcrumbs and tabs WRAPPER directives still work correctly: - Breadcrumbs: staff client home page, about page, error page. - Tabs: Administration -> Library transfer limits or circulation alerts. - To test translatability, run the translation tool for any language, e.g. perl misc/translator/translate update fr-FR Search the regenerated po file (in this example misc/translator/po/fr-FR-staff-prog.po) to confirm that there is no instance of something like "[%%# BOOTSTRAP BREADCRUMBS WRAPPER USAGE" -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33332 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #148662|0 |1 is obsolete| | --- Comment #2 from David Nind <david@davidnind.com> --- Created attachment 149285 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=149285&action=edit Bug 33332: Fix formatting of TT comments to improve translations This patch reformats some Template::Toolkit multi-line comments in html_helpers.inc so that each line is commented separately. This seems to prevent the translation tool from putting the comments into the po file. To test, apply the patch and confirm that pages which use the breadcrumbs and tabs WRAPPER directives still work correctly: - Breadcrumbs: staff client home page, about page, error page. - Tabs: Administration -> Library transfer limits or circulation alerts. - To test translatability, run the translation tool for any language, e.g. perl misc/translator/translate update fr-FR Search the regenerated po file (in this example misc/translator/po/fr-FR-staff-prog.po) to confirm that there is no instance of something like "[%%# BOOTSTRAP BREADCRUMBS WRAPPER USAGE" Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33332 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia@bugs.koha-communit |katrin.fischer@bsz-bw.de |y.org | -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33332 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #149285|0 |1 is obsolete| | --- Comment #4 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 149315 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=149315&action=edit Bug 33332: Fix formatting of TT comments to improve translations This patch reformats some Template::Toolkit multi-line comments in html_helpers.inc so that each line is commented separately. This seems to prevent the translation tool from putting the comments into the po file. To test, apply the patch and confirm that pages which use the breadcrumbs and tabs WRAPPER directives still work correctly: - Breadcrumbs: staff client home page, about page, error page. - Tabs: Administration -> Library transfer limits or circulation alerts. - To test translatability, run the translation tool for any language, e.g. perl misc/translator/translate update fr-FR Search the regenerated po file (in this example misc/translator/po/fr-FR-staff-prog.po) to confirm that there is no instance of something like "[%%# BOOTSTRAP BREADCRUMBS WRAPPER USAGE" Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33332 --- Comment #5 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Pushed to master for 23.05. Nice work everyone, thanks! -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33332 --- Comment #6 from Matt Blenkinsop <matt.blenkinsop@ptfs-europe.com> --- Nice work everyone! Pushed to stable for 22.11.x -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33332 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also|https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=33652 | -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33332 Bug 33332 depends on bug 32571, which changed state. Bug 32571 Summary: Use template wrapper to build tabbed components https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32571 What |Removed |Added ---------------------------------------------------------------------------- Status|RESOLVED |REOPENED Resolution|FIXED |--- -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33332 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=16559 -- You are receiving this mail because: You are watching all bug changes.