[Bug 8593] New: bug for html
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8593 Priority: P5 - low Change sponsored?: --- Bug ID: 8593 CC: gmcharlt@gmail.com Assignee: koha-bugs@lists.koha-community.org Summary: bug for html Severity: enhancement Classification: Unclassified OS: All Reporter: jorgia_m_kelsey@hotmail.com Hardware: All Status: NEW Version: unspecified Component: Staff Client Product: Koha Created attachment 11436 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=11436&action=edit edited intranet-main file -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8593 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Version|unspecified |master Summary|bug for html |Add unique IDs to pending | |approval markup on staff | |client home page -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8593 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #11436|0 |1 is obsolete| | --- Comment #1 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 11442 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=11442&action=edit [SIGNED-OFF] Bug 8593 - Add unique IDs to pending approval markup on staff client home page edited the intranet main-tt file. updated "suggestions pending". (w box) http://bugs.koha-community.org/show_bug.cgi?id=8593 Signed-off-by: Owen Leonard <oleonard@myacpl.org> -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8593 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8593 --- Comment #2 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 11443 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=11443&action=edit Bug 8593 - Follow-up - Add unique IDs to pending approval markup on staff client home page This patch adds similar IDs to the tags and comments <div> -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8593 Jorgia <jorgia_m_kelsey@hotmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs@lists.koha-commun |jorgia_m_kelsey@hotmail.com |ity.org | --- Comment #3 from Jorgia <jorgia_m_kelsey@hotmail.com> --- Created attachment 11462 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=11462&action=edit edited intranet-main file (box version) version of home page with edited suggestions pending w box around "suggestions pending" -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8593 --- Comment #4 from Jorgia <jorgia_m_kelsey@hotmail.com> --- Created attachment 11463 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=11463&action=edit edited intranet-main file (without box version) Main staff page css script. Version of suggestions pending layout 2. (without box surrounding "suggestions pending" -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8593 Jorgia <jorgia_m_kelsey@hotmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #11443|0 |1 is obsolete| | --- Comment #5 from Jorgia <jorgia_m_kelsey@hotmail.com> --- Created attachment 11464 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=11464&action=edit signed off -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8593 Chris Cormack <chris@bigballofwax.co.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #11462|0 |1 is obsolete| | --- Comment #6 from Chris Cormack <chris@bigballofwax.co.nz> --- Created attachment 11466 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=11466&action=edit bug 8593: css file for the box version of "suggestions pending" -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8593 Chris Cormack <chris@bigballofwax.co.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #11463|0 |1 is obsolete| | --- Comment #7 from Chris Cormack <chris@bigballofwax.co.nz> --- Created attachment 11468 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=11468&action=edit Bug 8593. css script version of "suggestions pending" without box -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8593 --- Comment #8 from Jared Camins-Esakov <jcamins@cpbibliography.com> --- I am confused by the patches on this bug. Does one (or more) supersede one (or more) of the others? It seems like the second two might be alternatives, where one or the other can be used, but not both. Is this true? Which one is being proposed for inclusion in Koha? -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8593 Chris Cormack <chris@bigballofwax.co.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |chris@bigballofwax.co.nz --- Comment #9 from Chris Cormack <chris@bigballofwax.co.nz> --- The first 2 are needed, then they next 2 are alternatives we can't decide which look we prefer. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8593 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #11464|signed off |[SIGNED-OFF] Bug 8593 - description| |Follow-up - Add unique IDs | |to pending approval -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8593 --- Comment #10 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 11613 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=11613&action=edit Screenshot of CSS option 1 -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8593 --- Comment #11 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 11616 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=11616&action=edit Screenshot of CSS option 2 -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8593 --- Comment #12 from Owen Leonard <oleonard@myacpl.org> --- I prefer the display as we have it now. The markup updates makes it easy for someone to add their own custom style to these links, and I think we should leave it at that for now. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8593 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off --- Comment #13 from Owen Leonard <oleonard@myacpl.org> --- I'm going to mark this as "signed off" so that the first couple of patches can go through QA. If anyone wants to argue for the inclusion of one of the attached CSS revisions they can comment and add their signoff. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8593 Ian Walls <koha.sekjal@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA CC| |koha.sekjal@gmail.com --- Comment #14 from Ian Walls <koha.sekjal@gmail.com> --- First two patches are template only changes adding IDs to tags. Marking them Passed QA. The debate of what CSS styling to do with them can be resolved separately. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8593 Paul Poulain <paul.poulain@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master CC| |paul.poulain@biblibre.com Version|master |rel_3_10 --- Comment #15 from Paul Poulain <paul.poulain@biblibre.com> --- (In reply to comment #14)
First two patches are template only changes adding IDs to tags. Marking them Passed QA. The debate of what CSS styling to do with them can be resolved separately.
I agree with Owen, and this we don't need to push more than the 2 first patches. 2 patch pushed -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8593 Chris Cormack <chris@bigballofwax.co.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |Pushed to Stable Version|rel_3_10 |rel_3_8 Severity|enhancement |minor --- Comment #16 from Chris Cormack <chris@bigballofwax.co.nz> --- With the css, this drops back to a bug fix. Adding ids allows people to style the page with no risk of any harm. Pushed to 3.8.x, will be in 3.8.5 -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org