[Bug 8573] New: Translation difficult in picture-upload.tt due to nested sentence in if/foreach/if/elsif - construction
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8573 Priority: P5 - low Change sponsored?: --- Bug ID: 8573 CC: frederic@tamil.fr Assignee: koha-bugs@lists.koha-community.org Summary: Translation difficult in picture-upload.tt due to nested sentence in if/foreach/if/elsif - construction Severity: normal Classification: Unclassified OS: All Reporter: veron@veron.ch Hardware: All Status: NEW Version: master Component: translate.koha-community.org Product: Koha The following code in koha-tmpl/intranet-tmpl/prog/en/modules/tools/picture-upload.tt leads in Pootle to a situation where a correct ranslation is simply not possible: ------------ [% IF ( COUNT.TCOUNTS ) %]<li>[% COUNT.TCOUNTS %] image(s) moved into the database:</li>[% END %] [% FOREACH filename IN COUNT.filenames %] <li>[% filename.source %] - Cardnumber: [% filename.cardnumber %] [% IF ( filename.filerrors ) %]<br /> <b>WARNING:</b> This image <i>not</i> imported because [% FOREACH filerror IN filename.filerrors %] [% IF ( filerror.DBERR ) %]the database returned an error. Please refer to the error log for more details.</li> [% ELSIF ( filerror.IMGEXISTS ) %]this patron does not exist in the database.</li> [% ELSIF ( filerror.MIMERR ) %]the image format is unrecognized.</li> [% ELSIF ( filerror.CORERR ) %]the image file is corrupted.</li> [% ELSIF ( filerror.OPNERR ) %]Koha was unable to open the image for reading.</li> [% ELSIF ( filerror.OVRSIZ ) %]the image file is too big.</li> [% ELSIF ( filerror.CRDFIL ) %]the [% filerror.CRDFIL %] is missing.</li> [% ELSE %]of an unknown error. Please refer to the error log for more details.</li>[% END %] [% END %] [% ELSE %] imported successfully.</li> [% END %] [% END %] ---------------------- Pootle separates this poorly: "imported because %s %sthe database returned an error. Please refer to the error log for more details." "imported because" then is missing for all following if/elsif branches, leading to mutilated sentences. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8573 Marc Véron <veron@veron.ch> changed: What |Removed |Added ---------------------------------------------------------------------------- Priority|P5 - low |P3 Assignee|koha-bugs@lists.koha-commun |veron@veron.ch |ity.org | -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8573 Marc Véron <veron@veron.ch> changed: What |Removed |Added ---------------------------------------------------------------------------- Component|translate.koha-community.or |Templates |g | Assignee|veron@veron.ch |oleonard@myacpl.org -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8573 --- Comment #1 from Marc Véron <veron@veron.ch> --- Created attachment 11375 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=11375&action=edit Bug 8573 - Translation difficult in picture-upload.tt due to nested sentence in if/foreach/if/elsif - construction Text could not be correctly translated due to poor parsing of nested sentences in Pootle. *Sentences de-nested to have whole sentence in each if /elsif branch *Changed WARNING to ERROR because it is an *Error* during upload. *Wording simplified. In one case added hint to refer to online help (size). This way text should be easier to be translated in Pootle. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8573 Marc Véron <veron@veron.ch> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8573 Marc Véron <veron@veron.ch> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |veron@veron.ch -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8573 Julian Maurice <julian.maurice@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Failed QA CC| |julian.maurice@biblibre.com --- Comment #2 from Julian Maurice <julian.maurice@biblibre.com> --- The patch does what it says. But there are 2 typos: Two consecutive <b> tags here: [% ELSIF ( filerror.OPNERR ) %]<b><b>ERROR:</b> and a remaining WARNING here (one <b> tag should be removed also): [% ELSE %]<b>WARNING:<b>ERROR:</b> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8573 Marc Véron <veron@veron.ch> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #11375|0 |1 is obsolete| | --- Comment #3 from Marc Véron <veron@veron.ch> --- Created attachment 11517 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=11517&action=edit Bug 8573 - Translation difficult in picture-upload.tt due to nested sentence in if/foreach/if/elsif - construction Text could not be correctly translated due to poor parsing of nested sentences in Pootle. *Sentences de-nested to have whole sentence in each if /elsif branch *Cleaned up <li></li> handling: moved closing </li> outside the for each loop to prevent orphaned closing </li>s. *Chanched indentation for better readibility *Changed WARNING to ERROR because it is an *Error* during upload. *Wording simplified (for translation). *In one case added hint to refer to online help (size). This way text should be easier to be translated in Pootle. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8573 Marc Véron <veron@veron.ch> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #11517|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8573 --- Comment #4 from Marc Véron <veron@veron.ch> --- Created attachment 11518 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=11518&action=edit Bug 8573 - Translation difficult in picture-upload.tt due to nested sentence in if/foreach/if/elsif - construction Text could not be correctly translated due to poor parsing of nested sentences in Pootle. *Sentences de-nested to have whole sentence in each if /elsif branch *Cleaned up <li></li> handling: moved closing </li> outside the for each loop to prevent orphaned closing </li>s. *Changed indentation for better readibility *Changed WARNING to ERROR because it is an *Error* during upload. *Wording simplified (for translation). *In one case added hint to refer to online help (size). This way text should be easier to be translated in Pootle. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8573 Marc Véron <veron@veron.ch> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8573 Julian Maurice <julian.maurice@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #11518|0 |1 is obsolete| | --- Comment #5 from Julian Maurice <julian.maurice@biblibre.com> --- Created attachment 11523 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=11523&action=edit [SIGNED-OFF] Bug 8573 - Translation difficult in picture-upload.tt due to nested sentence in if/foreach/if/elsif - construction Text could not be correctly translated due to poor parsing of nested sentences in Pootle. *Sentences de-nested to have whole sentence in each if /elsif branch *Cleaned up <li></li> handling: moved closing </li> outside the for each loop to prevent orphaned closing </li>s. *Changed indentation for better readibility *Changed WARNING to ERROR because it is an *Error* during upload. *Wording simplified (for translation). *In one case added hint to refer to online help (size). This way text should be easier to be translated in Pootle. Signed-off-by: Julian Maurice <julian.maurice@biblibre.com> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8573 Julian Maurice <julian.maurice@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8573 Mason James <mtj@kohaaloha.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA CC| |mtj@kohaaloha.com --- Comment #6 from Mason James <mtj@kohaaloha.com> --- (In reply to comment #5)
Created attachment 11523 [details] [SIGNED-OFF] Bug 8573 - Translation difficult in picture-upload.tt due to Signed-off-by: Julian Maurice <julian.maurice@biblibre.com>
patch looks good, passing QA mason@xen1:~/git/head$ koha-qa.pl * 5475444 Bug 8573 - Translation difficult in picture-upload.tt due to nested sentence in if/foreach/if/elsif - construction koha-tmpl/intranet-tmpl/prog/en/modules/tools/picture-upload.tt - perlcritic-progressive tests... OK - perl -c syntax tests... OK - xt/tt_valid.t tests... OK - xt/author/valid-template.t tests... OK -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8573 Chris Cormack <chris@bigballofwax.co.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |chris@bigballofwax.co.nz --- Comment #7 from Chris Cormack <chris@bigballofwax.co.nz> --- Pushed to 3.8.x, will be in 3.8.4 -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8573 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|oleonard@myacpl.org |veron@veron.ch -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8573 Paul Poulain <paul.poulain@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master CC| |paul.poulain@biblibre.com Version|master |rel_3_8 --- Comment #8 from Paul Poulain <paul.poulain@biblibre.com> --- Patch pushed to master -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8573 Chris Cormack <chris@bigballofwax.co.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |Pushed to Stable -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org