[Bug 11646] New: Untranslatable confirm popup in field 006 and 008 builders
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11646 Bug ID: 11646 Summary: Untranslatable confirm popup in field 006 and 008 builders Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: I18N/L10N Assignee: koha-bugs@lists.koha-community.org Reporter: pasi.kallinen@pttk.fi QA Contact: testopia@bugs.koha-community.org CC: frederic@tamil.fr marc21_field_006.tt and marc21_field_008.tt have the following confirmation popup, which is not picked up for translation: confirm('Show values for \'' + form.material_type.options[form.material_type.selectedIndex].text + '\' material type?')) -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11646 Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |bgkriegel@gmail.com Assignee|koha-bugs@lists.koha-commun |bgkriegel@gmail.com |ity.org | Severity|enhancement |normal -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11646 --- Comment #1 from Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> --- Created attachment 26521 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=26521&action=edit Bug 11646 - Untranslatable confirm popup in field 006 and 008 builders This patch MARC21 modifies value builders 006 and 008 to make confirm popup translatable To test: 1) Update po files for your preferred language, xx-YY cd misc/translator; perl translate update xx-YY 2) Check that confirm string is NOT present egrep -B3 "Show values for|material type\?" po/xx-YY*po 3) Apply the patch 4) Repeat 1) 5) Repeat 2), now the strings are present Also check that english or translated popup is right -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11646 Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11646 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off Patch complexity|--- |Small patch -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11646 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #26521|0 |1 is obsolete| | --- Comment #2 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 27370 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=27370&action=edit [SIGNED-OFF] Bug 11646 - Untranslatable confirm popup in field 006 and 008 builders This patch MARC21 modifies value builders 006 and 008 to make confirm popup translatable To test: 1) Update po files for your preferred language, xx-YY cd misc/translator; perl translate update xx-YY 2) Check that confirm string is NOT present egrep -B3 "Show values for|material type\?" po/xx-YY*po 3) Apply the patch 4) Repeat 1) 5) Repeat 2), now the strings are present Also check that english or translated popup is right Signed-off-by: Owen Leonard <oleonard@myacpl.org> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11646 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11646 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #27370|0 |1 is obsolete| | --- Comment #3 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 27384 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=27384&action=edit [PASSED QA] Bug 11646 - Untranslatable confirm popup in field 006 and 008 builders This patch MARC21 modifies value builders 006 and 008 to make confirm popup translatable To test: 1) Update po files for your preferred language, xx-YY cd misc/translator; perl translate update xx-YY 2) Check that confirm string is NOT present egrep -B3 "Show values for|material type\?" po/xx-YY*po 3) Apply the patch 4) Repeat 1) 5) Repeat 2), now the strings are present Also check that english or translated popup is right Signed-off-by: Owen Leonard <oleonard@myacpl.org> Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de> Works as described. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11646 Galen Charlton <gmcharlt@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master CC| |gmcharlt@gmail.com --- Comment #4 from Galen Charlton <gmcharlt@gmail.com> --- Pushed to master. Thanks, Bernardo! -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11646 Fridolin SOMERS <fridolyn.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |Pushed to Stable CC| |fridolyn.somers@biblibre.co | |m --- Comment #5 from Fridolin SOMERS <fridolyn.somers@biblibre.com> --- Pushed to 3.14.x, will be in 3.14.11 -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org