[Bug 28993] New: Switch magnifying class in staff detail pages to FA icon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28993 Bug ID: 28993 Summary: Switch magnifying class in staff detail pages to FA icon Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Templates Assignee: oleonard@myacpl.org Reporter: katrin.fischer@bsz-bw.de QA Contact: testopia@bugs.koha-community.org It appears that bug 13327 switched the magnifying class shown on authority links in the OPAC detail pages to a FA icon. It would be nice to make the same change to the staff detail pages. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28993 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28993 --- Comment #1 from Owen Leonard <oleonard@myacpl.org> --- I'd like to also replace the image on the authority detail page but I'm confused by this section of the template (authorities/detail.tt): [% IF ( subfiel.link ) %] <a class="authlink" href="/cgi-bin/koha/catalogue/search.pl?op=do_search&marclist=[% subfiel.link | uri %]&operator==&type=intranet&value=[% subfiel.marc_value |url %]"> <i class="fa fa-search" aria-label="Search on [% subfiel.marc_value | html %]" title="Search on [% subfiel.marc_value | html %]"></i> </a> [% END %] [% IF ( subfiel.authority ) %] <a href="/cgi-bin/koha/authorities/detail.pl?authid=[% subfiel.authority | uri %]" class="button">Auth</a> [% END %] Are subfiel.link and subfiel.authority really relevant to an authority record? I'm wondering if it's actually copy and paste from the MARC view. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28993 --- Comment #2 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Authorities can also be linked to each other hierarchically - could that have to do with it? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28993 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff Patch complexity|--- |Small patch -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28993 --- Comment #3 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 129355 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=129355&action=edit Bug 28993: Switch magnifying class in staff detail pages to FA icon This patch modifies the staff interface's bibliographic detail XSL so that a Font Awesome is used instead of a magnifying glass image when listing authority subject headings. The patch also corrects two other places where the image is used so that the image can be removed. Some markup from authorities.detail.tt is removed because it appears to be unused (a copy and paste from catalogue/detail.tt). To test, apply the patch and rebuild the staff interface CSS (https://wiki.koha-community.org/wiki/Working_with_SCSS_in_the_OPAC_and_staff...). - To view the changes to the staff interface bibliographic detail page, locate a record which has at least one subject heading which is linked to a subject authority record. - The subject heading link should be followed by a magifying glass (Font Awesome) icon which links to the authority record's detail page. - View a similar change to the MARC detail page for the record. Confirm that the subject headings are followed by a link to the authority detail page. - Follow the authority search link to locate and view an authority record. The information on the authority detail page should be correct. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28993 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28993 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #129355|0 |1 is obsolete| | --- Comment #4 from David Nind <david@davidnind.com> --- Created attachment 129715 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=129715&action=edit Bug 28993: Switch magnifying class in staff detail pages to FA icon This patch modifies the staff interface's bibliographic detail XSL so that a Font Awesome is used instead of a magnifying glass image when listing authority subject headings. The patch also corrects two other places where the image is used so that the image can be removed. Some markup from authorities.detail.tt is removed because it appears to be unused (a copy and paste from catalogue/detail.tt). To test, apply the patch and rebuild the staff interface CSS (https://wiki.koha-community.org/wiki/Working_with_SCSS_in_the_OPAC_and_staff...). - To view the changes to the staff interface bibliographic detail page, locate a record which has at least one subject heading which is linked to a subject authority record. - The subject heading link should be followed by a magifying glass (Font Awesome) icon which links to the authority record's detail page. - View a similar change to the MARC detail page for the record. Confirm that the subject headings are followed by a link to the authority detail page. - Follow the authority search link to locate and view an authority record. The information on the authority detail page should be correct. Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28993 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28993 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #129715|0 |1 is obsolete| | --- Comment #5 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 129981 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=129981&action=edit Bug 28993: Switch magnifying class in staff detail pages to FA icon This patch modifies the staff interface's bibliographic detail XSL so that a Font Awesome is used instead of a magnifying glass image when listing authority subject headings. The patch also corrects two other places where the image is used so that the image can be removed. Some markup from authorities.detail.tt is removed because it appears to be unused (a copy and paste from catalogue/detail.tt). To test, apply the patch and rebuild the staff interface CSS (https://wiki.koha-community.org/wiki/Working_with_SCSS_in_the_OPAC_and_staff...). - To view the changes to the staff interface bibliographic detail page, locate a record which has at least one subject heading which is linked to a subject authority record. - The subject heading link should be followed by a magifying glass (Font Awesome) icon which links to the authority record's detail page. - View a similar change to the MARC detail page for the record. Confirm that the subject headings are followed by a link to the authority detail page. - Follow the authority search link to locate and view an authority record. The information on the authority detail page should be correct. Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28993 --- Comment #6 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Especially like the newly added aria-label :) -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28993 Fridolin Somers <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Switch magnifying class in |Switch magnifying glass in |staff detail pages to FA |staff detail pages to FA |icon |icon CC| |fridolin.somers@biblibre.co | |m -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28993 --- Comment #7 from Fridolin Somers <fridolin.somers@biblibre.com> --- magnifying "glass" 🔍 I'll fix commit message when pushing to master -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28993 Fridolin Somers <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to master Version(s)| |22.05.00 released in| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28993 --- Comment #8 from Fridolin Somers <fridolin.somers@biblibre.com> --- Pushed to master for 22.05, thanks to everybody involved 🦄 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28993 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |kyle@bywatersolutions.com Status|Pushed to master |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28993 Jonathan Druart <jonathan.druart+koha@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |20362 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20362 [Bug 20362] Direct link to authority records missing in staff detail view (1xx, 7xx) -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon@bugs.koha-community.org