https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39624 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |27945 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27945 [Bug 27945] Limit the number of active article requests per patron category -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39624 --- Comment #1 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- Created attachment 180901 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=180901&action=edit Bug 39624: Add patron category * (All) to open_article_requests limit Test plan: Go to smart rules. Add a limit for All. Refresh and check if it is still there. Enable ArticleRequests and verify if the limit is working. Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39624 --- Comment #3 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- (In reply to David Nind from comment #2)

Could you please expand the test plan, it is not clear to me at all.

Where do you add a "limit for All"?

There is no "open_article_requests" on the page (Koha administration > Patrons and circulation > Circulation and fine rules).

Hi David, Scroll down on the admin/smart-rules.pl form. Look for: Default open article requests limit -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39624 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Text to go in the| |This fixes the "Default release notes| |open article requests | |limit" for the circulation | |and fine rules, so that the | |patron category dropdown | |list now includes an "All" | |option. | | | |Previously, there | |was no "All" patron | |category option, and you | |needed to set rules | |individually for each | |patron category. | | | |(This | |requires the | |ArticleRequests system | |preference enabled.) Summary|Add |Add an "All" patron |open_article_requests_limit |category option for the |for patron category 'All' |"Default open article | |requests limit" circulation | |rules Status|Needs Signoff |Failed QA --- Comment #4 from David Nind <david@davidnind.com> --- I have Failed QA. With the patch applied, you cannot delete the "All" rule: 1. If you attempt to delete the "All" rule: the page refreshes, but the rule is still there. 2. It works correctly before the patch for individual patron category rules. 3. It still works correctly after the patch for individual patron category rules. 4. It does not work after the patch for the "All" rule. In addition, both before and after the patch, when cancelling article requests using the staff interface, a progress spinner is displayed (this should probably be a separate bug): 1. Place some article requests 2. Go to Circulation > Patron request > Article requests 3. Select a request and use either the "Cancel request" option in the action column or the "Actions > Cancel request" button next to the filters 4. Note that a progress spinner is displayed, and the page does not refresh 5. If you refresh the page (or click the sidebar menu), the cancelled request is no longer shown Testing notes (using KTD): 1. Enable the ArticleRequests system preference (without this, you cannot see the settings for "Default open article requests limit" in step 3. 2. Go to Koha administration > Patrons and circulation > Circulation and fine rules. 3. Go to the section on the page with the heading "Default open article requests limit". 4. Note that for the dropdown list for "Patron category" there is no "All" option. 5. Apply the patch. 6. Repeat steps 3 and 4 and note that there is now an "All" option. 7. Test that the "All" limit works as expected: 7.1 Add an "All" limit for article requests: - Patron category: select "All" (the default) - Total article requests: enter "2" - Click "+ Add" 7.2 Place multiple requests in the OPAC, for example on record 5, Perl best practices, for a patron (I used the koha user): - Once the limit is exceeded (on your third request) you should get a message "You reached your open article requests limit." 8. Test that the "All" limit and a different limit for another patron category works as expected: 8.1 Cancel all the requests already placed 8.2 Add a limit for another patron category, I used "Staff" - Patron category: select "Staff" - Total article requests: enter "1" - Click "+ Add" (We now have two rules - All = 2, Staff = 1) 8.3 As the koha user, attempt to place 2 holds: ==> On the second request you should get the message "You reached your open article requests limit." 8.4 As another user in any patron category except "Staff", attempt to place 3 holds (you will need to change the password so you can log in to the OPAC, I used Mary Burton): ==> On the third request you should get the message "You reached your open article requests limit." -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39624 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39624 --- Comment #6 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- (In reply to David Nind from comment #4) Thx for testing.

With the patch applied, you cannot delete the "All" rule: 1. If you attempt to delete the "All" rule: the page refreshes, but the rule is still there. 4. It does not work after the patch for the "All" rule.

Should be fixed now.

In addition, both before and after the patch, when cancelling article requests using the staff interface, a progress spinner is displayed (this should probably be a separate bug): 1. Place some article requests 2. Go to Circulation > Patron request > Article requests 3. Select a request and use either the "Cancel request" option in the action column or the "Actions > Cancel request" button next to the filters 4. Note that a progress spinner is displayed, and the page does not refresh 5. If you refresh the page (or click the sidebar menu), the cancelled request is no longer shown

I saw the spinner a very short time. Request was cancelled. Seems to be OK for me. Not sure, but do you need to run build resources again for js stuff? -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39624 Brendan Gallagher <brendan@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #180901|0 |1 is obsolete| | --- Comment #7 from Brendan Gallagher <brendan@bywatersolutions.com> --- Created attachment 180997 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=180997&action=edit Bug 39624: Add patron category * (All) to open_article_requests limit Test plan: Go to smart rules. Add a limit for All. Refresh and check if it is still there. Enable ArticleRequests and verify if the limit is working. Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> Signed-off-by: Brendan Gallagher <brendan@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39624 Lucas Gass (lukeg) <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia@bugs.koha-communit |lucas@bywatersolutions.com |y.org | CC| |lucas@bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39624 Lucas Gass (lukeg) <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #180998|0 |1 is obsolete| | --- Comment #10 from Lucas Gass (lukeg) <lucas@bywatersolutions.com> --- Created attachment 181138 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=181138&action=edit Bug 39624: (follow-up) Fix deleting the All line Test plan: Add a line for All categories. Delete it again. Check when refreshing the page. Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> Signed-off-by: Brendan Gallagher <brendan@bywatersolutions.com> Signed-off-by: Lucas Gass <lucas@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39624 --- Comment #12 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- (In reply to Lucas Gass (lukeg) from comment #10)

Signed-off-by: Lucas Gass <lucas@bywatersolutions.com>

Thanks! Did you mean to pass QA too btw ? -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39624 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Severity|minor |enhancement --- Comment #14 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- I agree that this is an improvement, but I am not sure it qualifies as a bug fix. :) Still up to to RMaints to backport anyway! -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39624 --- Comment #15 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Pushed for 25.05! Well done everyone, thank you! -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39624 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Text to go in the|This fixes the "Default |This fixes the "Default release notes|open article requests |open article requests |limit" for the circulation |limit" for the circulation |and fine rules, so that the |and fine rules, so that the |patron category drop-down |patron category drop-down |list has an "All" option. |list has an "All" option. | | |Previously, there was no |Previously, there was no |"All" patron category |"All" patron category |option, and you needed to |option, and you needed to |set rules individually for |set rules individually for |each patron category. |each patron category. | | |This requires the |This requires the |ArticleRequests system |`ArticleRequests` system |preference enabled. |preference enabled. -- You are receiving this mail because: You are watching all bug changes.