[Bug 39265] New: Self registration: Hide library from the form if there is only one library
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39265 Bug ID: 39265 Summary: Self registration: Hide library from the form if there is only one library Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: OPAC Assignee: oleonard@myacpl.org Reporter: lari.taskula@hypernova.fi QA Contact: testopia@bugs.koha-community.org In a single-branch Koha installation it makes no sense to have library selection dropdown in the self registration form. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39265 Lari Taskula <lari.taskula@hypernova.fi> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |27618, 29859 --- Comment #1 from Lari Taskula <lari.taskula@hypernova.fi> --- The drop-down was hidden in Bug 27618 but reintroduced by regression from Bug 29859. https://github.com/Koha-Community/Koha/commit/d02e91f2694b7642282e124a871a8b... Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27618 [Bug 27618] Don't show dropdown if PatronSelfRegistrationLibraryList only has one library https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29859 [Bug 29859] Favor iterators over as_list -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39265 Lari Taskula <lari.taskula@hypernova.fi> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|oleonard@myacpl.org |lari.taskula@hypernova.fi -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39265 Lari Taskula <lari.taskula@hypernova.fi> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39265 --- Comment #2 from Lari Taskula <lari.taskula@hypernova.fi> --- Created attachment 179017 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=179017&action=edit Bug 39265: Hide library drop-down from opac-memberentry if there is only one library To test, apply the patch and enable PatronSelfRegistration. - Modify the PatronSelfRegistrationLibraryList system preference to include only one library. - Go to the self-registratoin page in the OPAC. - Under "Home library," you should see the library name. If you inspect the source you should see the library branchcode in a hidden form. - Confirm that the form submission includes the correct library information. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39265 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Trivial patch Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39265 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #179017|0 |1 is obsolete| | --- Comment #3 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 179018 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=179018&action=edit Bug 39265: Hide library drop-down from opac-memberentry if there is only one library To test, apply the patch and enable PatronSelfRegistration. - Modify the PatronSelfRegistrationLibraryList system preference to include only one library. - Go to the self-registratoin page in the OPAC. - Under "Home library," you should see the library name. If you inspect the source you should see the library branchcode in a hidden form. - Confirm that the form submission includes the correct library information. Signed-off-by: Owen Leonard <oleonard@myacpl.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39265 Jonathan Druart <jonathan.druart@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39265 Jonathan Druart <jonathan.druart@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #179018|0 |1 is obsolete| | --- Comment #4 from Jonathan Druart <jonathan.druart@gmail.com> --- Created attachment 179166 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=179166&action=edit Bug 39265: Hide library drop-down from opac-memberentry if there is only one library To test, apply the patch and enable PatronSelfRegistration. - Modify the PatronSelfRegistrationLibraryList system preference to include only one library. - Go to the self-registratoin page in the OPAC. - Under "Home library," you should see the library name. If you inspect the source you should see the library branchcode in a hidden form. - Confirm that the form submission includes the correct library information. Signed-off-by: Owen Leonard <oleonard@myacpl.org> Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39265 --- Comment #5 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- (In reply to Lari Taskula from comment #1)
The drop-down was hidden in Bug 27618 but reintroduced by regression from Bug 29859.
https://github.com/Koha-Community/Koha/commit/ d02e91f2694b7642282e124a871a8b6ebcde1055#diff- d9a6af2df2cc64675ffd2b565a4dcc7865d4be977545d5dd2b5ad1b4c4532b80L248
Thanks for this detective work! I had a feeling we had this before, this really helps. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39265 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to main Version(s)| |25.05.00 released in| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39265 --- Comment #6 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Pushed for 25.05! Well done everyone, thank you! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39265 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Version|unspecified |Main Text to go in the| |In a single-branch Koha release notes| |installation it makes no | |sense to have library | |selection drop-down in the | |self-registration form. | |This patch makes it so it | |no longer displays in that | |case. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39265 Fridolin Somers <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to main |Needs documenting CC| |fridolin.somers@biblibre.co | |m --- Comment #7 from Fridolin Somers <fridolin.somers@biblibre.com> --- Enhancement not pushed to 24.11.x -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org