[Bug 36374] New: The bookings modal JS should be tidied
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36374 Bug ID: 36374 Summary: The bookings modal JS should be tidied Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Architecture, internals, and plumbing Assignee: koha-bugs@lists.koha-community.org Reporter: martin.renvoize@ptfs-europe.com QA Contact: testopia@bugs.koha-community.org Depends on: 29002 For some reason my editor didn't seem to be tidying for JS when I wrote the bookings modal code... as this is still a pretty new area, I think we should run a tidy over it to get it consistent now before we continue working on it. Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29002 [Bug 29002] Add ability to book items ahead of time -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36374 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs@lists.koha-commun |martin.renvoize@ptfs-europe |ity.org |.com -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36374 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Severity|enhancement |minor -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36374 Jonathan Druart <jonathan.druart@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart@gmail.com --- Comment #1 from Jonathan Druart <jonathan.druart@gmail.com> --- Not reported yet, but I have a list of JS files I would like to keep tidied as well (under fetch dir). We need a QA tests + unit test + git hook to deal with that. Like we do for vue files. We will need to have an explicit list however as more of our JS files are not tidied. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36374 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |35813, 36120 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35813 [Bug 35813] When placing a booking, we should feedback successful placements https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36120 [Bug 36120] Add pickup locations to Bookings -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36374 --- Comment #2 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 163555 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=163555&action=edit Bug 36374: Tidy place_booking_modal.js according to our prettier config This was somehow missed when the file was first added.. my mistake. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36374 --- Comment #3 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 163556 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=163556&action=edit Bug 36374: Move modal js under /modals I also didn't stick to the more recent switch to putting modal js under a /modals dirctory. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36374 --- Comment #4 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Jonathan highlighted to me that my tidy config isn't the same as their using in Vue.. so I'll post a new patch once I've got my configs working as expected -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36374 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #163555|0 |1 is obsolete| | --- Comment #5 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 163558 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=163558&action=edit Bug 36374: Tidy place_booking_modal.js according to our prettier config This was somehow missed when the file was first added.. my mistake. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36374 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #163556|0 |1 is obsolete| | --- Comment #6 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 163559 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=163559&action=edit Bug 36374: Move modal js under /modals I also didn't stick to the more recent switch to putting modal js under a /modals dirctory. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36374 --- Comment #7 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 163560 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=163560&action=edit Bug 36374: Ensure js/modals/*.js files are tidy -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36374 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff --- Comment #8 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- /modals is a good enough place to start.. I'll post follow-up bugs to tidy the other two files in there as I know both are basically maintained by me at the moment and not touched by anyone else so far. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36374 --- Comment #9 from Jonathan Druart <jonathan.druart@gmail.com> --- As we also need other files (koha-tmpl/intranet-tmpl/prog/js/fetch/ should all be tidied), maybe we should have a flag in the files (/* keep me tidy */) we could git grep to list them? For discussion, I can have a look tomorrow. I am a bit afraid to have a hardcoded list in 3 different places (koha, qa, git hook) -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36374 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |36373 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36373 [Bug 36373] Show existing bookings in datepicker -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36374 --- Comment #10 from Jonathan Druart <jonathan.druart@gmail.com> --- Created attachment 163587 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=163587&action=edit Bug 36374: flag JS files to keep tidy -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36374 Jonathan Druart <jonathan.druart@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #163587|0 |1 is obsolete| | --- Comment #11 from Jonathan Druart <jonathan.druart@gmail.com> --- Created attachment 163588 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=163588&action=edit Bug 36374: flag JS files to keep tidy -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36374 Jonathan Druart <jonathan.druart@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|The bookings modal JS |Some of our JS files should |should be tidied |stay tidy -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36374 --- Comment #12 from Jonathan Druart <jonathan.druart@gmail.com> --- Created attachment 163589 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=163589&action=edit Bug 36374: Keep tidy files from 'fetch' directory And tidy them -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36374 --- Comment #13 from Jonathan Druart <jonathan.druart@gmail.com> --- It may be more convenient to add several paths (like here 'modals' and 'fetch'), but then we will need to adjust the 3 different paths, and this is something we should avoid I think. Not ideal but it's good enough for now for a first step. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36374 --- Comment #14 from Jonathan Druart <jonathan.druart@gmail.com> --- See also: git hook changes: https://gitlab.com/koha-community/koha-testing-docker/-/issues/414 qa script changes: https://gitlab.com/koha-community/qa-test-tools/-/issues/81 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36374 --- Comment #15 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- I think this is a better first step than my initial attempt.. I was considering a centralised file to list files we should be keeping tidy, but that felt more messy and likely to fall out of maintenance too... Last step I reckon is to add a QA check to ensure new JS files contain the /* keep tidy */ flag. :) -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36374 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #163558|0 |1 is obsolete| | --- Comment #16 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 163591 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=163591&action=edit Bug 36374: Tidy place_booking_modal.js according to our prettier config This was somehow missed when the file was first added.. my mistake. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36374 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #163559|0 |1 is obsolete| | --- Comment #17 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 163592 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=163592&action=edit Bug 36374: Move modal js under /modals I also didn't stick to the more recent switch to putting modal js under a /modals dirctory. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36374 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #163560|0 |1 is obsolete| | --- Comment #18 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 163593 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=163593&action=edit Bug 36374: Ensure js/modals/*.js files are tidy -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36374 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #163588|0 |1 is obsolete| | --- Comment #19 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 163594 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=163594&action=edit Bug 36374: flag JS files to keep tidy Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36374 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #163589|0 |1 is obsolete| | --- Comment #20 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 163595 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=163595&action=edit Bug 36374: Keep tidy files from 'fetch' directory And tidy them Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36374 --- Comment #21 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 163596 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=163596&action=edit Bug 36374: Also tidy ticket and concern modals js This patch does the promised follow-up to tidy the two other recently added js files for modals. As I'm the main maintainer of those to date I'm happy to rebase any patches already submitted atop this bug. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36374 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36374 --- Comment #22 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Given Jonathans input here I've signed off his follow-ups and think we're OK to go for at least Signed off. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36374 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |lucas@bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36374 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Severity|minor |enhancement CC| |m.de.rooy@rijksmuseum.nl --- Comment #23 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- Sounds like enh to me? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36374 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |pedro.amorim@ptfs-europe.co | |m -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36374 --- Comment #24 from Pedro Amorim <pedro.amorim@ptfs-europe.com> --- Hey, adding my opinion here. This should be 2 different bugs, one specifically as a bookings modal follow-up tidy and restructuring, and the other bug for the keep JS files tidy stuff. The former should be good to go but the latter may be worth discussing further. I like the idea behind the *keep tidy* but I worry that having to specify each file manually going forward will not work in the long term, i.e. another thing to maintain/consider, will get forgotten, etc. Personally I'd prefer we do it on a by directory basis, as Martin's originally suggested but perhaps at a lower i.e. koha-tmpl/intranet-tmpl/prog/js/modals/ instead of koha-tmpl/intranet-tmpl/prog/js/modals/place_booking. This could cause conflicts for other work sitting in bugzilla for starters but could also be seen as a middle ground between specifying each file individually and tidying the whole code base at once. Either that or make sure newly created .js files have the *keep tidy* at the top. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36374 --- Comment #25 from Jonathan Druart <jonathan.druart@gmail.com> --- I would not block it now that we have the QA script and the git hook that have been published already. We need to start with something, we can improve later if needed. The more we wait the more we will lack this tidy check. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36374 --- Comment #26 from Jonathan Druart <jonathan.druart@gmail.com> --- Additionally having it on directory basis is less flexible. We can still have both, and so refine later if needed ;) -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36374 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA --- Comment #27 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- I'm going to go ahead and set this one to PQA.. we've had some good eyes and fair opinions. I think it's the first step to cleaner JS overall and I agree I'd like to work hard to get further in the medium term.. but we have to be pragmatic and start somewhere. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36374 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Patch doesn't apply Keywords| |rel_24_05_candidate --- Comment #28 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Please rebase! Apply? [(y)es, (n)o, (i)nteractive] y Applying: Bug 36374: Tidy place_booking_modal.js according to our prettier config Applying: Bug 36374: Move modal js under /modals Applying: Bug 36374: Ensure js/modals/*.js files are tidy Applying: Bug 36374: flag JS files to keep tidy Applying: Bug 36374: Keep tidy files from 'fetch' directory Applying: Bug 36374: Also tidy ticket and concern modals js error: sha1 information is lacking or useless (koha-tmpl/intranet-tmpl/prog/js/modals/add_catalog_concern.js). error: could not build fake ancestor Patch failed at 0001 Bug 36374: Also tidy ticket and concern modals js hint: Use 'git am --show-current-patch=diff' to see the failed patch When you have resolved this problem run "git bz apply --continue". If you would prefer to skip this patch, instead run "git bz apply --skip". To restore the original branch and stop patching run "git bz apply --abort". Patch left in /tmp/Bug-36374-Also-tidy-ticket-and-concern-modals-js-e_l9qfib.patch -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36374 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #163591|0 |1 is obsolete| | --- Comment #29 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 165732 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=165732&action=edit Bug 36374: Tidy place_booking_modal.js according to our prettier config This was somehow missed when the file was first added.. my mistake. Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> Signed-off-by: Pedro Amorim <pedro.amorim@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36374 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #163592|0 |1 is obsolete| | --- Comment #30 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 165733 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=165733&action=edit Bug 36374: Move modal js under /modals I also didn't stick to the more recent switch to putting modal js under a /modals dirctory. Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> Signed-off-by: Pedro Amorim <pedro.amorim@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36374 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #163593|0 |1 is obsolete| | --- Comment #31 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 165734 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=165734&action=edit Bug 36374: Ensure js/modals/*.js files are tidy Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> Signed-off-by: Pedro Amorim <pedro.amorim@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36374 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #163594|0 |1 is obsolete| | --- Comment #32 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 165735 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=165735&action=edit Bug 36374: flag JS files to keep tidy Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> Signed-off-by: Pedro Amorim <pedro.amorim@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36374 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #163595|0 |1 is obsolete| | --- Comment #33 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 165736 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=165736&action=edit Bug 36374: Keep tidy files from 'fetch' directory And tidy them Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> Signed-off-by: Pedro Amorim <pedro.amorim@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36374 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #163596|0 |1 is obsolete| | --- Comment #34 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 165737 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=165737&action=edit Bug 36374: Also tidy ticket and concern modals js This patch does the promised follow-up to tidy the two other recently added js files for modals. As I'm the main maintainer of those to date I'm happy to rebase any patches already submitted atop this bug. Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> Signed-off-by: Pedro Amorim <pedro.amorim@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36374 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36374 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #165732|0 |1 is obsolete| | --- Comment #35 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 165738 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=165738&action=edit Bug 36374: Tidy place_booking_modal.js according to our prettier config This was somehow missed when the file was first added.. my mistake. Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> Signed-off-by: Pedro Amorim <pedro.amorim@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36374 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #165733|0 |1 is obsolete| | --- Comment #36 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 165739 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=165739&action=edit Bug 36374: Move modal js under /modals I also didn't stick to the more recent switch to putting modal js under a /modals dirctory. Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> Signed-off-by: Pedro Amorim <pedro.amorim@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36374 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #165734|0 |1 is obsolete| | --- Comment #37 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 165740 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=165740&action=edit Bug 36374: Ensure js/modals/*.js files are tidy Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> Signed-off-by: Pedro Amorim <pedro.amorim@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36374 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #165735|0 |1 is obsolete| | --- Comment #38 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 165741 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=165741&action=edit Bug 36374: flag JS files to keep tidy Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> Signed-off-by: Pedro Amorim <pedro.amorim@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36374 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #165736|0 |1 is obsolete| | --- Comment #39 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 165742 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=165742&action=edit Bug 36374: Keep tidy files from 'fetch' directory And tidy them Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> Signed-off-by: Pedro Amorim <pedro.amorim@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36374 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #165737|0 |1 is obsolete| | --- Comment #40 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 165743 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=165743&action=edit Bug 36374: Also tidy ticket and concern modals js This patch does the promised follow-up to tidy the two other recently added js files for modals. As I'm the main maintainer of those to date I'm happy to rebase any patches already submitted atop this bug. Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> Signed-off-by: Pedro Amorim <pedro.amorim@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36374 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to main Version(s)| |24.05.00 released in| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36374 --- Comment #41 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Pushed for 24.05! Well done everyone, thank you! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36374 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords|rel_24_05_candidate | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36374 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |35616 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35616 [Bug 35616] Add a 'source' field to Koha::Tickets to denote the path taken to report the ticket -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36374 Fridolin Somers <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |fridolin.somers@biblibre.co | |m Status|Pushed to main |Needs documenting --- Comment #42 from Fridolin Somers <fridolin.somers@biblibre.com> --- Not backported to 23.11.x -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36374 Aude Charillon <aude.charillon@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |FIXED Status|Needs documenting |RESOLVED CC| |aude.charillon@ptfs-europe. | |com --- Comment #43 from Aude Charillon <aude.charillon@ptfs-europe.com> --- No changes to the Manual needed. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36374 Bug 36374 depends on bug 35616, which changed state. Bug 35616 Summary: Add a 'source' field to Koha::Tickets to denote the path taken to report the ticket https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35616 What |Removed |Added ---------------------------------------------------------------------------- Status|Needs documenting |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36374 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks|36120 | Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36120 [Bug 36120] Add pickup locations to bookings -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36374 Bug 36374 depends on bug 29002, which changed state. Bug 29002 Summary: Add ability to book items ahead of time https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29002 What |Removed |Added ---------------------------------------------------------------------------- Status|Needs documenting |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org