[Bug 36120] New: Add pickup locations to Bookings
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36120 Bug ID: 36120 Summary: Add pickup locations to Bookings Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Circulation Assignee: koha-bugs@lists.koha-community.org Reporter: martin.renvoize@ptfs-europe.com QA Contact: testopia@bugs.koha-community.org CC: gmcharlt@gmail.com, kyle.m.hall@gmail.com Depends on: 29002 Currently, there's no way to set where a booking is intended to be collected from. Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29002 [Bug 29002] Add ability to book items ahead of time -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36120 --- Comment #1 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- *** Bug 36121 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36120 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on|29002 |35248 Assignee|koha-bugs@lists.koha-commun |martin.renvoize@ptfs-europe |ity.org |.com Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29002 [Bug 29002] Add ability to book items ahead of time https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35248 [Bug 35248] Bookings needs unit tests -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36120 --- Comment #2 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 162911 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=162911&action=edit Bug 36120: Add pickup_items to the pickup_locations response This patch adds pickup_items as a list of itemnumbers that can be picked from the library should it be selected as a pickup location. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36120 --- Comment #3 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 162912 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=162912&action=edit Bug 36120: Add pickup locations to bookings This patch adds a call to /biblios/biblionumber/pickup_locations to fetch valid pickup locations for the biblio. Upon selecting a pickup location we adapt the item select to only allow for selecting items returned as valid for pickup at the selected location. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36120 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=27340 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36120 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |tomascohen@gmail.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36120 --- Comment #4 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Still a lot to tie in here, but I wanted to put up the UI proof of concept to start facilitating feedback from Tomas and people regarding the calls to fetch pickup locations from the API. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36120 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |lucas@bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36120 --- Comment #5 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- I've not considered overrides really yet either. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36120 --- Comment #6 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 162914 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=162914&action=edit Bug 36120: Schema update -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36120 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #162911|0 |1 is obsolete| | --- Comment #7 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 162915 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=162915&action=edit Bug 36120: Add pickup_items to the pickup_locations response This patch adds pickup_items as a list of itemnumbers that can be picked from the library should it be selected as a pickup location. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36120 --- Comment #8 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 162916 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=162916&action=edit Bug 36120: Add pickup_library support to bookings API -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36120 --- Comment #9 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 162917 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=162917&action=edit Bug 36120: Add pickup locations to place bookings modal This patch adds a call to /biblios/biblionumber/pickup_locations to fetch valid pickup locations for the biblio. Upon selecting a pickup location we adapt the item select to only allow for selecting items returned as valid for pickup at the selected location. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36120 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #162912|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36120 --- Comment #10 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 162918 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=162918&action=edit Bug 36120: Add pickup_library_id to bookings table -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36120 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #162914|0 |1 is obsolete| | --- Comment #11 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 162919 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=162919&action=edit Bug 36120: Schema update -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36120 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #162915|0 |1 is obsolete| | --- Comment #12 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 162920 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=162920&action=edit Bug 36120: Add pickup_items to the pickup_locations response This patch adds pickup_items as a list of itemnumbers that can be picked from the library should it be selected as a pickup location. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36120 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #162916|0 |1 is obsolete| | --- Comment #13 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 162921 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=162921&action=edit Bug 36120: Add pickup_library support to bookings API -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36120 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #162917|0 |1 is obsolete| | --- Comment #14 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 162922 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=162922&action=edit Bug 36120: Add pickup locations to place bookings modal This patch adds a call to /biblios/biblionumber/pickup_locations to fetch valid pickup locations for the biblio. Upon selecting a pickup location we adapt the item select to only allow for selecting items returned as valid for pickup at the selected location. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36120 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #162918|0 |1 is obsolete| | --- Comment #15 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 162923 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=162923&action=edit Bug 36120: Add pickup_library_id to bookings table -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36120 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #162919|0 |1 is obsolete| | --- Comment #16 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 162924 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=162924&action=edit Bug 36120: Schema update -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36120 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #162920|0 |1 is obsolete| | --- Comment #17 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 162925 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=162925&action=edit Bug 36120: Add pickup_items to the pickup_locations response This patch adds pickup_items as a list of itemnumbers that can be picked from the library should it be selected as a pickup location. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36120 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #162921|0 |1 is obsolete| | --- Comment #18 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 162926 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=162926&action=edit Bug 36120: Add pickup_library support to bookings API -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36120 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #162922|0 |1 is obsolete| | --- Comment #19 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 162927 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=162927&action=edit Bug 36120: Add pickup locations to place bookings modal This patch adds a call to /biblios/biblionumber/pickup_locations to fetch valid pickup locations for the biblio. Upon selecting a pickup location we adapt the item select to only allow for selecting items returned as valid for pickup at the selected location. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36120 --- Comment #20 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 162928 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=162928&action=edit Bug 36120: Add pickup library to bookings list table -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36120 --- Comment #21 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- OK, ready for testing now as a whole :) Test plan 1) Enable some items to be bookable as per the test plan for 29002 2) Click 'Place booking' on any of the biblio pages for those bilios marked bookable as above 3) Note you are now required to pick a pickup location 4) Experiment with different pickup location rules as per the holds system 5) Note that items are enabled/disabled from the item selection based on pickup location 6) Place your booking 7) Note that 'Pickup location' is now listed in the table on the 'Bookings' page. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36120 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36120 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |david@davidnind.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36120 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |nick@bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36120 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |lisette.scheer@bywatersolut | |ions.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36120 --- Comment #22 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 162976 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=162976&action=edit Bug 36120: Ensure existing bookings are assigned a pickup library -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36120 --- Comment #23 from Lisette Scheer <lisette.scheer@bywatersolutions.com> --- I can't apply one of the dependencies: Applying: Bug 35787: Remove Koha::Template::Plugin::Biblio::CanBook error: sha1 information is lacking or useless (Koha/Template/Plugin/Biblio.pm). error: could not build fake ancestor Patch failed at 0001 Bug 35787: Remove Koha::Template::Plugin::Biblio::CanBook -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36120 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Patch doesn't apply --- Comment #24 from David Nind <david@davidnind.com> --- For me, it was bug 35788 that was not applying with sha1/fake ancestor error: ... Apply? [(y)es, (n)o, (i)nteractive] y Applying: Bug 35788: Remove Koha::Template::Plugin::Biblio::BookingsCount error: sha1 information is lacking or useless (Koha/Template/Plugin/Biblio.pm). error: could not build fake ancestor Patch failed at 0001 Bug 35788: Remove Koha::Template::Plugin::Biblio::BookingsCount -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36120 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- URL| |https://github.com/PTFS-Eur | |ope/koha/tree/bug_36120 --- Comment #25 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- https://github.com/PTFS-Europe/koha/tree/bug_36120 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36120 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36120 Lisette Scheer <lisette.scheer@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off --- Comment #26 from Lisette Scheer <lisette.scheer@bywatersolutions.com> --- Signed off, worked great! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36120 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #162923|0 |1 is obsolete| | --- Comment #27 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 163218 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=163218&action=edit Bug 36120: Add pickup_library_id to bookings table Signed-off-by: Lisette Scheer <lisette.scheer@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36120 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #162924|0 |1 is obsolete| | --- Comment #28 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 163219 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=163219&action=edit Bug 36120: Schema update Signed-off-by: Lisette Scheer <lisette.scheer@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36120 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #162925|0 |1 is obsolete| | --- Comment #29 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 163220 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=163220&action=edit Bug 36120: Add pickup_items to the pickup_locations response This patch adds pickup_items as a list of itemnumbers that can be picked from the library should it be selected as a pickup location. Signed-off-by: Lisette Scheer <lisette.scheer@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36120 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #162926|0 |1 is obsolete| | --- Comment #30 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 163221 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=163221&action=edit Bug 36120: Add pickup_library support to bookings API Signed-off-by: Lisette Scheer <lisette.scheer@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36120 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #162927|0 |1 is obsolete| | --- Comment #31 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 163222 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=163222&action=edit Bug 36120: Add pickup locations to place bookings modal This patch adds a call to /biblios/biblionumber/pickup_locations to fetch valid pickup locations for the biblio. Upon selecting a pickup location we adapt the item select to only allow for selecting items returned as valid for pickup at the selected location. Signed-off-by: Lisette Scheer <lisette.scheer@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36120 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #162928|0 |1 is obsolete| | --- Comment #32 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 163223 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=163223&action=edit Bug 36120: Add pickup library to bookings list table Signed-off-by: Lisette Scheer <lisette.scheer@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36120 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #162976|0 |1 is obsolete| | --- Comment #33 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 163224 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=163224&action=edit Bug 36120: Ensure existing bookings are assigned a pickup library Signed-off-by: Lisette Scheer <lisette.scheer@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36120 --- Comment #34 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Rebased and added Lisette's signoff lines. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36120 Kristi <kkrueger@cuyahogalibrary.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |kkrueger@cuyahogalibrary.or | |g --- Comment #35 from Kristi <kkrueger@cuyahogalibrary.org> --- For Martin: CCPL reviewed a video Lisette made of the pickup location option, and it looked as expected. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36120 --- Comment #36 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Excellent, thanks Kristi :) -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36120 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #163218|0 |1 is obsolete| | --- Comment #37 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 163435 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=163435&action=edit Bug 36120: Add pickup_library_id to bookings table Signed-off-by: Lisette Scheer <lisette.scheer@bywatersolutions.com> Signed-off-by: Kristi Krueger <kkrueger@cuyahogalibrary.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36120 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #163219|0 |1 is obsolete| | --- Comment #38 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 163436 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=163436&action=edit Bug 36120: Schema update Signed-off-by: Lisette Scheer <lisette.scheer@bywatersolutions.com> Signed-off-by: Kristi Krueger <kkrueger@cuyahogalibrary.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36120 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #163220|0 |1 is obsolete| | --- Comment #39 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 163437 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=163437&action=edit Bug 36120: Add pickup_items to the pickup_locations response This patch adds pickup_items as a list of itemnumbers that can be picked from the library should it be selected as a pickup location. Signed-off-by: Lisette Scheer <lisette.scheer@bywatersolutions.com> Signed-off-by: Kristi Krueger <kkrueger@cuyahogalibrary.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36120 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #163221|0 |1 is obsolete| | --- Comment #40 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 163438 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=163438&action=edit Bug 36120: Add pickup_library support to bookings API Signed-off-by: Lisette Scheer <lisette.scheer@bywatersolutions.com> Signed-off-by: Kristi Krueger <kkrueger@cuyahogalibrary.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36120 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #163222|0 |1 is obsolete| | --- Comment #41 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 163439 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=163439&action=edit Bug 36120: Add pickup locations to place bookings modal This patch adds a call to /biblios/biblionumber/pickup_locations to fetch valid pickup locations for the biblio. Upon selecting a pickup location we adapt the item select to only allow for selecting items returned as valid for pickup at the selected location. Signed-off-by: Lisette Scheer <lisette.scheer@bywatersolutions.com> Signed-off-by: Kristi Krueger <kkrueger@cuyahogalibrary.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36120 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #163223|0 |1 is obsolete| | --- Comment #42 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 163440 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=163440&action=edit Bug 36120: Add pickup library to bookings list table Signed-off-by: Lisette Scheer <lisette.scheer@bywatersolutions.com> Signed-off-by: Kristi Krueger <kkrueger@cuyahogalibrary.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36120 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #163224|0 |1 is obsolete| | --- Comment #43 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 163441 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=163441&action=edit Bug 36120: Ensure existing bookings are assigned a pickup library Signed-off-by: Lisette Scheer <lisette.scheer@bywatersolutions.com> Signed-off-by: Kristi Krueger <kkrueger@cuyahogalibrary.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36120 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #163435|0 |1 is obsolete| | --- Comment #44 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 163442 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=163442&action=edit Bug 36120: Add pickup_library_id to bookings table Sponsored-by: Cuyahoga County Public Library Signed-off-by: Lisette Scheer <lisette.scheer@bywatersolutions.com> Signed-off-by: Kristi Krueger <kkrueger@cuyahogalibrary.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36120 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #163436|0 |1 is obsolete| | --- Comment #45 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 163443 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=163443&action=edit Bug 36120: Schema update Sponsored-by: Cuyahoga County Public Library Signed-off-by: Lisette Scheer <lisette.scheer@bywatersolutions.com> Signed-off-by: Kristi Krueger <kkrueger@cuyahogalibrary.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36120 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #163437|0 |1 is obsolete| | --- Comment #46 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 163444 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=163444&action=edit Bug 36120: Add pickup_items to the pickup_locations response This patch adds pickup_items as a list of itemnumbers that can be picked from the library should it be selected as a pickup location. Sponsored-by: Cuyahoga County Public Library Signed-off-by: Lisette Scheer <lisette.scheer@bywatersolutions.com> Signed-off-by: Kristi Krueger <kkrueger@cuyahogalibrary.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36120 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #163438|0 |1 is obsolete| | --- Comment #47 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 163445 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=163445&action=edit Bug 36120: Add pickup_library support to bookings API Sponsored-by: Cuyahoga County Public Library Signed-off-by: Lisette Scheer <lisette.scheer@bywatersolutions.com> Signed-off-by: Kristi Krueger <kkrueger@cuyahogalibrary.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36120 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #163439|0 |1 is obsolete| | --- Comment #48 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 163446 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=163446&action=edit Bug 36120: Add pickup locations to place bookings modal This patch adds a call to /biblios/biblionumber/pickup_locations to fetch valid pickup locations for the biblio. Upon selecting a pickup location we adapt the item select to only allow for selecting items returned as valid for pickup at the selected location. Sponsored-by: Cuyahoga County Public Library Signed-off-by: Lisette Scheer <lisette.scheer@bywatersolutions.com> Signed-off-by: Kristi Krueger <kkrueger@cuyahogalibrary.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36120 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #163440|0 |1 is obsolete| | --- Comment #49 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 163447 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=163447&action=edit Bug 36120: Add pickup library to bookings list table Sponsored-by: Cuyahoga County Public Library Signed-off-by: Lisette Scheer <lisette.scheer@bywatersolutions.com> Signed-off-by: Kristi Krueger <kkrueger@cuyahogalibrary.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36120 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #163441|0 |1 is obsolete| | --- Comment #50 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 163448 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=163448&action=edit Bug 36120: Ensure existing bookings are assigned a pickup library Sponsored-by: Cuyahoga County Public Library Signed-off-by: Lisette Scheer <lisette.scheer@bywatersolutions.com> Signed-off-by: Kristi Krueger <kkrueger@cuyahogalibrary.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36120 --- Comment #51 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Credit where credits are due.. I added the Sponsored-by lines to the commits having forgotten until now. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36120 Bug 36120 depends on bug 35248, which changed state. Bug 35248 Summary: Bookings needs unit tests https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35248 What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to stable |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36120 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |34440 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34440 [Bug 34440] Add warm-up and cool-down periods to bookings -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36120 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |36374 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36374 [Bug 36374] The bookings modal JS should be tidied -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36120 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #163442|0 |1 is obsolete| | --- Comment #52 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 163565 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=163565&action=edit Bug 36120: Add pickup_library_id to bookings table Sponsored-by: Cuyahoga County Public Library Signed-off-by: Lisette Scheer <lisette.scheer@bywatersolutions.com> Signed-off-by: Kristi Krueger <kkrueger@cuyahogalibrary.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36120 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #163443|0 |1 is obsolete| | --- Comment #53 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 163566 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=163566&action=edit Bug 36120: Schema update Sponsored-by: Cuyahoga County Public Library Signed-off-by: Lisette Scheer <lisette.scheer@bywatersolutions.com> Signed-off-by: Kristi Krueger <kkrueger@cuyahogalibrary.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36120 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #163444|0 |1 is obsolete| | --- Comment #54 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 163567 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=163567&action=edit Bug 36120: Add pickup_items to the pickup_locations response This patch adds pickup_items as a list of itemnumbers that can be picked from the library should it be selected as a pickup location. Sponsored-by: Cuyahoga County Public Library Signed-off-by: Lisette Scheer <lisette.scheer@bywatersolutions.com> Signed-off-by: Kristi Krueger <kkrueger@cuyahogalibrary.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36120 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #163445|0 |1 is obsolete| | --- Comment #55 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 163568 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=163568&action=edit Bug 36120: Add pickup_library support to bookings API Sponsored-by: Cuyahoga County Public Library Signed-off-by: Lisette Scheer <lisette.scheer@bywatersolutions.com> Signed-off-by: Kristi Krueger <kkrueger@cuyahogalibrary.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36120 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #163446|0 |1 is obsolete| | --- Comment #56 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 163569 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=163569&action=edit Bug 36120: Add pickup locations to place bookings modal This patch adds a call to /biblios/biblionumber/pickup_locations to fetch valid pickup locations for the biblio. Upon selecting a pickup location we adapt the item select to only allow for selecting items returned as valid for pickup at the selected location. Sponsored-by: Cuyahoga County Public Library Signed-off-by: Lisette Scheer <lisette.scheer@bywatersolutions.com> Signed-off-by: Kristi Krueger <kkrueger@cuyahogalibrary.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36120 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #163447|0 |1 is obsolete| | --- Comment #57 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 163570 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=163570&action=edit Bug 36120: Add pickup library to bookings list table Sponsored-by: Cuyahoga County Public Library Signed-off-by: Lisette Scheer <lisette.scheer@bywatersolutions.com> Signed-off-by: Kristi Krueger <kkrueger@cuyahogalibrary.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36120 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #163448|0 |1 is obsolete| | --- Comment #58 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 163571 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=163571&action=edit Bug 36120: Ensure existing bookings are assigned a pickup library Sponsored-by: Cuyahoga County Public Library Signed-off-by: Lisette Scheer <lisette.scheer@bywatersolutions.com> Signed-off-by: Kristi Krueger <kkrueger@cuyahogalibrary.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36120 --- Comment #59 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Just a rebase on the tidy up bug. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36120 --- Comment #60 from Nick Clemens <nick@bywatersolutions.com> --- This works great in a lot of ways, but I found a couple issues: 1 - We need unit tests for the pickup_locations change and the API 2 - The pickup_locations for items should be set from the list for that item, not from the entire bib so far: for my $location (@pickup_locations) { should be for my $location (@{$item_pickup_locations}) { 3 - When changing branches, item options are disabled - if there are 100+ items you may have to scroll through all the disabled options to find the correct one 4 - If you click on any single item, the 'Any item' option is disabled and cannot be chosen again 5 - The pickup_library_id is defaulted to NULL - it should be NOT NULL to match hold pickup location -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36120 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #163565|0 |1 is obsolete| | --- Comment #61 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 163603 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=163603&action=edit Bug 36120: Add pickup_library_id to bookings table Sponsored-by: Cuyahoga County Public Library Signed-off-by: Lisette Scheer <lisette.scheer@bywatersolutions.com> Signed-off-by: Kristi Krueger <kkrueger@cuyahogalibrary.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36120 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #163566|0 |1 is obsolete| | --- Comment #62 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 163604 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=163604&action=edit Bug 36120: Schema update Sponsored-by: Cuyahoga County Public Library Signed-off-by: Lisette Scheer <lisette.scheer@bywatersolutions.com> Signed-off-by: Kristi Krueger <kkrueger@cuyahogalibrary.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36120 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #163567|0 |1 is obsolete| | --- Comment #63 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 163605 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=163605&action=edit Bug 36120: Add pickup_items to the pickup_locations response This patch adds pickup_items as a list of itemnumbers that can be picked from the library should it be selected as a pickup location. Sponsored-by: Cuyahoga County Public Library Signed-off-by: Lisette Scheer <lisette.scheer@bywatersolutions.com> Signed-off-by: Kristi Krueger <kkrueger@cuyahogalibrary.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36120 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #163568|0 |1 is obsolete| | --- Comment #64 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 163606 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=163606&action=edit Bug 36120: Add pickup_library support to bookings API Sponsored-by: Cuyahoga County Public Library Signed-off-by: Lisette Scheer <lisette.scheer@bywatersolutions.com> Signed-off-by: Kristi Krueger <kkrueger@cuyahogalibrary.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36120 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #163569|0 |1 is obsolete| | --- Comment #65 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 163607 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=163607&action=edit Bug 36120: Add pickup locations to place bookings modal This patch adds a call to /biblios/biblionumber/pickup_locations to fetch valid pickup locations for the biblio. Upon selecting a pickup location we adapt the item select to only allow for selecting items returned as valid for pickup at the selected location. Sponsored-by: Cuyahoga County Public Library Signed-off-by: Lisette Scheer <lisette.scheer@bywatersolutions.com> Signed-off-by: Kristi Krueger <kkrueger@cuyahogalibrary.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36120 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #163570|0 |1 is obsolete| | --- Comment #66 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 163608 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=163608&action=edit Bug 36120: Add pickup library to bookings list table Sponsored-by: Cuyahoga County Public Library Signed-off-by: Lisette Scheer <lisette.scheer@bywatersolutions.com> Signed-off-by: Kristi Krueger <kkrueger@cuyahogalibrary.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36120 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #163571|0 |1 is obsolete| | --- Comment #67 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 163609 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=163609&action=edit Bug 36120: Ensure existing bookings are assigned a pickup library Sponsored-by: Cuyahoga County Public Library Signed-off-by: Lisette Scheer <lisette.scheer@bywatersolutions.com> Signed-off-by: Kristi Krueger <kkrueger@cuyahogalibrary.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36120 --- Comment #68 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 163610 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=163610&action=edit Bug 36120: Ensure pickup_library_id is NOT NULL This patch updates the database schema to ensure bookings.pickup_library_id is NOT NULL -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36120 --- Comment #69 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 163611 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=163611&action=edit Bug 36120: Schema update -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36120 --- Comment #70 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 163612 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=163612&action=edit Bug 36120: Add unit test for pickup_library relation accessor This patch adds a unit test for the newly introduced pickup_library accessor added to Koha::Booking -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36120 --- Comment #71 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 163613 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=163613&action=edit Bug 36120: Unit tests for pickup_locations change This patch adds unit tests for the additional caching of location_items in the pickup_locations method of Koha::Biblio. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36120 --- Comment #72 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- (In reply to Nick Clemens from comment #60)
This works great in a lot of ways, but I found a couple issues: 1 - We need unit tests for the pickup_locations change and the API
API tests next to come, but Koha::Biblio and Koha::Booking tests are now covered
2 - The pickup_locations for items should be set from the list for that item, not from the entire bib so far: for my $location (@pickup_locations) { should be for my $location (@{$item_pickup_locations}) {
Good spot, corrected.
5 - The pickup_library_id is defaulted to NULL - it should be NOT NULL to match hold pickup location
Resolved now Still working on comments 3 and 4 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36120 --- Comment #73 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 163635 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=163635&action=edit Bug 36120: Re-enable 'Any item' selectable -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36120 --- Comment #74 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 163636 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=163636&action=edit Bug 36120: Account for both pickup_location and date selection in items This patch ensures we account for both pickup location and date selections having taken place before an item selection is pondered. We now correctly disable item options given both conditions rather than it being a race between the two. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36120 --- Comment #75 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- (In reply to Nick Clemens from comment #60)
3 - When changing branches, item options are disabled - if there are 100+ items you may have to scroll through all the disabled options to find the correct one
Can we put this one on a follow-up bug.. it pre-exists this bug (selecting dates and then trying to select item also disables but available items but doesn't re-order the select list)
4 - If you click on any single item, the 'Any item' option is disabled and cannot be chosen again
This is resolved too There's also a follow-up for something I spotted when digging more deeply.. we now account for the dates AND pickup locations in combination when disabling item options.. prior to that last patch we had a race condition where the most recent selected option would govern which items could be selected rather than both working in combination. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36120 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA --- Comment #76 from Nick Clemens <nick@bywatersolutions.com> --- The one remaining issue I am seeing is that changing the pickup location disables all the items in the items drop down, however, it retains whatever my last selection was, so I can place the booking anyways, but can't select a new item, 'Any item' can be disabled too If i update the booking dates, then some items can be enabled again -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36120 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #163636|0 |1 is obsolete| | --- Comment #77 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 165140 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=165140&action=edit Bug 36120: Account for both pickup_location and date selection in items This patch ensures we account for both pickup location and date selections having taken place before an item selection is pondered. We now correctly disable item options given both conditions rather than it being a race between the two. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36120 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Signed Off --- Comment #78 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Seems I missed part of the the last commit last upload.. squashed and uploaded it again.. that should resolve your issue Nick -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36120 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #163603|0 |1 is obsolete| | --- Comment #79 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 165175 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=165175&action=edit Bug 36120: Add pickup_library_id to bookings table Sponsored-by: Cuyahoga County Public Library Signed-off-by: Lisette Scheer <lisette.scheer@bywatersolutions.com> Signed-off-by: Kristi Krueger <kkrueger@cuyahogalibrary.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36120 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #163604|0 |1 is obsolete| | Attachment #163611|0 |1 is obsolete| | --- Comment #80 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 165176 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=165176&action=edit Bug 36120: Schema update Sponsored-by: Cuyahoga County Public Library Signed-off-by: Lisette Scheer <lisette.scheer@bywatersolutions.com> Signed-off-by: Kristi Krueger <kkrueger@cuyahogalibrary.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36120 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #163605|0 |1 is obsolete| | --- Comment #81 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 165177 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=165177&action=edit Bug 36120: Add pickup_items to the pickup_locations response This patch adds pickup_items as a list of itemnumbers that can be picked from the library should it be selected as a pickup location. Sponsored-by: Cuyahoga County Public Library Signed-off-by: Lisette Scheer <lisette.scheer@bywatersolutions.com> Signed-off-by: Kristi Krueger <kkrueger@cuyahogalibrary.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36120 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #163606|0 |1 is obsolete| | --- Comment #82 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 165178 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=165178&action=edit Bug 36120: Add pickup_library support to bookings API Sponsored-by: Cuyahoga County Public Library Signed-off-by: Lisette Scheer <lisette.scheer@bywatersolutions.com> Signed-off-by: Kristi Krueger <kkrueger@cuyahogalibrary.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36120 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #163607|0 |1 is obsolete| | --- Comment #83 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 165179 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=165179&action=edit Bug 36120: Add pickup locations to place bookings modal This patch adds a call to /biblios/biblionumber/pickup_locations to fetch valid pickup locations for the biblio. Upon selecting a pickup location we adapt the item select to only allow for selecting items returned as valid for pickup at the selected location. Sponsored-by: Cuyahoga County Public Library Signed-off-by: Lisette Scheer <lisette.scheer@bywatersolutions.com> Signed-off-by: Kristi Krueger <kkrueger@cuyahogalibrary.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36120 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #163608|0 |1 is obsolete| | --- Comment #84 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 165180 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=165180&action=edit Bug 36120: Add pickup library to bookings list table Sponsored-by: Cuyahoga County Public Library Signed-off-by: Lisette Scheer <lisette.scheer@bywatersolutions.com> Signed-off-by: Kristi Krueger <kkrueger@cuyahogalibrary.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36120 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #163609|0 |1 is obsolete| | --- Comment #85 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 165181 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=165181&action=edit Bug 36120: Ensure existing bookings are assigned a pickup library Sponsored-by: Cuyahoga County Public Library Signed-off-by: Lisette Scheer <lisette.scheer@bywatersolutions.com> Signed-off-by: Kristi Krueger <kkrueger@cuyahogalibrary.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36120 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #163610|0 |1 is obsolete| | --- Comment #86 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 165182 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=165182&action=edit Bug 36120: Ensure pickup_library_id is NOT NULL This patch updates the database schema to ensure bookings.pickup_library_id is NOT NULL -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36120 --- Comment #87 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 165183 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=165183&action=edit Bug 36120: Schema update -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36120 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #163612|0 |1 is obsolete| | --- Comment #88 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 165184 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=165184&action=edit Bug 36120: Add unit test for pickup_library relation accessor This patch adds a unit test for the newly introduced pickup_library accessor added to Koha::Booking -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36120 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #163613|0 |1 is obsolete| | --- Comment #89 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 165185 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=165185&action=edit Bug 36120: Unit tests for pickup_locations change This patch adds unit tests for the additional caching of location_items in the pickup_locations method of Koha::Biblio. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36120 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #163635|0 |1 is obsolete| | --- Comment #90 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 165186 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=165186&action=edit Bug 36120: Re-enable 'Any item' selectable -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36120 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #165140|0 |1 is obsolete| | --- Comment #91 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 165187 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=165187&action=edit Bug 36120: Account for both pickup_location and date selection in items This patch ensures we account for both pickup location and date selections having taken place before an item selection is pondered. We now correctly disable item options given both conditions rather than it being a race between the two. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36120 --- Comment #92 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 165188 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=165188&action=edit Bug 36120: Ensure pickup location and item can be picked in either order -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36120 --- Comment #93 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 165214 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=165214&action=edit Bug 36120: (follow-up) Only display locations for bookable items This patch updates the pickup locations picker to only include locations for items that are bookable. We should look at doing this on the API level as it highlights some issues with re-using item holds pickup location rules. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36120 --- Comment #94 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 165215 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=165215&action=edit Bug 36120: Restore edit -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36120 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #165215|0 |1 is obsolete| | --- Comment #95 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 165216 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=165216&action=edit Bug 36120: Restore edit -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36120 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36120 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #165175|0 |1 is obsolete| | Attachment #165176|0 |1 is obsolete| | Attachment #165177|0 |1 is obsolete| | Attachment #165178|0 |1 is obsolete| | Attachment #165179|0 |1 is obsolete| | Attachment #165180|0 |1 is obsolete| | Attachment #165181|0 |1 is obsolete| | Attachment #165182|0 |1 is obsolete| | Attachment #165183|0 |1 is obsolete| | Attachment #165184|0 |1 is obsolete| | Attachment #165185|0 |1 is obsolete| | Attachment #165186|0 |1 is obsolete| | Attachment #165187|0 |1 is obsolete| | Attachment #165188|0 |1 is obsolete| | Attachment #165214|0 |1 is obsolete| | Attachment #165216|0 |1 is obsolete| | --- Comment #96 from Nick Clemens <nick@bywatersolutions.com> --- Created attachment 165419 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=165419&action=edit Bug 36120: Add pickup_library_id to bookings table Sponsored-by: Cuyahoga County Public Library Signed-off-by: Lisette Scheer <lisette.scheer@bywatersolutions.com> Signed-off-by: Kristi Krueger <kkrueger@cuyahogalibrary.org> Signed-off-by: Nick Clemens <nick@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36120 --- Comment #97 from Nick Clemens <nick@bywatersolutions.com> --- Created attachment 165420 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=165420&action=edit Bug 36120: Schema update Sponsored-by: Cuyahoga County Public Library Signed-off-by: Lisette Scheer <lisette.scheer@bywatersolutions.com> Signed-off-by: Kristi Krueger <kkrueger@cuyahogalibrary.org> Signed-off-by: Nick Clemens <nick@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36120 --- Comment #98 from Nick Clemens <nick@bywatersolutions.com> --- Created attachment 165421 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=165421&action=edit Bug 36120: Add pickup_items to the pickup_locations response This patch adds pickup_items as a list of itemnumbers that can be picked from the library should it be selected as a pickup location. Sponsored-by: Cuyahoga County Public Library Signed-off-by: Lisette Scheer <lisette.scheer@bywatersolutions.com> Signed-off-by: Kristi Krueger <kkrueger@cuyahogalibrary.org> Signed-off-by: Nick Clemens <nick@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36120 --- Comment #99 from Nick Clemens <nick@bywatersolutions.com> --- Created attachment 165422 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=165422&action=edit Bug 36120: Add pickup_library support to bookings API Sponsored-by: Cuyahoga County Public Library Signed-off-by: Lisette Scheer <lisette.scheer@bywatersolutions.com> Signed-off-by: Kristi Krueger <kkrueger@cuyahogalibrary.org> Signed-off-by: Nick Clemens <nick@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36120 --- Comment #100 from Nick Clemens <nick@bywatersolutions.com> --- Created attachment 165423 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=165423&action=edit Bug 36120: Add pickup locations to place bookings modal This patch adds a call to /biblios/biblionumber/pickup_locations to fetch valid pickup locations for the biblio. Upon selecting a pickup location we adapt the item select to only allow for selecting items returned as valid for pickup at the selected location. Sponsored-by: Cuyahoga County Public Library Signed-off-by: Lisette Scheer <lisette.scheer@bywatersolutions.com> Signed-off-by: Kristi Krueger <kkrueger@cuyahogalibrary.org> Signed-off-by: Nick Clemens <nick@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36120 --- Comment #101 from Nick Clemens <nick@bywatersolutions.com> --- Created attachment 165424 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=165424&action=edit Bug 36120: Add pickup library to bookings list table Sponsored-by: Cuyahoga County Public Library Signed-off-by: Lisette Scheer <lisette.scheer@bywatersolutions.com> Signed-off-by: Kristi Krueger <kkrueger@cuyahogalibrary.org> Signed-off-by: Nick Clemens <nick@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36120 --- Comment #102 from Nick Clemens <nick@bywatersolutions.com> --- Created attachment 165425 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=165425&action=edit Bug 36120: Ensure existing bookings are assigned a pickup library Sponsored-by: Cuyahoga County Public Library Signed-off-by: Lisette Scheer <lisette.scheer@bywatersolutions.com> Signed-off-by: Kristi Krueger <kkrueger@cuyahogalibrary.org> Signed-off-by: Nick Clemens <nick@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36120 --- Comment #103 from Nick Clemens <nick@bywatersolutions.com> --- Created attachment 165426 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=165426&action=edit Bug 36120: Ensure pickup_library_id is NOT NULL This patch updates the database schema to ensure bookings.pickup_library_id is NOT NULL Signed-off-by: Nick Clemens <nick@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36120 --- Comment #104 from Nick Clemens <nick@bywatersolutions.com> --- Created attachment 165427 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=165427&action=edit Bug 36120: Schema update Signed-off-by: Nick Clemens <nick@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36120 --- Comment #105 from Nick Clemens <nick@bywatersolutions.com> --- Created attachment 165428 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=165428&action=edit Bug 36120: Add unit test for pickup_library relation accessor This patch adds a unit test for the newly introduced pickup_library accessor added to Koha::Booking Signed-off-by: Nick Clemens <nick@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36120 --- Comment #106 from Nick Clemens <nick@bywatersolutions.com> --- Created attachment 165429 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=165429&action=edit Bug 36120: Unit tests for pickup_locations change This patch adds unit tests for the additional caching of location_items in the pickup_locations method of Koha::Biblio. Signed-off-by: Nick Clemens <nick@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36120 --- Comment #107 from Nick Clemens <nick@bywatersolutions.com> --- Created attachment 165430 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=165430&action=edit Bug 36120: Re-enable 'Any item' selectable Signed-off-by: Nick Clemens <nick@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36120 --- Comment #108 from Nick Clemens <nick@bywatersolutions.com> --- Created attachment 165431 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=165431&action=edit Bug 36120: Account for both pickup_location and date selection in items This patch ensures we account for both pickup location and date selections having taken place before an item selection is pondered. We now correctly disable item options given both conditions rather than it being a race between the two. Signed-off-by: Nick Clemens <nick@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36120 --- Comment #109 from Nick Clemens <nick@bywatersolutions.com> --- Created attachment 165432 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=165432&action=edit Bug 36120: Ensure pickup location and item can be picked in either order Signed-off-by: Nick Clemens <nick@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36120 --- Comment #110 from Nick Clemens <nick@bywatersolutions.com> --- Created attachment 165433 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=165433&action=edit Bug 36120: (follow-up) Only display locations for bookable items This patch updates the pickup locations picker to only include locations for items that are bookable. We should look at doing this on the API level as it highlights some issues with re-using item holds pickup location rules. Signed-off-by: Nick Clemens <nick@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36120 --- Comment #111 from Nick Clemens <nick@bywatersolutions.com> --- Created attachment 165434 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=165434&action=edit Bug 36120: Restore edit Signed-off-by: Nick Clemens <nick@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36120 --- Comment #112 from Nick Clemens <nick@bywatersolutions.com> --- Created attachment 165435 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=165435&action=edit Bug 36120: (QA follow-up) Tidy Signed-off-by: Nick Clemens <nick@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36120 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Failed QA --- Comment #113 from Nick Clemens <nick@bywatersolutions.com> --- t/db_dependent/api/v1/biblios.t -s failing after these patch sets -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36120 --- Comment #114 from Nick Clemens <nick@bywatersolutions.com> --- Also: t/db_dependent/Circulation.t t/db_dependent/api/v1/bookings.t -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36120 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #165419|0 |1 is obsolete| | --- Comment #115 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 165984 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=165984&action=edit Bug 36120: Add pickup_library_id to bookings table Sponsored-by: Cuyahoga County Public Library Signed-off-by: Lisette Scheer <lisette.scheer@bywatersolutions.com> Signed-off-by: Kristi Krueger <kkrueger@cuyahogalibrary.org> Signed-off-by: Nick Clemens <nick@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36120 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #165420|0 |1 is obsolete| | Attachment #165427|0 |1 is obsolete| | --- Comment #116 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 165985 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=165985&action=edit Bug 36120: Schema update Sponsored-by: Cuyahoga County Public Library Signed-off-by: Lisette Scheer <lisette.scheer@bywatersolutions.com> Signed-off-by: Kristi Krueger <kkrueger@cuyahogalibrary.org> Signed-off-by: Nick Clemens <nick@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36120 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #165421|0 |1 is obsolete| | --- Comment #117 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 165986 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=165986&action=edit Bug 36120: Add pickup_items to the pickup_locations response This patch adds pickup_items as a list of itemnumbers that can be picked from the library should it be selected as a pickup location. Sponsored-by: Cuyahoga County Public Library Signed-off-by: Lisette Scheer <lisette.scheer@bywatersolutions.com> Signed-off-by: Kristi Krueger <kkrueger@cuyahogalibrary.org> Signed-off-by: Nick Clemens <nick@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36120 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #165422|0 |1 is obsolete| | --- Comment #118 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 165987 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=165987&action=edit Bug 36120: Add pickup_library support to bookings API Sponsored-by: Cuyahoga County Public Library Signed-off-by: Lisette Scheer <lisette.scheer@bywatersolutions.com> Signed-off-by: Kristi Krueger <kkrueger@cuyahogalibrary.org> Signed-off-by: Nick Clemens <nick@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36120 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #165423|0 |1 is obsolete| | --- Comment #119 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 165988 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=165988&action=edit Bug 36120: Add pickup locations to place bookings modal This patch adds a call to /biblios/biblionumber/pickup_locations to fetch valid pickup locations for the biblio. Upon selecting a pickup location we adapt the item select to only allow for selecting items returned as valid for pickup at the selected location. Sponsored-by: Cuyahoga County Public Library Signed-off-by: Lisette Scheer <lisette.scheer@bywatersolutions.com> Signed-off-by: Kristi Krueger <kkrueger@cuyahogalibrary.org> Signed-off-by: Nick Clemens <nick@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36120 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #165424|0 |1 is obsolete| | --- Comment #120 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 165989 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=165989&action=edit Bug 36120: Add pickup library to bookings list table Sponsored-by: Cuyahoga County Public Library Signed-off-by: Lisette Scheer <lisette.scheer@bywatersolutions.com> Signed-off-by: Kristi Krueger <kkrueger@cuyahogalibrary.org> Signed-off-by: Nick Clemens <nick@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36120 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #165425|0 |1 is obsolete| | --- Comment #121 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 165990 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=165990&action=edit Bug 36120: Ensure existing bookings are assigned a pickup library Sponsored-by: Cuyahoga County Public Library Signed-off-by: Lisette Scheer <lisette.scheer@bywatersolutions.com> Signed-off-by: Kristi Krueger <kkrueger@cuyahogalibrary.org> Signed-off-by: Nick Clemens <nick@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36120 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #165426|0 |1 is obsolete| | --- Comment #122 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 165991 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=165991&action=edit Bug 36120: Ensure pickup_library_id is NOT NULL This patch updates the database schema to ensure bookings.pickup_library_id is NOT NULL Signed-off-by: Nick Clemens <nick@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36120 --- Comment #123 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 165992 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=165992&action=edit Bug 36120: Schema update Signed-off-by: Nick Clemens <nick@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36120 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #165428|0 |1 is obsolete| | --- Comment #124 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 165993 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=165993&action=edit Bug 36120: Add unit test for pickup_library relation accessor This patch adds a unit test for the newly introduced pickup_library accessor added to Koha::Booking Signed-off-by: Nick Clemens <nick@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36120 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #165429|0 |1 is obsolete| | --- Comment #125 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 165994 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=165994&action=edit Bug 36120: Unit tests for pickup_locations change This patch adds unit tests for the additional caching of location_items in the pickup_locations method of Koha::Biblio. Signed-off-by: Nick Clemens <nick@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36120 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #165430|0 |1 is obsolete| | --- Comment #126 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 165995 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=165995&action=edit Bug 36120: Re-enable 'Any item' selectable Signed-off-by: Nick Clemens <nick@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36120 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #165431|0 |1 is obsolete| | --- Comment #127 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 165996 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=165996&action=edit Bug 36120: Account for both pickup_location and date selection in items This patch ensures we account for both pickup location and date selections having taken place before an item selection is pondered. We now correctly disable item options given both conditions rather than it being a race between the two. Signed-off-by: Nick Clemens <nick@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36120 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #165432|0 |1 is obsolete| | --- Comment #128 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 165997 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=165997&action=edit Bug 36120: Ensure pickup location and item can be picked in either order Signed-off-by: Nick Clemens <nick@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36120 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #165433|0 |1 is obsolete| | --- Comment #129 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 165998 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=165998&action=edit Bug 36120: (follow-up) Only display locations for bookable items This patch updates the pickup locations picker to only include locations for items that are bookable. We should look at doing this on the API level as it highlights some issues with re-using item holds pickup location rules. Signed-off-by: Nick Clemens <nick@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36120 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #165434|0 |1 is obsolete| | --- Comment #130 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 165999 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=165999&action=edit Bug 36120: Restore edit Signed-off-by: Nick Clemens <nick@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36120 --- Comment #131 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 166000 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=166000&action=edit Bug 36120: (QA follow-up) Fix /biblios.t unit test This patch adds some mock data for pickup_items getting included in the pickup locations response. Signed-off-by: Nick Clemens <nick@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36120 --- Comment #132 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 166001 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=166001&action=edit Bug 36120: (QA follow-up) Fix Circulation.t We now require pickup_library_id and so need to update the unit tests to reflect that for our sample bookings Signed-off-by: Nick Clemens <nick@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36120 --- Comment #133 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 166002 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=166002&action=edit Bug 36120: (QA follow-up) Fix api/v1/bookings.t We now require pickup_library_id and so need to update the unit tests to reflect that for our sample bookings Signed-off-by: Nick Clemens <nick@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36120 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia@bugs.koha-communit |nick@bywatersolutions.com |y.org | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36120 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36120 --- Comment #134 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Tests all passing now and full set rebased. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36120 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #165435|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36120 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- URL|https://github.com/PTFS-Eur | |ope/koha/tree/bug_36120 | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36120 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords| |rel_24_05_candidate -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36120 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords|rel_24_05_candidate |release-notes-needed Summary|Add pickup locations to |Add pickup locations to |Bookings |bookings -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36120 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to main Version(s)| |24.05.00 released in| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36120 --- Comment #135 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Pushed for 24.05! Well done everyone, thank you! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36120 Marie <marie.hedbom@musikverket.se> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |marie.hedbom@musikverket.se -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36120 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords|release-notes-needed | Text to go in the| |This enhancement adds the release notes| |requirement to pick a | |pickup location when | |placing a booking. | | | |**Sponsored by** *Cuyahoga | |County Public Library* -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36120 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Text to go in the|This enhancement adds the |This enhancement adds the release notes|requirement to pick a |requirement to pick a |pickup location when |pickup location when |placing a booking. |placing a booking. | | |**Sponsored by** *Cuyahoga | |County Public Library* | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36120 Fridolin Somers <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to main |Needs documenting CC| |fridolin.somers@biblibre.co | |m --- Comment #136 from Fridolin Somers <fridolin.somers@biblibre.com> --- Not backported to 23.11.x -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36120 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |37000 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37000 [Bug 37000] Upgrade fails at 23.12.00.044 [bug 36120] -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36120 Bug 36120 depends on bug 36374, which changed state. Bug 36374 Summary: Some of our JS files should stay tidy https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36374 What |Removed |Added ---------------------------------------------------------------------------- Status|Needs documenting |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36120 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on|36374 | Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36374 [Bug 36374] Some of our JS files should stay tidy -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36120 Paul Derscheid <paul.derscheid@lmscloud.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |37618 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37618 [Bug 37618] Select patron's, then item's home library by default for pickup location when creating bookings -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36120 Martin Renvoize (ashimema) <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks|37618 | Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37618 [Bug 37618] Select patron's, then item's home library by default for pickup location when creating bookings -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36120 Aude Charillon <aude.charillon@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Documentation| |https://gitlab.com/koha-com submission| |munity/koha-manual/-/merge_ | |requests/1009 Documentation| |Aude Charillon contact| | CC| |aude.charillon@ptfs-europe. | |com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36120 Aude Charillon <aude.charillon@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |FIXED Status|Needs documenting |RESOLVED --- Comment #137 from Aude Charillon <aude.charillon@ptfs-europe.com> --- Included in the Koha Manual. -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org