[Bug 41616] New: Warnings on authority_hooks.t
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41616 Bug ID: 41616 Summary: Warnings on authority_hooks.t Initiative type: --- Sponsorship --- status: Product: Koha Version: 24.11 Hardware: All OS: All Status: NEW Severity: minor Priority: P5 - low Component: Test Suite Assignee: chris@bigballofwax.co.nz Reporter: tomascohen@gmail.com QA Contact: testopia@bugs.koha-community.org Bug 36433 introduced a plugin hook for elasticsearch document generation, which makes the `authority_hooks.t` print some useless noise when ES is enabled in the context: ```shell prove t/db_dependent/Koha/Plugins/t/db_dependent/Koha/Plugins/authority_hooks.t t/db_dependent/Koha/Plugins/authority_hooks.t ................. 1/5 Plugin error (Test Plugin): Exception 'Koha::Exception' thrown 'elasticsearch_to_document ref record: MARC::Record - ref document: HASH' Plugin error (Test Plugin): Exception 'Koha::Exception' thrown 'elasticsearch_to_document ref record: MARC::Record - ref document: HASH' t/db_dependent/Koha/Plugins/authority_hooks.t ................. ok All tests successful. Files=20, Tests=119, 24 wallclock secs ( 0.04 usr 0.02 sys + 17.89 cusr 2.33 csys = 20.28 CPU) Result: PASS ``` -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41616 Tomás Cohen Arazi (tcohen) <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |36433, 27173 Assignee|chris@bigballofwax.co.nz |tomascohen@gmail.com Version|24.11 |Main Status|NEW |Needs Signoff CC| |tomascohen@gmail.com Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27173 [Bug 27173] Add plugin hooks for authority record changes https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36433 [Bug 36433] Plugin hook elasticsearch_to_document -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41616 Tomás Cohen Arazi (tcohen) <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41616 --- Comment #1 from Tomás Cohen Arazi (tcohen) <tomascohen@gmail.com> --- Created attachment 191434 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=191434&action=edit Bug 41616: Silence warning in authority_hooks.t This patch silences a useless warning that is printed when in ES context. To test: 1. Launch a KTD instance with ES enabled: $ ktd --proxy --name 41616 --search-engine es8 up -d $ ktd --name 41616 --wait-ready 120 2. Run: $ ktd --name 41616 --shell k$ prove t/db_dependent/Koha/Plugins/authority_hooks.t => SUCCESS: Tests pass => FAIL: You see: ```shell prove t/db_dependent/Koha/Plugins/authority_hooks.t t/db_dependent/Koha/Plugins/authority_hooks.t ................. 1/5 Plugin error (Test Plugin): Exception 'Koha::Exception' thrown 'elasticsearch_to_document ref record: MARC::Record - ref document: HASH' Plugin error (Test Plugin): Exception 'Koha::Exception' thrown 'elasticsearch_to_document ref record: MARC::Record - ref document: HASH' t/db_dependent/Koha/Plugins/authority_hooks.t ................. ok All tests successful. Files=20, Tests=119, 24 wallclock secs ( 0.04 usr 0.02 sys + 17.89 cusr 2.33 csys = 20.28 CPU) Result: PASS ``` 3. Apply this patch 4. Repeat 2 => SUCCESS: No tests changes, but no more weird warnings about elasticsearch 5. Sign off :-D 6. Cleanup: $ ktd --name 41616 down Signed-off-by: Tomás Cohen Arazi <tomascohen@theke.io> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41616 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41616 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #191434|0 |1 is obsolete| | --- Comment #2 from David Nind <david@davidnind.com> --- Created attachment 191550 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=191550&action=edit Bug 41616: Silence warning in authority_hooks.t This patch silences a useless warning that is printed when in ES context. To test: 1. Launch a KTD instance with ES enabled: $ ktd --proxy --name 41616 --search-engine es8 up -d $ ktd --name 41616 --wait-ready 120 2. Run: $ ktd --name 41616 --shell k$ prove t/db_dependent/Koha/Plugins/authority_hooks.t => SUCCESS: Tests pass => FAIL: You see: ```shell prove t/db_dependent/Koha/Plugins/authority_hooks.t t/db_dependent/Koha/Plugins/authority_hooks.t ................. 1/5 Plugin error (Test Plugin): Exception 'Koha::Exception' thrown 'elasticsearch_to_document ref record: MARC::Record - ref document: HASH' Plugin error (Test Plugin): Exception 'Koha::Exception' thrown 'elasticsearch_to_document ref record: MARC::Record - ref document: HASH' t/db_dependent/Koha/Plugins/authority_hooks.t ................. ok All tests successful. Files=20, Tests=119, 24 wallclock secs ( 0.04 usr 0.02 sys + 17.89 cusr 2.33 csys = 20.28 CPU) Result: PASS ``` 3. Apply this patch 4. Repeat 2 => SUCCESS: No tests changes, but no more weird warnings about elasticsearch 5. Sign off :-D 6. Cleanup: $ ktd --name 41616 down Signed-off-by: Tomás Cohen Arazi <tomascohen@theke.io> Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41616 Jan Kissig <bibliothek@th-wildau.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41616 Jan Kissig <bibliothek@th-wildau.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #191550|0 |1 is obsolete| | --- Comment #3 from Jan Kissig <bibliothek@th-wildau.de> --- Created attachment 193983 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=193983&action=edit Bug 41616: Silence warning in authority_hooks.t This patch silences a useless warning that is printed when in ES context. To test: 1. Launch a KTD instance with ES enabled: $ ktd --proxy --name 41616 --search-engine es8 up -d $ ktd --name 41616 --wait-ready 120 2. Run: $ ktd --name 41616 --shell k$ prove t/db_dependent/Koha/Plugins/authority_hooks.t => SUCCESS: Tests pass => FAIL: You see: ```shell prove t/db_dependent/Koha/Plugins/authority_hooks.t t/db_dependent/Koha/Plugins/authority_hooks.t ................. 1/5 Plugin error (Test Plugin): Exception 'Koha::Exception' thrown 'elasticsearch_to_document ref record: MARC::Record - ref document: HASH' Plugin error (Test Plugin): Exception 'Koha::Exception' thrown 'elasticsearch_to_document ref record: MARC::Record - ref document: HASH' t/db_dependent/Koha/Plugins/authority_hooks.t ................. ok All tests successful. Files=20, Tests=119, 24 wallclock secs ( 0.04 usr 0.02 sys + 17.89 cusr 2.33 csys = 20.28 CPU) Result: PASS ``` 3. Apply this patch 4. Repeat 2 => SUCCESS: No tests changes, but no more weird warnings about elasticsearch 5. Sign off :-D 6. Cleanup: $ ktd --name 41616 down Signed-off-by: Tomás Cohen Arazi <tomascohen@theke.io> Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41616 Jan Kissig <bibliothek@th-wildau.de> changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia@bugs.koha-communit |bibliothek@th-wildau.de |y.org | CC| |bibliothek@th-wildau.de -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41616 Lucas Gass (lukeg) <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to main Version(s)| |26.05.00 released in| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41616 --- Comment #4 from Lucas Gass (lukeg) <lucas@bywatersolutions.com> --- Nice work everyone! Pushed to main for 26.05 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41616 Jacob O'Mara <jacob.omara@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)|26.05.00 |26.05.00,25.11.04 released in| | Status|Pushed to main |Pushed to stable -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41616 --- Comment #5 from Jacob O'Mara <jacob.omara@openfifth.co.uk> --- Thanks all, pushed to 25.11.x -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org