[Bug 38167] New: ESLint: migrate config to flat format + cleanup some node dependencies
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38167 Bug ID: 38167 Summary: ESLint: migrate config to flat format + cleanup some node dependencies Change sponsored?: --- Product: Koha Version: Main Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Architecture, internals, and plumbing Assignee: koha-bugs@lists.koha-community.org Reporter: victor@tuxayo.net QA Contact: testopia@bugs.koha-community.org ESLint9 switched to a new config file format[1]. Using the old config format looks like this: ESLINT_USE_FLAT_CONFIG='false' eslint koha-tmpl/intranet-tmpl/prog/js/ajax.js So here we will be doing the migration like this: npx @eslint/migrate-config .eslintrc.json https://eslint.org/docs/latest/use/configure/migration-guide [1] https://eslint.org/docs/latest/use/configure/configuration-files https://eslint.org/blog/2022/08/new-config-system-part-1/ https://eslint.org/blog/2022/08/new-config-system-part-2/ ----- The goal of this is to make it easier to check guideline JS8 https://wiki.koha-community.org/wiki/Coding_Guidelines#JS8:_Follow_guideline... And be one step closer to able to check it on .vue and .ts files -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38167 --- Comment #1 from Victor Grousset/tuxayo <victor@tuxayo.net> --- Created attachment 172754 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=172754&action=edit Bug 38167: Migrate ESLint config to new flat format Test: 1. Do not apply 2. eslint koha-tmpl/intranet-tmpl/prog/js/ajax.js 3. It should fail 4. ESLINT_USE_FLAT_CONFIG='false' eslint koha-tmpl/intranet-tmpl/prog/js/ajax.js 5. It should work 6. Apply patches 7. Restart KTD to have a clean state of dependencies and check that provisionning still works. 8. ESLINT_USE_FLAT_CONFIG='false' eslint koha-tmpl/intranet-tmpl/prog/js/ajax.js 9. It should fail 10. eslint koha-tmpl/intranet-tmpl/prog/js/ajax.js 11. It should work 12 Double check rspack still works: rspack build Because we removed babel. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38167 --- Comment #2 from Victor Grousset/tuxayo <victor@tuxayo.net> --- Created attachment 172755 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=172755&action=edit Bug 38167: Remove Babel which was only used by Webpack And our old versions was depending on a old buggy version of "globals" that broke ESLint when using new config file format. Removing Babel if it's not used anymore instead of updating it. (There would be a way to test the updat works anyway. @vue/cli-service was depending on babel core. Removing it since it's deprecated (see replacements below) instead having to keep a subset of Babel packages and updating them. https://cli.vuejs.org/#getting-started https://github.com/vuejs/vue-cli -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38167 Victor Grousset/tuxayo <victor@tuxayo.net> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |38149, 37824 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37824 [Bug 37824] Replace webpack with rspack for fun and profit https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38149 [Bug 38149] Make ESLint config compatible with version 9 and have ESLint and Prettier installed by default -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38167 Victor Grousset/tuxayo <victor@tuxayo.net> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38167 --- Comment #3 from Victor Grousset/tuxayo <victor@tuxayo.net> --- If this is merged as it is. A note will have to be left in bug 37824 because
- we can always fallback onto webpack, it's not going anywhere.
To leave a trace of changes that relevant to an eventual fallback to webpack. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38167 --- Comment #4 from Victor Grousset/tuxayo <victor@tuxayo.net> --- Created attachment 173070 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=173070&action=edit Bug 38167: Remove remaining @vue/cli-service use -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38167 --- Comment #5 from Victor Grousset/tuxayo <victor@tuxayo.net> --- Created attachment 173071 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=173071&action=edit Bug 38167: Make Prettier and ESLint happier for cypress/plugins/index.js -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38167 Paul Derscheid <paul.derscheid@lmscloud.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #172754|0 |1 is obsolete| | --- Comment #6 from Paul Derscheid <paul.derscheid@lmscloud.de> --- Created attachment 174429 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=174429&action=edit Bug 38167: Migrate ESLint config to new flat format Test: 1. Do not apply 2. eslint koha-tmpl/intranet-tmpl/prog/js/ajax.js 3. It should fail 4. ESLINT_USE_FLAT_CONFIG='false' eslint koha-tmpl/intranet-tmpl/prog/js/ajax.js 5. It should work 6. Apply patches 7. Restart KTD to have a clean state of dependencies and check that provisionning still works. 8. ESLINT_USE_FLAT_CONFIG='false' eslint koha-tmpl/intranet-tmpl/prog/js/ajax.js 9. It should fail 10. eslint koha-tmpl/intranet-tmpl/prog/js/ajax.js 11. It should work 12 Double check rspack still works: rspack build Because we removed babel. Signed-off-by: Paul Derscheid <paul.derscheid@lmscloud.de> -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38167 Paul Derscheid <paul.derscheid@lmscloud.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #172755|0 |1 is obsolete| | --- Comment #7 from Paul Derscheid <paul.derscheid@lmscloud.de> --- Created attachment 174430 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=174430&action=edit Bug 38167: Remove Babel which was only used by Webpack And our old versions was depending on a old buggy version of "globals" that broke ESLint when using new config file format. Removing Babel if it's not used anymore instead of updating it. (There would be a way to test the updat works anyway. @vue/cli-service was depending on babel core. Removing it since it's deprecated (see replacements below) instead having to keep a subset of Babel packages and updating them. https://cli.vuejs.org/#getting-started https://github.com/vuejs/vue-cli Signed-off-by: Paul Derscheid <paul.derscheid@lmscloud.de> -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38167 Paul Derscheid <paul.derscheid@lmscloud.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #173070|0 |1 is obsolete| | --- Comment #8 from Paul Derscheid <paul.derscheid@lmscloud.de> --- Created attachment 174431 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=174431&action=edit Bug 38167: Remove remaining @vue/cli-service use Signed-off-by: Paul Derscheid <paul.derscheid@lmscloud.de> -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38167 Paul Derscheid <paul.derscheid@lmscloud.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #173071|0 |1 is obsolete| | --- Comment #9 from Paul Derscheid <paul.derscheid@lmscloud.de> --- Created attachment 174432 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=174432&action=edit Bug 38167: Make Prettier and ESLint happier for cypress/plugins/index.js Signed-off-by: Paul Derscheid <paul.derscheid@lmscloud.de> -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38167 Paul Derscheid <paul.derscheid@lmscloud.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off CC| |paul.derscheid@lmscloud.de -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38167 Paul Derscheid <paul.derscheid@lmscloud.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |38426 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38426 [Bug 38426] Node.js v18 EOL around 25.05 release time -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38167 Jonathan Druart <jonathan.druart@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart@gmail.com --- Comment #10 from Jonathan Druart <jonathan.druart@gmail.com> --- (In reply to Paul Derscheid from comment #8)
Created attachment 174431 [details] [review] Bug 38167: Remove remaining @vue/cli-service use
Signed-off-by: Paul Derscheid <paul.derscheid@lmscloud.de>
Isn't this occurrence of "vue-cli" related? cypress.config.ts: framework: "vue-cli", -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38167 Tomás Cohen Arazi (tcohen) <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |tomascohen@gmail.com Assignee|koha-bugs@lists.koha-commun |victor@tuxayo.net |ity.org | -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38167 Jonathan Druart <jonathan.druart@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38167 --- Comment #11 from Victor Grousset/tuxayo <victor@tuxayo.net> --- Good find, I guess it is. Context: ``` component: { devServer: { framework: "vue-cli", bundler: "webpack", }, ``` What operation could use this config? Because just running the tests didn't use this and didn't fail. Whereas the stuff removed in the commit had to be removed to be able run the tests. https://docs.cypress.io/app/component-testing/component-framework-configurat...
Custom Dev Server A custom function can be passed into the devServer option, which allows the use of build systems not provided by Cypress out of the box.
After this plus other search it's still blurry what is a dev server. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38167 --- Comment #12 from Paul Derscheid <paul.derscheid@lmscloud.de> --- I think this is unused because we don't have component tests yet. If I am not mistaken we just went e2e. There's https://www.npmjs.com/package/cypress-rspack-dev-server (btw) but it doesn't support vue yet (just react). -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38167 --- Comment #13 from Paul Derscheid <paul.derscheid@lmscloud.de> --- But if we don't have any yet, I just want to casually advocate for adding component tests in the future. Huge gains in actual test coverage for behaviour, comparatively little effort. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38167 Victor Grousset/tuxayo <victor@tuxayo.net> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #174429|0 |1 is obsolete| | --- Comment #14 from Victor Grousset/tuxayo <victor@tuxayo.net> --- Created attachment 174855 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=174855&action=edit Bug 38167: Migrate ESLint config to new flat format Test: 1. Do not apply 2. eslint koha-tmpl/intranet-tmpl/prog/js/ajax.js 3. It should fail 4. ESLINT_USE_FLAT_CONFIG='false' eslint koha-tmpl/intranet-tmpl/prog/js/ajax.js 5. It should work 6. Apply patches 7. Restart KTD to have a clean state of dependencies and check that provisionning still works. 8. ESLINT_USE_FLAT_CONFIG='false' eslint koha-tmpl/intranet-tmpl/prog/js/ajax.js 9. It should fail 10. eslint koha-tmpl/intranet-tmpl/prog/js/ajax.js 11. It should work 12 Double check rspack still works: rspack build Because we removed babel. Signed-off-by: Paul Derscheid <paul.derscheid@lmscloud.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38167 Victor Grousset/tuxayo <victor@tuxayo.net> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #174430|0 |1 is obsolete| | --- Comment #15 from Victor Grousset/tuxayo <victor@tuxayo.net> --- Created attachment 174856 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=174856&action=edit Bug 38167: Remove Babel which was only used by Webpack And our old versions was depending on a old buggy version of "globals" that broke ESLint when using new config file format. Removing Babel if it's not used anymore instead of updating it. (There would be a way to test the updat works anyway. @vue/cli-service was depending on babel core. Removing it since it's deprecated (see replacements below) instead having to keep a subset of Babel packages and updating them. https://cli.vuejs.org/#getting-started https://github.com/vuejs/vue-cli Signed-off-by: Paul Derscheid <paul.derscheid@lmscloud.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38167 --- Comment #16 from Victor Grousset/tuxayo <victor@tuxayo.net> --- Created attachment 174857 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=174857&action=edit Bug 38167: [DO NOT PUSH] yarn.lock changes And our old versions was depending on a old buggy version of "globals" that broke ESLint when using new config file format. Removing Babel if it's not used anymore instead of updating it. (There would be a way to test the updat works anyway. @vue/cli-service was depending on babel core. Removing it since it's deprecated (see replacements below) instead having to keep a subset of Babel packages and updating them. https://cli.vuejs.org/#getting-started https://github.com/vuejs/vue-cli Signed-off-by: Paul Derscheid <paul.derscheid@lmscloud.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38167 Victor Grousset/tuxayo <victor@tuxayo.net> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #174431|0 |1 is obsolete| | --- Comment #17 from Victor Grousset/tuxayo <victor@tuxayo.net> --- Created attachment 174858 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=174858&action=edit Bug 38167: Remove remaining @vue/cli-service use Signed-off-by: Paul Derscheid <paul.derscheid@lmscloud.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38167 Victor Grousset/tuxayo <victor@tuxayo.net> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #174432|0 |1 is obsolete| | --- Comment #18 from Victor Grousset/tuxayo <victor@tuxayo.net> --- Created attachment 174859 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=174859&action=edit Bug 38167: Make Prettier and ESLint happier for cypress/plugins/index.js Signed-off-by: Paul Derscheid <paul.derscheid@lmscloud.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38167 --- Comment #19 from Victor Grousset/tuxayo <victor@tuxayo.net> --- Rebased and split yarn.lock changes to their own commit. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38167 --- Comment #20 from Victor Grousset/tuxayo <victor@tuxayo.net> --- (In reply to Paul Derscheid from comment #12)
I think this is unused because we don't have component tests yet.
If I am not mistaken we just went e2e.
There's https://www.npmjs.com/package/cypress-rspack-dev-server (btw) but it doesn't support vue yet (just react).
Indeed: https://github.com/th3fallen/cypress-rspack-dev-server/issues/3 (In reply to Paul Derscheid from comment #13)
But if we don't have any yet, I just want to casually advocate for adding component tests in the future.
Huge gains in actual test coverage for behaviour, comparatively little effort.
That would have been a reason to consider staying on webpack but as we see here, we could only know about cypress-rspack-dev-server existence and limitations after starting removing webpack dependencies. And thus making rolling back not a drop in replacement >_< Should we just remove the `component` object from the config? Or leave it (as it's unused) so if someone wants to do component tests it's easier to adapt to cypress-rspack-dev-server? (whether it supports rspack or we have to come back to webpack) -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38167 --- Comment #21 from Paul Derscheid <paul.derscheid@lmscloud.de> --- I think we can remove it since it's unused and the default config, so we lose nothing (and it's in git anyway). We could probably also use webpack for component tests (but rspack would probably be faster), since the bundling method is not thaaaaaaat relevant imo. I also think it won't take forever for cypress to adopt the rspack dev server under their official namespace once support for vue, svelte and angular is added. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38167 --- Comment #22 from Paul Derscheid <paul.derscheid@lmscloud.de> --- We can no longer remove it as we now need @vue/cli-service for mockData.js. I could however resolve the issue by upgrading @vue/cli-service to its latests version (which depends on @achrinza/node-ipc@9.2.9 which is compatible with node v22. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38167 Victor Grousset/tuxayo <victor@tuxayo.net> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |38524 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38524 [Bug 38524] Add support for Vue.js and TypeScript to ESLint config to be able to actually enforce coding guideline JS8 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38167 --- Comment #23 from Victor Grousset/tuxayo <victor@tuxayo.net> --- How exactly does mockData.js need @vue/cli-service ? See bug 38503 comment 11 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38167 Victor Grousset/tuxayo <victor@tuxayo.net> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #174855|0 |1 is obsolete| | --- Comment #24 from Victor Grousset/tuxayo <victor@tuxayo.net> --- Created attachment 175427 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=175427&action=edit Bug 38167: Migrate ESLint config to new flat format Test: 1. Do not apply 2. eslint koha-tmpl/intranet-tmpl/prog/js/ajax.js 3. It should fail 4. ESLINT_USE_FLAT_CONFIG='false' eslint koha-tmpl/intranet-tmpl/prog/js/ajax.js 5. It should work 6. Apply patches 7. Restart KTD to have a clean state of dependencies and check that provisionning still works. 8. ESLINT_USE_FLAT_CONFIG='false' eslint koha-tmpl/intranet-tmpl/prog/js/ajax.js 9. It should fail 10. eslint koha-tmpl/intranet-tmpl/prog/js/ajax.js 11. It should work 12 Double check rspack still works: rspack build Because we removed babel. Signed-off-by: Paul Derscheid <paul.derscheid@lmscloud.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38167 Victor Grousset/tuxayo <victor@tuxayo.net> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #174856|0 |1 is obsolete| | --- Comment #25 from Victor Grousset/tuxayo <victor@tuxayo.net> --- Created attachment 175428 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=175428&action=edit Bug 38167: Remove Babel which was only used by Webpack And our old versions was depending on a old buggy version of "globals" that broke ESLint when using new config file format. Removing Babel if it's not used anymore instead of updating it. (There would be a way to test the updat works anyway. @vue/cli-service was depending on babel core. Removing it since it's deprecated (see replacements below) instead having to keep a subset of Babel packages and updating them. https://cli.vuejs.org/#getting-started https://github.com/vuejs/vue-cli Signed-off-by: Paul Derscheid <paul.derscheid@lmscloud.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38167 Victor Grousset/tuxayo <victor@tuxayo.net> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #174857|0 |1 is obsolete| | --- Comment #26 from Victor Grousset/tuxayo <victor@tuxayo.net> --- Created attachment 175429 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=175429&action=edit Bug 38167: [DO NOT PUSH] yarn.lock changes Signed-off-by: Paul Derscheid <paul.derscheid@lmscloud.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38167 --- Comment #27 from Victor Grousset/tuxayo <victor@tuxayo.net> --- Created attachment 175430 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=175430&action=edit Bug 38167: Remove remaining @vue/cli-service uses Signed-off-by: Paul Derscheid <paul.derscheid@lmscloud.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38167 Victor Grousset/tuxayo <victor@tuxayo.net> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #174859|0 |1 is obsolete| | --- Comment #28 from Victor Grousset/tuxayo <victor@tuxayo.net> --- Created attachment 175431 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=175431&action=edit Bug 38167: Make Prettier and ESLint happier for cypress/plugins/index.js Signed-off-by: Paul Derscheid <paul.derscheid@lmscloud.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38167 Victor Grousset/tuxayo <victor@tuxayo.net> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #174858|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38167 Victor Grousset/tuxayo <victor@tuxayo.net> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Signed Off --- Comment #29 from Victor Grousset/tuxayo <victor@tuxayo.net> --- comment 10 addressed (another occurrence of "vue-cli" removed) rebased on the updated bug 38149 patches that bumped prettier's version compared to when they were first submitted eslint and rspack commands in test plan still work so doesn't look like that would invalidate the previous signoff. -------------------------------- (In reply to Paul Derscheid from comment #22)
We can no longer remove it as we now need @vue/cli-service for mockData.js.
Testing on bug 38503 and bug 38461 without @vue/cli-service worked so it seem we can keep the removal :D -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38167 Victor Grousset/tuxayo <victor@tuxayo.net> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |38770 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38770 [Bug 38770] Remove @vue/cli-service and babel -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38167 Victor Grousset/tuxayo <victor@tuxayo.net> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #175428|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38167 Victor Grousset/tuxayo <victor@tuxayo.net> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #175429|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38167 Victor Grousset/tuxayo <victor@tuxayo.net> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #175430|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38167 Victor Grousset/tuxayo <victor@tuxayo.net> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks|38426 | Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38426 [Bug 38426] Node.js v18 EOL around 25.05 release time -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38167 Victor Grousset/tuxayo <victor@tuxayo.net> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #175427|0 |1 is obsolete| | --- Comment #30 from Victor Grousset/tuxayo <victor@tuxayo.net> --- Created attachment 175897 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=175897&action=edit Bug 38167: Migrate ESLint config to new flat format Test: 1. Do not apply 2. eslint koha-tmpl/intranet-tmpl/prog/js/ajax.js 3. It should fail 4. ESLINT_USE_FLAT_CONFIG='false' eslint koha-tmpl/intranet-tmpl/prog/js/ajax.js 5. It should work 6. Apply patches BZ38700 will conflict with BZ38149 on yarn.lock solve conflict with sudo yarn install --modules-folder /kohadevbox/node_modules git bz apply --continue git will only continue for 38700 and don't actually apply this (38167) So retry git bz apply 38167 Don't apply the dependecies are they are already there. This time you're good :) (the conflict can't be durably solved because 38770 need to be applied independently or with BZ38149 depending on what other bug needs to be tested :/ ) 7. Restart KTD to have a clean state of dependencies and check that provisionning still works. 8. ESLINT_USE_FLAT_CONFIG='false' eslint koha-tmpl/intranet-tmpl/prog/js/ajax.js 9. It should fail 10. eslint koha-tmpl/intranet-tmpl/prog/js/ajax.js 11. It should work Signed-off-by: Paul Derscheid <paul.derscheid@lmscloud.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38167 Victor Grousset/tuxayo <victor@tuxayo.net> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #175431|0 |1 is obsolete| | --- Comment #31 from Victor Grousset/tuxayo <victor@tuxayo.net> --- Created attachment 175898 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=175898&action=edit Bug 38167: Make Prettier and ESLint happier for cypress/plugins/index.js Signed-off-by: Paul Derscheid <paul.derscheid@lmscloud.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38167 --- Comment #32 from Victor Grousset/tuxayo <victor@tuxayo.net> --- Retested after the removal of @vue/cli-service and babel was moved to bug 38770. Test plan got messier with the applying step but that doesn't seem to be avoidable with having node deps changes in bug 38770 that need to be applied here (so with bug 38149) or independently (because they are needed somewhere else without bug 38149) -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38167 Martin Renvoize (ashimema) <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #175897|0 |1 is obsolete| | --- Comment #33 from Martin Renvoize (ashimema) <martin.renvoize@ptfs-europe.com> --- Created attachment 176195 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=176195&action=edit Bug 38167: Migrate ESLint config to new flat format Test: 1. Do not apply 2. eslint koha-tmpl/intranet-tmpl/prog/js/ajax.js 3. It should fail 4. ESLINT_USE_FLAT_CONFIG='false' eslint koha-tmpl/intranet-tmpl/prog/js/ajax.js 5. It should work 6. Apply patches BZ38700 will conflict with BZ38149 on yarn.lock solve conflict with sudo yarn install --modules-folder /kohadevbox/node_modules git bz apply --continue git will only continue for 38700 and don't actually apply this (38167) So retry git bz apply 38167 Don't apply the dependecies are they are already there. This time you're good :) (the conflict can't be durably solved because 38770 need to be applied independently or with BZ38149 depending on what other bug needs to be tested :/ ) 7. Restart KTD to have a clean state of dependencies and check that provisionning still works. 8. ESLINT_USE_FLAT_CONFIG='false' eslint koha-tmpl/intranet-tmpl/prog/js/ajax.js 9. It should fail 10. eslint koha-tmpl/intranet-tmpl/prog/js/ajax.js 11. It should work Signed-off-by: Paul Derscheid <paul.derscheid@lmscloud.de> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38167 Martin Renvoize (ashimema) <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #175898|0 |1 is obsolete| | --- Comment #34 from Martin Renvoize (ashimema) <martin.renvoize@ptfs-europe.com> --- Created attachment 176196 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=176196&action=edit Bug 38167: Make Prettier and ESLint happier for cypress/plugins/index.js Signed-off-by: Paul Derscheid <paul.derscheid@lmscloud.de> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38167 Martin Renvoize (ashimema) <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA CC| |martin.renvoize@ptfs-europe | |.com QA Contact|testopia@bugs.koha-communit |martin.renvoize@ptfs-europe |y.org |.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38167 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |FIXED Status|Passed QA |RESOLVED --- Comment #35 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- see comment on bug 38149. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38167 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|FIXED |--- Status|RESOLVED |BLOCKED -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38167 Jonathan Druart <jonathan.druart@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|BLOCKED |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38167 --- Comment #36 from Jonathan Druart <jonathan.druart@gmail.com> --- Second patch is going to conflict with current main, do we really need it? IMO it's more a job for the "tidy all" bug (it will be done automatically there). -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38167 --- Comment #37 from Jonathan Druart <jonathan.druart@gmail.com> --- Comment on attachment 176196 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=176196 Bug 38167: Make Prettier and ESLint happier for cypress/plugins/index.js This is only tidying (I think!) and will be tidy later (bug 38664). As it conflicts now we can just drop it. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38167 Jonathan Druart <jonathan.druart@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #176196|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38167 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |25.05.00 released in| | Status|Passed QA |Pushed to main -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38167 --- Comment #38 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Pushed for 25.05! Well done everyone, thank you! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38167 --- Comment #39 from Paul Derscheid <paul.derscheid@lmscloud.de> --- Created attachment 176693 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=176693&action=edit Bug 38167: (QA follow-up) Remove old, add new eslint config to Makefile.PL To test: 1) Run t/Makefile.t, observe failure 2) Apply patch 3) Run t/Makefile.t, observe success -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38167 Bug 38167 depends on bug 37824, which changed state. Bug 37824 Summary: Replace webpack with rspack for fun and profit https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37824 What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to oldstable |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38167 Baptiste Wojtkowski (bwoj) <baptiste.wojtkowski@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |baptiste.wojtkowski@biblibr | |e.com Version(s)|25.05.00 |25.05.00,24.11.08 released in| | --- Comment #40 from Baptiste Wojtkowski (bwoj) <baptiste.wojtkowski@biblibre.com> --- Pushed into 24.11.x for 24.11.08 nice work everyone -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38167 Baptiste Wojtkowski (bwoj) <baptiste.wojtkowski@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to main |Pushed to stable -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38167 Bug 38167 depends on bug 38770, which changed state. Bug 38770 Summary: Remove @vue/cli-service and babel https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38770 What |Removed |Added ---------------------------------------------------------------------------- Status|Needs documenting |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38167 Wainui Witika-Park <wainuiwitikapark@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to stable |Needs documenting --- Comment #41 from Wainui Witika-Park <wainuiwitikapark@catalyst.net.nz> --- Not backporting to 22.11.x as it wasn't backported to 24.05.x -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38167 Bug 38167 depends on bug 38149, which changed state. Bug 38149 Summary: Make ESLint config compatible with version 9 and have ESLint and Prettier installed by default https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38149 What |Removed |Added ---------------------------------------------------------------------------- Status|Needs documenting |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38167 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |FIXED CC| |david@davidnind.com Status|Needs documenting |RESOLVED --- Comment #42 from David Nind <david@davidnind.com> --- Architecture related, no changes to the manual required. -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org