[Bug 14116] New: Silence noise t/Scrubber.t
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14116 Bug ID: 14116 Summary: Silence noise t/Scrubber.t Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Test Suite Assignee: chris@bigballofwax.co.nz Reporter: mtompset@hotmail.com QA Contact: gmcharlt@gmail.com Some diag's are better suited as prints. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14116 M. Tompsett <mtompset@hotmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|chris@bigballofwax.co.nz |mtompset@hotmail.com Blocks| |8879 Severity|enhancement |minor Status|NEW |ASSIGNED -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14116 M. Tompsett <mtompset@hotmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14116 --- Comment #1 from M. Tompsett <mtompset@hotmail.com> --- Created attachment 38757 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=38757&action=edit Bug 14116: Silence noisy output for t/Scrubber. Some diag's are better suited as prints. TEST PLAN --------- 1) $ prove t/Scrubber.t -- there's some noise. 2) apply patch 3) $ prove t/Scrubber.t -- noise issue resolved. Output is still reasonable for -v. 4) koha qa test tools -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14116 Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #38757|0 |1 is obsolete| | --- Comment #2 from Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> --- Created attachment 38906 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=38906&action=edit [SIGNED-OFF] Bug 14116: Silence noisy output for t/Scrubber. Some diag's are better suited as prints. TEST PLAN --------- 1) $ prove t/Scrubber.t -- there's some noise. 2) apply patch 3) $ prove t/Scrubber.t -- noise issue resolved. Output is still reasonable for -v. 4) koha qa test tools Signed-off-by: Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> Works, no koha-qa errors -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14116 Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |bgkriegel@gmail.com Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14116 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart@biblibre.co | |m --- Comment #3 from Jonathan Druart <jonathan.druart@biblibre.com> --- Actually I think we should just put these strings as comments. I don't see any usefulness to print them. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14116 --- Comment #4 from M. Tompsett <mtompset@hotmail.com> --- (In reply to Jonathan Druart from comment #3)
Actually I think we should just put these strings as comments. I don't see any usefulness to print them.
The point of the patch was to silence noise, not necessarily clean up output. ;) -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14116 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |tomascohen@gmail.com --- Comment #5 from Tomás Cohen Arazi <tomascohen@gmail.com> --- (In reply to M. Tompsett from comment #4)
(In reply to Jonathan Druart from comment #3)
Actually I think we should just put these strings as comments. I don't see any usefulness to print them.
The point of the patch was to silence noise, not necessarily clean up output. ;)
It only silences a part of the noise. New patch needed /me thinks. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14116 --- Comment #6 from M. Tompsett <mtompset@hotmail.com> --- (In reply to Tomás Cohen Arazi from comment #5)
It only silences a part of the noise. New patch needed /me thinks.
So, another commit on this bug? Or another bug report? -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14116 M. Tompsett <mtompset@hotmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #38906|0 |1 is obsolete| | --- Comment #7 from M. Tompsett <mtompset@hotmail.com> --- Created attachment 39615 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=39615&action=edit Bug 14116: Silence noisy output for t/Scrubber. Some diag's are better suited as prints. TEST PLAN --------- 1) $ prove t/Scrubber.t -- there's some noise. 2) apply patch 3) $ prove t/Scrubber.t -- noise issue resolved. Output is still reasonable for -v. 4) koha qa test tools Signed-off-by: Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> Works, no koha-qa errors -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14116 --- Comment #8 from M. Tompsett <mtompset@hotmail.com> --- Created attachment 39616 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=39616&action=edit Bug 14116: Clean up output, not just noise. Same test plan. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14116 M. Tompsett <mtompset@hotmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Needs Signoff --- Comment #9 from M. Tompsett <mtompset@hotmail.com> --- Added second commit that needs sign off. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14116 M. Tompsett <mtompset@hotmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #39615|0 |1 is obsolete| | Attachment #39616|0 |1 is obsolete| | --- Comment #10 from M. Tompsett <mtompset@hotmail.com> --- Created attachment 39617 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=39617&action=edit Bug 14116: Silence noisy output for t/Scrubber. Why diag or print out things, unless it is -v? And why print anything except success or failure type messages? This cleans up the output. TEST PLAN --------- 1) $ prove t/Scrubber.t -- there's some noise. 2) apply patch 3) $ prove t/Scrubber.t -- noise issue resolved. Output is still reasonable for -v. 4) koha qa test tools -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14116 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14116 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #39617|0 |1 is obsolete| | --- Comment #11 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Created attachment 39619 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=39619&action=edit [SIGNED OFF] Bug 14116: Silence noisy output for t/Scrubber. Why diag or print out things, unless it is -v? And why print anything except success or failure type messages? This cleans up the output. TEST PLAN --------- 1) $ prove t/Scrubber.t -- there's some noise. 2) apply patch 3) $ prove t/Scrubber.t -- noise issue resolved. Output is still reasonable for -v. 4) koha qa test tools Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14116 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14116 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #39619|0 |1 is obsolete| | --- Comment #12 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 39694 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=39694&action=edit [PASSED QA] Bug 14116: Silence noisy output for t/Scrubber. Why diag or print out things, unless it is -v? And why print anything except success or failure type messages? This cleans up the output. TEST PLAN --------- 1) $ prove t/Scrubber.t -- there's some noise. 2) apply patch 3) $ prove t/Scrubber.t -- noise issue resolved. Output is still reasonable for -v. 4) koha qa test tools Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14116 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master --- Comment #13 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Patch pushed to master. Thanks Mark! -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org