[Bug 14117] New: Silence warnings t/Search_PazPar2.t
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14117 Bug ID: 14117 Summary: Silence warnings t/Search_PazPar2.t Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Test Suite Assignee: chris@bigballofwax.co.nz Reporter: mtompset@hotmail.com QA Contact: gmcharlt@gmail.com Relative URLs trigger warnings. Test for them, instead of letting them loose on the screen. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14117 M. Tompsett <mtompset@hotmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|chris@bigballofwax.co.nz |mtompset@hotmail.com Blocks| |8879 Status|NEW |ASSIGNED Severity|enhancement |minor -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14117 M. Tompsett <mtompset@hotmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14117 --- Comment #1 from M. Tompsett <mtompset@hotmail.com> --- Created attachment 38758 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=38758&action=edit Bug 14117: Silence warnings t/SearchPazPar2.t The use of relative URLS (null actually), triggers warnings. Catch them, instead of letting them loose. TEST PLAN --------- 1) $ prove t/Search_PazPar2.t -- noise for each test currently. 2) apply patch 3) $ prove t/Search_PazPar2.t -- No noise, and extra tests added. -v shows caught warning tests. 4) koha qa test tools. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14117 Indranil Das Gupta <indradg@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #38758|0 |1 is obsolete| | --- Comment #2 from Indranil Das Gupta <indradg@gmail.com> --- Created attachment 39016 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=39016&action=edit Bug 14117: Silence warnings t/SearchPazPar2.t The use of relative URLS (null actually), triggers warnings. Catch them, instead of letting them loose. TEST PLAN --------- 1) $ prove t/Search_PazPar2.t -- noise for each test currently. 2) apply patch 3) $ prove t/Search_PazPar2.t -- No noise, and extra tests added. -v shows caught warning tests. 4) koha qa test tools. Signed-off-by: Indranil Das Gupta <indradg@gmail.com> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14117 Indranil Das Gupta <indradg@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off CC| |indradg@gmail.com -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14117 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart@biblibre.co | |m --- Comment #3 from Jonathan Druart <jonathan.druart@biblibre.com> --- Does the warning is expected? The tests you have added don't make any sense to me. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14117 --- Comment #4 from Jonathan Druart <jonathan.druart@biblibre.com> --- Actually the whole file don't make any sense... -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14117 --- Comment #5 from M. Tompsett <mtompset@hotmail.com> --- (In reply to Jonathan Druart from comment #4)
Actually the whole file don't make any sense...
Prior to the patch? -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14117 --- Comment #6 from Jonathan Druart <jonathan.druart@biblibre.com> --- yes -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14117 --- Comment #7 from M. Tompsett <mtompset@hotmail.com> --- (In reply to Jonathan Druart from comment #6)
yes
Because of yaz client? Or is there something else I'm missing? -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14117 --- Comment #8 from Jonathan Druart <jonathan.druart@biblibre.com> --- (In reply to M. Tompsett from comment #7)
(In reply to Jonathan Druart from comment #6)
yes
Because of yaz client? Or is there something else I'm missing?
Sorry I don't get it. I have just said that the file does not make sense, the tests are not really useful. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14117 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14117 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #39016|0 |1 is obsolete| | --- Comment #9 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 39693 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=39693&action=edit [PASSED QA] Bug 14117: Silence warnings t/SearchPazPar2.t The use of relative URLS (null actually), triggers warnings. Catch them, instead of letting them loose. TEST PLAN --------- 1) $ prove t/Search_PazPar2.t -- noise for each test currently. 2) apply patch 3) $ prove t/Search_PazPar2.t -- No noise, and extra tests added. -v shows caught warning tests. 4) koha qa test tools. Signed-off-by: Indranil Das Gupta <indradg@gmail.com> Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14117 --- Comment #10 from M. Tompsett <mtompset@hotmail.com> --- (In reply to Jonathan Druart from comment #8)
[SNIP] the tests are not really useful.
I have to agree, but this at least makes them quiet. Though, that does mean the issue of "Will tests ever be written that are meaningful for Search_ParPaz2?" is still worth addressing, but perhaps as a separate bug, since this is not about the quality of tests, but the noisiness of them. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14117 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |tomascohen@gmail.com Status|Passed QA |Pushed to Master --- Comment #11 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Patch pushed to master. Thanks Mark! -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org