[Bug 42177] New: Cannot manage bundles
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42177 Bug ID: 42177 Summary: Cannot manage bundles Initiative type: --- Sponsorship --- status: Product: Koha Version: Main Hardware: All OS: All Status: NEW Severity: minor Priority: P5 - low Component: Cataloging Assignee: koha-bugs@lists.koha-community.org Reporter: kevin.carnes@ub.lu.se QA Contact: testopia@bugs.koha-community.org CC: m.de.rooy@rijksmuseum.nl There is no bundlesEnabled preference, so clicking the manage bundles button for an item does not work. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42177 Kevin Carnes <kevin.carnes@ub.lu.se> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff Assignee|koha-bugs@lists.koha-commun |kevin.carnes@ub.lu.se |ity.org | --- Comment #1 from Kevin Carnes <kevin.carnes@ub.lu.se> --- Created attachment 196158 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=196158&action=edit Bug 42177: Allow managing bundles There is no preference for bundlesEnabled, so use the variable instead. Test plan: 1. Edit a record. 2. Modify the leader so that it has a collection bibliographic level. 3. Ensure that is has at least one item. 4. Observe that clicking the manage bundle button next to the item has no effect. 5. Apply the patch. 6. Observe that the manage bundle button now works. 7. Sign off Sponsored-by: Lund University Library -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42177 Kevin Carnes <kevin.carnes@ub.lu.se> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |42178 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42178 [Bug 42178] The Close button submits the remove from bundle form -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42177 Roman Dolny <roman.dolny@jezuici.pl> changed: What |Removed |Added ---------------------------------------------------------------------------- Sponsorship status|--- |Sponsored Comma delimited| |Lund University Library list of Sponsors| | Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42177 Roman Dolny <roman.dolny@jezuici.pl> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #196158|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42177 --- Comment #2 from Roman Dolny <roman.dolny@jezuici.pl> --- Created attachment 196180 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=196180&action=edit Bug 42177: Allow managing bundles There is no preference for bundlesEnabled, so use the variable instead. Test plan: 1. Edit a record. 2. Modify the leader so that it has a collection bibliographic level. 3. Ensure that is has at least one item. 4. Observe that clicking the manage bundle button next to the item has no effect. 5. Apply the patch. 6. Observe that the manage bundle button now works. 7. Sign off Sponsored-by: Lund University Library Signed-off-by: Roman Dolny <roman.dolny@jezuici.pl> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42177 Baptiste Wojtkowski (bwoj) <baptiste.wojtkowski@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |baptiste.wojtkowski@biblibr | |e.com Depends on| |41566 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41566 [Bug 41566] Tidy kohaTable block - catalogue -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42177 Baptiste Wojtkowski (bwoj) <baptiste.wojtkowski@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia@bugs.koha-communit |baptiste.wojtkowski@biblibr |y.org |e.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42177 Baptiste Wojtkowski (bwoj) <baptiste.wojtkowski@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords| |regression Status|Signed Off |Passed QA --- Comment #3 from Baptiste Wojtkowski (bwoj) <baptiste.wojtkowski@biblibre.com> --- It appears to be a regression introduced by 41566. I'm ok with the fix from a QA PoV -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42177 Baptiste Wojtkowski (bwoj) <baptiste.wojtkowski@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #196180|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42177 --- Comment #4 from Baptiste Wojtkowski (bwoj) <baptiste.wojtkowski@biblibre.com> --- Created attachment 198308 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=198308&action=edit Bug 42177: Allow managing bundles There is no preference for bundlesEnabled, so use the variable instead. Test plan: 1. Edit a record. 2. Modify the leader so that it has a collection bibliographic level. 3. Ensure that is has at least one item. 4. Observe that clicking the manage bundle button next to the item has no effect. 5. Apply the patch. 6. Observe that the manage bundle button now works. 7. Sign off Sponsored-by: Lund University Library Signed-off-by: Roman Dolny <roman.dolny@jezuici.pl> Signed-off-by: Baptiste Wojtkowski <baptiste.wojtkowski@biblibre.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42177 Baptiste Wojtkowski (bwoj) <baptiste.wojtkowski@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Severity|minor |normal -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42177 --- Comment #5 from Baptiste Wojtkowski (bwoj) <baptiste.wojtkowski@biblibre.com> --- Btw for your information, on ktd http://koha-ktd:8081/cgi-bin/koha/catalogue/detail.pl?biblionumber=144 is a bundle -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42177 Lucas Gass (lukeg) <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to main Version(s)| |26.05.00 released in| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42177 --- Comment #6 from Lucas Gass (lukeg) <lucas@bywatersolutions.com> --- Nice work everyone! Pushed to main for 26.05 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42177 Jonathan Druart <jonathan.druart@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart@gmail.com --- Comment #7 from Jonathan Druart <jonathan.druart@gmail.com> --- Is this enough? There is: 1821 if (bundlesEnabled) { -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42177 --- Comment #8 from Jonathan Druart <jonathan.druart@gmail.com> --- Created attachment 198499 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=198499&action=edit Bug 42177: bundlesEnabled fix Patch from commit 48cb558 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42177 --- Comment #9 from Jonathan Druart <jonathan.druart@gmail.com> --- I think this is the correct fix: * bundlesEnabled is not a syspref, it should not be stored in Koha.prefs * bundlesEnabled JS var was not defined -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42177 --- Comment #10 from Kevin Carnes <kevin.carnes@ub.lu.se> --- I agree that that is the correct fix since it's not a preference and it's used twice in JS (I missed the second one). -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42177 Jonathan Druart <jonathan.druart@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords| |additional_work_needed -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42177 Jonathan Druart <jonathan.druart@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #198499|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42177 --- Comment #11 from Jonathan Druart <jonathan.druart@gmail.com> --- Created attachment 198500 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=198500&action=edit Bug 42177: bundlesEnabled fix Patch from commit 8b6569e -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42177 --- Comment #12 from Kevin Carnes <kevin.carnes@ub.lu.se> --- It appears that the JS const bundlesEnabled is already defined in catalogue_detail.inc which is included in detail.tt, so it doesn't need to be defined again. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42177 Jonathan Druart <jonathan.druart@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #198500|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42177 --- Comment #13 from Jonathan Druart <jonathan.druart@gmail.com> --- Created attachment 198528 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=198528&action=edit Bug 42177: bundlesEnabled fix Patch from commit 7336132 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42177 --- Comment #14 from Jonathan Druart <jonathan.druart@gmail.com> --- (In reply to Kevin Carnes from comment #12)
It appears that the JS const bundlesEnabled is already defined in catalogue_detail.inc which is included in detail.tt, so it doesn't need to be defined again.
Good catch! That explains why it was not a problem. I've adjusted the patch. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42177 Lucas Gass (lukeg) <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords|additional_work_needed | CC| |lucas@bywatersolutions.com --- Comment #15 from Lucas Gass (lukeg) <lucas@bywatersolutions.com> --- follow-up pushed to main -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42177 Jacob O'Mara <jacob.omara@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to main |Needs documenting --- Comment #16 from Jacob O'Mara <jacob.omara@openfifth.co.uk> --- This will not be backported to 25.11.x due to it being deemed an enhancement or a dependancy not being met -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org