[Bug 41983] New: Holds to Pull and Holds Queue should show when holds are part of a group
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41983 Bug ID: 41983 Summary: Holds to Pull and Holds Queue should show when holds are part of a group Initiative type: --- Sponsorship --- status: Product: Koha Version: Main Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Hold requests Assignee: koha-bugs@lists.koha-community.org Reporter: andrew@bywatersolutions.com QA Contact: testopia@bugs.koha-community.org CC: gmcharlt@gmail.com, lisette@bywatersolutions.com, tomascohen@gmail.com Depends on: 15516 When a library is using grouped holds, it would be helpful to see in the Holds to Pull and Holds Queue lists when an item to be pulled is for a hold that's part of a group. This could be done by adding a column with the hold group ID to these pages that only shows when DisplayAddHoldGroups is enabled and can be hidden via column configuration. Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15516 [Bug 15516] Allow to place a hold on first available item from a group of titles -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41983 Andrew Fuerste-Henry <andrew@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Holds to Pull and Holds |Holds Queue should show |Queue should show when |when holds are part of a |holds are part of a group |group --- Comment #1 from Andrew Fuerste-Henry <andrew@bywatersolutions.com> --- Holds to Pull already does show hold groups, but Holds Queue does not. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41983 Sara Brown <sbrown@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=42054 -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41983 Catrina Berka <catrina@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |catrina@bywatersolutions.co | |m -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41983 carthur@slolibrary.org <carthur@slolibrary.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |carthur@slolibrary.org -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41983 Pedro Amorim <pedro.amorim@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41983 --- Comment #2 from Pedro Amorim <pedro.amorim@openfifth.co.uk> --- Created attachment 196739 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=196739&action=edit Bug 41983: Insert hold_group_id when creating tmp_holdsqueue Patch from commit b9dfed9 -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41983 --- Comment #3 from Pedro Amorim <pedro.amorim@openfifth.co.uk> --- Created attachment 196740 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=196740&action=edit Bug 41983: [DONT PUSH] dbic Patch from commit 9c0b5e7 -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41983 --- Comment #4 from Pedro Amorim <pedro.amorim@openfifth.co.uk> --- Created attachment 196741 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=196741&action=edit Bug 41983: Add hold_group_id column to tmp_holdsqueue table Patch from commit df7359b -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41983 --- Comment #5 from Pedro Amorim <pedro.amorim@openfifth.co.uk> --- Created attachment 196742 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=196742&action=edit Bug 41983: Display in UI Test plan: 1) Enable DisplayAddHoldGroups sys prefs 2) Go to 'Henry' and click 'Search to hold': <staff_url>/cgi-bin/koha/members/moremember.pl?borrowernumber=19 3) Search for 'test' and click the top 'Select all' link 4) Click the downward arrow in the 'Place hold' button and pick 'Place hold for Henry' 5) Set a pickup location for each hold and tick the 'Treat as hold group' checkbox 6) Click 'Place holds'. 7) Run build_holds_queue.pl: perl misc/cronjobs/holds/build_holds_queue.pl --force 8) Visit the Holds queue page: <staff_url>/cgi-bin/koha/circ/view_holdsqueue.pl?branchlimit=&itemtypeslimit=&run_report=1 9) Confirm the 'part of a hold group' bit shows and display the modal like 'Holds to pull' -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41983 Pedro Amorim <pedro.amorim@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |pedro.amorim@openfifth.co.u | |k Assignee|koha-bugs@lists.koha-commun |pedro.amorim@openfifth.co.u |ity.org |k -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41983 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |david@davidnind.com Status|Needs Signoff |Failed QA --- Comment #6 from David Nind <david@davidnind.com> --- Failed QA, because of these errors: 1. Step 7 - updating the holds queue (no error before the patch): perl misc/cronjobs/holds/build_holds_queue.pl --force C4::HoldsQueue::CreatePicklistFromItemMap(): DBI Exception: DBD::mysql::st execute failed: Unknown column 'hold_group_id' in 'INSERT INTO' at /kohadevbox/koha/C4/HoldsQueue.pm line 1333 2.Step 8 - Accessing the holds queue page: Template process failed: undef error - DBIx::Class::Storage::DBI::_dbh_execute(): DBI Exception: DBD::mysql::st execute failed: Unknown column 'me.hold_group_id' in 'SELECT' at /kohadevbox/koha/Koha/Objects.pm line 401 at /kohadevbox/koha/C4/Templates.pm line 146 Note that these steps are not included in the test plan: 1. Apply the patches 2. Updated the database: updatedatabase 3. Run DBIC: dbic 4. Restart everything: restart_all Other testing notes: 1. Adds a "Treat as hold group" option when placing multiple holds for a patron (for example, using the "Search to hold" option from a patron's account page or searching the catalog and placing holds on multiple items). (Hint text is: Place a hold on the next available title from this group) -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41983 Pedro Amorim <pedro.amorim@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41983 Pedro Amorim <pedro.amorim@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #196739|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41983 Pedro Amorim <pedro.amorim@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #196740|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41983 Pedro Amorim <pedro.amorim@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #196741|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41983 Pedro Amorim <pedro.amorim@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #196742|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41983 --- Comment #7 from Pedro Amorim <pedro.amorim@openfifth.co.uk> --- Created attachment 197209 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=197209&action=edit Bug 41983: Insert hold_group_id when creating tmp_holdsqueue Patch from commit 71705a4 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41983 --- Comment #8 from Pedro Amorim <pedro.amorim@openfifth.co.uk> --- Created attachment 197210 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=197210&action=edit Bug 41983: [DONT PUSH] dbic Patch from commit 83f909b -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41983 --- Comment #9 from Pedro Amorim <pedro.amorim@openfifth.co.uk> --- Created attachment 197212 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=197212&action=edit Bug 41983: Add hold_group_id column to tmp_holdsqueue table Patch from commit cc0bf6f -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41983 --- Comment #10 from Pedro Amorim <pedro.amorim@openfifth.co.uk> --- Created attachment 197213 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=197213&action=edit Bug 41983: Display in UI Test plan: 0) Update the database (ktd, ignore if sandbox): $ updatedatabase 1) Enable DisplayAddHoldGroups sys prefs 2) Go to 'Henry' and click 'Search to hold': <staff_url>/cgi-bin/koha/members/moremember.pl?borrowernumber=19 3) Search for 'test' and click the top 'Select all' link 4) Click the downward arrow in the 'Place hold' button and pick 'Place hold for Henry' 5) Set a pickup location for each hold and tick the 'Treat as hold group' checkbox 6) Click 'Place holds'. 7) Run build_holds_queue.pl: perl misc/cronjobs/holds/build_holds_queue.pl --force 8) Visit the Holds queue page: <staff_url>/cgi-bin/koha/circ/view_holdsqueue.pl?branchlimit=&itemtypeslimit=&run_report=1 9) Confirm the 'part of a hold group' bit shows and display the modal like 'Holds to pull' -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41983 --- Comment #11 from Pedro Amorim <pedro.amorim@openfifth.co.uk> --- Thank you David. I've fixed a copy-paste error in the atomicupdate file and added the 'Update database' step to the test plan. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41983 Andrew Fuerste-Henry <andrew@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Failed QA --- Comment #12 from Andrew Fuerste-Henry <andrew@bywatersolutions.com> --- If RealTimeHoldsQueue is enabled we should rebuild the holds queue when groups are edited. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41983 Emily Lamancusa (emlam) <emily.lamancusa@montgomerycountymd.gov> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |emily.lamancusa@montgomeryc | |ountymd.gov -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41983 Pedro Amorim <pedro.amorim@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41983 --- Comment #13 from Pedro Amorim <pedro.amorim@openfifth.co.uk> --- Created attachment 198016 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=198016&action=edit Bug 41983: (QA follow-up): Rebuild the holds queue when groups are edited Test plan (ktd) 0) Update the database (ktd, ignore if sandbox): $ updatedatabase 1) Enable 'RealTimeHoldsQueue' and 'DisplayAddHoldGroups' system preferences 2) restart_all # This is required or the worker won't pick up the new sys pref values 3) Place at least 2 holds for a patron on different items/biblios, without grouping them: <staff_url>/cgi-bin/koha/members/moremember.pl?borrowernumber=19 4) Build the holds queue once to get a baseline: $ perl misc/cronjobs/holds/build_holds_queue.pl --force 5) Visit the holds queue and confirm the holds appear without a group indicator: <staff_url>/cgi-bin/koha/circ/view_holdsqueue.pl?branchlimit=&itemtypeslimit=&run_report=1 6) Create a hold group for those holds via the patron page <staff_url>/cgi-bin/koha/circ/circulation.pl?borrowernumber=<patron_borrowernumber> 7) Without running build_holds_queue.pl, refresh the holds queue, confirm the 'part of a hold group' indicator now appears 8) Ungroup the holds, refresh the holds queue, confirm the 'part of a hold group' is no longer showing 9) Run the unit tests: $ prove t/db_dependent/Reserves/HoldGroup.t -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41983 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41983 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #197209|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41983 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #197210|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41983 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #197212|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41983 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #197213|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41983 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #198016|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41983 --- Comment #14 from David Nind <david@davidnind.com> --- Created attachment 198065 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=198065&action=edit Bug 41983: Insert hold_group_id when creating tmp_holdsqueue Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41983 --- Comment #15 from David Nind <david@davidnind.com> --- Created attachment 198066 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=198066&action=edit Bug 41983: [DONT PUSH] dbic Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41983 --- Comment #16 from David Nind <david@davidnind.com> --- Created attachment 198067 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=198067&action=edit Bug 41983: Add hold_group_id column to tmp_holdsqueue table Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41983 --- Comment #17 from David Nind <david@davidnind.com> --- Created attachment 198068 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=198068&action=edit Bug 41983: Display in UI Test plan: 0) Update the database (ktd, ignore if sandbox): $ updatedatabase 1) Enable DisplayAddHoldGroups sys prefs 2) Go to 'Henry' and click 'Search to hold': <staff_url>/cgi-bin/koha/members/moremember.pl?borrowernumber=19 3) Search for 'test' and click the top 'Select all' link 4) Click the downward arrow in the 'Place hold' button and pick 'Place hold for Henry' 5) Set a pickup location for each hold and tick the 'Treat as hold group' checkbox 6) Click 'Place holds'. 7) Run build_holds_queue.pl: perl misc/cronjobs/holds/build_holds_queue.pl --force 8) Visit the Holds queue page: <staff_url>/cgi-bin/koha/circ/view_holdsqueue.pl?branchlimit=&itemtypeslimit=&run_report=1 9) Confirm the 'part of a hold group' bit shows and display the modal like 'Holds to pull' Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41983 --- Comment #18 from David Nind <david@davidnind.com> --- Created attachment 198069 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=198069&action=edit Bug 41983: (QA follow-up): Rebuild the holds queue when groups are edited Test plan (ktd) 0) Update the database (ktd, ignore if sandbox): $ updatedatabase 1) Enable 'RealTimeHoldsQueue' and 'DisplayAddHoldGroups' system preferences 2) restart_all # This is required or the worker won't pick up the new sys pref values 3) Place at least 2 holds for a patron on different items/biblios, without grouping them: <staff_url>/cgi-bin/koha/members/moremember.pl?borrowernumber=19 4) Build the holds queue once to get a baseline: $ perl misc/cronjobs/holds/build_holds_queue.pl --force 5) Visit the holds queue and confirm the holds appear without a group indicator: <staff_url>/cgi-bin/koha/circ/view_holdsqueue.pl?branchlimit=&itemtypeslimit=&run_report=1 6) Create a hold group for those holds via the patron page <staff_url>/cgi-bin/koha/circ/circulation.pl?borrowernumber=<patron_borrowernumber> 7) Without running build_holds_queue.pl, refresh the holds queue, confirm the 'part of a hold group' indicator now appears 8) Ungroup the holds, refresh the holds queue, confirm the 'part of a hold group' is no longer showing 9) Run the unit tests: $ prove t/db_dependent/Reserves/HoldGroup.t Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41983 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Text to go in the| |This adds "(part of a hold release notes| |group)" to the holds queue | |(under the title in the | |title column), when hold | |groups are enabled | |(DisplayAddHoldGroups | |system preference). --- Comment #19 from David Nind <david@davidnind.com> --- Testing notes (using KTD): 1. Using hold groups: - Enable DisplayAddHoldGroups system preference - Adds a "Treat as hold group" option when placing multiple holds for a patron (for example, using the "Search to hold" option from a patron's account page or searching the catalog and placing holds on multiple items). (Hint text is: Place a hold on the next available title from this group) - Can group existing holds for a patron (multiple holds required): . Go to a patron's check out or details section, and select the holds tab . Select items . Click "Group selected" button under the holds table 2. These patches add a "(part of a hold group)" under the title (in the title column)on the holds queue (Circulation > Holds and bookings > Holds queue). 3. It took me a while to figure out how to ungroup the holds (step 8 of the test plan): - Go to the holds tab for the patron (either checkout or details sections) - In the "Holds group" column, click the number of the hold group (it is a link, but is hard to see) - In the pop-up window, click "Ungroup holds" -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41983 Pedro Amorim <pedro.amorim@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |41956 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41956 [Bug 41956] Hold group/hyperhold modals should show hold_group_id -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41983 Andrew Fuerste-Henry <andrew@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia@bugs.koha-communit |andrew@bywatersolutions.com |y.org | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41983 Andrew Fuerste-Henry <andrew@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41983 Andrew Fuerste-Henry <andrew@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #198065|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41983 Andrew Fuerste-Henry <andrew@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #198066|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41983 Andrew Fuerste-Henry <andrew@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #198067|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41983 Andrew Fuerste-Henry <andrew@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #198068|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41983 Andrew Fuerste-Henry <andrew@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #198069|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41983 --- Comment #20 from Andrew Fuerste-Henry <andrew@bywatersolutions.com> --- Created attachment 198090 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=198090&action=edit Bug 41983: Insert hold_group_id when creating tmp_holdsqueue Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Andrew Fuerste Henry <andrew@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41983 --- Comment #21 from Andrew Fuerste-Henry <andrew@bywatersolutions.com> --- Created attachment 198091 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=198091&action=edit Bug 41983: [DONT PUSH] dbic Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Andrew Fuerste Henry <andrew@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41983 --- Comment #22 from Andrew Fuerste-Henry <andrew@bywatersolutions.com> --- Created attachment 198092 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=198092&action=edit Bug 41983: Add hold_group_id column to tmp_holdsqueue table Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Andrew Fuerste Henry <andrew@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41983 --- Comment #23 from Andrew Fuerste-Henry <andrew@bywatersolutions.com> --- Created attachment 198093 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=198093&action=edit Bug 41983: Display in UI Test plan: 0) Update the database (ktd, ignore if sandbox): $ updatedatabase 1) Enable DisplayAddHoldGroups sys prefs 2) Go to 'Henry' and click 'Search to hold': <staff_url>/cgi-bin/koha/members/moremember.pl?borrowernumber=19 3) Search for 'test' and click the top 'Select all' link 4) Click the downward arrow in the 'Place hold' button and pick 'Place hold for Henry' 5) Set a pickup location for each hold and tick the 'Treat as hold group' checkbox 6) Click 'Place holds'. 7) Run build_holds_queue.pl: perl misc/cronjobs/holds/build_holds_queue.pl --force 8) Visit the Holds queue page: <staff_url>/cgi-bin/koha/circ/view_holdsqueue.pl?branchlimit=&itemtypeslimit=&run_report=1 9) Confirm the 'part of a hold group' bit shows and display the modal like 'Holds to pull' Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Andrew Fuerste Henry <andrew@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41983 --- Comment #24 from Andrew Fuerste-Henry <andrew@bywatersolutions.com> --- Created attachment 198094 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=198094&action=edit Bug 41983: (QA follow-up): Rebuild the holds queue when groups are edited Test plan (ktd) 0) Update the database (ktd, ignore if sandbox): $ updatedatabase 1) Enable 'RealTimeHoldsQueue' and 'DisplayAddHoldGroups' system preferences 2) restart_all # This is required or the worker won't pick up the new sys pref values 3) Place at least 2 holds for a patron on different items/biblios, without grouping them: <staff_url>/cgi-bin/koha/members/moremember.pl?borrowernumber=19 4) Build the holds queue once to get a baseline: $ perl misc/cronjobs/holds/build_holds_queue.pl --force 5) Visit the holds queue and confirm the holds appear without a group indicator: <staff_url>/cgi-bin/koha/circ/view_holdsqueue.pl?branchlimit=&itemtypeslimit=&run_report=1 6) Create a hold group for those holds via the patron page <staff_url>/cgi-bin/koha/circ/circulation.pl?borrowernumber=<patron_borrowernumber> 7) Without running build_holds_queue.pl, refresh the holds queue, confirm the 'part of a hold group' indicator now appears 8) Ungroup the holds, refresh the holds queue, confirm the 'part of a hold group' is no longer showing 9) Run the unit tests: $ prove t/db_dependent/Reserves/HoldGroup.t Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Andrew Fuerste Henry <andrew@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41983 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Holds Queue should show |Holds queue should show |when holds are part of a |when holds are part of a |group |group -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41983 Lucas Gass (lukeg) <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |lucas@bywatersolutions.com Status|Passed QA |Failed QA --- Comment #25 from Lucas Gass (lukeg) <lucas@bywatersolutions.com> --- In the atomic update: ADD COLUMN hold_group_id int(11) DEFAULT NULL In kohastructure.sql: hold_group_id` int(10) unsigned DEFAULT NULL Which should it be? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41983 Pedro Amorim <pedro.amorim@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41983 --- Comment #26 from Pedro Amorim <pedro.amorim@openfifth.co.uk> --- Created attachment 198521 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=198521&action=edit Bug 41983: (QA follow-up): Fix atomicupdate hold_group_id column Patch from commit 91b16b6 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41983 Lucas Gass (lukeg) <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to main Version(s)| |26.05.00 released in| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41983 --- Comment #27 from Lucas Gass (lukeg) <lucas@bywatersolutions.com> --- Nice work everyone! Pushed to main for 26.05 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41983 Jacob O'Mara <jacob.omara@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to main |Needs documenting --- Comment #28 from Jacob O'Mara <jacob.omara@openfifth.co.uk> --- This will not be backported to 25.11.x due to it being deemed an enhancement or a dependancy not being met -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org