[Bug 17345] New: Typo in sysprefs.sql prevents all systempreferences from being installed
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17345 Bug ID: 17345 Summary: Typo in sysprefs.sql prevents all systempreferences from being installed Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: major Priority: P5 - low Component: Installation and upgrade (web-based installer) Assignee: koha-bugs@lists.koha-community.org Reporter: katrin.fischer@bsz-bw.de QA Contact: testopia@bugs.koha-community.org CC: gmcharlt@gmail.com I noticed some odd things in my installation - turned out, half the preferences where missing because of a typo in the sysprefs.sql file. Attaching a patch in a second. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17345 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Trivial patch Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17345 --- Comment #1 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 55796 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=55796&action=edit Bug 17345: Fix typo in sysprefs.sql This fixes a tiny typo in sysprefs.sql that kept all systempreferences from being installed. To test: - Create a new koha database, run the web installer - Verify that all systempreferences have been loaded select count(*) from systempreferences should be no less than 553 or - Truncate your systempreferences table - Verify that the repaired sysprefs.sql file loads without error -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17345 Josef Moravec <josef.moravec@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17345 Josef Moravec <josef.moravec@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #55796|0 |1 is obsolete| | --- Comment #2 from Josef Moravec <josef.moravec@gmail.com> --- Created attachment 55817 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=55817&action=edit Bug 17345: Fix typo in sysprefs.sql This fixes a tiny typo in sysprefs.sql that kept all systempreferences from being installed. To test: - Create a new koha database, run the web installer - Verify that all systempreferences have been loaded select count(*) from systempreferences should be no less than 553 or - Truncate your systempreferences table - Verify that the repaired sysprefs.sql file loads without error Signed-off-by: Josef Moravec <josef.moravec@gmail.com> Tested by truncating systempreferences table -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17345 --- Comment #3 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Hi Josef - thx for testing! I noticed later I was missing the Version pref after doing the truncation - maybe something to check! -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17345 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs@lists.koha-commun |katrin.fischer@bsz-bw.de |ity.org | Depends on| |16272 CC| |jonathan.druart@bugs.koha-c | |ommunity.org --- Comment #4 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Erk, sorry about that. Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16272 [Bug 16272] Transform checkout from on-site checkout to regular checkout -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17345 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17345 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #55817|0 |1 is obsolete| | --- Comment #5 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 55863 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=55863&action=edit Bug 17345: Fix typo in sysprefs.sql This fixes a tiny typo in sysprefs.sql that kept all systempreferences from being installed. To test: - Create a new koha database, run the web installer - Verify that all systempreferences have been loaded select count(*) from systempreferences should be no less than 553 or - Truncate your systempreferences table - Verify that the repaired sysprefs.sql file loads without error Signed-off-by: Josef Moravec <josef.moravec@gmail.com> Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17345 Brendan Gallagher <brendan@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master CC| |brendan@bywatersolutions.co | |m --- Comment #6 from Brendan Gallagher <brendan@bywatersolutions.com> --- Pushed to Master - Should be in the November Release 16.11 - Thanks! -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon@bugs.koha-community.org