[Bug 17384] New: Staff categories no longer visible in patron editing form
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17384 Bug ID: 17384 Summary: Staff categories no longer visible in patron editing form Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: major Priority: P5 - low Component: Patrons Assignee: koha-bugs@lists.koha-community.org Reporter: veron@veron.ch QA Contact: testopia@bugs.koha-community.org CC: gmcharlt@gmail.com, kyle.m.hall@gmail.com To reproduce: - Try to edit an existing patron with category Staff (category type Staff), or try to create a patron with such category - Verify that the category drop down does not have any category of category type Staff. This happens on current master (Koha version: 16.06.00.031) -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17384 Marc Véron <veron@veron.ch> changed: What |Removed |Added ---------------------------------------------------------------------------- Priority|P5 - low |P1 - high Summary|Staff categories no longer |Categories do not display |visible in patron editing |in staff editing form if |form |they have only one category | |assigned --- Comment #1 from Marc Véron <veron@veron.ch> --- New way to reproduce: - Go to Home > Administration > Patron categories - Make sure that you have only one category for a category type. Examples: Only one category "Staff" for category type "Staff" or Only one category "Library" for category type "Org." - Edit a patron or create a new patron - Verify that categories of examples above do not show up in category drop down - Go back to Home > Administration > Patron categories and add categories to both category types - Edit or create a new patron. Veryfy that categories show up in dropdown. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17384 Marc Véron <veron@veron.ch> changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Categories do not display |Categories do not display |in staff editing form if |in patron editing form if |they have only one category |they have only one category |assigned |assigned Assignee|koha-bugs@lists.koha-commun |veron@veron.ch |ity.org | -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17384 --- Comment #2 from Marc Véron <veron@veron.ch> --- Created attachment 55962 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=55962&action=edit Bug 17384 - Categories do not display in patron editing form if they have only one category assigned To reproduce: - Go to Home > Administration > Patron categories - Make sure that you have only one category for a category type. Examples: Only one category "Staff" for category type "Staff" or Only one category "Library" for category type "Org." - Edit a patron or create a new patron - Verify that categories of examples above do not show up in category drop down - Go back to Home > Administration > Patron categories and add categories to both category types - Edit or create a new patron. Veryfy that categories show up in dropdown. To test: - Apply patch - Make sure you have a category type with only one category assigned (e.g. category taype Staff with category Staff) - Edit a patron or create a new patron. Verify that the category shows up in categroy drop down. - Additional test: Verify that template param 'catcode' from removed line is not used in template memberentrygen.tt -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17384 Marc Véron <veron@veron.ch> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17384 Chris Cormack <chris@bigballofwax.co.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17384 Chris Cormack <chris@bigballofwax.co.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #55962|0 |1 is obsolete| | --- Comment #3 from Chris Cormack <chris@bigballofwax.co.nz> --- Created attachment 55966 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=55966&action=edit Bug 17384 - Categories do not display in patron editing form if they have only one category assigned To reproduce: - Go to Home > Administration > Patron categories - Make sure that you have only one category for a category type. Examples: Only one category "Staff" for category type "Staff" or Only one category "Library" for category type "Org." - Edit a patron or create a new patron - Verify that categories of examples above do not show up in category drop down - Go back to Home > Administration > Patron categories and add categories to both category types - Edit or create a new patron. Veryfy that categories show up in dropdown. To test: - Apply patch - Make sure you have a category type with only one category assigned (e.g. category taype Staff with category Staff) - Edit a patron or create a new patron. Verify that the category shows up in categroy drop down. - Additional test: Verify that template param 'catcode' from removed line is not used in template memberentrygen.tt Signed-off-by: Chris Cormack <chris@bigballofwax.co.nz> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17384 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17384 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #55966|0 |1 is obsolete| | --- Comment #4 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 55973 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=55973&action=edit Bug 17384 - Categories do not display in patron editing form if they have only one category assigned To reproduce: - Go to Home > Administration > Patron categories - Make sure that you have only one category for a category type. Examples: Only one category "Staff" for category type "Staff" or Only one category "Library" for category type "Org." - Edit a patron or create a new patron - Verify that categories of examples above do not show up in category drop down - Go back to Home > Administration > Patron categories and add categories to both category types - Edit or create a new patron. Veryfy that categories show up in dropdown. To test: - Apply patch - Make sure you have a category type with only one category assigned (e.g. category taype Staff with category Staff) - Edit a patron or create a new patron. Verify that the category shows up in categroy drop down. - Additional test: Verify that template param 'catcode' from removed line is not used in template memberentrygen.tt Signed-off-by: Chris Cormack <chris@bigballofwax.co.nz> Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17384 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart@bugs.koha-c | |ommunity.org --- Comment #5 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Caused by: commit cae4b980607be083e5e0fb163c4949c73d6347db Bug 15407: Koha::Patron::Categories - replace GetborCatFromCatType Really weird line, I guess it's a leftover debug line I put to understand this part of code. Thanks for fixing it! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17384 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |15407 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15407 [Bug 15407] Move the patron categories related code to Koha::Patron::Categories - part 2 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17384 Brendan Gallagher <brendan@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |brendan@bywatersolutions.co | |m Status|Passed QA |Pushed to Master --- Comment #6 from Brendan Gallagher <brendan@bywatersolutions.com> --- Pushed to Master - Should be in the November Release 16.11 - Thanks! -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org