https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22973 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |22974 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22974 [Bug 22974] Patron password update validation broken -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22973 --- Comment #1 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 90031 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=90031&action=edit Bug 22973: Remove type attribute from script tags: Staff client includes 2/2 This patch removes the "type" attribute from <script> tags in several staff client include files. Also removed: Obsolete "//<![CDATA[ //]]>" markers. This patch also makes minor indentation changes, so diff using the "-w" flag. To test, apply the patch and confirm that examples of affected pages work properly without any JavaScript errors in the browser console: - Installer -> Onboarding (uses installer-strings.inc, validator-strings.inc) - Patrons -> Patron details -> Change password (uses password_check.inc) - Patrons -> Patron details -> Print summary (slip-print.inc) - Circulation -> Check out (strings.inc, timepicker.inc) - Cataloging -> New from Z39.50/SRU (z3950_search.inc) Validating the HTML source of any of these pages should return no errors related to the "type" attribute. -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22973 Hayley Mapley <hayleymapley@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #90031|0 |1 is obsolete| | --- Comment #2 from Hayley Mapley <hayleymapley@catalyst.net.nz> --- Created attachment 90055 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=90055&action=edit Bug 22973: Remove type attribute from script tags: Staff client includes 2/2 This patch removes the "type" attribute from <script> tags in several staff client include files. Also removed: Obsolete "//<![CDATA[ //]]>" markers. This patch also makes minor indentation changes, so diff using the "-w" flag. To test, apply the patch and confirm that examples of affected pages work properly without any JavaScript errors in the browser console: - Installer -> Onboarding (uses installer-strings.inc, validator-strings.inc) - Patrons -> Patron details -> Change password (uses password_check.inc) - Patrons -> Patron details -> Print summary (slip-print.inc) - Circulation -> Check out (strings.inc, timepicker.inc) - Cataloging -> New from Z39.50/SRU (z3950_search.inc) Validating the HTML source of any of these pages should return no errors related to the "type" attribute. Signed-off-by: Hayley Mapley <hayleymapley@catalyst.net.nz> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22973 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22973 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |nick@bywatersolutions.com Status|Passed QA |Pushed to Master --- Comment #4 from Nick Clemens <nick@bywatersolutions.com> --- Awesome work all! Pushed to master for 19.05 -- You are receiving this mail because: You are watching all bug changes.