[Bug 35557] New: LoadResultsCovers is not used (staff)
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35557 Bug ID: 35557 Summary: LoadResultsCovers is not used (staff) Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: ASSIGNED Severity: normal Priority: P5 - low Component: Templates Assignee: jonathan.druart+koha@gmail.com Reporter: jonathan.druart+koha@gmail.com QA Contact: testopia@bugs.koha-community.org The JS function LoadResultsCovers is not used from the Staff interface. It is supposed to load the local cover images in JS but actually we are embedding the thumbnail in the img tag. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35557 --- Comment #1 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- Created attachment 159783 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=159783&action=edit Bug 35557: Remove LoadResultsCovers The JS function LoadResultsCovers is not used from the Staff interface. It is supposed to load the local cover images in JS but actually we are embedding the thumbnail in the img tag. Test plan: Confirm that LoadResultsCovers was called but had no effect. Note that the selector ^local-thumbnail only exists in shelfbrowser.inc but results.js is only used from results.tt (not shelfbrowser.inc) Current status: ASSIGNED -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35557 Jonathan Druart <jonathan.druart+koha@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35557 Jonathan Druart <jonathan.druart+koha@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #159783|0 |1 is obsolete| | --- Comment #2 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- Created attachment 159784 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=159784&action=edit Bug 35557: Remove LoadResultsCovers The JS function LoadResultsCovers is not used from the Staff interface. It is supposed to load the local cover images in JS but actually we are embedding the thumbnail in the img tag. Test plan: Confirm that LoadResultsCovers was called but had no effect. Note that the selector ^local-thumbnail only exists in shelfbrowser.inc but results.js is only used from results.tt (not shelfbrowser.inc) -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35557 Jonathan Druart <jonathan.druart+koha@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |35558 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35558 [Bug 35558] Do not fetch local image if none exists -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35557 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35557 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #159784|0 |1 is obsolete| | --- Comment #3 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Created attachment 159913 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=159913&action=edit Bug 35557: Remove LoadResultsCovers The JS function LoadResultsCovers is not used from the Staff interface. It is supposed to load the local cover images in JS but actually we are embedding the thumbnail in the img tag. Test plan: Confirm that LoadResultsCovers was called but had no effect. Note that the selector ^local-thumbnail only exists in shelfbrowser.inc but results.js is only used from results.tt (not shelfbrowser.inc) Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35557 Julian Maurice <julian.maurice@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia@bugs.koha-communit |julian.maurice@biblibre.com |y.org | CC| |julian.maurice@biblibre.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35557 Julian Maurice <julian.maurice@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #159913|0 |1 is obsolete| | --- Comment #4 from Julian Maurice <julian.maurice@biblibre.com> --- Created attachment 160225 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=160225&action=edit Bug 35557: Remove LoadResultsCovers The JS function LoadResultsCovers is not used from the Staff interface. It is supposed to load the local cover images in JS but actually we are embedding the thumbnail in the img tag. Test plan: Confirm that LoadResultsCovers was called but had no effect. Note that the selector ^local-thumbnail only exists in shelfbrowser.inc but results.js is only used from results.tt (not shelfbrowser.inc) Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> Signed-off-by: Julian Maurice <julian.maurice@biblibre.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35557 --- Comment #5 from Julian Maurice <julian.maurice@biblibre.com> --- Created attachment 160226 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=160226&action=edit Bug 35557: Remove references to unused PREF_LocalCoverImages Signed-off-by: Julian Maurice <julian.maurice@biblibre.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35557 Julian Maurice <julian.maurice@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35557 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |24.05.00 released in| | Status|Passed QA |Pushed to master -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35557 --- Comment #6 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Pushed for 24.05! Well done everyone, thank you! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35557 Fridolin Somers <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)|24.05.00 |24.05.00,23.11.02 released in| | Status|Pushed to master |Pushed to stable CC| |fridolin.somers@biblibre.co | |m --- Comment #7 from Fridolin Somers <fridolin.somers@biblibre.com> --- Pushed to 23.11.x for 23.11.02 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35557 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)|24.05.00,23.11.02 |24.05.00,23.11.02,23.05.08 released in| | CC| |lucas@bywatersolutions.com Status|Pushed to stable |Pushed to oldstable --- Comment #8 from Lucas Gass <lucas@bywatersolutions.com> --- Backported to 23.05.x for upcoming 23.05.08 -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org