[Bug 33722] New: Cannot see existing public lists from virtualshelves/addbybiblionumber.pl
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33722 Bug ID: 33722 Summary: Cannot see existing public lists from virtualshelves/addbybiblionumber.pl Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Circulation Assignee: koha-bugs@lists.koha-community.org Reporter: lucas@bywatersolutions.com QA Contact: testopia@bugs.koha-community.org CC: gmcharlt@gmail.com, kyle.m.hall@gmail.com To recreate: 1. Have two users with staff access and lists permissions. ( User A and User B) 2. Create some public lists with User A. Make some that are for staff only and some for everyone. 3. Make sure you create at least 10 different public lists. 4. Log in to the staff interface as user B and search the catalog. 5. Select a few titles and in the toolbar click 'Add to list'. 6. Here you should properly see your lists and any public lists which you can edit. 7. If you have more than 10 lists you won't see them all in this dropdown. 8. At the bottom of the dropdown you should see 'More lists', click it. 9. Notice here you cannot select any of the existing public lists which User B should be able to edit. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33722 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Severity|enhancement |normal -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33722 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33722 --- Comment #1 from Lucas Gass <lucas@bywatersolutions.com> --- Created attachment 151107 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=151107&action=edit Bug 33722: Make public lists viewable for users on virtualshelves/addbybiblionumber.pl To test: 1. Have two users with staff access and lists permissions. ( User A and User B) 2. Create some public lists with User A. Make some that are for staff only and some for everyone. 3. Make sure you create at least 10 different public lists. 4. Log in to the staff interface as user B and search the catalog. 5. Select a few titles and in the toolbar click 'Add to list'. 6. Here you should properly see your lists and any public lists which you can edit. 7. If you have more than 10 lists you won't see them all in this dropdown. 8. At the bottom of the dropdown you should see 'More lists', click it. 9. Notice here you cannot select any of the existing public lists which User B should be able to edit. 10. APPLY PATCH 11. Repeate steps 5 - 8. Now you should be able to edit public lists. 12. Create some private lists with User A and make sure User B cannot see them. 13. PLay with some new lists for User A and change 'Allow changes to contents from' and make sure User B can see the ones they should. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33722 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs@lists.koha-commun |lucas@bywatersolutions.com |ity.org | Patch complexity|--- |Small patch -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33722 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33722 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #151107|0 |1 is obsolete| | --- Comment #2 from David Nind <david@davidnind.com> --- Created attachment 151328 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=151328&action=edit Bug 33722: Make public lists viewable for users on virtualshelves/addbybiblionumber.pl To test: 1. Have two users with staff access and lists permissions. ( User A and User B) 2. Create some public lists with User A. Make some that are for staff only and some for everyone. 3. Make sure you create at least 10 different public lists. 4. Log in to the staff interface as user B and search the catalog. 5. Select a few titles and in the toolbar click 'Add to list'. 6. Here you should properly see your lists and any public lists which you can edit. 7. If you have more than 10 lists you won't see them all in this dropdown. 8. At the bottom of the dropdown you should see 'More lists', click it. 9. Notice here you cannot select any of the existing public lists which User B should be able to edit. 10. APPLY PATCH 11. Repeate steps 5 - 8. Now you should be able to edit public lists. 12. Create some private lists with User A and make sure User B cannot see them. 13. PLay with some new lists for User A and change 'Allow changes to contents from' and make sure User B can see the ones they should. Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33722 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |david@davidnind.com --- Comment #3 from David Nind <david@davidnind.com> --- The only thing I noticed was that you can choose to make a list Private and choose Nobody for allow changes to content. You then lose access to the list, and even a super librarian can't see it. This is also the case in master, so I think this is a separate bug. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33722 --- Comment #4 from Lucas Gass <lucas@bywatersolutions.com> --- (In reply to David Nind from comment #3)
The only thing I noticed was that you can choose to make a list Private and choose Nobody for allow changes to content.
You then lose access to the list, and even a super librarian can't see it.
This is also the case in master, so I think this is a separate bug.
I fail to see the point of the nobody option, for either public or private lists. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33722 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |m.de.rooy@rijksmuseum.nl --- Comment #5 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- (In reply to Lucas Gass from comment #4)
(In reply to David Nind from comment #3)
The only thing I noticed was that you can choose to make a list Private and choose Nobody for allow changes to content.
You then lose access to the list, and even a super librarian can't see it.
This is also the case in master, so I think this is a separate bug.
I fail to see the point of the nobody option, for either public or private lists.
Did its behavior change? The intention is to not allow *changes*. Not to hide it. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33722 --- Comment #6 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- (In reply to Marcel de Rooy from comment #5)
(In reply to Lucas Gass from comment #4)
(In reply to David Nind from comment #3)
The only thing I noticed was that you can choose to make a list Private and choose Nobody for allow changes to content.
You then lose access to the list, and even a super librarian can't see it.
This is also the case in master, so I think this is a separate bug.
I fail to see the point of the nobody option, for either public or private lists.
Did its behavior change? The intention is to not allow *changes*. Not to hide it.
Yes, this definitely is a bug. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33722 --- Comment #7 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- Even if it allow changes from owner, I should see it in the public lists of opac and on the staff view, but I dont. Things got messed up in this area. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33722 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=30418 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33722 --- Comment #8 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- (In reply to Marcel de Rooy from comment #7)
Even if it allow changes from owner, I should see it in the public lists of opac and on the staff view, but I dont. Things got messed up in this area.
Bug 30418 perhaps ? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33722 --- Comment #9 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- (In reply to David Nind from comment #3)
The only thing I noticed was that you can choose to make a list Private and choose Nobody for allow changes to content.
You then lose access to the list, and even a super librarian can't see it.
This is also the case in master, so I think this is a separate bug.
I thought that I saw it too. But cannot reproduce anymore now somehow. Could you give the exact steps to reproduce? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33722 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA --- Comment #10 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- - [% IF private_shelves_shared_with_me.count %] - <optgroup label="Private lists shared with me"> - [% FOREACH private_shelf IN private_shelves_shared_with_me %] - <option value="[% private_shelf.shelfnumber | html %]">[% private_shelf.shelfname | html %]</option> - [% END %] - </optgroup> - [% END %] We loose the separate display of shared lists. We still have in OPAC. I think we should keep that distinction. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33722 --- Comment #11 from David Nind <david@davidnind.com> --- (In reply to Marcel de Rooy from comment #9)
(In reply to David Nind from comment #3)
The only thing I noticed was that you can choose to make a list Private and choose Nobody for allow changes to content.
You then lose access to the list, and even a super librarian can't see it.
This is also the case in master, so I think this is a separate bug.
I thought that I saw it too. But cannot reproduce anymore now somehow. Could you give the exact steps to reproduce?
I can't reproduce it on master now either - maybe I was mixing up my different browser windows with different staff users. Apologies for the noise... -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33722 --- Comment #12 from Lucas Gass <lucas@bywatersolutions.com> --- (In reply to Marcel de Rooy from comment #10)
- [% IF private_shelves_shared_with_me.count %] - <optgroup label="Private lists shared with me"> - [% FOREACH private_shelf IN private_shelves_shared_with_me %] - <option value="[% private_shelf.shelfnumber | html %]">[% private_shelf.shelfname | html %]</option> - [% END %] - </optgroup> - [% END %]
We loose the separate display of shared lists. We still have in OPAC. I think we should keep that distinction.
Pardon my ignorance here. I don't understand how a private list can be shared with someone else. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33722 --- Comment #13 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- (In reply to Lucas Gass from comment #12)
(In reply to Marcel de Rooy from comment #10)
- [% IF private_shelves_shared_with_me.count %] - <optgroup label="Private lists shared with me"> - [% FOREACH private_shelf IN private_shelves_shared_with_me %] - <option value="[% private_shelf.shelfnumber | html %]">[% private_shelf.shelfname | html %]</option> - [% END %] - </optgroup> - [% END %]
We loose the separate display of shared lists. We still have in OPAC. I think we should keep that distinction.
Pardon my ignorance here. I don't understand how a private list can be shared with someone else.
There is a feature to share lists with each other, so you can edit them together even. It's only in the OPAC and requires OpacAllowSharingPrivateLists. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33722 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |35547 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35547 [Bug 35547] When using "Add to a list" dialog ( addbybiblionumber.pl ) list that are "staff only" do not show up -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33722 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |RESOLVED Resolution|--- |DUPLICATE --- Comment #14 from Lucas Gass <lucas@bywatersolutions.com> --- *** This bug has been marked as a duplicate of bug 35547 *** -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33722 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on|35547 | Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35547 [Bug 35547] When using "Add to a list" button with more than 10 lists, "staff only" does not show up -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org