[Bug 34180] New: Template variable in JavaScript prevents authority MARC preview from displaying
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34180 Bug ID: 34180 Summary: Template variable in JavaScript prevents authority MARC preview from displaying Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: ASSIGNED Severity: normal Priority: P5 - low Component: MARC Authority data support Assignee: oleonard@myacpl.org Reporter: oleonard@myacpl.org QA Contact: testopia@bugs.koha-community.org authorities-detail-modal.js has template variables in it: <img src=\"[% interface | html %]/[% theme | html %]/img/spinner-small.gif\" alt=\"\" /> We need to define variables in a Template Toolkit-processed file. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34180 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Trivial patch Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34180 --- Comment #1 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 152918 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=152918&action=edit Bug 34180: Template variable in JavaScript prevents authority MARC preview from displaying Since template variables cannot be processed by JS, we must use a template to declare a JS variable which the JS file can used. This patch corrects this problem in the JS file which handles display of the authority MARC preview from the authority search results page. To test, apply the patch and go to Authorities. - Perform a search which will return multiple authority results. - Click "Actions -> MARC preview." The preview should display correctly. - Click "Actions -> MARC preview" on another search result. This preview should also look correct. - There should be no JavaScript errors in the browser console. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34180 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Template variable in |Template variable in |JavaScript prevents |JavaScript triggers error |authority MARC preview from |when showing authority MARC |displaying |preview -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34180 Phil Ringnalda <phil@chetcolibrary.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34180 Phil Ringnalda <phil@chetcolibrary.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #152918|0 |1 is obsolete| | --- Comment #2 from Phil Ringnalda <phil@chetcolibrary.org> --- Created attachment 152919 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=152919&action=edit Bug 34180: Template variable in JavaScript prevents authority MARC preview from displaying Since template variables cannot be processed by JS, we must use a template to declare a JS variable which the JS file can used. This patch corrects this problem in the JS file which handles display of the authority MARC preview from the authority search results page. To test, apply the patch and go to Authorities. - Perform a search which will return multiple authority results. - Click "Actions -> MARC preview." The preview should display correctly. - Click "Actions -> MARC preview" on another search result. This preview should also look correct. - There should be no JavaScript errors in the browser console. Signed-off-by: Phil Ringnalda <phil@chetcolibrary.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34180 Phil Ringnalda <phil@chetcolibrary.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |phil@chetcolibrary.org -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34180 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #152919|0 |1 is obsolete| | --- Comment #3 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 152979 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=152979&action=edit Bug 34180: Template variable in JavaScript prevents authority MARC preview from displaying Since template variables cannot be processed by JS, we must use a template to declare a JS variable which the JS file can used. This patch corrects this problem in the JS file which handles display of the authority MARC preview from the authority search results page. To test, apply the patch and go to Authorities. - Perform a search which will return multiple authority results. - Click "Actions -> MARC preview." The preview should display correctly. - Click "Actions -> MARC preview" on another search result. This preview should also look correct. - There should be no JavaScript errors in the browser console. Signed-off-by: Phil Ringnalda <phil@chetcolibrary.org> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34180 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |martin.renvoize@ptfs-europe | |.com Status|Signed Off |Passed QA --- Comment #4 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Trivial patch, resolves the issue.. no regressions spotted. Passing QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34180 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to master Version(s)| |23.11.00 released in| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34180 --- Comment #5 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Pushed to master for 23.11. Nice work everyone, thanks! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34180 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to master |Pushed to stable Version(s)|23.11.00 |23.11.00,23.05.02 released in| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34180 --- Comment #6 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Thanks for all the hard work! Pushed to 23.05.x for the next release -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34180 Matt Blenkinsop <matt.blenkinsop@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to stable |Pushed to oldstable Version(s)|23.11.00,23.05.02 |23.11.00,23.05.02,22.11.08 released in| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34180 --- Comment #7 from Matt Blenkinsop <matt.blenkinsop@ptfs-europe.com> --- Nice work everyone! Pushed to oldstable for 22.11.x -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org