https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33999 --- Comment #1 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 152314 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=152314&action=edit Bug 33999: Subscription details link on bibliographic detail page should have permission check This patch wraps the "Subscription details" link on the bibliographic detail page with a permissions check, "CAN_user_serials," so that a user lacking permission to access the Serials module will not be shown the link. To test, apply the patch and view the bibliographic detail page of a serial record. - When viewing the "Subscriptions" tab as a user with Serials permissions you should see the "Subscription details" link. - When viewing the tab as a user without the correct permissions the link should not be present. -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33999 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #152314|0 |1 is obsolete| | --- Comment #2 from Lucas Gass <lucas@bywatersolutions.com> --- Created attachment 152320 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=152320&action=edit Bug 33999: Subscription details link on bibliographic detail page should have permission check This patch wraps the "Subscription details" link on the bibliographic detail page with a permissions check, "CAN_user_serials," so that a user lacking permission to access the Serials module will not be shown the link. To test, apply the patch and view the bibliographic detail page of a serial record. - When viewing the "Subscriptions" tab as a user with Serials permissions you should see the "Subscription details" link. - When viewing the tab as a user without the correct permissions the link should not be present. Signed-off-by: Lucas Gass <lucas@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33999 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Signed Off -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33999 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #152320|0 |1 is obsolete| | --- Comment #5 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 152977 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=152977&action=edit Bug 33999: Subscription details link on bibliographic detail page should have permission check This patch wraps the "Subscription details" link on the bibliographic detail page with a permissions check, "CAN_user_serials," so that a user lacking permission to access the Serials module will not be shown the link. To test, apply the patch and view the bibliographic detail page of a serial record. - When viewing the "Subscriptions" tab as a user with Serials permissions you should see the "Subscription details" link. - When viewing the tab as a user without the correct permissions the link should not be present. Signed-off-by: Lucas Gass <lucas@bywatersolutions.com> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33999 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |martin.renvoize@ptfs-europe | |.com QA Contact|testopia@bugs.koha-communit |martin.renvoize@ptfs-europe |y.org |.com Status|Signed Off |Passed QA --- Comment #7 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Nice catch, Passing QA -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33999 --- Comment #8 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Pushed to master for 23.11. Nice work everyone, thanks! -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33999 --- Comment #9 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Thanks for all the hard work! Pushed to 23.05.x for the next release -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33999 --- Comment #10 from Matt Blenkinsop <matt.blenkinsop@ptfs-europe.com> --- Nice work everyone! Pushed to oldstable for 22.11.x -- You are receiving this mail because: You are watching all bug changes.