[Bug 6059] New: Problem with changing quantity on uncertain prices list
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6059 Bug #: 6059 Summary: Problem with changing quantity on uncertain prices list Classification: Unclassified Change sponsored?: --- Product: Koha Version: rel_3_4 Platform: All URL: /cgi-bin/koha/acqui/uncertainprice.pl?booksellerid=2&o wner=1 OS/Version: All Status: NEW Severity: major Priority: P5 Component: Acquisitions AssignedTo: henridamien@koha-fr.org ReportedBy: katrin.fischer@bsz-bw.de QAContact: koha-bugs@lists.koha-community.org On the list for managing uncertain prices there is a column for quantity that can be edited. When creating your items on order the possibility to create items there does not make sense. When changing the quantity the uncertain price will be unset and the quantity changes to your entered number. But no additional items will be created and there is no warning about that. -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6059 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Version|3.4 |master Assignee|henridamien@koha-fr.org |koha-bugs@lists.koha-commun | |ity.org --- Comment #1 from Owen Leonard <oleonard@myacpl.org> --- This appears to still be valid in master as of 3.12 beta1. -- You are receiving this mail because: You are the QA Contact for the bug. You are the assignee for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6059 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart@biblibre.co | |m --- Comment #2 from Jonathan Druart <jonathan.druart@biblibre.com> --- Not sure to know what is the expected behavior here. -- You are receiving this mail because: You are watching all bug changes. You are the QA Contact for the bug. You are the assignee for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6059 --- Comment #3 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Hi Jonathan, I think it should not be possible to edit the quantity when items are created 'on order' - because it won't create the items. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6059 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6059 --- Comment #4 from Jonathan Druart <jonathan.druart@biblibre.com> --- Created attachment 37560 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=37560&action=edit Bug 6059: Don't permit to change the quantity when items are created on ordering If items are created on ordering, the quantity for uncertain prices should not be editable. Test plan: 0/ Set AcqCreateItem to "on ordering" 1/ Create a basket and add an order with 1+ items 2/ Mark it as uncertain prices 3/ Go on the uncertain prices page for this vendor (acqui/uncertainprice.pl?booksellerid=X) 4/ Confirm you are not allowed to update the quantity 5/ Change the price and save 6/ Confirm the quantity is still correct Set the pref to another value and confirm the behavior has not changed. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6059 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs@lists.koha-commun |jonathan.druart@biblibre.co |ity.org |m -- You are receiving this mail because: You are the assignee for the bug. You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6059 M. Tompsett <mtompset@hotmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6059 M. Tompsett <mtompset@hotmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #37560|0 |1 is obsolete| | --- Comment #5 from M. Tompsett <mtompset@hotmail.com> --- Created attachment 38149 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=38149&action=edit Bug 6059: Don't permit to change the quantity when items are created on ordering If items are created on ordering, the quantity for uncertain prices should not be editable. Test plan: 0/ Set AcqCreateItem to "on ordering" 1/ Create a basket and add an order with 1+ items 2/ Mark it as uncertain prices 3/ Go on the uncertain prices page for this vendor (acqui/uncertainprice.pl?booksellerid=X) 4/ Confirm you are not allowed to update the quantity 5/ Change the price and save 6/ Confirm the quantity is still correct Set the pref to another value and confirm the behavior has not changed. NOTE: Tested with 'on placing order' and 'on receiving order'. Signed-off-by: Mark Tompsett <mtompset@hotmail.com> -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6059 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Small patch Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6059 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #38149|0 |1 is obsolete| | --- Comment #6 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 38153 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=38153&action=edit [PASSED QA] Bug 6059: Don't permit to change the quantity when items are created on ordering If items are created on ordering, the quantity for uncertain prices should not be editable. Test plan: 0/ Set AcqCreateItem to "on ordering" 1/ Create a basket and add an order with 1+ items 2/ Mark it as uncertain prices 3/ Go on the uncertain prices page for this vendor (acqui/uncertainprice.pl?booksellerid=X) 4/ Confirm you are not allowed to update the quantity 5/ Change the price and save 6/ Confirm the quantity is still correct Set the pref to another value and confirm the behavior has not changed. NOTE: Tested with 'on placing order' and 'on receiving order'. Signed-off-by: Mark Tompsett <mtompset@hotmail.com> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6059 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master CC| |tomascohen@gmail.com --- Comment #7 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Patch pushed to master. Thanks Jonathan! -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6059 Chris Cormack <chris@bigballofwax.co.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |chris@bigballofwax.co.nz Status|Pushed to Master |Pushed to Stable --- Comment #8 from Chris Cormack <chris@bigballofwax.co.nz> --- Pushed to 3.18.x will be in 3.18.7 -- You are receiving this mail because: You are watching all bug changes. You are the QA Contact for the bug.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org