[Bug 10388] New: acq edited items showing 'null's
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10388 Bug ID: 10388 Summary: acq edited items showing 'null's Classification: Unclassified Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Acquisitions Assignee: koha-bugs@lists.koha-community.org Reporter: nengard@gmail.com Created attachment 18567 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=18567&action=edit edited item says null When editing items on the receipt page in acquisitions you see 'null' in all fields that have no value. This used to be a blank - or clear column, but now in 3.10.x and 3.12 and master it's showing null. It should be blank instead. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10388 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer@bsz-bw.de --- Comment #1 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Just a note that this bug goes back quite far - I have encountered it in 3.10.2 recently. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10388 --- Comment #2 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- This is still valid. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10388 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10388 --- Comment #3 from Jonathan Druart <jonathan.druart@biblibre.com> --- Created attachment 37550 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=37550&action=edit Bug 10388: Does not display 'null' after editing an item on receiving After editing an item on receiving, 'null' is displayed if no value is defined for a field. It should be blank. Test plan: 0/ Set AcqCreateItem to 'ordering' 1/ Go on the receipt page page 2/ Edit an item 3/ Does not fill all values 4/ Confirm that undefined values are replaced with an empty string -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10388 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs@lists.koha-commun |jonathan.druart@biblibre.co |ity.org |m CC| |jonathan.druart@biblibre.co | |m -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10388 M. Tompsett <mtompset@hotmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Small patch Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10388 M. Tompsett <mtompset@hotmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #37550|0 |1 is obsolete| | --- Comment #4 from M. Tompsett <mtompset@hotmail.com> --- Created attachment 37672 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=37672&action=edit Bug 10388: Does not display 'null' after editing an item on receiving After editing an item on receiving, 'null' is displayed if no value is defined for a field. It should be blank. Test plan: 0/ Set AcqCreateItem to 'ordering' 1/ Go on the receipt page page 2/ Edit an item 3/ Does not fill all values 4/ Confirm that undefined values are replaced with an empty string NOTE: I think you meant receive. Editing requires at least clicking the dropdown value, even if you don't change it before clicking save. null's appeared. Post patch application was able to get nulls to disappear. :) Signed-off-by: Mark Tompsett <mtompset@hotmail.com> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10388 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10388 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #37672|0 |1 is obsolete| | --- Comment #5 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 38152 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=38152&action=edit [PASSED QA] Bug 10388: Does not display 'null' after editing an item on receiving After editing an item on receiving, 'null' is displayed if no value is defined for a field. It should be blank. Test plan: 0/ Set AcqCreateItem to 'ordering' 1/ Go on the receipt page page 2/ Edit an item 3/ Does not fill all values 4/ Confirm that undefined values are replaced with an empty string NOTE: I think you meant receive. Editing requires at least clicking the dropdown value, even if you don't change it before clicking save. null's appeared. Post patch application was able to get nulls to disappear. :) Signed-off-by: Mark Tompsett <mtompset@hotmail.com> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10388 --- Comment #6 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- One question I won't have to answer in training again :) yay! -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10388 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master CC| |tomascohen@gmail.com --- Comment #7 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Patch pushed to master. Thanks Jonathan! -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10388 Chris Cormack <chris@bigballofwax.co.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |chris@bigballofwax.co.nz Status|Pushed to Master |Pushed to Stable --- Comment #8 from Chris Cormack <chris@bigballofwax.co.nz> --- Pushed to 3.18.x will be in 3.18.7 -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org