[Bug 32853] New: Fix cataloguing/value_builder/unimarc_field_125.pl
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32853 Bug ID: 32853 Summary: Fix cataloguing/value_builder/unimarc_field_125.pl Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: ASSIGNED Severity: trivial Priority: P5 - low Component: Cataloging Assignee: julian.maurice@biblibre.com Reporter: julian.maurice@biblibre.com QA Contact: testopia@bugs.koha-community.org CC: m.de.rooy@rijksmuseum.nl Blocks: 30975 This is part of the refactoring happening in bug 30975 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30975 [Bug 30975] Framework plugins do not work on cloned fields/subfields -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32853 --- Comment #1 from Julian Maurice <julian.maurice@biblibre.com> --- Created attachment 146118 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=146118&action=edit Bug 32853: Fix cataloguing/value_builder/unimarc_field_125.pl Use event parameter This is part of the refactoring happening in bug 30975 Test plan: 1. Verify that the plugin continues to work as before -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32853 Julian Maurice <julian.maurice@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32853 Julian Maurice <julian.maurice@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #146118|0 |1 is obsolete| | --- Comment #2 from Julian Maurice <julian.maurice@biblibre.com> --- Created attachment 146789 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=146789&action=edit Bug 32853: Fix cataloguing/value_builder/unimarc_field_125.pl Use event parameter This is part of the refactoring happening in bug 30975 Test plan: 1. Verify that the plugin continues to work as before -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32853 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |david@davidnind.com --- Comment #3 from David Nind <david@davidnind.com> --- I'm not familiar enough with UNIMARC to figure out how to use this plugin. Could you describe how to use this one? For example, which subfields to add this to, how to use it, and what it does. Thanks! David -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32853 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Failed QA --- Comment #4 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- This works, but doesn't really seem to make sense. It's not linked by default anywhere and it uses the template of UNIMARC 100. Looking at the definition of 125 doesn't clear things up either. (https://archive.ifla.org/VI/8/unimarc-concise-bibliographic-format-2008.pdf) -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32853 Phil Ringnalda <phil@chetcolibrary.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |phil@chetcolibrary.org --- Comment #5 from Phil Ringnalda <phil@chetcolibrary.org> --- What's the path forward here? All three of unimarc_field_124.pl, unimarc_field_125.pl, and unimarc_field_126.pl are the exact same thing, most likely from someone copying 100 and then realizing they needed separate ones for each subfield and forgetting to remove the non-subfield ones. Julian's patch for the 124 copy has already been pushed, and nothing bad has happened in the last five months as a result. Are we going to file a bug to remove all three plugins, or remove them in these bugs (including essentially reopening bug 32850 to remove 124), or push the patches here and in bug 32856 and then think about removing them? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32853 Victor Grousset/tuxayo <victor@tuxayo.net> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |victor@tuxayo.net --- Comment #6 from Victor Grousset/tuxayo <victor@tuxayo.net> ---
Julian's patch for the 124 copy has already been pushed, and nothing bad has happened in the last five months as a result.
Nothing bad was reported for years even. Julian's patch doesn't even change a thing regarding the issue right? The problem Katrin found seems to have been like that for a long time. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32853 --- Comment #7 from Julian Maurice <julian.maurice@biblibre.com> --- (In reply to Katrin Fischer from comment #4)
This works, but doesn't really seem to make sense. It's not linked by default anywhere and it uses the template of UNIMARC 100. Looking at the definition of 125 doesn't clear things up either. (https://archive.ifla.org/VI/8/unimarc-concise-bibliographic-format-2008.pdf)
Can this issue be moved to another bug report ? This is blocking bug 30975 and the patch doesn't change anything functionally -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32853 --- Comment #8 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- (In reply to Julian Maurice from comment #7)
(In reply to Katrin Fischer from comment #4)
This works, but doesn't really seem to make sense. It's not linked by default anywhere and it uses the template of UNIMARC 100. Looking at the definition of 125 doesn't clear things up either. (https://archive.ifla.org/VI/8/unimarc-concise-bibliographic-format-2008.pdf)
Can this issue be moved to another bug report ? This is blocking bug 30975 and the patch doesn't change anything functionally
Agreed, thx for bringing this up Julian. I filed: Bug 35184 - Consolidate UNIMARC value builders for 100, 124, 125, 125 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32853 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32853 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #146789|0 |1 is obsolete| | --- Comment #9 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 158045 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=158045&action=edit Bug 32853: Fix cataloguing/value_builder/unimarc_field_125.pl Use event parameter This is part of the refactoring happening in bug 30975 Test plan: 1. Verify that the plugin continues to work as before Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32853 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to master Version(s)| |23.11.00 released in| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32853 --- Comment #10 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Pushed to master for 23.11. Nice work everyone, thanks! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32853 Fridolin Somers <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)|23.11.00 |23.11.00,23.05.06 released in| | CC| |fridolin.somers@biblibre.co | |m Status|Pushed to master |Pushed to stable --- Comment #11 from Fridolin Somers <fridolin.somers@biblibre.com> --- Pushed to 23.05.x for 23.05.06 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32853 Matt Blenkinsop <matt.blenkinsop@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to stable |Pushed to oldstable Version(s)|23.11.00,23.05.06 |23.11.00,23.05.06,22.11.12 released in| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32853 --- Comment #12 from Matt Blenkinsop <matt.blenkinsop@ptfs-europe.com> --- Nice work everyone! Pushed to oldstable for 22.11.x -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org