https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35078 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|HTML tag in system |Invalid HTML in |preference is not rendered |OpacShowSavings system | |preference Severity|enhancement |minor -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35078 --- Comment #1 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 157251 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=157251&action=edit Bug 35078: Remove invalid HTML from OpacShowSavings system preference The options defined for the OpacShowSavings system preference contain HTML: "on patron's checkout history page (the system preference <em>opacreadinghistory</em> must be enabled)". This text ends up in an <option> tag, and even though the form is rendered using the multiple-select plugin the HTML still won't render and should be removed. To test, apply the patch and restart all. - Go to Administration -> System preferences and search for "OpacShowSavings" - Check the dropdown of options on the preference. The system preference names referred to should now be single-quoted instead of wrapped in visible <em> tags. - Confirm that the preference still works correctly. -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35078 Caroline Cyr La Rose <caroline.cyr-la-rose@inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #157251|0 |1 is obsolete| | --- Comment #2 from Caroline Cyr La Rose <caroline.cyr-la-rose@inlibro.com> --- Created attachment 157252 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=157252&action=edit Bug 35078: Remove invalid HTML from OpacShowSavings system preference The options defined for the OpacShowSavings system preference contain HTML: "on patron's checkout history page (the system preference <em>opacreadinghistory</em> must be enabled)". This text ends up in an <option> tag, and even though the form is rendered using the multiple-select plugin the HTML still won't render and should be removed. To test, apply the patch and restart all. - Go to Administration -> System preferences and search for "OpacShowSavings" - Check the dropdown of options on the preference. The system preference names referred to should now be single-quoted instead of wrapped in visible <em> tags. - Confirm that the preference still works correctly. Signed-off-by: Caroline Cyr La Rose <caroline.cyr-la-rose@inlibro.com> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35078 Victor Grousset/tuxayo <victor@tuxayo.net> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #157252|0 |1 is obsolete| | --- Comment #4 from Victor Grousset/tuxayo <victor@tuxayo.net> --- Created attachment 157366 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=157366&action=edit Bug 35078: Remove invalid HTML from OpacShowSavings system preference The options defined for the OpacShowSavings system preference contain HTML: "on patron's checkout history page (the system preference <em>opacreadinghistory</em> must be enabled)". This text ends up in an <option> tag, and even though the form is rendered using the multiple-select plugin the HTML still won't render and should be removed. To test, apply the patch and restart all. - Go to Administration -> System preferences and search for "OpacShowSavings" - Check the dropdown of options on the preference. The system preference names referred to should now be single-quoted instead of wrapped in visible <em> tags. - Confirm that the preference still works correctly. Signed-off-by: Caroline Cyr La Rose <caroline.cyr-la-rose@inlibro.com> Signed-off-by: Victor Grousset/tuxayo <victor@tuxayo.net> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35078 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |23.11.00 released in| | Status|Passed QA |Pushed to master -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35078 Fridolin Somers <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |fridolin.somers@biblibre.co | |m Version(s)|23.11.00 |23.11.00,23.05.06 released in| | Status|Pushed to master |Pushed to stable --- Comment #7 from Fridolin Somers <fridolin.somers@biblibre.com> --- Pushed to 23.05.x for 23.05.06 -- You are receiving this mail because: You are watching all bug changes.