https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30828 Joonas Kylmälä <joonas.kylmala@iki.fi> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30828 --- Comment #1 from Joonas Kylmälä <joonas.kylmala@iki.fi> --- Created attachment 135257 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=135257&action=edit Bug 30828: remove useless type parameter in placerequest.pl To test: 1) Grep for placerequest.pl in the source code and check that request.tt is the only place where the type parameter is passed. -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30828 --- Comment #3 from Michal Urban <michalurban177@gmail.com> --- Tested and signed off by Michal Urban -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30828 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |david@davidnind.com --- Comment #5 from David Nind <david@davidnind.com> --- Testing notes: 1. Before applying patch: git grep "$type eq 'str8'" 2. Should only find one occurrence in reserve/placerequest.pl 3 After applying patch, no occurences. -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30828 --- Comment #7 from Michal Urban <michalurban177@gmail.com> --- (In reply to David Nind from comment #6)

(In reply to Michal Urban from comment #3)

...

Tested and signed off by Michal Urban

Hi Michal.

Looks like we were both testing at the same time!

Hopefully the QA Team can add your sign off to the patch.

David

Haha what a coincidence. Thanks David, this was my first test so I wasn’t sure what to do but I’ll make sure to add test notes like you did next time. :) -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30828 Jonathan Druart <jonathan.druart+koha@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #135283|0 |1 is obsolete| | --- Comment #8 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- Created attachment 135467 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=135467&action=edit Bug 30828: Remove useless 'type' parameter in placerequest.pl To test: 1) Grep for placerequest.pl in the source code and check that request.tt is the only place where the type parameter is passed. Signed-off-by: David Nind <david@davidnind.com> JD amended patch: adjust commit title Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30828 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia@bugs.koha-communit |jonathan.druart+koha@gmail. |y.org |com CC| |tomascohen@gmail.com -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30828 --- Comment #10 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Pushed to master for 22.11. Nice work everyone, thanks! -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30828 Arthur Suzuki <arthur.suzuki@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |arthur.suzuki@biblibre.com Status|Pushed to stable |Pushed to oldstable --- Comment #12 from Arthur Suzuki <arthur.suzuki@biblibre.com> --- thx, pushed to 21.11.x for 21.11.07 -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30828 Victor Grousset/tuxayo <victor@tuxayo.net> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |victor@tuxayo.net Resolution|--- |FIXED Status|Pushed to oldstable |RESOLVED --- Comment #13 from Victor Grousset/tuxayo <victor@tuxayo.net> --- Not backported to oldoldstable (21.05.x). Feel free to ask if it's needed. Nothing to document, marking resolved. -- You are receiving this mail because: You are watching all bug changes.