[Bug 28723] New: Holds table not displayed when it contains a biblio without title
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28723 Bug ID: 28723 Summary: Holds table not displayed when it contains a biblio without title Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: ASSIGNED Severity: normal Priority: P5 - low Component: Staff Client Assignee: julian.maurice@biblibre.com Reporter: julian.maurice@biblibre.com QA Contact: testopia@bugs.koha-community.org CC: gmcharlt@gmail.com Steps to reproduce: 1. Create a biblio without title, then create an item for this biblio. 2. Place a hold on it. 3. Go to the patron detail page and click on the Holds tab 4. Confirm that holds are not displayed (the table is there but empty) In the browser console you can see an error message:
Uncaught TypeError: oObj.title is null
-- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28723 --- Comment #1 from Julian Maurice <julian.maurice@biblibre.com> --- Created attachment 122973 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=122973&action=edit Bug 28723: Fix holds table display when a biblio has no title Test plan: 1. Create a biblio without title, then create an item for this biblio. 2. Place a hold on it. 3. Go to the patron detail page and click on the Holds tab 4. Confirm that holds are correctly displayed -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28723 Julian Maurice <julian.maurice@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28723 Julian Maurice <julian.maurice@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28723 Julian Maurice <julian.maurice@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #122973|0 |1 is obsolete| | --- Comment #2 from Julian Maurice <julian.maurice@biblibre.com> --- Created attachment 122975 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=122975&action=edit Bug 28723: Fix holds table display when a biblio has no title Test plan: 1. Create a biblio without title, then create an item for this biblio. 2. Place a hold on it. 3. Go to the patron detail page and click on the Holds tab 4. Confirm that holds are correctly displayed -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28723 David Cook <dcook@prosentient.com.au> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |dcook@prosentient.com.au -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28723 Joonas Kylmälä <joonas.kylmala@helsinki.fi> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Failed QA CC| |joonas.kylmala@helsinki.fi --- Comment #3 from Joonas Kylmälä <joonas.kylmala@helsinki.fi> --- The English text added in the patch is untranslatable, please see https://wiki.koha-community.org/wiki/Coding_Guidelines#JS5:_Enabling_transla... -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28723 Julian Maurice <julian.maurice@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #122975|0 |1 is obsolete| | --- Comment #4 from Julian Maurice <julian.maurice@biblibre.com> --- Created attachment 135447 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=135447&action=edit Bug 28723: Fix holds table display when a biblio has no title Test plan: 1. Create a biblio without title, then create an item for this biblio. 2. Place a hold on it. 3. Go to the patron detail page and click on the Holds tab 4. Confirm that holds are correctly displayed -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28723 Julian Maurice <julian.maurice@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff --- Comment #5 from Julian Maurice <julian.maurice@biblibre.com> --- (In reply to Joonas Kylmälä from comment #3)
The English text added in the patch is untranslatable Fixed in the last patch
-- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28723 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28723 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #135447|0 |1 is obsolete| | --- Comment #6 from David Nind <david@davidnind.com> --- Created attachment 135452 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=135452&action=edit Bug 28723: Fix holds table display when a biblio has no title Test plan: 1. Create a biblio without title, then create an item for this biblio. 2. Place a hold on it. 3. Go to the patron detail page and click on the Holds tab 4. Confirm that holds are correctly displayed Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28723 Jonathan Druart <jonathan.druart+koha@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart+koha@gmail. | |com --- Comment #7 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- koha-tmpl/intranet-tmpl/prog/js/checkouts.js: + (oObj.title ? oObj.title.escapeHtml() : '' ); koha-tmpl/intranet-tmpl/prog/js/checkouts.js: + (oObj.title ? oObj.title.escapeHtml() : '' ); koha-tmpl/intranet-tmpl/prog/js/holds.js: + (oObj.title ? oObj.title.escapeHtml() : __('No title')); It's inconsistent. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28723 --- Comment #8 from Julian Maurice <julian.maurice@biblibre.com> --- (In reply to Jonathan Druart from comment #7)
It's inconsistent. What do you suggest ? I can replace 'No title' by an empty string, but if instead we want 'No title' in checkouts.js too, that should be done in another bug IMO biblio-title.inc uses 'No title'
-- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28723 --- Comment #9 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- I would go with the empty string for now. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28723 --- Comment #10 from Julian Maurice <julian.maurice@biblibre.com> --- Created attachment 135484 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=135484&action=edit Bug 28723: Replace "No title" by an empty string This is to be consistent with what is done in checkouts.js -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28723 Jonathan Druart <jonathan.druart+koha@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28723 Jonathan Druart <jonathan.druart+koha@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #135452|0 |1 is obsolete| | Attachment #135484|0 |1 is obsolete| | --- Comment #11 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- Created attachment 135485 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=135485&action=edit Bug 28723: Fix holds table display when a biblio has no title Test plan: 1. Create a biblio without title, then create an item for this biblio. 2. Place a hold on it. 3. Go to the patron detail page and click on the Holds tab 4. Confirm that holds are correctly displayed Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28723 --- Comment #12 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- Created attachment 135486 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=135486&action=edit Bug 28723: Replace "No title" by an empty string This is to be consistent with what is done in checkouts.js Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28723 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to master Version(s)| |22.11.00 released in| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28723 --- Comment #13 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Pushed to master for 22.11. Nice work everyone, thanks! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28723 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |tomascohen@gmail.com QA Contact|testopia@bugs.koha-communit |jonathan.druart+koha@gmail. |y.org |com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28723 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)|22.11.00 |22.11.00, 22.05.01 released in| | CC| |lucas@bywatersolutions.com Status|Pushed to master |Pushed to stable --- Comment #14 from Lucas Gass <lucas@bywatersolutions.com> --- Pushed to 22.05.x for 22.05.01 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28723 Arthur Suzuki <arthur.suzuki@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)|22.11.00, 22.05.01 |22.11.00, 22.05.01, released in| |21.11.07 CC| |arthur.suzuki@biblibre.com Status|Pushed to stable |Pushed to oldstable --- Comment #15 from Arthur Suzuki <arthur.suzuki@biblibre.com> --- pushed to 21.11.x for 21.11.07, thx! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28723 Victor Grousset/tuxayo <victor@tuxayo.net> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to oldstable |RESOLVED CC| |victor@tuxayo.net Resolution|--- |FIXED --- Comment #16 from Victor Grousset/tuxayo <victor@tuxayo.net> --- Not backported to oldoldstable (21.05.x). Feel free to ask if it's needed. Nothing to document, marking resolved. -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org