[Bug 7253] New: fast cataloging not always checking out
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7253 Bug #: 7253 Summary: fast cataloging not always checking out Classification: Unclassified Change sponsored?: --- Product: Koha Version: unspecified Platform: All OS/Version: All Status: NEW Severity: normal Priority: P5 - low Component: Cataloging AssignedTo: gmcharlt@gmail.com ReportedBy: nengard@gmail.com QAContact: ian.walls@bywatersolutions.com Today during training we had the staff perform "fast cataloging" (They were given items to checkout that where not in Koha) After creating the item (clicking the "add item" button) some of the books were immediately checked out to the patron, while others never went past the "add item" screen. If a "duplicate record suspected" message appears it will not automatically check the item out to the borrower after clicking "add item" It stays on the "edit items" screen. I'm not sure that's the only time something is not checked out, but it is certainly one reason a book won't be checked out when fast cataloged. -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7253 Nicole C. Engard <nengard@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version|unspecified |master Severity|normal |major -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7253 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer@bsz-bw.de --- Comment #1 from Katrin Fischer <katrin.fischer@bsz-bw.de> 2011-12-06 16:14:37 UTC --- Hi Nicole, in my tests the checkouts didn't happen when you change the barcode on the item form. All other tests so far went well. Could this be the reason? -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7253 --- Comment #2 from Nicole C. Engard <nengard@gmail.com> 2011-12-06 16:39:13 UTC --- Katrin, That could be another reason, but if a duplicate if found most certainly doesn't check out the item. Nicole -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7253 Fridolyn SOMERS <fridolyn.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |fridolyn.somers@biblibre.co | |m -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7253 Fridolyn SOMERS <fridolyn.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff Assignee|gmcharlt@gmail.com |fridolyn.somers@biblibre.co | |m --- Comment #3 from Fridolyn SOMERS <fridolyn.somers@biblibre.com> --- Created attachment 14459 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=14459&action=edit Proposed patch See commit comment -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7253 Fridolyn SOMERS <fridolyn.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Small patch -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7253 Nicole C. Engard <nengard@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #14459|0 |1 is obsolete| | --- Comment #4 from Nicole C. Engard <nengard@gmail.com> --- Created attachment 14489 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=14489&action=edit [SIGNED-OFF] Bug 7253: fast cataloging not always checking out When using fast cataloguing to create a biblio and item on the fly, workflow looses datas when a duplicate is detected. This comes from the use of a mix of circborrowernumber and borrowernumber in forms. This patch corrects by using always circborrowernumber in fast cataloguing workflow. Also adds html and uri escape for barecode where necessery. Test plan : With duplicate : - Go to a borrower circulation page - Enter a non existing barcode - Enter a due date - Click on "Check Out" => a message says the barcode was not found - Click on "Fast cataloguing" => The biblio edition page appears with fast cataloguing framework - Fill mandatory fields by using an existing ISBN - Click on "Save" => a yes/no message says "Duplicate record suspected" (Choosing yes will brake fast caloguing workflow, in this case librarian should create an item and checkout again) - Click on "No" => The item edition page appears with barcode already filled - Fill mandatory datas - Click on "Add item" => Borrower circulation page appears again, check that item has been checked out with the specified due date You may test without duplicate Signed-off-by: Nicole C. Engard <nengard@bywatersolutions.com> Tested following the plan and by fast cataloging a non-duplicate. All works as expected. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7253 Nicole C. Engard <nengard@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7253 mathieu saby <mathieu.saby@univ-rennes2.fr> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |mathieu.saby@univ-rennes2.f | |r -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7253 Paul Poulain <paul.poulain@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |paul.poulain@biblibre.com --- Comment #5 from Paul Poulain <paul.poulain@biblibre.com> --- Patch tested with a sandbox, by koha.aixmarseille <koha.aixmarseille@gmail.com> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7253 Paul Poulain <paul.poulain@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #14489|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7253 --- Comment #6 from Paul Poulain <paul.poulain@biblibre.com> --- Created attachment 14495 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=14495&action=edit Bug 7253: fast cataloging not always checking out When using fast cataloguing to create a biblio and item on the fly, workflow looses datas when a duplicate is detected. This comes from the use of a mix of circborrowernumber and borrowernumber in forms. This patch corrects by using always circborrowernumber in fast cataloguing workflow. Also adds html and uri escape for barecode where necessery. Test plan : With duplicate : - Go to a borrower circulation page - Enter a non existing barcode - Enter a due date - Click on "Check Out" => a message says the barcode was not found - Click on "Fast cataloguing" => The biblio edition page appears with fast cataloguing framework - Fill mandatory fields by using an existing ISBN - Click on "Save" => a yes/no message says "Duplicate record suspected" (Choosing yes will brake fast caloguing workflow, in this case librarian should create an item and checkout again) - Click on "No" => The item edition page appears with barcode already filled - Fill mandatory datas - Click on "Add item" => Borrower circulation page appears again, check that item has been checked out with the specified due date You may test without duplicate Signed-off-by: Nicole C. Engard <nengard@bywatersolutions.com> Tested following the plan and by fast cataloging a non-duplicate. All works as expected. Signed-off-by: koha.aixmarseille <koha.aixmarseille@gmail.com> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7253 Koha Team AMU <koha.aixmarseille@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |koha.aixmarseille@gmail.com -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7253 --- Comment #7 from Fridolyn SOMERS <fridolyn.somers@biblibre.com> --- Created attachment 14536 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=14536&action=edit Proposed patch (follow-up 1) Follow-up to manage toolbar during fast cataloguing. Librarian may brake workflow by using some of its menus. See commit comment. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7253 Fridolyn SOMERS <fridolyn.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7253 Koha Team AMU <koha.aixmarseille@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7253 --- Comment #8 from Paul Poulain <paul.poulain@biblibre.com> --- Patch tested with a sandbox, by koha.aixmarseille <koha.aixmarseille@gmail.com> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7253 Jared Camins-Esakov <jcamins@cpbibliography.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Needs Signoff --- Comment #9 from Jared Camins-Esakov <jcamins@cpbibliography.com> --- The follow-up will need a signoff. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7253 Fridolyn SOMERS <fridolyn.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #14536|0 |1 is obsolete| | --- Comment #10 from Fridolyn SOMERS <fridolyn.somers@biblibre.com> --- Created attachment 15087 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=15087&action=edit [SIGNED-OFF] Bug 7253: followup : manage toolbar for fastcataloging Follow-up has been signed-off with a sandbox by koha.aixmarseille (comment 8) but attachement did not change. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7253 Fridolyn SOMERS <fridolyn.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7253 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7253 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #14495|0 |1 is obsolete| | Attachment #15087|0 |1 is obsolete| | --- Comment #11 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 15218 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=15218&action=edit Bug 7253: fast cataloging not always checking out When using fast cataloguing to create a biblio and item on the fly, workflow looses datas when a duplicate is detected. This comes from the use of a mix of circborrowernumber and borrowernumber in forms. This patch corrects by using always circborrowernumber in fast cataloguing workflow. Also adds html and uri escape for barecode where necessery. Test plan : With duplicate : - Go to a borrower circulation page - Enter a non existing barcode - Enter a due date - Click on "Check Out" => a message says the barcode was not found - Click on "Fast cataloguing" => The biblio edition page appears with fast cataloguing framework - Fill mandatory fields by using an existing ISBN - Click on "Save" => a yes/no message says "Duplicate record suspected" (Choosing yes will brake fast caloguing workflow, in this case librarian should create an item and checkout again) - Click on "No" => The item edition page appears with barcode already filled - Fill mandatory datas - Click on "Add item" => Borrower circulation page appears again, check that item has been checked out with the specified due date You may test without duplicate Signed-off-by: Nicole C. Engard <nengard@bywatersolutions.com> Tested following the plan and by fast cataloging a non-duplicate. All works as expected. Signed-off-by: koha.aixmarseille <koha.aixmarseille@gmail.com> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7253 --- Comment #12 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 15219 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=15219&action=edit Bug 7253: followup : manage toolbar for fastcataloging During fast cataloging, hide some toolbar menus of biblio edition page : - Save and view record - Z3950 Search - Framework change Also display "(fast cataloging)" in biblio and item editon. Signed-off-by: koha.aixmarseille <koha.aixmarseille@gmail.com> Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de> Passes all tests and QA script. Tested: - adding a fast add with duplicate and without - adding a new record, checked toolbar showed up correctly - editing existing record, checked toolbar showed up correctly -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7253 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #15218|0 |1 is obsolete| | --- Comment #13 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 15220 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=15220&action=edit Bug 7253: fast cataloging not always checking out When using fast cataloguing to create a biblio and item on the fly, workflow looses datas when a duplicate is detected. This comes from the use of a mix of circborrowernumber and borrowernumber in forms. This patch corrects by using always circborrowernumber in fast cataloguing workflow. Also adds html and uri escape for barecode where necessery. Test plan : With duplicate : - Go to a borrower circulation page - Enter a non existing barcode - Enter a due date - Click on "Check Out" => a message says the barcode was not found - Click on "Fast cataloguing" => The biblio edition page appears with fast cataloguing framework - Fill mandatory fields by using an existing ISBN - Click on "Save" => a yes/no message says "Duplicate record suspected" (Choosing yes will brake fast caloguing workflow, in this case librarian should create an item and checkout again) - Click on "No" => The item edition page appears with barcode already filled - Fill mandatory datas - Click on "Add item" => Borrower circulation page appears again, check that item has been checked out with the specified due date You may test without duplicate Signed-off-by: Nicole C. Engard <nengard@bywatersolutions.com> Tested following the plan and by fast cataloging a non-duplicate. All works as expected. Signed-off-by: koha.aixmarseille <koha.aixmarseille@gmail.com> Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7253 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #15219|0 |1 is obsolete| | --- Comment #14 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 15221 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=15221&action=edit Bug 7253: followup : manage toolbar for fastcataloging During fast cataloging, hide some toolbar menus of biblio edition page : - Save and view record - Z3950 Search - Framework change Also display "(fast cataloging)" in biblio and item editon. Signed-off-by: koha.aixmarseille <koha.aixmarseille@gmail.com> Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de> Passes all tests and QA script. Tested: - adding a fast add with duplicate and without - adding a new record, checked toolbar showed up correctly - editing existing record, checked toolbar showed up correctly -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7253 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|koha.sekjal@gmail.com |katrin.fischer@bsz-bw.de -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7253 Jared Camins-Esakov <jcamins@cpbibliography.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master --- Comment #15 from Jared Camins-Esakov <jcamins@cpbibliography.com> --- This patch has been pushed to master. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7253 Chris Cormack <chris@bigballofwax.co.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |Pushed to Stable CC| |chris@bigballofwax.co.nz --- Comment #16 from Chris Cormack <chris@bigballofwax.co.nz> --- Pushed to 3.10.x and 3.8.x will be in 3.10.4 and 3.8.11 -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org