http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9585 --- Comment #2 from Owen Leonard <oleonard@myacpl.org> --- It looks to me like you'd have to have a UNIMARC setup to really fully test it ("Please note that the Serial Collection tab is currently available only for UNIMARC"). But testing the "subscriptions" and "holdings" settings of the opacSerialDefaultTab shows the correct behavior, the change does appear to be logical. -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9585 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #15215|0 |1 is obsolete| | --- Comment #3 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 15261 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=15261&action=edit [SIGNED-OFF] Bug 9585 - Fix spelling mistake in default tab conditional for opac-detail There is just a small typo where one of the results of a conditional is "subscription" rather than "subscriptions". If this comes up, the correct tab (subscriptions) will not be chosen. I'm not sure what will happen...it'll probably just have the "holdings", "subscriptions", and "serial collection" tabs all default to closed with none of them being open. Test Plan: The easiest way to test is just to double-check the other strings in the conditional which say "subscriptions" rather than "subscription". You can also look at opac-detail.tt where the param is shown, and note that there is no condition for "subscription" - just "subscriptions". Any tests other than that would be overly complex for such a trivial patch. Signed-off-by: Owen Leonard <oleonard@myacpl.org> -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9585 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #15261|0 |1 is obsolete| | --- Comment #5 from Jonathan Druart <jonathan.druart@biblibre.com> --- Created attachment 15274 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=15274&action=edit Bug 9585 - Fix spelling mistake in default tab conditional for opac-detail There is just a small typo where one of the results of a conditional is "subscription" rather than "subscriptions". If this comes up, the correct tab (subscriptions) will not be chosen. I'm not sure what will happen...it'll probably just have the "holdings", "subscriptions", and "serial collection" tabs all default to closed with none of them being open. Test Plan: The easiest way to test is just to double-check the other strings in the conditional which say "subscriptions" rather than "subscription". You can also look at opac-detail.tt where the param is shown, and note that there is no condition for "subscription" - just "subscriptions". Any tests other than that would be overly complex for such a trivial patch. Signed-off-by: Owen Leonard <oleonard@myacpl.org> Signed-off-by: Jonathan Druart <jonathan.druart@biblibre.com> -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9585 Chris Cormack <chris@bigballofwax.co.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |Pushed to Stable CC| |chris@bigballofwax.co.nz --- Comment #7 from Chris Cormack <chris@bigballofwax.co.nz> --- Pushed to 3.8.x and 3.10.x will be in 3.8.11 and 3.10.4 -- You are receiving this mail because: You are watching all bug changes.