[Bug 26975] New: Reindent authorities editor template
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26975 Bug ID: 26975 Summary: Reindent authorities editor template Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: ASSIGNED Severity: enhancement Priority: P5 - low Component: Templates Assignee: oleonard@myacpl.org Reporter: oleonard@myacpl.org QA Contact: testopia@bugs.koha-community.org CC: testopia@bugs.koha-community.org Blocks: 26974 I would like to update the batch item modification template so that it has consistent indentation. It needs to have some tabs replaced with spaces and to have trailing spaces removed. Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26974 [Bug 26974] Move authorities editor template JavaScript to the footer -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26975 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff Patch complexity|--- |Small patch -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26975 --- Comment #1 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 113312 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=113312&action=edit Bug 26975: Reindent authorities editor template This patch performs general template cleanup to the authorities editor: Make indentation consistent, replace tabs with spaces, and trim trailing whitespace. To test, apply the patch and edit or create a new authority record. Test the functionality of the authority editor and confirm that everything works correctly, including JS interactions like subfield reordering, tag and subfield cloning, and tag and subfield deletion. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26975 --- Comment #2 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 113313 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=113313&action=edit Bug 26795: (follow-up) Add markup comments This patch adds comments to the template to highlight the markup structure. This patch should have no effect on the page's appearance or functionality. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26975 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #113312|0 |1 is obsolete| | Attachment #113313|0 |1 is obsolete| | --- Comment #3 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 116267 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=116267&action=edit Bug 26975: Reindent authorities editor template This patch performs general template cleanup to the authorities editor: Make indentation consistent, replace tabs with spaces, and trim trailing whitespace. To test, apply the patch and edit or create a new authority record. Test the functionality of the authority editor and confirm that everything works correctly, including JS interactions like subfield reordering, tag and subfield cloning, and tag and subfield deletion. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26975 --- Comment #4 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 116268 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=116268&action=edit Bug 26795: (follow-up) Add markup comments This patch adds comments to the template to highlight the markup structure. This patch should have no effect on the page's appearance or functionality. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26975 Phil Ringnalda <phil@chetcolibrary.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |phil@chetcolibrary.org --- Comment #5 from Phil Ringnalda <phil@chetcolibrary.org> --- Verified that everything else still works, but bug 27737 makes it impossible to test the authority search plugin behavior. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26975 Phil Ringnalda <phil@chetcolibrary.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Patch doesn't apply --- Comment #6 from Phil Ringnalda <phil@chetcolibrary.org> --- And of course, fixing bug 27737 caused this patch to no longer apply. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26975 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26975 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #116267|0 |1 is obsolete| | Attachment #116268|0 |1 is obsolete| | --- Comment #7 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 129279 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=129279&action=edit Bug 26975: Reindent authorities editor template This patch performs general template cleanup to the authorities editor: Make indentation consistent, replace tabs with spaces, and trim trailing whitespace. To test, apply the patch and edit or create a new authority record. Test the functionality of the authority editor and confirm that everything works correctly, including JS interactions like subfield reordering, tag and subfield cloning, and tag and subfield deletion. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26975 --- Comment #8 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 129280 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=129280&action=edit Bug 26795: (follow-up) Add markup comments This patch adds comments to the template to highlight the markup structure. This patch should have no effect on the page's appearance or functionality. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26975 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |24415 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24415 [Bug 24415] Authority enhancement - Improve access to tabs -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26975 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26975 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #129279|0 |1 is obsolete| | --- Comment #9 from David Nind <david@davidnind.com> --- Created attachment 129965 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=129965&action=edit Bug 26975: Reindent authorities editor template This patch performs general template cleanup to the authorities editor: Make indentation consistent, replace tabs with spaces, and trim trailing whitespace. To test, apply the patch and edit or create a new authority record. Test the functionality of the authority editor and confirm that everything works correctly, including JS interactions like subfield reordering, tag and subfield cloning, and tag and subfield deletion. Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26975 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #129280|0 |1 is obsolete| | --- Comment #10 from David Nind <david@davidnind.com> --- Created attachment 129966 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=129966&action=edit Bug 26795: (follow-up) Add markup comments This patch adds comments to the template to highlight the markup structure. This patch should have no effect on the page's appearance or functionality. https://bugs.koha-community.org/show_bug.cgi?id=26975 Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26975 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #129965|0 |1 is obsolete| | Attachment #129966|0 |1 is obsolete| | --- Comment #11 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 130636 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=130636&action=edit Bug 26975: Reindent authorities editor template This patch performs general template cleanup to the authorities editor: Make indentation consistent, replace tabs with spaces, and trim trailing whitespace. To test, apply the patch and edit or create a new authority record. Test the functionality of the authority editor and confirm that everything works correctly, including JS interactions like subfield reordering, tag and subfield cloning, and tag and subfield deletion. Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26975 --- Comment #12 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 130637 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=130637&action=edit Bug 26795: (follow-up) Add markup comments This patch adds comments to the template to highlight the markup structure. This patch should have no effect on the page's appearance or functionality. https://bugs.koha-community.org/show_bug.cgi?id=26975 Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26975 --- Comment #13 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 130928 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=130928&action=edit k -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26975 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26975 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #130636|0 |1 is obsolete| | Attachment #130637|0 |1 is obsolete| | Attachment #130928|0 |1 is obsolete| | --- Comment #14 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 130929 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=130929&action=edit Bug 26975: Reindent authorities editor template This patch performs general template cleanup to the authorities editor: Make indentation consistent, replace tabs with spaces, and trim trailing whitespace. To test, apply the patch and edit or create a new authority record. Test the functionality of the authority editor and confirm that everything works correctly, including JS interactions like subfield reordering, tag and subfield cloning, and tag and subfield deletion. Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26975 --- Comment #15 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 130930 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=130930&action=edit Bug 26795: (follow-up) Add markup comments This patch adds comments to the template to highlight the markup structure. This patch should have no effect on the page's appearance or functionality. https://bugs.koha-community.org/show_bug.cgi?id=26975 Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26975 Fridolin Somers <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #130930|0 |1 is obsolete| | --- Comment #16 from Fridolin Somers <fridolin.somers@biblibre.com> --- Created attachment 131052 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=131052&action=edit Bug 26975: (follow-up) Add markup comments This patch adds comments to the template to highlight the markup structure. This patch should have no effect on the page's appearance or functionality. https://bugs.koha-community.org/show_bug.cgi?id=26975 Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26975 Fridolin Somers <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |fridolin.somers@biblibre.co | |m --- Comment #17 from Fridolin Somers <fridolin.somers@biblibre.com> --- Fixed typo in follow-up patch name : Bug 26795 => Bug 26975 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26975 Fridolin Somers <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |22.05.00 released in| | Status|Passed QA |Pushed to master -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26975 --- Comment #18 from Fridolin Somers <fridolin.somers@biblibre.com> --- Pushed to master for 22.05, thanks to everybody involved 🦄 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26975 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |FIXED Status|Pushed to master |RESOLVED CC| |kyle@bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org