[Bug 29876] New: Style report id in report results heading
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29876 Bug ID: 29876 Summary: Style report id in report results heading Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: ASSIGNED Severity: enhancement Priority: P5 - low Component: Templates Assignee: oleonard@myacpl.org Reporter: oleonard@myacpl.org QA Contact: testopia@bugs.koha-community.org Depends on: 24834 Created attachment 129403 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=129403&action=edit Screenshot showing the updated interface I find the inclusion of the report id in the heading of the SQL report results page to be confusing because it can look like it is showing the number of results. I think adding some style to it would help. Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24834 [Bug 24834] Display report number after running -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29876 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29876 --- Comment #1 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 129404 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=129404&action=edit Bug 29876: Style report id in report results heading This patch makes minor changes to the template and adds some CSS to style the report id portion of the page heading. To test, apply the patch and go to Reports -> Saved SQL reports. - Run any report. - On the results page, confirm that the report id portion of the page heading is styled and labeled "Report number." -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29876 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29876 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #129404|0 |1 is obsolete| | --- Comment #2 from Lucas Gass <lucas@bywatersolutions.com> --- Created attachment 129430 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=129430&action=edit Bug 29876: Style report id in report results heading This patch makes minor changes to the template and adds some CSS to style the report id portion of the page heading. To test, apply the patch and go to Reports -> Saved SQL reports. - Run any report. - On the results page, confirm that the report id portion of the page heading is styled and labeled "Report number." Signed-off-by: Lucas Gass <lucas@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29876 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |lucas@bywatersolutions.com --- Comment #3 from Lucas Gass <lucas@bywatersolutions.com> --- This is makes it much more clear, thanks! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29876 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29876 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #129430|0 |1 is obsolete| | --- Comment #4 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 129973 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=129973&action=edit Bug 29876: Style report id in report results heading This patch makes minor changes to the template and adds some CSS to style the report id portion of the page heading. To test, apply the patch and go to Reports -> Saved SQL reports. - Run any report. - On the results page, confirm that the report id portion of the page heading is styled and labeled "Report number." Signed-off-by: Lucas Gass <lucas@bywatersolutions.com> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29876 --- Comment #5 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Only a small thing: Should we make this read Report ID to match the label on the saved reports table? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29876 Fridolin Somers <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |fridolin.somers@biblibre.co | |m --- Comment #6 from Fridolin Somers <fridolin.somers@biblibre.com> --- (In reply to Katrin Fischer from comment #5)
Only a small thing: Should we make this read Report ID to match the label on the saved reports table?
+1 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29876 --- Comment #7 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 130567 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=130567&action=edit Bug 29876: (follow-up) Change "Report number" to "Report ID" This makes is consistent with the display of saved reports where the number is shown in an "ID" column. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29876 Fridolin Somers <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to master Version(s)| |22.05.00 released in| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29876 --- Comment #8 from Fridolin Somers <fridolin.somers@biblibre.com> --- Pushed to master for 22.05, thanks to everybody involved 🦄 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29876 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to master |RESOLVED CC| |kyle@bywatersolutions.com Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org