[Bug 32185] New: Template error in opac-reserve.pl
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32185 Bug ID: 32185 Summary: Template error in opac-reserve.pl Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: major Priority: P5 - low Component: OPAC Assignee: oleonard@myacpl.org Reporter: katrin.fischer@bsz-bw.de QA Contact: testopia@bugs.koha-community.org This turned up in translations: koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-reserve.tt: <span class="notforloan">Not for loan ([% AuthorisedValues.GetDescriptionByKohaField( kohafield => 'items.notforloan', authorised_value => itemLoo.notforloan ) %] %]) Results in this string: Not for loan (%s %%]) -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32185 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED Keywords| |rel_22_11_candidate Assignee|oleonard@myacpl.org |katrin.fischer@bsz-bw.de -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32185 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Passed QA Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32185 --- Comment #1 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 143810 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=143810&action=edit Bug 32185: Fix template typo in opac-reserve.pl This removes the %] showing for not for loan items disappear. To test: * Create a record with multiple items, mark one 'not for loan' * Place an item level request on this record in the OPAC * Make sure you 'Show nonholdable items' * Verify the %] shows in the column with the not for loan status * Apply patch * Verify display is now improved -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32185 --- Comment #2 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- As this was found translating we can be sure it affects translations, changing a string in the OPAC. Maybe we could do another update to the strings a few days before release to catch such last minute fixed stuff? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32185 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to master Version(s)| |22.11.00 released in| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32185 --- Comment #3 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Pushed to master for 22.11. Nice work everyone, thanks! -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org