[Bug 20207] New: Anonymous Purchase Suggestions show on OPAC even when OPACViewOthersSuggestions is set to Don't Show
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20207 Bug ID: 20207 Summary: Anonymous Purchase Suggestions show on OPAC even when OPACViewOthersSuggestions is set to Don't Show Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: OPAC Assignee: oleonard@myacpl.org Reporter: jzairo@bywatersolutions.com QA Contact: testopia@bugs.koha-community.org When you enable AnonSuggestions and ALLOW patrons that aren't logged in to make purchase suggestions, once a suggestion has successfully been submitted, Anonymous Purchase Suggestions will show on OPAC even when system preference OPACViewOthersSuggestions, is set to Don't Show. The suggestions will show on opac-suggestions.pl. However, if you search for the title you suggested, you will get a message saying "You are not authorized to see pending purchase suggestions." -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20207 Mark Hofstetter <koha@trust-box.at> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |koha@trust-box.at --- Comment #1 from Mark Hofstetter <koha@trust-box.at> --- quick testing on 22.05.05.000 seem to indicate that this bug still persists although it seems to work on 21.05.04.000 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20207 Mark Hofstetter <koha@trust-box.at> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|oleonard@myacpl.org |koha@trust-box.at Change sponsored?|--- |Sponsored -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20207 --- Comment #2 from Mark Hofstetter <koha@trust-box.at> --- Created attachment 143789 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=143789&action=edit Bug 20207: Anonymous Purchase Suggestions show on OPAC even when OPACViewOthersSuggestions is set to Don't Show When you enable AnonSuggestions and ALLOW patrons that aren't logged in to make purchase suggestions, once a suggestion has successfully been submitted, Anonymous Purchase Suggestions will show on OPAC even when system preference OPACViewOthersSuggestions, is set to Don't Show. The suggestions will show on opac-suggestions.pl. However, if you search for the title you suggested, you will get a message saying "You are not authorized to see pending purchase suggestions." This patch fixes the error, ie if OPACViewOthersSuggestions is set to false not other suggestions are shown (if you are not logged in and AnonSuggestions) OR ONLY your own suggestions if you are logged in To test: 1) activate AnonSuggestions 2) create an anon suggestion 3) create a suggestion with a logged in user 4) toggle OPACViewOthersSuggestions Show/Don't show 5) all suggestions are shown cgi-bin/koha/opac-suggestions.pl in either case 6) apply patch 7) OPACViewOthersSuggestions is now respected ie suggestions from other users are only shown if activated 8) Please sign off Sponsored-by: Library of the Natural History Museum Vienna -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20207 Mark Hofstetter <koha@trust-box.at> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20207 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20207 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #143789|0 |1 is obsolete| | --- Comment #3 from David Nind <david@davidnind.com> --- Created attachment 143798 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=143798&action=edit Bug 20207: Anonymous Purchase Suggestions show on OPAC even when OPACViewOthersSuggestions is set to Don't Show When you enable AnonSuggestions and ALLOW patrons that aren't logged in to make purchase suggestions, once a suggestion has successfully been submitted, Anonymous Purchase Suggestions will show on OPAC even when system preference OPACViewOthersSuggestions, is set to Don't Show. The suggestions will show on opac-suggestions.pl. However, if you search for the title you suggested, you will get a message saying "You are not authorized to see pending purchase suggestions." This patch fixes the error, ie if OPACViewOthersSuggestions is set to false not other suggestions are shown (if you are not logged in and AnonSuggestions) OR ONLY your own suggestions if you are logged in To test: 1) activate AnonSuggestions 2) create an anon suggestion 3) create a suggestion with a logged in user 4) toggle OPACViewOthersSuggestions Show/Don't show 5) all suggestions are shown cgi-bin/koha/opac-suggestions.pl in either case 6) apply patch 7) OPACViewOthersSuggestions is now respected ie suggestions from other users are only shown if activated 8) Please sign off Sponsored-by: Library of the Natural History Museum Vienna Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20207 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |david@davidnind.com --- Comment #4 from David Nind <david@davidnind.com> --- This fixes the display of purchase suggestions on the OPAC when not logged in However, if you are a logged in user on the OPAC you still only see your own purchase suggestions. (Home > Your account > Purchase suggestions > [toggle 'Suggested by anyone' and 'Suggested by me' in search for] Should this be fixed on this bug, or a new one? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20207 --- Comment #5 from Mark Hofstetter <koha@trust-box.at> --- sorry I don't see the possibility to [toggle 'Suggested by anyone' and 'Suggested by me' in search for] I am working on 22.05 imho OPACViewOthersSuggestions suggests (sorry f the pun) that no other suggestions are shown. Maybe 'Suggested by anyone' should be rephrased or only shown if OPACViewOthersSuggestions is true -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20207 --- Comment #6 from David Nind <david@davidnind.com> --- Created attachment 143800 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=143800&action=edit Screenshot [22.05.x] - logged in patron purchase suggestions Apologies for any confusion caused! I've run through things again (detailed notes below), with these conclusions: - This patch fixes things on master for the issue identified in this bug (I didn't try and apply the patch to 22.05.x) - A separate bug is required for master only for logged in patrons: if OPACViewOthersSuggestions is set to 'Show', it only shows the logged in patron's suggestions and not all suggestions (this is working correctly on 22.05.x, but NOT on master) I hope I haven't confused things even more! 22.05.x ======= Setup: need at least x1 suggestion already by an anonymous patron, and x1 suggestion by a logged in patron. Not logged in ------------- AnonSuggestions set to 'Allow' AND OPACViewOthersSuggestions set to 'Show' AND when not logged in
From OPAC home > Purchase suggestions: ==> displays suggestions from anonymous and logged in patrons (as expected)
If OPACViewOthersSuggestions is set to "Don't show": ==> doesn't display any suggestions (as expected) If OPACViewOthersSuggestions is set to "Don't show" and you add a new suggestion when not logged in: ==> it shows other suggestions made by anonymous users (but NOT suggestions made by logged in users) Logged in --------- Login as a patron and go to Your account > Purchase suggestions - purchase suggestions show correctly: - OPACViewOthersSuggestions set to "Don't show" - can only see your own suggestions (as expected) - OPACViewOthersSuggestions set to "Show" - after the search for the input field there is a dropdown list with options to show suggestions "Suggested by me" and "Suggested by anyone", works as expected master ====== Setup: need at least x1 suggestion already by an anonymous patron, and x1 suggestion by a logged in patron. Not logged in ------------- AnonSuggestions set to 'Allow' AND OPACViewOthersSuggestions set to 'Show' AND when not logged in
From OPAC home > Purchase suggestions: ==> displays suggestions from anonymous and logged in patrons (as expected)
If OPACViewOthersSuggestions is set to "Don't show": ==> displays suggestions from anonymous and logged in patrons (NOT expected, also different behaviour from 22.05.x where it does not show any suggestions) If OPACViewOthersSuggestions is set to "Don't show" and you add a new suggestion when not logged in: ==> it shows other suggestions made by anonymous AND logged in patrons (NOT expected, also different behaviour from 22.05.x where it only shows suggestions from anonymous users). Logged in user -------------- Login as a patron and go to Your account > Purchase suggestions - purchase suggestions DON'T show correctly: - OPACViewOthersSuggestions set to "Don't show" - can only see your own suggestions (as expected) - OPACViewOthersSuggestions set to "Show" - after the search for the input field there is a dropdown list with options to show suggestions "Suggested by me" and "Suggested by anyone", correctly shows your own suggestions, but when you select "Suggested by anyone" and press 'Go' it DOESN'T show suggestions made by others (NOT expected, different behaviour from 22.05.x where it works as expected) -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20207 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=32183 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20207 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Severity|enhancement |normal -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20207 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia@bugs.koha-communit |katrin.fischer@bsz-bw.de |y.org | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20207 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Anonymous Purchase |Anonymous suggestions show |Suggestions show on OPAC |in OPAC even when |even when |OPACViewOthersSuggestions |OPACViewOthersSuggestions |is set to 'Don't show' |is set to Don't Show | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20207 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords| |regression -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20207 --- Comment #7 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- 2 things here (for the future): * When fixing a bug, make sure it's marked as such (bugzilla defaults to enhancement). This can influence how fast things are looked at, if they are pushed to stable vesions etc. * The bug title should describe the problem, the commit message/subject shoudl describe the fix. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20207 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA Patch complexity|--- |Small patch -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20207 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #143798|0 |1 is obsolete| | --- Comment #8 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 143811 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=143811&action=edit Bug 20207: Don't show anyones's suggestions when OPACViewOthersSuggestions is deactivated When you enable AnonSuggestions and ALLOW patrons that aren't logged in to make purchase suggestions, once a suggestion has successfully been submitted, anonymous purchase suggestions will show on OPAC even when system preference OPACViewOthersSuggestions, is set to Don't show. The suggestions will show on opac-suggestions.pl. However, if you search for the title you suggested, you will get a message saying "You are not authorized to see pending purchase suggestions." This patch fixes the error, ie if OPACViewOthersSuggestions is set to false not other suggestions are shown (if you are not logged in and AnonSuggestions) OR ONLY your own suggestions if you are logged in To test: 1) activate AnonSuggestions 2) create an anon suggestion 3) create a suggestion with a logged in user 4) toggle OPACViewOthersSuggestions Show/Don't show 5) all suggestions are shown cgi-bin/koha/opac-suggestions.pl in either case 6) apply patch 7) OPACViewOthersSuggestions is now respected ie suggestions from other users are only shown if activated 8) Please sign off Sponsored-by: Library of the Natural History Museum Vienna Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20207 --- Comment #9 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 143812 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=143812&action=edit Bug 20207: Don't show search options when no suggestions show When you are not logged in and OPACViewOthersSuggestions is deactivated, you don't see any suggestions. When we see no suggestions, we should also not show the option to serach in suggestions. To test: * as a logged in user and logged out, try various combinations of: * OPACViewOthersSuggestions * AnonSuggestions * Verify display matches expectations (new button, shown suggestions, search input) Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20207 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords| |rel_22_11_candidate --- Comment #10 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- No string changes. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20207 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |22.11.00 released in| | Status|Passed QA |Pushed to master -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20207 --- Comment #11 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Pushed to master for 22.11. Nice work everyone, thanks! -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org