[Bug 26943] New: Show not for loan descriptions in cataloging search (addbooks.pl)
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26943 Bug ID: 26943 Summary: Show not for loan descriptions in cataloging search (addbooks.pl) Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Cataloging Assignee: koha-bugs@lists.koha-community.org Reporter: andrew@bywatersolutions.com QA Contact: testopia@bugs.koha-community.org CC: m.de.rooy@rijksmuseum.nl To recreate: - create a positive value and a description of "Positive" - set an item to your "Positive" value - pull up the related bib in a cataloging search - confirm it shows "Not for loan" in the Location column - create a negative value and a description of "Negative" - set an item to your "Negative" value - pull up the related bib in a cataloging search - confirm it shows "On order" in the Location column We should show the actual display values here, rather than collapsing all positive values into "not for loan" and all negative values into "on order." -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26943 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26943 --- Comment #1 from Lucas Gass <lucas@bywatersolutions.com> --- Created attachment 113429 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=113429&action=edit Bug 26943: Add notforloan statuses to catalog search - create a positive value and a description of "Positive" - set an item to your "Positive" value - pull up the related bib in a cataloging search - confirm it shows "Not for loan" in the Location column - create a negative value and a description of "Negative" - set an item to your "Negative" value - pull up the related bib in a cataloging search - confirm it shows "On order" in the Location column - Apply patch - re-do the cataloing search, instead of 'Not for loan' or 'On order' you should instead see the actual nfl description -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26943 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |lucas@bywatersolutions.com Assignee|koha-bugs@lists.koha-commun |lucas@bywatersolutions.com |ity.org | -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26943 Michal Denar <black23@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |black23@gmail.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26943 Andrew Fuerste-Henry <andrew@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26943 Andrew Fuerste-Henry <andrew@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #113429|0 |1 is obsolete| | --- Comment #2 from Andrew Fuerste-Henry <andrew@bywatersolutions.com> --- Created attachment 114105 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=114105&action=edit Bug 26943: Add notforloan statuses to catalog search - create a positive value and a description of "Positive" - set an item to your "Positive" value - pull up the related bib in a cataloging search - confirm it shows "Not for loan" in the Location column - create a negative value and a description of "Negative" - set an item to your "Negative" value - pull up the related bib in a cataloging search - confirm it shows "On order" in the Location column - Apply patch - re-do the cataloing search, instead of 'Not for loan' or 'On order' you should instead see the actual nfl description Signed-off-by: Andrew Fuerste-Henry <andrew@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26943 Julian Maurice <julian.maurice@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Severity|normal |enhancement CC| |julian.maurice@biblibre.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26943 Andrew Fuerste-Henry <andrew@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #114105|0 |1 is obsolete| | --- Comment #3 from Andrew Fuerste-Henry <andrew@bywatersolutions.com> --- Created attachment 115183 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=115183&action=edit Bug 26943: Add notforloan statuses to catalog search - create a positive value and a description of "Positive" - set an item to your "Positive" value - pull up the related bib in a cataloging search - confirm it shows "Not for loan" in the Location column - create a negative value and a description of "Negative" - set an item to your "Negative" value - pull up the related bib in a cataloging search - confirm it shows "On order" in the Location column - Apply patch - re-do the cataloing search, instead of 'Not for loan' or 'On order' you should instead see the actual nfl description Signed-off-by: Andrew Fuerste-Henry <andrew@bywatersolutions.com> Signed-off-by: Telishia Mickens <tmickens@gc.edu> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26943 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA --- Comment #4 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Hi Lucas, a little glitch here: Before every status was on a new line (display:block), now it's inside a new span with a different class, this no longer works and all the status appear on one line which can make the column cell go wide pretty fast. Can you please fix? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26943 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26943 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #115183|0 |1 is obsolete| | --- Comment #5 from Lucas Gass <lucas@bywatersolutions.com> --- Created attachment 115376 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=115376&action=edit Bug 26943: Add notforloan statuses to catalog search - create a positive value and a description of "Positive" - set an item to your "Positive" value - pull up the related bib in a cataloging search - confirm it shows "Not for loan" in the Location column - create a negative value and a description of "Negative" - set an item to your "Negative" value - pull up the related bib in a cataloging search - confirm it shows "On order" in the Location column - Apply patch - re-do the cataloing search, instead of 'Not for loan' or 'On order' you should instead see the actual nfl description Signed-off-by: Andrew Fuerste-Henry <andrew@bywatersolutions.com> Signed-off-by: Telishia Mickens <tmickens@gc.edu> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26943 --- Comment #6 from Lucas Gass <lucas@bywatersolutions.com> --- Cait, I see what you mean, to fix it I have simply done same thing as the unavailable right above the notforloan one, I added a <br />. Since its a little change I am keeping Andrew and Telishia's SO lines. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26943 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Text to go in the| |Adds the ability to see not release notes| |for loan descriptions in | |the cataloging search | |results. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26943 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Small patch Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26943 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #115376|0 |1 is obsolete| | --- Comment #7 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 116474 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=116474&action=edit Bug 26943: Add notforloan statuses to catalog search - create a positive value and a description of "Positive" - set an item to your "Positive" value - pull up the related bib in a cataloging search - confirm it shows "Not for loan" in the Location column - create a negative value and a description of "Negative" - set an item to your "Negative" value - pull up the related bib in a cataloging search - confirm it shows "On order" in the Location column - Apply patch - re-do the cataloing search, instead of 'Not for loan' or 'On order' you should instead see the actual nfl description Signed-off-by: Andrew Fuerste-Henry <andrew@bywatersolutions.com> Signed-off-by: Telishia Mickens <tmickens@gc.edu> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26943 --- Comment #8 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Thx, Lucas, sorry it took me a while to get back to this. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26943 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart@bugs.koha-c | |ommunity.org --- Comment #9 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- We are "loosing" 2 wordings that are no longer translatable, but I think it's fine. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26943 --- Comment #10 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- (In reply to Jonathan Druart from comment #9)
We are "loosing" 2 wordings that are no longer translatable, but I think it's fine.
We already do this in the normal serach result lists... so I guess it's consistent. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26943 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to master Version(s)| |21.05.00 released in| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26943 --- Comment #11 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Pushed to master for 21.05, thanks to everybody involved! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26943 Caroline Cyr La Rose <caroline.cyr-la-rose@inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |caroline.cyr-la-rose@inlibr | |o.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26943 Fridolin Somers <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |fridolin.somers@biblibre.co | |m Version(s)|21.05.00 |21.05.00,20.11.03 released in| | Status|Pushed to master |Pushed to stable --- Comment #12 from Fridolin Somers <fridolin.somers@biblibre.com> --- Small enhancement, I choose to backport. Pushed to 20.11.x for 20.11.03 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26943 Andrew Fuerste-Henry <andrew@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to stable |Pushed to oldstable Version(s)|21.05.00,20.11.03 |21.05.00,20.11.03,20.05.09 released in| | --- Comment #13 from Andrew Fuerste-Henry <andrew@bywatersolutions.com> --- Pushed to 20.05.x for 20.05.09 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26943 Victor Grousset/tuxayo <victor@tuxayo.net> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to oldstable |RESOLVED Resolution|--- |FIXED CC| |victor@tuxayo.net --- Comment #14 from Victor Grousset/tuxayo <victor@tuxayo.net> --- Not backported to oldoldstable (19.11.x). Feel free to ask if it's needed. -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org