https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27655 --- Comment #1 from Peter Vashchuk <stalkernoid@gmail.com> --- Created attachment 116501 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=116501&action=edit Bug 27655: Add barcode "columnname" to "column_settings.yml" Preferences of the "Holds to pull" table missing the "Barcode" column. This patch appends that column name to the "column_settings.yml" in correct order. This also led to checked out columns in this settings page that were not those which were hidden when the table displayed (i.e. columns were shifted). To reproduce: 1) Head over to /cgi-bin/koha/admin/columns_settings.pl 2) Open the collapsed "Circulation" list, go to the "Holds" page and find preferences of the "Holds to pull" table there. 3) Check that the "Barcodes" column is missing from it. 4) Mark the last few columns for not to be displayed (for example, three) and save the preferences. Remember the column names you checked out. 5) Open the circulations section, then open "Holds to pull" report when you have there some elements displayed, you should notice that hidden columns shifted by one, as well if you press "gear" icon to quickly enable/disable the columns, you will see those unchecked in list last three will be not those you marked out. 6) Apply the patch. 7) Reload the "table settings" page, check that the "Barcodes" column is present. 8) Check that on the "Circulation -> Holds to Pull" page all columns hidden accordingly and properly (as explained in step 5. -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27655 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #116501|0 |1 is obsolete| | --- Comment #2 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 116527 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=116527&action=edit Bug 27655: Add barcode "columnname" to "column_settings.yml" Preferences of the "Holds to pull" table missing the "Barcode" column. This patch appends that column name to the "column_settings.yml" in correct order. This also led to checked out columns in this settings page that were not those which were hidden when the table displayed (i.e. columns were shifted). To reproduce: 1) Head over to /cgi-bin/koha/admin/columns_settings.pl 2) Open the collapsed "Circulation" list, go to the "Holds" page and find preferences of the "Holds to pull" table there. 3) Check that the "Barcodes" column is missing from it. 4) Mark the last few columns for not to be displayed (for example, three) and save the preferences. Remember the column names you checked out. 5) Open the circulations section, then open "Holds to pull" report when you have there some elements displayed, you should notice that hidden columns shifted by one, as well if you press "gear" icon to quickly enable/disable the columns, you will see those unchecked in list last three will be not those you marked out. 6) Apply the patch. 7) Reload the "table settings" page, check that the "Barcodes" column is present. 8) Check that on the "Circulation -> Holds to Pull" page all columns hidden accordingly and properly (as explained in step 5. Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27655 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Barcode column is missing |Barcode column is missing |from "Holds to pull" table |from "Holds to pull" table |preferences yaml file. |preferences yaml file -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27655 --- Comment #4 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Pushed to master for 21.05, thanks to everybody involved! -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27655 Fridolin Somers <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |fridolin.somers@biblibre.co | |m Depends on| |23485 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23485 [Bug 23485] Holds to pull (pendingreserves.pl) should list barcodes -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27655 Fridolin Somers <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to master |Pushed to stable Version(s)|21.05.00 |21.05.00,20.11.03 released in| | --- Comment #6 from Fridolin Somers <fridolin.somers@biblibre.com> --- Pushed to 20.11.x for 20.11.03 -- You are receiving this mail because: You are watching all bug changes.