[Bug 15687] New: Syntax errors in misc/translator/xgettext.pl
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15687 Bug ID: 15687 Summary: Syntax errors in misc/translator/xgettext.pl Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: ASSIGNED Severity: major Priority: P5 - low Component: Architecture, internals, and plumbing Assignee: julian.maurice@biblibre.com Reporter: julian.maurice@biblibre.com QA Contact: testopia@bugs.koha-community.org Depends on: 6679 It seems that Bug 6679 broke xgettext.pl To reproduce: 1. cd misc/translator 2. perl -cw xgettext.pl Errors: Use of ?PATTERN? without explicit operator is deprecated at xgettext.pl line 51. Number found where operator expected at xgettext.pl line 52, near "$t == C4::TmplTokenType::DIRECTIVE? 1" (Might be a runaway multi-line ?? string starting on line 51) (Missing operator before 1?) "my" variable $t masks earlier declaration in same scope at xgettext.pl line 54. Use of my $_ is experimental at xgettext.pl line 54. "my" variable $t masks earlier declaration in same statement at xgettext.pl line 55. Use of ?PATTERN? without explicit operator is deprecated at xgettext.pl line 55. "my" variable $t masks earlier declaration in same statement at xgettext.pl line 56. String found where operator expected at xgettext.pl line 57, near "''" (Missing semicolon on previous line?) syntax error at xgettext.pl line 52, near "$t == C4::TmplTokenType::DIRECTIVE? 1" syntax error at xgettext.pl line 57, near "''" Global symbol "$x" requires explicit package name at xgettext.pl line 58. syntax error at xgettext.pl line 58, near "} ) " Can't use global @_ in "my" at xgettext.pl line 64, near "= @_" Global symbol "$string" requires explicit package name at xgettext.pl line 66. Global symbol "$token" requires explicit package name at xgettext.pl line 66. Global symbol "$string" requires explicit package name at xgettext.pl line 67. Global symbol "$token" requires explicit package name at xgettext.pl line 69. syntax error at xgettext.pl line 71, near "}" xgettext.pl has too many errors. Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6679 [Bug 6679] Fixing code so it passes basic Perl::Critic tests -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15687 --- Comment #1 from Julian Maurice <julian.maurice@biblibre.com> --- Created attachment 47370 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=47370&action=edit Bug 15687: Fix xgettext.pl syntax errors -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15687 Julian Maurice <julian.maurice@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15687 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart@bugs.koha-c | |ommunity.org --- Comment #2 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- the translate script is broken as well % ./translate update fr-FR -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15687 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Severity|major |critical CC| |kyle@bywatersolutions.com --- Comment #3 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Julian, there are some other occurrences in xgettext.pl which certainly need to be fixed. I think that the easiest way is to revert the original patch. Upgrading to critical. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15687 --- Comment #4 from Julian Maurice <julian.maurice@biblibre.com> --- (In reply to Jonathan Druart from comment #3)
Julian, there are some other occurrences in xgettext.pl which certainly need to be fixed.
I think that the easiest way is to revert the original patch.
With the patch, - perl -cw xgettext.pl is OK - ./translate update fr-FR works fine too Why do you think the revert is needed ? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15687 --- Comment #5 from Julian Maurice <julian.maurice@biblibre.com> --- s/needed/easiest/ -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15687 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15687 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #47370|0 |1 is obsolete| | --- Comment #6 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 47381 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=47381&action=edit Bug 15687: Fix xgettext.pl syntax errors Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15687 --- Comment #7 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- (In reply to Julian Maurice from comment #4)
(In reply to Jonathan Druart from comment #3)
Julian, there are some other occurrences in xgettext.pl which certainly need to be fixed.
I think that the easiest way is to revert the original patch.
With the patch, - perl -cw xgettext.pl is OK - ./translate update fr-FR works fine too
Why do you think the revert is needed ?
Indeed, sorry. Everything is fine with the patch applied. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15687 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15687 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #47381|0 |1 is obsolete| | --- Comment #8 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 47461 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=47461&action=edit Bug 15687: Fix xgettext.pl syntax errors Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15687 --- Comment #9 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 47462 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=47462&action=edit Bug 15687 [QA Followup] - Tidy sub to remove tab characters Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15687 Brendan Gallagher <brendan@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |brendan@bywatersolutions.co | |m Status|Passed QA |Pushed to Master --- Comment #10 from Brendan Gallagher <brendan@bywatersolutions.com> --- Pushed to Master - Should be in the May 2016 release. Thanks! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15687 Julian Maurice <julian.maurice@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |Pushed to Stable --- Comment #11 from Julian Maurice <julian.maurice@biblibre.com> --- Patches pushed to 3.22.x, will be in 3.22.3 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15687 Frédéric Demians <frederic@tamil.fr> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |frederic@tamil.fr --- Comment #12 from Frédéric Demians <frederic@tamil.fr> --- Patches pushed to 3.20.x, will be in 3.20.9. -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org