https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15687 Bug ID: 15687 Summary: Syntax errors in misc/translator/xgettext.pl Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: ASSIGNED Severity: major Priority: P5 - low Component: Architecture, internals, and plumbing Assignee: julian.maurice@biblibre.com Reporter: julian.maurice@biblibre.com QA Contact: testopia@bugs.koha-community.org Depends on: 6679 It seems that Bug 6679 broke xgettext.pl To reproduce: 1. cd misc/translator 2. perl -cw xgettext.pl Errors: Use of ?PATTERN? without explicit operator is deprecated at xgettext.pl line 51. Number found where operator expected at xgettext.pl line 52, near "$t == C4::TmplTokenType::DIRECTIVE? 1" (Might be a runaway multi-line ?? string starting on line 51) (Missing operator before 1?) "my" variable $t masks earlier declaration in same scope at xgettext.pl line 54. Use of my $_ is experimental at xgettext.pl line 54. "my" variable $t masks earlier declaration in same statement at xgettext.pl line 55. Use of ?PATTERN? without explicit operator is deprecated at xgettext.pl line 55. "my" variable $t masks earlier declaration in same statement at xgettext.pl line 56. String found where operator expected at xgettext.pl line 57, near "''" (Missing semicolon on previous line?) syntax error at xgettext.pl line 52, near "$t == C4::TmplTokenType::DIRECTIVE? 1" syntax error at xgettext.pl line 57, near "''" Global symbol "$x" requires explicit package name at xgettext.pl line 58. syntax error at xgettext.pl line 58, near "} ) " Can't use global @_ in "my" at xgettext.pl line 64, near "= @_" Global symbol "$string" requires explicit package name at xgettext.pl line 66. Global symbol "$token" requires explicit package name at xgettext.pl line 66. Global symbol "$string" requires explicit package name at xgettext.pl line 67. Global symbol "$token" requires explicit package name at xgettext.pl line 69. syntax error at xgettext.pl line 71, near "}" xgettext.pl has too many errors. Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6679 [Bug 6679] Fixing code so it passes basic Perl::Critic tests -- You are receiving this mail because: You are watching all bug changes.