[Bug 32409] New: Cannot search cashups using non-latin-1 scripts
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32409 Bug ID: 32409 Summary: Cannot search cashups using non-latin-1 scripts Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: REST API Assignee: koha-bugs@lists.koha-community.org Reporter: tomascohen@gmail.com CC: tomascohen@gmail.com Same as bug 32406, but on cash register cashups. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32409 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs@lists.koha-commun |tomascohen@gmail.com |ity.org | Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32409 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32409 --- Comment #1 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Created attachment 144449 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=144449&action=edit Bug 32409: Fix cashup searching with non latin-1 chars This patch fixes a problem with the way queries are passed to the API so cashups are searchable with non-laint1 chars. To test: 1. Have two superlibrarian users, one with non-latin1 chars on the name (e.g. خمسة) 2. Setup a debit type that can be sold. 3. Use the POS module to have some activity, using both your regular user and the other one. 4. Go to the register you used, and choose 'Transaction history' 5. Perform a couple cashups with each user ('Record cashup'). 6. Look at the 'Cashup history' table => SUCCESS: You see cashups for both users 7. Use the 'Search' filter with latin chars => SUCCESS: Your user with only latin1 chars is displayed on the table 8. Repeat, using some non-latin1 char found on the other user => FAIL: Table is not refreshed or filtered! 9. Apply this patch 10. Reload the page 11. Repeat 8 => SUCCESS: Filtering works now! 12. Sign off :-D Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32409 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=32406 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32409 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=32401 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32409 David Cook <dcook@prosentient.com.au> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |dcook@prosentient.com.au -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32409 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32409 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #144449|0 |1 is obsolete| | --- Comment #2 from David Nind <david@davidnind.com> --- Created attachment 144461 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=144461&action=edit Bug 32409: Fix cashup searching with non latin-1 chars This patch fixes a problem with the way queries are passed to the API so cashups are searchable with non-laint1 chars. To test: 1. Have two superlibrarian users, one with non-latin1 chars on the name (e.g. خمسة) 2. Setup a debit type that can be sold. 3. Use the POS module to have some activity, using both your regular user and the other one. 4. Go to the register you used, and choose 'Transaction history' 5. Perform a couple cashups with each user ('Record cashup'). 6. Look at the 'Cashup history' table => SUCCESS: You see cashups for both users 7. Use the 'Search' filter with latin chars => SUCCESS: Your user with only latin1 chars is displayed on the table 8. Repeat, using some non-latin1 char found on the other user => FAIL: Table is not refreshed or filtered! 9. Apply this patch 10. Reload the page 11. Repeat 8 => SUCCESS: Filtering works now! 12. Sign off :-D Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32409 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |david@davidnind.com Text to go in the| |This fixes the cashup release notes| |history table so that | |filters can use non latin-1 | |characters (Point of sale > | |Cash summary for <library> | |> select register). Before | |this fix, the table was not | |filtered or refreshed if | |you entered non latin-1 | |characters. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32409 --- Comment #3 from David Cook <dcook@prosentient.com.au> --- I would like to QA this one, but the instructions in the test plan aren't detailed enough. I can't get to "Transaction history" or "Cashup history". Leaving this for someone else to do unless a new test plan is added. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32409 David Cook <dcook@prosentient.com.au> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |32401 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32401 [Bug 32401] x-koha-query cannot contain non-ISO-8859-1 values -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32409 David Cook <dcook@prosentient.com.au> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks|32401 | Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32401 [Bug 32401] x-koha-query cannot contain non-ISO-8859-1 values -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32409 --- Comment #4 from David Nind <david@davidnind.com> --- (In reply to David Cook from comment #3)
I would like to QA this one, but the instructions in the test plan aren't detailed enough. I can't get to "Transaction history" or "Cashup history".
Leaving this for someone else to do unless a new test plan is added.
Some notes on setting up for testing: 1. Enable the UseCashRegisters system preference. 2. Enabled the EnablePointOfSale system preference. 3. Create a cash register for Centerville (Administration > New cash register > call it CASH). 4. Add some debit types for some products from Administration > Accounting > Debit types > New debit type (change the code, description, and amount to add multiple debit types): - Debit type code: PRODUCT1 - Default amount: 10.00 - Description: Description for product 1 - Can be manually invoiced? Selected - Can be sold?: Selected 5. Add some POS transactions using the koha user from Home > Point of sale 6. Select 'Transaction history for CASH' from the menu on the left. 7. Select the 'Record cashup' from the option at the top. 6. Repeat steps 5-7 as the other staff user created in step 1 of the test plan. 7. For step 6 of the test plan, select 'Transaction history for CASH' from the menu on the left. 8. Scroll down to the bottom of the page - you should see a heading with "Cashup history". Then the rest of the test plan. Hope this helps! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32409 Jonathan Druart <jonathan.druart+koha@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |32401 See Also|https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=32401 | Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32401 [Bug 32401] x-koha-query cannot contain non-ISO-8859-1 values -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32409 Jonathan Druart <jonathan.druart+koha@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32409 Jonathan Druart <jonathan.druart+koha@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #144461|0 |1 is obsolete| | --- Comment #5 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- Created attachment 145925 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=145925&action=edit Bug 32409: Fix cashup searching with non latin-1 chars This patch fixes a problem with the way queries are passed to the API so cashups are searchable with non-laint1 chars. To test: 1. Have two superlibrarian users, one with non-latin1 chars on the name (e.g. خمسة) 2. Setup a debit type that can be sold. 3. Use the POS module to have some activity, using both your regular user and the other one. 4. Go to the register you used, and choose 'Transaction history' 5. Perform a couple cashups with each user ('Record cashup'). 6. Look at the 'Cashup history' table => SUCCESS: You see cashups for both users 7. Use the 'Search' filter with latin chars => SUCCESS: Your user with only latin1 chars is displayed on the table 8. Repeat, using some non-latin1 char found on the other user => FAIL: Table is not refreshed or filtered! 9. Apply this patch 10. Reload the page 11. Repeat 8 => SUCCESS: Filtering works now! 12. Sign off :-D Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32409 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |23.05.00 released in| | Status|Passed QA |Pushed to master -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32409 --- Comment #6 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Pushed to master for 23.05. Nice work everyone, thanks! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32409 Jacob O'Mara <jacob.omara@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to master |Pushed to stable Version(s)|23.05.00 |23.05.00,22.11.03 released in| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32409 --- Comment #7 from Jacob O'Mara <jacob.omara@ptfs-europe.com> --- Nice work, thanks everyone! Pushed to 22.11.x for the next release. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32409 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to stable |Pushed to oldstable Version(s)|23.05.00,22.11.03 |23.05.00,22.11.03,22.05.10 released in| | CC| |lucas@bywatersolutions.com --- Comment #8 from Lucas Gass <lucas@bywatersolutions.com> --- Backported to 22.05.x for upcoming 22.05.10 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32409 Arthur Suzuki <arthur.suzuki@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)|23.05.00,22.11.03,22.05.10 |23.05.00,22.11.03,22.05.10, released in| |21.11.16 CC| |arthur.suzuki@biblibre.com Status|Pushed to oldstable |Pushed to oldoldstable --- Comment #9 from Arthur Suzuki <arthur.suzuki@biblibre.com> --- applied to 21.11.x for 21.11.16 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32409 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |martin.renvoize@ptfs-europe | |.com Severity|enhancement |normal -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32409 wainuiwitikapark@catalyst.net.nz changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |wainuiwitikapark@catalyst.n | |et.nz --- Comment #10 from wainuiwitikapark@catalyst.net.nz --- Not backported to 21.05.x -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org