https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32406 David Cook <dcook@prosentient.com.au> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs@lists.koha-commun |dcook@prosentient.com.au |ity.org | --- Comment #1 from David Cook <dcook@prosentient.com.au> --- The solution to this problem is to use the "q" parameter instead of the "x-koha-query" header. While the "q" parameter runs the risk of creating too long of a URL, it is more functional than the "x-koha-query" header. Really we should be doing POSTs to the REST API when using DataTables, but the "good enough" fix here is to just change "header_filter" from "true" to "false" in koha-tmpl/intranet-tmpl/prog/en/modules/acqui/parcel.tt -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32406 --- Comment #2 from David Cook <dcook@prosentient.com.au> --- Created attachment 144432 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=144432&action=edit Bug 32406: Switch acq datatable from headers to query param This patch changes the pending orders datatable from using the x-koha-query header to the "q" query parameter, so that it is able to support UTF-8 encoded scripts rather than just Latin-1 scripts. Test plan: 1. Apply patch 2. Go to http://localhost:8081/cgi-bin/koha/cataloguing/addbiblio.pl?biblionumber=29 3. Change title from "Gairm" to "五" (alternatively use "cœur" or Arabic title) 4. Create a basket containing multiple records including bib 29 五 5. Close the basket 6. Receive shipment 7. You should be on a page like the following: http://localhost:8081/cgi-bin/koha/acqui/parcel.pl?invoiceid=3 8. In the search box, type in 五 9. Note that you see a "Processing..." box and then the results are filtered to just show the order for 五 -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32406 David Cook <dcook@prosentient.com.au> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |30165 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30165 [Bug 30165] Several q parameters break the filters -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32406 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32406 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |tomascohen@gmail.com See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=32409 -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32406 --- Comment #6 from David Cook <dcook@prosentient.com.au> --- (In reply to Marcel de Rooy from comment #5)

Just posted a comment on 32401 about encoding header. This is a move from header to URL parameter. Could we have a privacy issue with exposing search terms like that, since URLs are much more visible? Log files, etc.

For bug 32406, I wouldn't worry about it, because it's order data. It's unlikely to be sensitive. But it's an interesting point. In master, the search is already put in the "q" parameter for http://localhost:8081/cgi-bin/koha/members/member.pl I suppose things like email addresses, phone numbers, usernames, etc could potentially be passed through that and wind up in logs. It wouldn't necessarily be that coherent though. But I think it would be fair to argue that searches should be POSTs. Of course, that gets complicated in terms of a RESTful interface. I think one could consider the "search" to be the resource though, so POSTing to create a search makes sense. Bit of a philosophical-technical discussion to have there I think. -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32406 David Cook <dcook@prosentient.com.au> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |32401 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32401 [Bug 32401] x-koha-query cannot contain non-ISO-8859-1 values -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32406 Jonathan Druart <jonathan.druart+koha@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |32401 See Also|https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=32401 | Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32401 [Bug 32401] x-koha-query cannot contain non-ISO-8859-1 values -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32406 Jonathan Druart <jonathan.druart+koha@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #144446|0 |1 is obsolete| | --- Comment #8 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- Created attachment 145924 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=145924&action=edit Bug 32406: Switch acq datatable from headers to query param This patch changes the pending orders datatable from using the x-koha-query header to the "q" query parameter, so that it is able to support UTF-8 encoded scripts rather than just Latin-1 scripts. Test plan: 1. Apply patch 2. Go to http://localhost:8081/cgi-bin/koha/cataloguing/addbiblio.pl?biblionumber=29 3. Change title from "Gairm" to "五" (alternatively use "cœur" or Arabic title) 4. Create a basket containing multiple records including bib 29 五 5. Close the basket 6. Receive shipment 7. You should be on a page like the following: http://localhost:8081/cgi-bin/koha/acqui/parcel.pl?invoiceid=3 8. In the search box, type in 五 9. Note that you see a "Processing..." box and then the results are filtered to just show the order for 五 Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> tcohen amend: removed the line instead as we are probably phasing out that DT configuration option anyway. Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32406 --- Comment #9 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Pushed to master for 23.05. Nice work everyone, thanks! -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32406 --- Comment #10 from Jacob O'Mara <jacob.omara@ptfs-europe.com> --- Nice work, thanks everyone! Pushed to 22.11.x for the next release. -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32406 Arthur Suzuki <arthur.suzuki@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)|23.05.00,22.11.03,22.05.10 |23.05.00,22.11.03,22.05.10, released in| |21.11.16 Status|Pushed to oldstable |Pushed to oldoldstable CC| |arthur.suzuki@biblibre.com --- Comment #12 from Arthur Suzuki <arthur.suzuki@biblibre.com> --- applied to 21.11.x for 21.11.16 -- You are receiving this mail because: You are watching all bug changes.