https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26258 --- Comment #1 from Christopher Brannon <cbrannon@cdalibrary.org> --- And club counts should not be in parenthesis. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26258 George Williams (NEKLS) <george@nekls.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |george@nekls.org --- Comment #3 from George Williams (NEKLS) <george@nekls.org> --- I agree. Consistency would be nice. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26258 --- Comment #5 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 108779 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=108779&action=edit Updated inconsistencies -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26258 --- Comment #7 from Owen Leonard <oleonard@myacpl.org> --- I think it's worth reconsidering whether claims and clubs really need to show the "inactive" count. Why should we need to know the number of clubs available? Why should we know how many inactive claims there are? -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26258 --- Comment #9 from Owen Leonard <oleonard@myacpl.org> --- We could have grammatically-correct labels using the techniques added by Bug 15395, and could unify the different labels by showing a count of only unresolved claims and only enrolled clubs. https://zivotdesign.com/p/#1/15980387474009 -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26258 --- Comment #11 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- I like it, especially the idea for making it work for singular/plural and getting rid of the (s). -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26258 --- Comment #13 from Christopher Brannon <cbrannon@cdalibrary.org> --- At least on our test server, the claims counts are displayed differently than the other counters. They are incorporating labels that the others do not. They are at least consistent now. I agree with Owen that I don't think it is necessary to know how many clubs are available, just how many they are signed up for. I could still go either way on having both numbers on the inactive claims. Maybe just have the number of claims, and if something needs attention, change the color? I think if we are going to move towards using labels, all the counters should be in labels, and we should do away with the parenthesis. It seems overkill. One or the other. Labels look better and provide more functionality. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26258 --- Comment #14 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 153679 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=153679&action=edit An idea for updated tab styles -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26258 --- Comment #16 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- (In reply to Owen Leonard from comment #14)

Created attachment 153679 [details] An idea for updated tab styles

+1 -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26258 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26258 --- Comment #19 from Christopher Brannon <cbrannon@cdalibrary.org> --- Exciting times. :) Open, I like your concept. I still think we should do away with the total number of clubs. It is arbitrary. Not all clubs apply to all patrons. It isn't really useful in this scenario. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26258 --- Comment #20 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 166147 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=166147&action=edit Bug 26258: Circulation tabs inconsistent with counters This patch makes changes to the markup, style, and behaviour of counters which are displayed on the patron's account tabs: Checkouts, Holds, etc. Tabs which contain a count which might change based on a user's actions will keep up to date, e.g. changing claims status, enrolling in clubs, etc. To test, apply the patch and enable features if necessary: recalls, article requests, claims, clubs, and patron lists. Test both from the checkout page and the patron detail page: Recalls: - If necessary, check out some items to patrons so that there are titles which can be recalled. - Log in to the OPAC and place one or more recalls. - Return to the staff interface and view the "Recalls" tab on the patron's account. - Click Actions -> Cancel for one of the recalls. The recall should be marked "Cancelled" and the count on the tab should update. Return claims: - If necessary, check out some items to a patron. Click the "Claim returned" button on a few of the patron's checkouts. - As you add claims, the "Claims" tab should update the count of claims. *** NOTE: This changes the display of claims in the tab so that the count of unresolved claims appears first: "Unresolved / Resolved". I think it makes more sense for the first number to be the one which shows the number of "active" issues. - Open the Claims tab. Click Actions->Resolve on one or more claims, confirming that the resolved claim is hidden and the tab numbers update. - Test setting the ClaimReturnedWarningThreshold system preference to various values: e.g. empty, 1, 5. - If the pref is empty, OR if the pref is set to a number higher than the number of patron claims, the count of claims should be styled with the "info" blue background and the count of resolved claims is not shown. *** NOTE: Hiding the resolved claims seems logical if there is not a concern about the total number of claims. - If the number of all claims exceeds the value of the preference, the tab should show a count of "Unresolved claims / Resolved claims" with the yellow warning style. Restrictions: - Adding a restriction to the account should cause a counter with a red background to appear on the tab. Clubs: - If necessary, create at least one club template and then multiple clubs. - From the "Clubs" tab on the patron's account, try enrolling and cancelling enrollments to confirm that the count on the tab updates correctly. *** NOTE: I have removed the count of available clubs because I think it's not relevant to this interface. We don't do it with patron lists, so this makes it a little more consistent.. Patron lists: - If necessary, create two ore more patron lists. - From the "Patron lists" tab, try adding and removing the patron from lists. The tab counter should update correctly. Sponsored-by: Athens County Public Libraries -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26258 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26258 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Text to go in the| |This enhancement changes release notes| |the markup, style, and | |behaviour of counters which | |are displayed on a patron's | |check out and details tabs: | |1. A new style: the counter | |background has a light blue | |square with rounded corners | |2. The claims tab: | | . The | |order of the counters is | |now Unresolved claims / | |Resolved claims | | . The | |background colour for the | |counter changes to orange | |when the value set in | |ClaimReturnedWarningThresho | |ld is reached | |3. The | |restrictions tab: the | |counter background color is | |red | |4. The clubs tab: now | |only shows the number of | |clubs a patron is enrolled | |in (the count of available | |clubs is removed) CC| |david@davidnind.com --- Comment #22 from David Nind <david@davidnind.com> --- I'll attach some before and after screenshots. My testing notes (using KTD): 1. Recalls - Enable system preference - Set some rules: . Recalls allowed (total): 5 . Recalls per record (count): 5 . On shelf recalls allowed: Recall due date interval (day) . Recall overdue fine amount: 5 . Recall pickup period (day): 5 - Checkout some items to Patron A - Log in as Patron B (set username/password by editing the patron details) - Make a recall for Patron B for one of the items checked out by Patron A 2. Returns claimed: - Select a value for ClaimReturnedLostValue for the claim lost action button to appear under a patron's checkouts: I used Lost - Set a value for ClaimReturnedWarningThreshold: 2 - Check out some items to the patron - Make 3 claims - Resolve one claim: Claims tab > Actions > Resolve -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26258 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #166159|0 |1 is obsolete| | --- Comment #24 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 166239 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=166239&action=edit Bug 26258: Circulation tabs inconsistent with counters This patch makes changes to the markup, style, and behaviour of counters which are displayed on the patron's account tabs: Checkouts, Holds, etc. Tabs which contain a count which might change based on a user's actions will keep up to date, e.g. changing claims status, enrolling in clubs, etc. To test, apply the patch and enable features if necessary: recalls, article requests, claims, clubs, and patron lists. Test both from the checkout page and the patron detail page: Recalls: - If necessary, check out some items to patrons so that there are titles which can be recalled. - Log in to the OPAC and place one or more recalls. - Return to the staff interface and view the "Recalls" tab on the patron's account. - Click Actions -> Cancel for one of the recalls. The recall should be marked "Cancelled" and the count on the tab should update. Return claims: - If necessary, check out some items to a patron. Click the "Claim returned" button on a few of the patron's checkouts. - As you add claims, the "Claims" tab should update the count of claims. *** NOTE: This changes the display of claims in the tab so that the count of unresolved claims appears first: "Unresolved / Resolved". I think it makes more sense for the first number to be the one which shows the number of "active" issues. - Open the Claims tab. Click Actions->Resolve on one or more claims, confirming that the resolved claim is hidden and the tab numbers update. - Test setting the ClaimReturnedWarningThreshold system preference to various values: e.g. empty, 1, 5. - If the pref is empty, OR if the pref is set to a number higher than the number of patron claims, the count of claims should be styled with the "info" blue background and the count of resolved claims is not shown. *** NOTE: Hiding the resolved claims seems logical if there is not a concern about the total number of claims. - If the number of all claims exceeds the value of the preference, the tab should show a count of "Unresolved claims / Resolved claims" with the yellow warning style. Restrictions: - Adding a restriction to the account should cause a counter with a red background to appear on the tab. Clubs: - If necessary, create at least one club template and then multiple clubs. - From the "Clubs" tab on the patron's account, try enrolling and cancelling enrollments to confirm that the count on the tab updates correctly. *** NOTE: I have removed the count of available clubs because I think it's not relevant to this interface. We don't do it with patron lists, so this makes it a little more consistent.. Patron lists: - If necessary, create two ore more patron lists. - From the "Patron lists" tab, try adding and removing the patron from lists. The tab counter should update correctly. Sponsored-by: Athens County Public Libraries Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26258 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Failed QA --- Comment #25 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- I am not completely sure about the color choice in combination with the dark green of the tabs. But I also see something "blue" on the restrictions and patron list tabs that I am not sure about (screenshot in Mattermost). Can you please have a look? -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26258 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Failed QA --- Comment #26 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- I am sorry, I still get the little blue boxes :( More so, I pushed another patron accounts tab: bug 33737 - Add bookings to patron details - could you please include a follow-up for it? -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26258 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |ASSIGNED --- Comment #27 from Owen Leonard <oleonard@myacpl.org> --- Okay, going off the information that Katrin is using Firefox 115 ESR I realized that my patch uses some CSS which isn't widely-supported enough to work for us yet. The :has pseudo class only arrived in Firefox as of v121. Using a combination of :has and :empty let me simplify the template logic a lot but I can try to do it the hard way. -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26258 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |24097 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24097 [Bug 24097] Don't show claims tab in patron account, when there are no claims -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26258 --- Comment #29 from Martin Renvoize (ashimema) <martin.renvoize@openfifth.co.uk> --- Hmm, shame this seemed to get stuck -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26258 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #166239|0 |1 is obsolete| | --- Comment #30 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 184453 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=184453&action=edit Bug 26258: Circulation tabs inconsistent with counters This patch makes changes to the markup, style, and behaviour of counters which are displayed on the patron's account tabs: Checkouts, Holds, etc. This is a simplified patch compared to previous versions in order to try to get this moving foward. The patch no longer includes added code to keep tab counts up to date as, for instance, claims are added or removed. To test, apply the patch and rebuild the staff interface CSS. - Enable features if necessary: recalls, article requests, claims, clubs, and patron lists. Test both from the checkout page and the patron detail page. Recalls: - If necessary, check out some items to patrons so that there are titles which can be recalled. - Log in to the OPAC and place one or more recalls. - Return to the staff interface and view the "Recalls" tab on the patron's account. Return claims: - If necessary, check out some items to a patron. Click the "Claim returned" button on a few of the patron's checkouts. - As you add claims, the "Claims" tab should update the count of claims. *** NOTE: This changes the display of claims in the tab so that the count of unresolved claims appears first: "Unresolved / Resolved". I think it makes more sense for the first number to be the one which shows the number of "active" issues. - Test setting the ClaimReturnedWarningThreshold system preference to various values: e.g. empty, 1, 5. - If the pref is empty, OR if the pref is set to a number higher than the number of patron claims, the count of claims should be styled with the "info" blue background and the count of resolved claims is not shown. *** NOTE: Hiding the resolved claims seems logical if there is not a concern about the total number of claims. - If the number of all claims exceeds the value of the preference, the tab should show a count of "Unresolved claims / Resolved claims" with the yellow warning style. Restrictions: - Adding a restriction to the account should cause a counter with a red background to appear on the tab. Clubs: - If necessary, create at least one club template and then multiple clubs. - From the "Clubs" tab on the patron's account, try enrolling and cancelling enrollments to confirm that the count on the tab updates correctly. *** NOTE: I have removed the count of available clubs because I think it's not relevant to this interface. We don't do it with patron lists, so this makes it a little more consistent.. Patron lists: - If necessary, create two ore more patron lists. - From the "Patron lists" tab, try adding and removing the patron from lists. Sponsored-by: Athens County Public Libraries -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26258 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #184453|0 |1 is obsolete| | --- Comment #31 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 186269 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=186269&action=edit Bug 26258: Circulation tabs inconsistent with counters This patch makes changes to the markup, style, and behaviour of counters which are displayed on the patron's account tabs: Checkouts, Holds, etc. This is a simplified patch compared to previous versions in order to try to get this moving foward. The patch no longer includes added code to keep tab counts up to date as, for instance, claims are added or removed. To test, apply the patch and rebuild the staff interface CSS. - Enable features if necessary: recalls, article requests, claims, clubs, and patron lists. Test both from the checkout page and the patron detail page. Recalls: - If necessary, check out some items to patrons so that there are titles which can be recalled. - Log in to the OPAC and place one or more recalls. - Return to the staff interface and view the "Recalls" tab on the patron's account. Return claims: - If necessary, check out some items to a patron. Click the "Claim returned" button on a few of the patron's checkouts. - As you add claims, the "Claims" tab should update the count of claims. *** NOTE: This changes the display of claims in the tab so that the count of unresolved claims appears first: "Unresolved / Resolved". I think it makes more sense for the first number to be the one which shows the number of "active" issues. - Test setting the ClaimReturnedWarningThreshold system preference to various values: e.g. empty, 1, 5. - If the pref is empty, OR if the pref is set to a number higher than the number of patron claims, the count of claims should be styled with the "info" blue background and the count of resolved claims is not shown. *** NOTE: Hiding the resolved claims seems logical if there is not a concern about the total number of claims. - If the number of all claims exceeds the value of the preference, the tab should show a count of "Unresolved claims / Resolved claims" with the yellow warning style. Restrictions: - Adding a restriction to the account should cause a counter with a red background to appear on the tab. Clubs: - If necessary, create at least one club template and then multiple clubs. - From the "Clubs" tab on the patron's account, try enrolling and cancelling enrollments to confirm that the count on the tab updates correctly. *** NOTE: I have removed the count of available clubs because I think it's not relevant to this interface. We don't do it with patron lists, so this makes it a little more consistent.. Patron lists: - If necessary, create two ore more patron lists. - From the "Patron lists" tab, try adding and removing the patron from lists. Sponsored-by: Athens County Public Libraries -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26258 Martin Renvoize (ashimema) <martin.renvoize@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #188503|0 |1 is obsolete| | --- Comment #33 from Martin Renvoize (ashimema) <martin.renvoize@openfifth.co.uk> --- Created attachment 189541 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=189541&action=edit Bug 26258: Circulation tabs inconsistent with counters This patch makes changes to the markup, style, and behaviour of counters which are displayed on the patron's account tabs: Checkouts, Holds, etc. This is a simplified patch compared to previous versions in order to try to get this moving foward. The patch no longer includes added code to keep tab counts up to date as, for instance, claims are added or removed. To test, apply the patch and rebuild the staff interface CSS. - Enable features if necessary: recalls, article requests, claims, clubs, and patron lists. Test both from the checkout page and the patron detail page. Recalls: - If necessary, check out some items to patrons so that there are titles which can be recalled. - Log in to the OPAC and place one or more recalls. - Return to the staff interface and view the "Recalls" tab on the patron's account. Return claims: - If necessary, check out some items to a patron. Click the "Claim returned" button on a few of the patron's checkouts. - As you add claims, the "Claims" tab should update the count of claims. *** NOTE: This changes the display of claims in the tab so that the count of unresolved claims appears first: "Unresolved / Resolved". I think it makes more sense for the first number to be the one which shows the number of "active" issues. - Test setting the ClaimReturnedWarningThreshold system preference to various values: e.g. empty, 1, 5. - If the pref is empty, OR if the pref is set to a number higher than the number of patron claims, the count of claims should be styled with the "info" blue background and the count of resolved claims is not shown. *** NOTE: Hiding the resolved claims seems logical if there is not a concern about the total number of claims. - If the number of all claims exceeds the value of the preference, the tab should show a count of "Unresolved claims / Resolved claims" with the yellow warning style. Restrictions: - Adding a restriction to the account should cause a counter with a red background to appear on the tab. Clubs: - If necessary, create at least one club template and then multiple clubs. - From the "Clubs" tab on the patron's account, try enrolling and cancelling enrollments to confirm that the count on the tab updates correctly. *** NOTE: I have removed the count of available clubs because I think it's not relevant to this interface. We don't do it with patron lists, so this makes it a little more consistent.. Patron lists: - If necessary, create two ore more patron lists. - From the "Patron lists" tab, try adding and removing the patron from lists. Sponsored-by: Athens County Public Libraries Signed-off-by: Martin Renvoize <martin.renvoize@openfifth.co.uk> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26258 Martin Renvoize (ashimema) <martin.renvoize@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA --- Comment #34 from Martin Renvoize (ashimema) <martin.renvoize@openfifth.co.uk> --- This is a great improvement for consistency.. thanks Owen -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26258 Martin Renvoize (ashimema) <martin.renvoize@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords| |rel_24_11_candidate -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26258 Lucas Gass (lukeg) <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to main Version(s)| |25.11.00 released in| | -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26258 Lucas Gass (lukeg) <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords|rel_25_11_candidate | CC| |lucas@bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26258 David Cook <dcook@prosentient.com.au> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |dcook@prosentient.com.au -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26258 Lucas Gass (lukeg) <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords|additional_work_needed | --- Comment #38 from Lucas Gass (lukeg) <lucas@bywatersolutions.com> --- follow-up pushed to main, thanks Owen! -- You are receiving this mail because: You are watching all bug changes.