[Bug 16131] New: Messages for branch transfers show with bullet points
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16131 Bug ID: 16131 Summary: Messages for branch transfers show with bullet points Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Circulation Assignee: koha-bugs@lists.koha-community.org Reporter: aleishaamohia@hotmail.com QA Contact: testopia@bugs.koha-community.org CC: gmcharlt@gmail.com, kyle.m.hall@gmail.com The branch transfer messages are styled as a list and show with bullet points. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16131 Aleisha Amohia <aleishaamohia@hotmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16131 --- Comment #1 from Aleisha Amohia <aleishaamohia@hotmail.com> --- Created attachment 49422 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=49422&action=edit Bug 16131: Messages for branch transfers show with bullet points This patches removes the list code from the messages To test: 1) Attempt to transfer an item to its home library. Confirm no bullet point in message 2) Check out an item to a user. Attempt to transfer the same item. Confirm no bullet point in message 3) Set syspref BranchTransferLimitsType to Enforce for item types. Go to Admin -> Library transfer limits and select a library (Library B) other than your home library (Library A). Uncheck all options. Go back to branch transfers and attempt to transfer an item from Library A to Library B. Confirm no bullet point in message. Sponsored-by: Catalyst IT -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16131 Aleisha Amohia <aleishaamohia@hotmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs@lists.koha-commun |aleishaamohia@hotmail.com |ity.org | Change sponsored?|--- |Sponsored -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16131 Marc Véron <veron@veron.ch> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #49422|0 |1 is obsolete| | --- Comment #2 from Marc Véron <veron@veron.ch> --- Created attachment 49427 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=49427&action=edit Bug 16131: Messages for branch transfers show with bullet points This patches removes the list code from the messages To test: 1) Attempt to transfer an item to its home library. Confirm no bullet point in message 2) Check out an item to a user. Attempt to transfer the same item. Confirm no bullet point in message 3) Set syspref BranchTransferLimitsType to Enforce for item types. Go to Admin -> Library transfer limits and select a library (Library B) other than your home library (Library A). Uncheck all options. Go back to branch transfers and attempt to transfer an item from Library A to Library B. Confirm no bullet point in message. Sponsored-by: Catalyst IT Signed-off-by: Marc Véron <veron@veron.ch> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16131 Marc Véron <veron@veron.ch> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Trivial patch Status|Needs Signoff |Signed Off CC| |veron@veron.ch -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16131 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart@bugs.koha-c | |ommunity.org --- Comment #3 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- (In reply to Aleisha Amohia from comment #0)
The branch transfer messages are styled as a list and show with bullet points.
And, what the problem with that? That could be achieve with some css (something like list-style: none;) -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16131 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |In Discussion -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16131 Josef Moravec <josef.moravec@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |josef.moravec@gmail.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16131 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|In Discussion |Failed QA --- Comment #4 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- I think the bullet points are there because mulitple errors can apply at the same time. If we just remove the <ul><li> without replacing it with something else, we have the issue that the text of different errors will flow into each other. I tested like this: * Check out Centerville item to someone in Centerville * Transfer that item to Centerville Errors shown are: * Item is already at destination library. * Item was on loan to koha (42) and has been returned. So I think the patch would need more work, but we probably also need to think about how we wan this to look like. Multiple 'blue' dialog boxes for mulitple errors? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16131 --- Comment #5 from Aleisha Amohia <aleisha@catalyst.net.nz> --- (In reply to Katrin Fischer from comment #4)
Multiple 'blue' dialog boxes for mulitple errors?
That sounds like a good option to me. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16131 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |oleonard@myacpl.org -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16131 Aleisha Amohia <aleisha@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16131 Aleisha Amohia <aleisha@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #49427|0 |1 is obsolete| | --- Comment #6 from Aleisha Amohia <aleisha@catalyst.net.nz> --- Created attachment 190642 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=190642&action=edit Bug 16131: Show branch transfer error messages in separate alert boxes Currently error messages show in one alert box as bullet points. When there is only one error shown, this looks a bit strange to have a list with one item. This enhancement displays each error message as its own alert box. To test: 1. Check out a Centerville item to someone in Centerville. For example, check out 39999000004175 to yourself. 2. Go to Circulation -> Transfers. Enter the barcode 39999000004175 and transfer the item to Centerville. 3. Confirm two error messages are shown, with one blue box for each. 4. Go to Koha administration -> System preferences. Set UseBranchTransferLimits to Enforce and BranchTransferLimitsType to collection code. 5. Go to Koha administration -> Library transfer limits. Go to the REF tab and uncheck the Allow transfer? box for FFL - Fairfield, then hit Save 6. Go to Circulation -> Transfers. Enter the barcode 39999000004175 and transfer the item to Fairfield. 7. Confirm the error message shows in a blue box with no bullet point. 8. Type something random in the item barcode box and click Transfer. 9. Confirm the error message shows in a blue box with no bullet point. Sponsored-by: Catalyst IT -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16131 Aleisha Amohia <aleisha@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords| |Academy, Sandbox -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16131 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16131 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #190642|0 |1 is obsolete| | --- Comment #7 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 190645 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=190645&action=edit Bug 16131: Show branch transfer error messages in separate alert boxes Currently error messages show in one alert box as bullet points. When there is only one error shown, this looks a bit strange to have a list with one item. This enhancement displays each error message as its own alert box. To test: 1. Check out a Centerville item to someone in Centerville. For example, check out 39999000004175 to yourself. 2. Go to Circulation -> Transfers. Enter the barcode 39999000004175 and transfer the item to Centerville. 3. Confirm two error messages are shown, with one blue box for each. 4. Go to Koha administration -> System preferences. Set UseBranchTransferLimits to Enforce and BranchTransferLimitsType to collection code. 5. Go to Koha administration -> Library transfer limits. Go to the REF tab and uncheck the Allow transfer? box for FFL - Fairfield, then hit Save 6. Go to Circulation -> Transfers. Enter the barcode 39999000004175 and transfer the item to Fairfield. 7. Confirm the error message shows in a blue box with no bullet point. 8. Type something random in the item barcode box and click Transfer. 9. Confirm the error message shows in a blue box with no bullet point. Sponsored-by: Catalyst IT Signed-off-by: Owen Leonard <oleonard@myacpl.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16131 Laura Escamilla <Laura.escamilla@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16131 Laura Escamilla <Laura.escamilla@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #190645|0 |1 is obsolete| | --- Comment #8 from Laura Escamilla <Laura.escamilla@bywatersolutions.com> --- Created attachment 190684 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=190684&action=edit Bug 16131: Show branch transfer error messages in separate alert boxes Currently error messages show in one alert box as bullet points. When there is only one error shown, this looks a bit strange to have a list with one item. This enhancement displays each error message as its own alert box. To test: 1. Check out a Centerville item to someone in Centerville. For example, check out 39999000004175 to yourself. 2. Go to Circulation -> Transfers. Enter the barcode 39999000004175 and transfer the item to Centerville. 3. Confirm two error messages are shown, with one blue box for each. 4. Go to Koha administration -> System preferences. Set UseBranchTransferLimits to Enforce and BranchTransferLimitsType to collection code. 5. Go to Koha administration -> Library transfer limits. Go to the REF tab and uncheck the Allow transfer? box for FFL - Fairfield, then hit Save 6. Go to Circulation -> Transfers. Enter the barcode 39999000004175 and transfer the item to Fairfield. 7. Confirm the error message shows in a blue box with no bullet point. 8. Type something random in the item barcode box and click Transfer. 9. Confirm the error message shows in a blue box with no bullet point. Sponsored-by: Catalyst IT Signed-off-by: Owen Leonard <oleonard@myacpl.org> Signed-off-by: Laura_Escamilla <laura.escamilla@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16131 Laura Escamilla <Laura.escamilla@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |Laura.escamilla@bywatersolu | |tions.com QA Contact|testopia@bugs.koha-communit |Laura.escamilla@bywatersolu |y.org |tions.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16131 Lucas Gass (lukeg) <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |26.05.00 released in| | Status|Passed QA |Pushed to main -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16131 --- Comment #9 from Lucas Gass (lukeg) <lucas@bywatersolutions.com> --- Nice work everyone! Pushed to main for 26.05 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16131 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Text to go in the| |When transferring items release notes| |(Circulation > Transfers > | |Transfer), any error | |messages are shown as a | |bulleted list in one alert | |box. | | | |If there is only one error, | |it looks a bit odd having a | |bulleted list with only one | |item. | | | |With this enhancement, each | |error message is now shown | |in its own alert box. CC| |david@davidnind.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16131 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Messages for branch |Error messages for library |transfers show with bullet |transfers show with bullet |points |points --- Comment #10 from David Nind <david@davidnind.com> --- Something I noted when attempting to write a release note. The error messages are shown in a blue alert box (CSS style = alert alert-info), which is more for information than an error. Should this be a yellow alert box? I'm sure I've seen this somewhere about what type to use for different types of messages, but can't find it now... -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16131 Chloé Zermatten <chloe.zermatten@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)|26.05.00 |26.05.00,25.11.02 released in| | Status|Pushed to main |Pushed to stable -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16131 --- Comment #11 from Chloé Zermatten <chloe.zermatten@openfifth.co.uk> --- All pushed to 25.11.x Thanks all! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16131 Laura Escamilla <Laura.escamilla@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to stable |Needs documenting --- Comment #12 from Laura Escamilla <Laura.escamilla@bywatersolutions.com> --- Not backporting to 25.05 as this is an enhancement. Happy to revisit if needed. -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org