[Bug 6007] New: Checking 'Display only used Tags/Subfields' on MARC framework page results in unusable output
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6007 Bug #: 6007 Summary: Checking 'Display only used Tags/Subfields' on MARC framework page results in unusable output Classification: Unclassified Change sponsored?: --- Product: Koha Version: master Platform: All URL: /cgi-bin/koha/admin/marctagstructure.pl OS/Version: All Status: NEW Severity: normal Priority: P5 Component: System Administration AssignedTo: paul.poulain@biblibre.com ReportedBy: oleonard@myacpl.org QAContact: koha-bugs@lists.koha-community.org CC: gmcharlt@gmail.com Created attachment 3531 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=3531 Screenshot of the problematic display When looking at tags for a particular MARC framework, if you check the 'Display only used Tags/Subfields' the page automatically reloads and the table redisplays in a way that is unusable. The table columns no longer match the header and there are no longer links for editing, deleting, etc. -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6007 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer@bsz-bw.de Blocks| |1487 -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6007 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks|1487 | -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6007 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |1487 -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6007 --- Comment #1 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- This is better in current master. All columns still show up, as do the links for editing, but the table is way too wide, requiring you to scroll. -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6007 David Cook <dcook@prosentient.com.au> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |dcook@prosentient.com.au See Also| |http://bugs.koha-community. | |org/bugzilla3/show_bug.cgi? | |id=12477 -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6007 Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |bgkriegel@gmail.com --- Comment #2 from Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> --- Created attachment 29315 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=29315&action=edit Screenshot of 'fixed' display Problem with this is value stored in 'seealso' column, e.g. for 650$a (/cgi-bin/koha/admin/marc_subfields_structure.pl?tagfield=650&frameworkcode=BKS) See also: '100b','100c','100q','100d','100e','110a','110b','110c','110d','110e','111a','111e','111c','111d','130a','700a','700b','700c','700q','700d','700e','710a','710b','710c','710d','710e','711a','711e','711c','711d','720a','720e','796a','796b','796c','796q','796d','796e','797a','797b','797c','797d','797e','798a','798e','798c','798d','800a','800b','800c','800q','800d','800e','810a','810b','810c','810d','810e','811a','811e','811c','811d','896a','896b','896c','896q','896d','896e','897a','897b','897c','897d','897e','898a','898e','898c','898d','505r' Now, what's the use of this value? Can't be edited and is not displayed on record editor nor framework editor. AFAIK, it only exists in database. Can it be set to NULL? I did that, and the the view is more 'normal' -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6007 --- Comment #3 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Hi Bernardo, I think this is a leftover from NoZebra. -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6007 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff Patch complexity|--- |Small patch -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6007 --- Comment #4 from Jonathan Druart <jonathan.druart@biblibre.com> --- Created attachment 37563 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=37563&action=edit Bug 6007: Fix MARC framework display when only used tags/subfields The "Display only used tags/subfields" output breaks DataTables and the output is unusable. Test plan: 1/ Go on admin/marctagstructure.pl after you have selected a framework 2/ Check the checkbox 3/ The table should be correctly displayed. Before this patch, the table have 2 lines per tag, now all data are contained into the same line. -- You are receiving this mail because: You are watching all bug changes. You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6007 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart@biblibre.co | |m Assignee|paul.poulain@biblibre.com |jonathan.druart@biblibre.co | |m Severity|normal |major --- Comment #5 from Jonathan Druart <jonathan.druart@biblibre.com> --- Since an error appears, I consider this one as major. -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6007 Josef Moravec <josef.moravec@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #37563|0 |1 is obsolete| | --- Comment #6 from Josef Moravec <josef.moravec@gmail.com> --- Created attachment 37568 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=37568&action=edit [SIGNED-OFF] Bug 6007: Fix MARC framework display when only used tags/subfields The "Display only used tags/subfields" output breaks DataTables and the output is unusable. Test plan: 1/ Go on admin/marctagstructure.pl after you have selected a framework 2/ Check the checkbox 3/ The table should be correctly displayed. Before this patch, the table have 2 lines per tag, now all data are contained into the same line. Signed-off-by: Josef Moravec <josef.moravec@gmail.com> -- You are receiving this mail because: You are watching all bug changes. You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6007 Josef Moravec <josef.moravec@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |josef.moravec@gmail.com Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6007 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6007 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #37568|0 |1 is obsolete| | --- Comment #7 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 37659 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=37659&action=edit [PASSED QA] Bug 6007: Fix MARC framework display when only used tags/subfields The "Display only used tags/subfields" output breaks DataTables and the output is unusable. Test plan: 1/ Go on admin/marctagstructure.pl after you have selected a framework 2/ Check the checkbox 3/ The table should be correctly displayed. Before this patch, the table have 2 lines per tag, now all data are contained into the same line. Signed-off-by: Josef Moravec <josef.moravec@gmail.com> Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6007 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |tomascohen@gmail.com Status|Passed QA |Pushed to Master --- Comment #8 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Patch pushed to master. Thanks Jonathan! -- You are receiving this mail because: You are watching all bug changes. You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6007 Chris Cormack <chris@bigballofwax.co.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |chris@bigballofwax.co.nz --- Comment #9 from Chris Cormack <chris@bigballofwax.co.nz> --- Template changes holding for 3.18.7 -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6007 Chris Cormack <chris@bigballofwax.co.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |Pushed to Stable --- Comment #10 from Chris Cormack <chris@bigballofwax.co.nz> --- Applied on 3.18.x will be in 3.18.7 -- You are receiving this mail because: You are watching all bug changes. You are the QA Contact for the bug.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org