[Bug 8796] New: patron cards not starting on designated card
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8796 Priority: P5 - low Change sponsored?: --- Bug ID: 8796 Assignee: cnighswonger@foundations.edu Summary: patron cards not starting on designated card Severity: major Classification: Unclassified OS: All Reporter: nengard@gmail.com Hardware: All Status: NEW Version: rel_3_8 Component: Label printing Product: Koha When I put a number in "Enter starting card number" I am expecting it to start printing cards in that position the way it does in the label creator. However it always starts in the first position. I have tested and confirmed this in 3.8.4 and Master (as of this morning). -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8796 --- Comment #1 from Marc Véron <veron@veron.ch> --- Created attachment 12485 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=12485&action=edit Starting labels on positions 2 and 7 (on the label sheet) It took quite a while until I figured out what happens - it is simply a misunderstanding: The label position means the position where the first label is positioned on the printout sheet (and not the index of the first label to print). Ah, and this said: It only affects PDF printing, not CSV or XML export. See screenshots of PDF printouts attached (same batch, starting at the 2nd and at the 7th position). Marc -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8796 --- Comment #2 from Marc Véron <veron@veron.ch> --- Created attachment 12487 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=12487&action=edit Bug 8796 - patron cards not starting on designated card Better wording for the meaning of 'Position' to prevent mistakes on behaviour. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8796 Marc Véron <veron@veron.ch> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff CC| |veron@veron.ch Assignee|cnighswonger@foundations.ed |veron@veron.ch |u | -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8796 --- Comment #3 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 12573 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=12573&action=edit [SIGNED-OFF] Bug 8796 - patron cards not starting on designated card Better wording for the meaning of 'Position' to prevent mistakes on behaviour. Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8796 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #12487|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8796 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off CC| |kyle@bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8796 Mason James <mtj@kohaaloha.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA CC| |mtj@kohaaloha.com QA Contact| |mtj@kohaaloha.com --- Comment #4 from Mason James <mtj@kohaaloha.com> --- (In reply to comment #3)
Created attachment 12573 [details] [SIGNED-OFF] Bug 8796 - patron cards not starting on designated card
Better wording for the meaning of 'Position' to prevent mistakes on behaviour.
Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
trivial patch, passing QA... -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8796 Paul Poulain <paul.poulain@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master CC| |paul.poulain@biblibre.com Severity|major |normal --- Comment #5 from Paul Poulain <paul.poulain@biblibre.com> --- Patch pushed to master (severity lowered, it's not major !) -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8796 Chris Cormack <chris@bigballofwax.co.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |Pushed to Stable CC| |chris@bigballofwax.co.nz --- Comment #6 from Chris Cormack <chris@bigballofwax.co.nz> --- Pushed to 3.8.x, will be in 3.8.6 -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8796 Nicole C. Engard <nengard@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Stable |ASSIGNED --- Comment #7 from Nicole C. Engard <nengard@gmail.com> --- This is an issue in the 3.10.x (and probably master) branch -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8796 Marc Véron <veron@veron.ch> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8796 Nicole C. Engard <nengard@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|RESOLVED |REOPENED Resolution|FIXED |--- --- Comment #8 from Nicole C. Engard <nengard@gmail.com> --- I reopened this last year and then veron@veron.ch closed it without comment. This is still an issue in master as of this morning. I tested it. Nicole -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8796 --- Comment #9 from Marc Véron <veron@veron.ch> --- Sorry, I mistaked. After patch 2012-09-28 12:45 UTC was pushed for 3.8.6 (signed off by Kyle M Hall), the behavior was as expected (Better wording for the meaning of 'Position' to prevent mistakes on behaviour). It seems that meanwhile the behaviour changed. On current master, printing a batch of cards seems always to start on the first (top left) position (and not as shown in attachment 1). Should the version be set to "Current master" (instead of 3.8) ? -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8796 Marc Véron <veron@veron.ch> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|veron@veron.ch |cnighswonger@foundations.ed | |u -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8796 Nicole C. Engard <nengard@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version|3.8 |master -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8796 Heinrich Hartl <Heinrich.Hartl@email.de> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |Heinrich.Hartl@email.de Priority|P5 - low |P3 --- Comment #10 from Heinrich Hartl <Heinrich.Hartl@email.de> --- The bug is still existing in 3.18.4. Printing in the created .pdf starts irrespective of input in position 1 of the label sheet/template. The bug is effectively preventing the use of patron label creator. So I suggest it to be given higher priority! Moreover the documentation of the patron card creator in the manual is incomplete. In http://translate.koha-community.org/manual/3.18/en/html-desktop \ /#patroncardcreator Chapter 3.1.6.4. Batches seems to be truncated / incomplete. The text displayed in the 3.18.4 export popup is Enter starting card number and seems not to be consistent with attachment [SIGNED-OFF] Bug 8796... The user is still left without clear idea what this value means. Why not use a text similar to "Start printing in template-position" [] -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8796 Marc Véron <veron@veron.ch> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #12573|0 |1 is obsolete| | --- Comment #11 from Marc Véron <veron@veron.ch> --- Comment on attachment 12573 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=12573 [SIGNED-OFF] Bug 8796 - patron cards not starting on designated card Applying: Bug 8796 - patron cards not starting on designated card Using index info to reconstruct a base tree... Falling back to patching base and 3-way merge... No changes -- Patch already applied. Obsoleted this patch. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8796 --- Comment #12 from Marc Véron <veron@veron.ch> --- Created attachment 37343 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=37343&action=edit Bug 8796 - patron cards not starting on designated card The patron cards always printed from position 1 on the print form, because patroncards/create-pdf.pl expected start_label as parameter and got star_card instead. To verify and test: 1) Go to Home > Tools >Patron card creator >Manage batches 2) Select a batch anc click "Export" 3) Set "Enter starting card number" e.g. to 5 4) Export 5) Download PDF and view it Result: The first card is always printed on position 1 (top left) instead of position 5. Apply patch Repeat steps above Step 3) should now read "Enter starting card position" Result after step 5) The first card ist printed at the correct position on the printing form. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8796 Marc Véron <veron@veron.ch> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #12485|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8796 Marc Véron <veron@veron.ch> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|REOPENED |Needs Signoff Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8796 Marc Véron <veron@veron.ch> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|cnighswonger@foundations.ed |veron@veron.ch |u | -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8796 Josef Moravec <josef.moravec@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #37343|0 |1 is obsolete| | --- Comment #13 from Josef Moravec <josef.moravec@gmail.com> --- Created attachment 37355 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=37355&action=edit Bug 8796 - patron cards not starting on designated card The patron cards always printed from position 1 on the print form, because patroncards/create-pdf.pl expected start_label as parameter and got star_card instead. To verify and test: 1) Go to Home > Tools >Patron card creator >Manage batches 2) Select a batch anc click "Export" 3) Set "Enter starting card number" e.g. to 5 4) Export 5) Download PDF and view it Result: The first card is always printed on position 1 (top left) instead of position 5. Apply patch Repeat steps above Step 3) should now read "Enter starting card position" Result after step 5) The first card ist printed at the correct position on the printing form. Signed-off-by: Josef Moravec <josef.moravec@gmail.com> Works as expected -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8796 Josef Moravec <josef.moravec@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off CC| |josef.moravec@gmail.com -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8796 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8796 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #37355|0 |1 is obsolete| | --- Comment #14 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 37520 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=37520&action=edit [PASSED QA] Bug 8796 - patron cards not starting on designated card The patron cards always printed from position 1 on the print form, because patroncards/create-pdf.pl expected start_label as parameter and got star_card instead. To verify and test: 1) Go to Home > Tools >Patron card creator >Manage batches 2) Select a batch anc click "Export" 3) Set "Enter starting card number" e.g. to 5 4) Export 5) Download PDF and view it Result: The first card is always printed on position 1 (top left) instead of position 5. Apply patch Repeat steps above Step 3) should now read "Enter starting card position" Result after step 5) The first card ist printed at the correct position on the printing form. Signed-off-by: Josef Moravec <josef.moravec@gmail.com> Works as expected Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8796 Marc Véron <veron@veron.ch> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |http://bugs.koha-community. | |org/bugzilla3/show_bug.cgi? | |id=13954 -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8796 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |tomascohen@gmail.com Status|Passed QA |Patch doesn't apply --- Comment #15 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Please rebase so I push it. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8796 --- Comment #16 from Marc Véron <veron@veron.ch> --- Created attachment 37628 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=37628&action=edit Bug 8796 - patron cards not starting on designated card The patron cards always printed from position 1 on the print form, because patroncards/create-pdf.pl expected start_label as parameter and got star_card instead. To verify and test: 1) Go to Home > Tools >Patron card creator >Manage batches 2) Select a batch anc click "Export" 3) Set "Enter starting card number" e.g. to 5 4) Export 5) Download PDF and view it Result: The first card is always printed on position 1 (top left) instead of position 5. Apply patch Repeat steps above Step 3) should now read "Enter starting card position" Result after step 5) The first card ist printed at the correct position on the printing form. Signed-off-by: Josef Moravec <josef.moravec@gmail.com> Works as expected Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> Rebased to apply on master / MV -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8796 Marc Véron <veron@veron.ch> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #37628|0 |1 is obsolete| | --- Comment #17 from Marc Véron <veron@veron.ch> --- Comment on attachment 37628 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=37628 Bug 8796 - patron cards not starting on designated card Did a mistake while rebasing. Obsoleted. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8796 --- Comment #18 from Marc Véron <veron@veron.ch> --- Created attachment 37629 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=37629&action=edit Bug 8796 - patron cards not starting on designated card The patron cards always printed from position 1 on the print form, because patroncards/create-pdf.pl expected start_label as parameter and got star_card instead. To verify and test: 1) Go to Home > Tools >Patron card creator >Manage batches 2) Select a batch anc click "Export" 3) Set "Enter starting card number" e.g. to 5 4) Export 5) Download PDF and view it Result: The first card is always printed on position 1 (top left) instead of position 5. Apply patch Repeat steps above Step 3) should now read "Enter starting card position" Result after step 5) The first card ist printed at the correct position on the printing form. Signed-off-by: Josef Moravec <josef.moravec@gmail.com> Works as expected Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> Rebased for current master and tested. /MV -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8796 Marc Véron <veron@veron.ch> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |Passed QA --- Comment #19 from Marc Véron <veron@veron.ch> --- I hope it's OK to put it back to Passed QA after rebase (1 line). -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8796 Marc Véron <veron@veron.ch> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #37520|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8796 --- Comment #20 from Tomás Cohen Arazi <tomascohen@gmail.com> --- (In reply to Marc Véron from comment #19)
I hope it's OK to put it back to Passed QA after rebase (1 line).
It is! -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8796 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master --- Comment #21 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Patch pushed to master. Thanks Marc! -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8796 --- Comment #22 from Chris Cormack <chris@bigballofwax.co.nz> --- String changes, held for 3.18.7 -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8796 --- Comment #23 from Chris Cormack <chris@bigballofwax.co.nz> --- Theres a conflict in patroncards/create-pdf.pdf .. please rebase on 3.18.x if you want it in 3.18.7 -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org