[Bug 23049] New: Replace MANUAL_INV authorised value with a dedicated table
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23049 Bug ID: 23049 Summary: Replace MANUAL_INV authorised value with a dedicated table Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Fines and fees Assignee: koha-bugs@lists.koha-community.org Reporter: martin.renvoize@ptfs-europe.com QA Contact: testopia@bugs.koha-community.org Target Milestone: --- Account debits types should be properly recorded in their own table with a purpose-built interface for working upon them. This would pave the way for extensions to the cash management side of Koha, allowing for more granular definitions of charges for a point of sale system and giving an obvious location to add features like recording tax rates on different charges. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23049 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |6759 Blocks| |17702 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6759 [Bug 6759] Use a different account type for account renewals than for new accounts https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17702 [Bug 17702] Create configuration for account types -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23049 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |22610 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22610 [Bug 22610] SIP Payment Types should be moved out of accountype -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23049 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart@bugs.koha-c | |ommunity.org --- Comment #1 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- What about translation? -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23049 --- Comment #2 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- I intend on including translation in the patch I'll be submitting here ;) The point is.. I have a number of ways I need to extend the account debit functionality to add a point of sale mechanism to Koha. This is simply foundational work for that as leaving these credits as authorized values preclude them from being extended in any meaningful way. It is my firm opinion that Authorized Values should not just be used as a catch-all. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23049 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs@lists.koha-commun |martin.renvoize@ptfs-europe |ity.org |.com -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23049 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks|22610 | Depends on| |22610 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22610 [Bug 22610] SIP Payment Types should be moved out of accountype -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23049 Bug 23049 depends on bug 22610, which changed state. Bug 22610 Summary: SIP Payment Types should be moved out of accountype https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22610 What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to master |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23049 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=23636 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23049 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on|6759 |23354 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6759 [Bug 6759] Use a different account type for account renewals than for new accounts https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23354 [Bug 23354] Add a 'Pay' screen to allow anonymous payments in a POS fashion -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23049 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |23636 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23636 [Bug 23636] MANUAL_INV values should be able to have a code, a description, and a price. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23049 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |22393 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22393 [Bug 22393] Remove last remaining manualinvoice use -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23049 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |21739 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21739 [Bug 21739] 'Copier fees' should not be used as accounttype on maninvoice.pl -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23049 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |23046 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23046 [Bug 23046] Add tax handling to accounts -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23049 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=17702 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23049 --- Comment #3 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 93513 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=93513&action=edit Bug 23049: Add debit_type * Add account_debit_types table * Add account_debit_types defaults * Add Koha::Account::DebitType and Koha::Account::DebitTypes * Prevent deletion of defaults * Update database to insert existing values -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23049 --- Comment #4 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 93514 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=93514&action=edit Bug 23049: Add branch limitations tables -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23049 --- Comment #5 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 93515 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=93515&action=edit Bug 23049: Update DBIC Classes for branch limitations -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23049 --- Comment #6 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 93516 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=93516&action=edit Bug 23049: Add CHECK constraint to accountlines -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23049 --- Comment #7 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 93518 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=93518&action=edit Bug 23049: Account types configuration - Admin page Test plan: 1) Go to admin home, note there is new Debit types page in Accounting section 2) Go to any other admin page and confirm there is link to Debit types in the admin menu as well 3) Go to Debit types page 4) You should see a datatable listing existing debit types, ensure they are working as expected. 5) Try to create, edit and delete some debit types. Note: Some debit types cannot be deleted as they are needed for koha functionality. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23049 --- Comment #8 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 93519 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=93519&action=edit Bug 23049: Update maninvoice to reference debit types -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23049 --- Comment #9 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 93520 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=93520&action=edit Bug 23049: Use debit_type in staff client views -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23049 --- Comment #10 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 93521 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=93521&action=edit Bug 23049: Update existing accounttype values -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23049 --- Comment #11 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 93522 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=93522&action=edit Bug 23049: Split system and local types Test plan 1) Apply patches up to this point 2) View the new debit types management page and comment whether the split table view is clearer/better. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23049 --- Comment #12 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 93523 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=93523&action=edit Bug 23049: Add tests Test plan: prove t/db_dependent/Koha/Account/DebitType.t prove t/db_dependent/Koha/Account/DebitTypes.t -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23049 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23049 --- Comment #13 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- I discussed translations with Katrin and she preferred I do a dependant bug rather than role it in here.. that's my next target so this patchset is ready to test. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23049 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |kyle@bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23049 --- Comment #14 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 93529 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=93529&action=edit Bug 23049: Use a filtered table instead of two tables Test Plan * Apply this patch and comment on new page design. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23049 Séverine Queune <severine.queune@bulac.fr> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |severine.queune@bulac.fr Status|Needs Signoff |Failed QA --- Comment #15 from Séverine Queune <severine.queune@bulac.fr> --- Not a critical point, but column name "Account type code" is different in the creation/modification form where it's "Account debit type code". The "Account type code" is supposed to accept 16 letters, but blocks after 5. If I use letters, currency symbols or comma for the "Default amount", the data is set to 0.00 after saving : I think it could be better if we could have a control field (don't know if it the correct term) that only accept numbers and the autorized decimal separator. Other behaviors seemed good to me, the design is clear and the options (filter / search) efficient ! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23049 --- Comment #16 from Kyle M Hall <kyle@bywatersolutions.com> --- (In reply to Séverine Queune from comment #15)
Not a critical point, but column name "Account type code" is different in the creation/modification form where it's "Account debit type code".
The "Account type code" is supposed to accept 16 letters, but blocks after 5.
Actually, it should be 80 based on bug 23539
If I use letters, currency symbols or comma for the "Default amount", the data is set to 0.00 after saving : I think it could be better if we could have a control field (don't know if it the correct term) that only accept numbers and the autorized decimal separator.
Agreed, an html5 pattern like ^\d+\.\d{2}$ should do it! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23049 --- Comment #17 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 93557 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=93557&action=edit Bug 23049: (follow-up) Impliment feedback -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23049 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #93557|0 |1 is obsolete| | --- Comment #18 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 93564 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=93564&action=edit Bug 23049: (follow-up) Impliment feedback -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23049 --- Comment #19 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 93565 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=93565&action=edit Bug 23049: (follow-up) Remove MANUAL_INV from AV -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23049 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff --- Comment #20 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Thankyou for the fast feedback Séverine, I believe I've resolved those issues now with the followup :). -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23049 sandboxes@biblibre.com <sandboxes@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |sandboxes@biblibre.com Status|Needs Signoff |Signed Off --- Comment #21 from sandboxes@biblibre.com <sandboxes@biblibre.com> --- Patch tested with a sandbox, by Séverine QUEUNE <severine.queune@bulac.fr> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23049 sandboxes@biblibre.com <sandboxes@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #93513|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23049 sandboxes@biblibre.com <sandboxes@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #93514|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23049 sandboxes@biblibre.com <sandboxes@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #93515|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23049 sandboxes@biblibre.com <sandboxes@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #93516|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23049 sandboxes@biblibre.com <sandboxes@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #93518|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23049 sandboxes@biblibre.com <sandboxes@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #93519|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23049 sandboxes@biblibre.com <sandboxes@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #93520|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23049 sandboxes@biblibre.com <sandboxes@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #93521|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23049 sandboxes@biblibre.com <sandboxes@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #93522|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23049 sandboxes@biblibre.com <sandboxes@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #93523|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23049 sandboxes@biblibre.com <sandboxes@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #93529|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23049 sandboxes@biblibre.com <sandboxes@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #93564|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23049 sandboxes@biblibre.com <sandboxes@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #93565|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23049 --- Comment #22 from sandboxes@biblibre.com <sandboxes@biblibre.com> --- Created attachment 93567 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=93567&action=edit Bug 23049: Add debit_type * Add account_debit_types table * Add account_debit_types defaults * Add Koha::Account::DebitType and Koha::Account::DebitTypes * Prevent deletion of defaults * Update database to insert existing values Signed-off-by: Séverine QUEUNE <severine.queune@bulac.fr> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23049 --- Comment #23 from sandboxes@biblibre.com <sandboxes@biblibre.com> --- Created attachment 93568 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=93568&action=edit Bug 23049: Add branch limitations tables Signed-off-by: Séverine QUEUNE <severine.queune@bulac.fr> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23049 --- Comment #24 from sandboxes@biblibre.com <sandboxes@biblibre.com> --- Created attachment 93569 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=93569&action=edit Bug 23049: Update DBIC Classes for branch limitations Signed-off-by: Séverine QUEUNE <severine.queune@bulac.fr> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23049 --- Comment #25 from sandboxes@biblibre.com <sandboxes@biblibre.com> --- Created attachment 93570 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=93570&action=edit Bug 23049: Add CHECK constraint to accountlines Signed-off-by: Séverine QUEUNE <severine.queune@bulac.fr> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23049 --- Comment #26 from sandboxes@biblibre.com <sandboxes@biblibre.com> --- Created attachment 93571 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=93571&action=edit Bug 23049: Account types configuration - Admin page Test plan: 1) Go to admin home, note there is new Debit types page in Accounting section 2) Go to any other admin page and confirm there is link to Debit types in the admin menu as well 3) Go to Debit types page 4) You should see a datatable listing existing debit types, ensure they are working as expected. 5) Try to create, edit and delete some debit types. Note: Some debit types cannot be deleted as they are needed for koha functionality. Signed-off-by: Séverine QUEUNE <severine.queune@bulac.fr> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23049 --- Comment #27 from sandboxes@biblibre.com <sandboxes@biblibre.com> --- Created attachment 93572 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=93572&action=edit Bug 23049: Update maninvoice to reference debit types Signed-off-by: Séverine QUEUNE <severine.queune@bulac.fr> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23049 --- Comment #28 from sandboxes@biblibre.com <sandboxes@biblibre.com> --- Created attachment 93573 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=93573&action=edit Bug 23049: Use debit_type in staff client views Signed-off-by: Séverine QUEUNE <severine.queune@bulac.fr> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23049 --- Comment #29 from sandboxes@biblibre.com <sandboxes@biblibre.com> --- Created attachment 93574 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=93574&action=edit Bug 23049: Update existing accounttype values Signed-off-by: Séverine QUEUNE <severine.queune@bulac.fr> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23049 --- Comment #30 from sandboxes@biblibre.com <sandboxes@biblibre.com> --- Created attachment 93575 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=93575&action=edit Bug 23049: Split system and local types Test plan 1) Apply patches up to this point 2) View the new debit types management page and comment whether the split table view is clearer/better. Signed-off-by: Séverine QUEUNE <severine.queune@bulac.fr> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23049 --- Comment #31 from sandboxes@biblibre.com <sandboxes@biblibre.com> --- Created attachment 93576 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=93576&action=edit Bug 23049: Add tests Test plan: prove t/db_dependent/Koha/Account/DebitType.t prove t/db_dependent/Koha/Account/DebitTypes.t Signed-off-by: Séverine QUEUNE <severine.queune@bulac.fr> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23049 --- Comment #32 from sandboxes@biblibre.com <sandboxes@biblibre.com> --- Created attachment 93577 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=93577&action=edit Bug 23049: Use a filtered table instead of two tables Test Plan * Apply this patch and comment on new page design. Signed-off-by: Séverine QUEUNE <severine.queune@bulac.fr> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23049 --- Comment #33 from sandboxes@biblibre.com <sandboxes@biblibre.com> --- Created attachment 93578 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=93578&action=edit Bug 23049: (follow-up) Impliment feedback Signed-off-by: Séverine QUEUNE <severine.queune@bulac.fr> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23049 --- Comment #34 from sandboxes@biblibre.com <sandboxes@biblibre.com> --- Created attachment 93579 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=93579&action=edit Bug 23049: (follow-up) Remove MANUAL_INV from AV Signed-off-by: Séverine QUEUNE <severine.queune@bulac.fr> Signed-off-by: Séverine QUEUNE <severine.queune@bulac.fr> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23049 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |ASSIGNED --- Comment #35 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Just found myself a whole area of code I overlooked.. putting back to assigned to reflect I have a bit more work to do before we're ready for another round of testing. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23049 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #93567|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23049 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #93568|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23049 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #93569|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23049 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #93570|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23049 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #93571|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23049 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #93572|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23049 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #93573|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23049 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #93574|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23049 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #93575|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23049 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #93576|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23049 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #93577|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23049 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #93578|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23049 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #93579|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23049 --- Comment #36 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 93960 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=93960&action=edit Bug 23049: Add debit_type * Add account_debit_types table * Add ac_debit_types_branches table * Add account_debit_types defaults * Add Koha::Account::DebitType and Koha::Account::DebitTypes * Prevent deletion of defaults * Migrate MANUAL_INV values * Remove MANUAL_INV references * Migrate accounttype values Signed-off-by: Séverine QUEUNE <severine.queune@bulac.fr> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23049 --- Comment #37 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 93961 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=93961&action=edit Bug 23049: Add CHECK constraint to accountlines Signed-off-by: Séverine QUEUNE <severine.queune@bulac.fr> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23049 --- Comment #38 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 93962 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=93962&action=edit Bug 23049: Account types configuration - Admin page Test plan: 1) Go to admin home, note there is new Debit types page in Accounting section 2) Go to any other admin page and confirm there is link to Debit types in the admin menu as well 3) Go to Debit types page 4) You should see a datatable listing existing debit types, ensure they are working as expected. 5) Try to create, edit and delete some debit types. Note: Some debit types cannot be deleted as they are needed for koha functionality. Signed-off-by: Séverine QUEUNE <severine.queune@bulac.fr> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23049 --- Comment #39 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 93963 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=93963&action=edit Bug 23049: Filter out system types by default Test Plan 1) Navigate to the debit types management page added in previous patches 2) Note that system types are now filtered out by default 3) Click on the new unfilter button to include system types 4) Signoff Signed-off-by: Séverine QUEUNE <severine.queune@bulac.fr> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23049 --- Comment #40 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 93964 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=93964&action=edit Bug 23049: Update maninvoice to reference debit types Test plan: 1) Naviage to a patron record and select the accounts > manual invoice tab 2) Add some manual invoices and confirm they are working as expected 3) Signoff Signed-off-by: Séverine QUEUNE <severine.queune@bulac.fr> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23049 --- Comment #41 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 93965 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=93965&action=edit Bug 23049: Add tests Test plan: prove t/db_dependent/Koha/Account/DebitType.t prove t/db_dependent/Koha/Account/DebitTypes.t Signed-off-by: Séverine QUEUNE <severine.queune@bulac.fr> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23049 --- Comment #42 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 93966 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=93966&action=edit Bug 23049: Update existing code to use debit_type * Update C4::Accounts::chargelostitem * Update C4::Accounts::manualinvoice * Update C4::Circulation::_FixOverduesOnReturn * Update C4::Circulation::_FixAccountForLostAndReturned * Update C4::Overdues::UpdateFine * Update C4::Overdues::GetFine * Update C4::Overdues::GetOverduesForBranch * Update Koha::Account->pay * Update Koha::Account->add_debit * Update Koha::Account->non_issues_charges * Update Koha::Account::Line->apply * Update Koha::Account::Line->adjust * Update controller scripts * Update reports scripts * Update tests Test Plan 1) Run the test suit and ensure everything still passes 2) Test reports/cash_register_stats still works 3) Test that adding manual invoices still works 4) Test that making payments still works 5) Test that lost item fee handling still works 6) Test that invoice printing still works 7) Test that the sco still works Signed-off-by: Séverine QUEUNE <severine.queune@bulac.fr> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23049 --- Comment #43 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 93967 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=93967&action=edit Bug 23049: Update 'Res' to 'RESERVE' for consistency This patch updates all cases where debit_type_code was 'Res' to 'RESERVE' which is more informative and consistent with the new style guidelines. Signed-off-by: Séverine QUEUNE <severine.queune@bulac.fr> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23049 --- Comment #44 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 93968 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=93968&action=edit Bug 23049: Capitalise 'rent' calls to add_debit This works towards making type codes consistent Signed-off-by: Séverine QUEUNE <severine.queune@bulac.fr> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23049 --- Comment #45 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 93969 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=93969&action=edit Bug 23049: Update 'PF' to 'PROCESSING' for consistency Signed-off-by: Séverine QUEUNE <severine.queune@bulac.fr> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23049 --- Comment #46 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 93970 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=93970&action=edit Bug 23049: Capitalise type passed to add_debit for account Signed-off-by: Séverine QUEUNE <severine.queune@bulac.fr> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23049 --- Comment #47 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 93972 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=93972&action=edit Bug 23049: Update 'HE' to 'RESERVE_EXPIRED' for consistency This patch updates all cases where debit_type_code was 'HE' to 'RESERVE_EXPIRED' which is more informative and consistent with the new style guidelines. Signed-off-by: Séverine QUEUNE <severine.queune@bulac.fr> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23049 --- Comment #48 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 93973 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=93973&action=edit Bug 23049: Capitalise type passed to add_debit for lost_item Signed-off-by: Séverine QUEUNE <severine.queune@bulac.fr> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23049 --- Comment #49 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 93974 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=93974&action=edit Bug 23049: Remove manual_debit as it's never called Signed-off-by: Séverine QUEUNE <severine.queune@bulac.fr> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23049 --- Comment #50 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 93975 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=93975&action=edit Bug 23049: Capitalise type passed to add_debit for overdue Signed-off-by: Séverine QUEUNE <severine.queune@bulac.fr> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23049 --- Comment #51 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 93976 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=93976&action=edit Bug 23049: 'N' -> 'NEW_CARD' Signed-off-by: Séverine QUEUNE <severine.queune@bulac.fr> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23049 --- Comment #52 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 93977 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=93977&action=edit Bug 23049: Drop type lookup as it's now a foreign key Signed-off-by: Séverine QUEUNE <severine.queune@bulac.fr> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23049 --- Comment #53 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 93978 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=93978&action=edit Bug 23049: Update API Signed-off-by: Séverine QUEUNE <severine.queune@bulac.fr> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23049 --- Comment #54 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 93979 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=93979&action=edit Bug 23049: (follow-up) Fix manual debits via add_debit Signed-off-by: Séverine QUEUNE <severine.queune@bulac.fr> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23049 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23049 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23049 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on|23354 | Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23354 [Bug 23354] Add a 'Pay' screen to allow anonymous payments in a POS fashion -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23049 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |23354 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23354 [Bug 23354] Add a 'Pay' screen to allow anonymous payments in a POS fashion -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23049 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |23321 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23321 [Bug 23321] Add 'cash registers' to the accounts system -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23049 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |BLOCKED CC| |m.de.rooy@rijksmuseum.nl --- Comment #55 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- OK Trying to be brave, start QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23049 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia@bugs.koha-communit |m.de.rooy@rijksmuseum.nl |y.org | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23049 --- Comment #56 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- INSERT IGNORE INTO account_debit_types ( code, default_amount, description, can_be_added_manually, is_system ) SELECT SUBSTR(authorised_value, 1, 64), lib, authorised_value, 1, 0 This does not match somehow. Default amount filled by lib ? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23049 --- Comment #57 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- NAME ac_debit_types_branches Names for databases, tables, columns, and indexes can be up to 64 characters long. Alias names can be up to 256 characters long. Why not account_debit_types_branches instead of some abbreviated form. Making developers look for a table a bit longer? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23049 --- Comment #58 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- Moving authorized values to new table: SUBSTR(authorised_value, 1, 64) This may be a source of trouble, at least theoretically. Why not switch from the 64 to 80 chars? `accounttype` varchar(80) default NULL, `debit_type_code` varchar(64) default NULL, `payment_type` varchar(80) default NULL, -- optional authorised value PAYMENT_TYPE This looks a bit inconsistent too? Why not give the table an autoincrement id as PK and do not duplicate the code everywhere? Accountlines could be large, less space? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23049 --- Comment #59 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- FAIL Koha/Account/DebitType.pm OK critic OK forbidden patterns OK git manipulation OK pod OK pod coverage SKIP spelling FAIL valid Inconsistent hierarchy during C3 merge of class 'Koha::Account::DebitType': Koha::Account::DebitType, current merge results [ ] merging failed on 'Koha::Object' FAIL Koha/Account/DebitTypes.pm OK critic OK forbidden patterns OK git manipulation OK pod FAIL pod coverage POD is missing for 'object_class' SKIP spelling OK valid Not sure what exactly triggered the first one. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23049 --- Comment #60 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Thanks for taking a look Marcel, I'll get onto the feedback today... all of it seems sane to me so far. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23049 --- Comment #61 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- This is a quite fundamental one: UPDATE accountlines SET debit_type_code = accounttype, accounttype = NULL WHERE accounttype IN (SELECT code from account_debit_types) Hmm. I do not really like this at first glance (and second too ;). I would prefer one account type and not a separate debit code. If I would be scrolling through account lines, I think it is weird to have to look at two columns to determine the type of this transaction. But might understand this choice from the perspective to keep this patch set a bit smaller and narrow it down to the old MANUAL_INV stuff. So, my problem actually goes a bit beyond this report too and is also about the design of accounts. We should have added an accounts type table in the first place. Now we are doing it for a subset of our account types. And I am wondering if this step will bring us closer to that goal of integrating these types or will just hinder us along the way. I am inclined to think that we should not separate the two now. And I understand that this creates new problems. The account types would be partially controlled by the debit codes list. So we could not (yet) put a FK on it. But it might be a better starting point for controlling the other account types? Since this is an important design choice, I would suggest to discuss this on the dev list or within the QA team, or dev meeting? We need some more consensus on that decision. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23049 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|BLOCKED |Failed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23049 --- Comment #62 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- (In reply to Marcel de Rooy from comment #58)
Moving authorized values to new table: SUBSTR(authorised_value, 1, 64) This may be a source of trouble, at least theoretically. Why not switch from the 64 to 80 chars?
`accounttype` varchar(80) default NULL, `debit_type_code` varchar(64) default NULL, `payment_type` varchar(80) default NULL, -- optional authorised value PAYMENT_TYPE This looks a bit inconsistent too?
Why not give the table an autoincrement id as PK and do not duplicate the code everywhere? Accountlines could be large, less space?
I stuck to codes here to continue the pattern for simple reporting and also to allow for simple translations of the core system defaults where a code is significantly simpler to remember for translators. (Discussed with Katrin at hackfest regarding the translation comment, she was very pleased that we could keep the existing translations in the form of the include files). -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23049 --- Comment #63 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- (In reply to Marcel de Rooy from comment #59)
FAIL Koha/Account/DebitType.pm OK critic OK forbidden patterns OK git manipulation OK pod OK pod coverage SKIP spelling FAIL valid Inconsistent hierarchy during C3 merge of class 'Koha::Account::DebitType': Koha::Account::DebitType, current merge results [ ] merging failed on 'Koha::Object'
FAIL Koha/Account/DebitTypes.pm OK critic OK forbidden patterns OK git manipulation OK pod FAIL pod coverage POD is missing for 'object_class' SKIP spelling OK valid
Not sure what exactly triggered the first one.
The first one is the use of Koha::Objects::Limit::Library as a base class. Tomas has been looking into how to quiet this warning as we believe it's just noise at the moment. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23049 --- Comment #64 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- (In reply to Marcel de Rooy from comment #61)
This is a quite fundamental one:
UPDATE accountlines SET debit_type_code = accounttype, accounttype = NULL WHERE accounttype IN (SELECT code from account_debit_types)
Hmm. I do not really like this at first glance (and second too ;). I would prefer one account type and not a separate debit code. If I would be scrolling through account lines, I think it is weird to have to look at two columns to determine the type of this transaction.
Actually, as it currently stands you already have to look at two columns to ascertain whether the accountline is a debit or credit, so having these two fields next to each other is clearer in my opinion. I would like to rename accounttype to credit_type but didn't want to do that here and make the bug even bigger.
But might understand this choice from the perspective to keep this patch set a bit smaller and narrow it down to the old MANUAL_INV stuff.
Correct, I was trying to make this patch a bit more manageable. Bug 17702 became inpenetrably large by doing it all in one hit.
So, my problem actually goes a bit beyond this report too and is also about the design of accounts. We should have added an accounts type table in the first place. Now we are doing it for a subset of our account types. And I am wondering if this step will bring us closer to that goal of integrating these types or will just hinder us along the way. I am inclined to think that we should not separate the two now. And I understand that this creates new problems. The account types would be partially controlled by the debit codes list. So we could not (yet) put a FK on it. But it might be a better starting point for controlling the other account types?
The aim was to have a similar treatment for credit_types in a second bug.. although presently I see no use case for user-definable credit_types at this time. I strongly believe one of the major strengths of this bug is that we're introducing better DB design including FK constraints. One cannot point a single field at multiple tables for such constraints at this time and I don't believe there is any plan for such support in SQL.
Since this is an important design choice, I would suggest to discuss this on the dev list or within the QA team, or dev meeting? We need some more consensus on that decision.
I'm happy to attempt something else if you can come up with any suggestions, but I don't really want this to go back to discussion again (this is just a reimplementation of bug 17702 which I believe has already been discussed). I've already saught support for this from those most closely in touch with accounts and thats how I arrived at this design (Tomas, Kyle, Josef). -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23049 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #93960|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23049 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #93961|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23049 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #93962|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23049 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #93963|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23049 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #93964|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23049 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #93965|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23049 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #93966|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23049 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #93967|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23049 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #93968|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23049 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #93969|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23049 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #93970|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23049 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #93972|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23049 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #93973|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23049 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #93974|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23049 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #93975|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23049 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #93976|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23049 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #93977|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23049 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #93978|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23049 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #93979|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23049 --- Comment #65 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 93989 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=93989&action=edit Bug 23049: Add debit_type * Add account_debit_types table * Add ac_debit_types_branches table * Add account_debit_types defaults * Add Koha::Account::DebitType and Koha::Account::DebitTypes * Prevent deletion of defaults * Migrate MANUAL_INV values * Remove MANUAL_INV references * Migrate accounttype values Signed-off-by: Séverine QUEUNE <severine.queune@bulac.fr> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23049 --- Comment #66 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 93990 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=93990&action=edit Bug 23049: Add CHECK constraint to accountlines Signed-off-by: Séverine QUEUNE <severine.queune@bulac.fr> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23049 --- Comment #67 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 93991 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=93991&action=edit Bug 23049: Account types configuration - Admin page Test plan: 1) Go to admin home, note there is new Debit types page in Accounting section 2) Go to any other admin page and confirm there is link to Debit types in the admin menu as well 3) Go to Debit types page 4) You should see a datatable listing existing debit types, ensure they are working as expected. 5) Try to create, edit and delete some debit types. Note: Some debit types cannot be deleted as they are needed for koha functionality. Signed-off-by: Séverine QUEUNE <severine.queune@bulac.fr> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23049 --- Comment #68 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 93992 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=93992&action=edit Bug 23049: Filter out system types by default Test Plan 1) Navigate to the debit types management page added in previous patches 2) Note that system types are now filtered out by default 3) Click on the new unfilter button to include system types 4) Signoff Signed-off-by: Séverine QUEUNE <severine.queune@bulac.fr> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23049 --- Comment #69 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 93993 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=93993&action=edit Bug 23049: Update maninvoice to reference debit types Test plan: 1) Naviage to a patron record and select the accounts > manual invoice tab 2) Add some manual invoices and confirm they are working as expected 3) Signoff Signed-off-by: Séverine QUEUNE <severine.queune@bulac.fr> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23049 --- Comment #70 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 93994 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=93994&action=edit Bug 23049: Add tests Test plan: prove t/db_dependent/Koha/Account/DebitType.t prove t/db_dependent/Koha/Account/DebitTypes.t Signed-off-by: Séverine QUEUNE <severine.queune@bulac.fr> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23049 --- Comment #71 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 93995 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=93995&action=edit Bug 23049: Update existing code to use debit_type * Update C4::Accounts::chargelostitem * Update C4::Accounts::manualinvoice * Update C4::Circulation::_FixOverduesOnReturn * Update C4::Circulation::_FixAccountForLostAndReturned * Update C4::Overdues::UpdateFine * Update C4::Overdues::GetFine * Update C4::Overdues::GetOverduesForBranch * Update Koha::Account->pay * Update Koha::Account->add_debit * Update Koha::Account->non_issues_charges * Update Koha::Account::Line->apply * Update Koha::Account::Line->adjust * Update controller scripts * Update reports scripts * Update tests Test Plan 1) Run the test suit and ensure everything still passes 2) Test reports/cash_register_stats still works 3) Test that adding manual invoices still works 4) Test that making payments still works 5) Test that lost item fee handling still works 6) Test that invoice printing still works 7) Test that the sco still works Signed-off-by: Séverine QUEUNE <severine.queune@bulac.fr> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23049 --- Comment #72 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 93996 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=93996&action=edit Bug 23049: Update debit_type_code 'Res' to 'RESERVE' This patch updates all cases where debit_type_code was 'Res' to 'RESERVE' which is more informative and consistent with the new style guidelines. The patch also ensure all calls to add_debit with a type or 'reserve' now pass the capitalised code instead. Signed-off-by: Séverine QUEUNE <severine.queune@bulac.fr> Capitalise reserve -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23049 --- Comment #73 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 93997 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=93997&action=edit Bug 23049: Capitalise type passed to add_debit for `rent` Signed-off-by: Séverine QUEUNE <severine.queune@bulac.fr> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23049 --- Comment #74 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 93998 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=93998&action=edit Bug 23049: Update 'PF' to 'PROCESSING' for consistency Signed-off-by: Séverine QUEUNE <severine.queune@bulac.fr> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23049 --- Comment #75 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 93999 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=93999&action=edit Bug 23049: Capitalise type passed to add_debit for `account` Signed-off-by: Séverine QUEUNE <severine.queune@bulac.fr> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23049 --- Comment #76 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 94000 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=94000&action=edit Bug 23049: Update 'HE' to 'RESERVE_EXPIRED' for consistency This patch updates all cases where debit_type_code was 'HE' to 'RESERVE_EXPIRED' which is more informative and consistent with the new style guidelines. Signed-off-by: Séverine QUEUNE <severine.queune@bulac.fr> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23049 --- Comment #77 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 94001 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=94001&action=edit Bug 23049: Capitalise type passed to add_debit for lost_item Signed-off-by: Séverine QUEUNE <severine.queune@bulac.fr> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23049 --- Comment #78 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 94002 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=94002&action=edit Bug 23049: Remove manual_debit as it's never called Signed-off-by: Séverine QUEUNE <severine.queune@bulac.fr> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23049 --- Comment #79 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 94003 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=94003&action=edit Bug 23049: Capitalise type passed to add_debit for `overdue` Signed-off-by: Séverine QUEUNE <severine.queune@bulac.fr> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23049 --- Comment #80 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 94004 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=94004&action=edit Bug 23049: Update 'N' to 'NEW_CARD' for consistency Signed-off-by: Séverine QUEUNE <severine.queune@bulac.fr> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23049 --- Comment #81 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 94005 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=94005&action=edit Bug 23049: Drop type lookup as it's now a foreign key Signed-off-by: Séverine QUEUNE <severine.queune@bulac.fr> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23049 --- Comment #82 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 94006 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=94006&action=edit Bug 23049: Update API Signed-off-by: Séverine QUEUNE <severine.queune@bulac.fr> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23049 --- Comment #83 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 94007 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=94007&action=edit Bug 23049: More thorough param checking -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23049 --- Comment #84 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 94008 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=94008&action=edit Bug 23064: (follow-up) VARCHAR(80) + ac -> account -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23049 --- Comment #85 from Kyle M Hall <kyle@bywatersolutions.com> --- (In reply to Marcel de Rooy from comment #61)
This is a quite fundamental one:
UPDATE accountlines SET debit_type_code = accounttype, accounttype = NULL WHERE accounttype IN (SELECT code from account_debit_types)
Hmm. I do not really like this at first glance (and second too ;). I would prefer one account type and not a separate debit code. If I would be scrolling through account lines, I think it is weird to have to look at two columns to determine the type of this transaction. But might understand this choice from the perspective to keep this patch set a bit smaller and narrow it down to the old MANUAL_INV stuff.
So, my problem actually goes a bit beyond this report too and is also about the design of accounts. We should have added an accounts type table in the first place. Now we are doing it for a subset of our account types. And I am wondering if this step will bring us closer to that goal of integrating these types or will just hinder us along the way. I am inclined to think that we should not separate the two now. And I understand that this creates new problems. The account types would be partially controlled by the debit codes list. So we could not (yet) put a FK on it. But it might be a better starting point for controlling the other account types?
Since this is an important design choice, I would suggest to discuss this on the dev list or within the QA team, or dev meeting? We need some more consensus on that decision.
I agree that having one set of values pulled from a dedicated table and having the other set of values pulled from Authorised Values is a less than preferable situation. I *do* like having separate fields for the debit and credit type because A) it makes it crystal clear if an account line is a credit or a debit and B) it allows for FK constraints. I think the solution is to follow this bug quickly with a second bug that moves credit types into a dedicated table as well. As long as those come together quickly ( definitely within the same release ), I believe this will be a big step forward! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23049 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |23805 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23805 [Bug 23805] Add a dedicated credit_types table -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23049 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |josef.moravec@gmail.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23049 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |tomascohen@gmail.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23049 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC|sandboxes@biblibre.com | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23049 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23049 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #93989|0 |1 is obsolete| | --- Comment #86 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 94073 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=94073&action=edit Bug 23049: Add debit_type * Add account_debit_types table * Add ac_debit_types_branches table * Add account_debit_types defaults * Add Koha::Account::DebitType and Koha::Account::DebitTypes * Prevent deletion of defaults * Migrate MANUAL_INV values * Remove MANUAL_INV references * Migrate accounttype values Signed-off-by: Séverine QUEUNE <severine.queune@bulac.fr> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23049 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #93990|0 |1 is obsolete| | --- Comment #87 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 94074 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=94074&action=edit Bug 23049: Add CHECK constraint to accountlines Signed-off-by: Séverine QUEUNE <severine.queune@bulac.fr> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23049 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #93991|0 |1 is obsolete| | --- Comment #88 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 94075 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=94075&action=edit Bug 23049: Account types configuration - Admin page Test plan: 1) Go to admin home, note there is new Debit types page in Accounting section 2) Go to any other admin page and confirm there is link to Debit types in the admin menu as well 3) Go to Debit types page 4) You should see a datatable listing existing debit types, ensure they are working as expected. 5) Try to create, edit and delete some debit types. Note: Some debit types cannot be deleted as they are needed for koha functionality. Signed-off-by: Séverine QUEUNE <severine.queune@bulac.fr> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23049 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #93992|0 |1 is obsolete| | --- Comment #89 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 94076 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=94076&action=edit Bug 23049: Filter out system types by default Test Plan 1) Navigate to the debit types management page added in previous patches 2) Note that system types are now filtered out by default 3) Click on the new unfilter button to include system types 4) Signoff Signed-off-by: Séverine QUEUNE <severine.queune@bulac.fr> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23049 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #93993|0 |1 is obsolete| | --- Comment #90 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 94077 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=94077&action=edit Bug 23049: Update maninvoice to reference debit types Test plan: 1) Naviage to a patron record and select the accounts > manual invoice tab 2) Add some manual invoices and confirm they are working as expected 3) Signoff Signed-off-by: Séverine QUEUNE <severine.queune@bulac.fr> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23049 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #93994|0 |1 is obsolete| | --- Comment #91 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 94078 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=94078&action=edit Bug 23049: Add tests Test plan: prove t/db_dependent/Koha/Account/DebitType.t prove t/db_dependent/Koha/Account/DebitTypes.t Signed-off-by: Séverine QUEUNE <severine.queune@bulac.fr> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23049 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #93995|0 |1 is obsolete| | --- Comment #92 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 94079 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=94079&action=edit Bug 23049: Update existing code to use debit_type * Update C4::Accounts::chargelostitem * Update C4::Accounts::manualinvoice * Update C4::Circulation::_FixOverduesOnReturn * Update C4::Circulation::_FixAccountForLostAndReturned * Update C4::Overdues::UpdateFine * Update C4::Overdues::GetFine * Update C4::Overdues::GetOverduesForBranch * Update Koha::Account->pay * Update Koha::Account->add_debit * Update Koha::Account->non_issues_charges * Update Koha::Account::Line->apply * Update Koha::Account::Line->adjust * Update controller scripts * Update reports scripts * Update tests Test Plan 1) Run the test suit and ensure everything still passes 2) Test reports/cash_register_stats still works 3) Test that adding manual invoices still works 4) Test that making payments still works 5) Test that lost item fee handling still works 6) Test that invoice printing still works 7) Test that the sco still works Signed-off-by: Séverine QUEUNE <severine.queune@bulac.fr> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23049 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #93996|0 |1 is obsolete| | --- Comment #93 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 94080 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=94080&action=edit Bug 23049: Update debit_type_code 'Res' to 'RESERVE' This patch updates all cases where debit_type_code was 'Res' to 'RESERVE' which is more informative and consistent with the new style guidelines. The patch also ensure all calls to add_debit with a type or 'reserve' now pass the capitalised code instead. Signed-off-by: Séverine QUEUNE <severine.queune@bulac.fr> Capitalise reserve -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23049 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #93997|0 |1 is obsolete| | --- Comment #94 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 94081 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=94081&action=edit Bug 23049: Capitalise type passed to add_debit for `rent` Signed-off-by: Séverine QUEUNE <severine.queune@bulac.fr> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23049 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #93998|0 |1 is obsolete| | --- Comment #95 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 94082 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=94082&action=edit Bug 23049: Update 'PF' to 'PROCESSING' for consistency Signed-off-by: Séverine QUEUNE <severine.queune@bulac.fr> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23049 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #93999|0 |1 is obsolete| | --- Comment #96 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 94083 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=94083&action=edit Bug 23049: Capitalise type passed to add_debit for `account` Signed-off-by: Séverine QUEUNE <severine.queune@bulac.fr> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23049 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #94000|0 |1 is obsolete| | --- Comment #97 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 94084 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=94084&action=edit Bug 23049: Update 'HE' to 'RESERVE_EXPIRED' for consistency This patch updates all cases where debit_type_code was 'HE' to 'RESERVE_EXPIRED' which is more informative and consistent with the new style guidelines. Signed-off-by: Séverine QUEUNE <severine.queune@bulac.fr> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23049 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #94001|0 |1 is obsolete| | --- Comment #98 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 94085 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=94085&action=edit Bug 23049: Capitalise type passed to add_debit for lost_item Signed-off-by: Séverine QUEUNE <severine.queune@bulac.fr> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23049 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #94002|0 |1 is obsolete| | --- Comment #99 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 94086 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=94086&action=edit Bug 23049: Remove manual_debit as it's never called Signed-off-by: Séverine QUEUNE <severine.queune@bulac.fr> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23049 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #94003|0 |1 is obsolete| | --- Comment #100 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 94087 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=94087&action=edit Bug 23049: Capitalise type passed to add_debit for `overdue` Signed-off-by: Séverine QUEUNE <severine.queune@bulac.fr> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23049 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #94004|0 |1 is obsolete| | --- Comment #101 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 94088 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=94088&action=edit Bug 23049: Update 'N' to 'NEW_CARD' for consistency Signed-off-by: Séverine QUEUNE <severine.queune@bulac.fr> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23049 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #94005|0 |1 is obsolete| | --- Comment #102 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 94089 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=94089&action=edit Bug 23049: Drop type lookup as it's now a foreign key Signed-off-by: Séverine QUEUNE <severine.queune@bulac.fr> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23049 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #94006|0 |1 is obsolete| | --- Comment #103 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 94090 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=94090&action=edit Bug 23049: Update API Signed-off-by: Séverine QUEUNE <severine.queune@bulac.fr> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23049 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #94007|0 |1 is obsolete| | --- Comment #104 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 94091 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=94091&action=edit Bug 23049: More thorough param checking -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23049 --- Comment #105 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 94092 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=94092&action=edit Bug 23049: (follow-up) VARCHAR(80) + ac -> account -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23049 --- Comment #106 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 94093 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=94093&action=edit Bug 23049: (follow-up) Correction to includes -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23049 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #94008|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23049 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #94073|0 |1 is obsolete| | --- Comment #107 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 94111 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=94111&action=edit Bug 23049: Add debit_type * Add account_debit_types table * Add ac_debit_types_branches table * Add account_debit_types defaults * Add Koha::Account::DebitType and Koha::Account::DebitTypes * Prevent deletion of defaults * Migrate MANUAL_INV values * Remove MANUAL_INV references * Migrate accounttype values Signed-off-by: Séverine QUEUNE <severine.queune@bulac.fr> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23049 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #94074|0 |1 is obsolete| | --- Comment #108 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 94112 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=94112&action=edit Bug 23049: Add CHECK constraint to accountlines Signed-off-by: Séverine QUEUNE <severine.queune@bulac.fr> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23049 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #94075|0 |1 is obsolete| | --- Comment #109 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 94113 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=94113&action=edit Bug 23049: Account types configuration - Admin page Test plan: 1) Go to admin home, note there is new Debit types page in Accounting section 2) Go to any other admin page and confirm there is link to Debit types in the admin menu as well 3) Go to Debit types page 4) You should see a datatable listing existing debit types, ensure they are working as expected. 5) Try to create, edit and delete some debit types. Note: Some debit types cannot be deleted as they are needed for koha functionality. Signed-off-by: Séverine QUEUNE <severine.queune@bulac.fr> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23049 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #94076|0 |1 is obsolete| | --- Comment #110 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 94114 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=94114&action=edit Bug 23049: Filter out system types by default Test Plan 1) Navigate to the debit types management page added in previous patches 2) Note that system types are now filtered out by default 3) Click on the new unfilter button to include system types 4) Signoff Signed-off-by: Séverine QUEUNE <severine.queune@bulac.fr> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23049 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #94077|0 |1 is obsolete| | --- Comment #111 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 94115 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=94115&action=edit Bug 23049: Update maninvoice to reference debit types Test plan: 1) Naviage to a patron record and select the accounts > manual invoice tab 2) Add some manual invoices and confirm they are working as expected 3) Signoff Signed-off-by: Séverine QUEUNE <severine.queune@bulac.fr> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23049 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #94078|0 |1 is obsolete| | --- Comment #112 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 94116 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=94116&action=edit Bug 23049: Add tests Test plan: prove t/db_dependent/Koha/Account/DebitType.t prove t/db_dependent/Koha/Account/DebitTypes.t Signed-off-by: Séverine QUEUNE <severine.queune@bulac.fr> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23049 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #94079|0 |1 is obsolete| | --- Comment #113 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 94117 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=94117&action=edit Bug 23049: Update existing code to use debit_type * Update C4::Accounts::chargelostitem * Update C4::Accounts::manualinvoice * Update C4::Circulation::_FixOverduesOnReturn * Update C4::Circulation::_FixAccountForLostAndReturned * Update C4::Overdues::UpdateFine * Update C4::Overdues::GetFine * Update C4::Overdues::GetOverduesForBranch * Update Koha::Account->pay * Update Koha::Account->add_debit * Update Koha::Account->non_issues_charges * Update Koha::Account::Line->apply * Update Koha::Account::Line->adjust * Update controller scripts * Update reports scripts * Update tests Test Plan 1) Run the test suit and ensure everything still passes 2) Test reports/cash_register_stats still works 3) Test that adding manual invoices still works 4) Test that making payments still works 5) Test that lost item fee handling still works 6) Test that invoice printing still works 7) Test that the sco still works Signed-off-by: Séverine QUEUNE <severine.queune@bulac.fr> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23049 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #94080|0 |1 is obsolete| | --- Comment #114 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 94118 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=94118&action=edit Bug 23049: Update debit_type_code 'Res' to 'RESERVE' This patch updates all cases where debit_type_code was 'Res' to 'RESERVE' which is more informative and consistent with the new style guidelines. The patch also ensure all calls to add_debit with a type or 'reserve' now pass the capitalised code instead. Signed-off-by: Séverine QUEUNE <severine.queune@bulac.fr> Capitalise reserve -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23049 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #94081|0 |1 is obsolete| | --- Comment #115 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 94119 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=94119&action=edit Bug 23049: Capitalise type passed to add_debit for `rent` Signed-off-by: Séverine QUEUNE <severine.queune@bulac.fr> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23049 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #94082|0 |1 is obsolete| | --- Comment #116 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 94120 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=94120&action=edit Bug 23049: Update 'PF' to 'PROCESSING' for consistency Signed-off-by: Séverine QUEUNE <severine.queune@bulac.fr> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23049 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #94083|0 |1 is obsolete| | --- Comment #117 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 94121 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=94121&action=edit Bug 23049: Capitalise type passed to add_debit for `account` Signed-off-by: Séverine QUEUNE <severine.queune@bulac.fr> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23049 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #94084|0 |1 is obsolete| | --- Comment #118 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 94122 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=94122&action=edit Bug 23049: Update 'HE' to 'RESERVE_EXPIRED' for consistency This patch updates all cases where debit_type_code was 'HE' to 'RESERVE_EXPIRED' which is more informative and consistent with the new style guidelines. Signed-off-by: Séverine QUEUNE <severine.queune@bulac.fr> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23049 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #94085|0 |1 is obsolete| | --- Comment #119 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 94123 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=94123&action=edit Bug 23049: Capitalise type passed to add_debit for lost_item Signed-off-by: Séverine QUEUNE <severine.queune@bulac.fr> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23049 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #94086|0 |1 is obsolete| | --- Comment #120 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 94124 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=94124&action=edit Bug 23049: Remove manual_debit as it's never called Signed-off-by: Séverine QUEUNE <severine.queune@bulac.fr> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23049 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #94087|0 |1 is obsolete| | --- Comment #121 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 94125 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=94125&action=edit Bug 23049: Capitalise type passed to add_debit for `overdue` Signed-off-by: Séverine QUEUNE <severine.queune@bulac.fr> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23049 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #94088|0 |1 is obsolete| | --- Comment #122 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 94126 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=94126&action=edit Bug 23049: Update 'N' to 'NEW_CARD' for consistency Signed-off-by: Séverine QUEUNE <severine.queune@bulac.fr> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23049 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #94089|0 |1 is obsolete| | --- Comment #123 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 94127 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=94127&action=edit Bug 23049: Drop type lookup as it's now a foreign key Signed-off-by: Séverine QUEUNE <severine.queune@bulac.fr> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23049 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #94090|0 |1 is obsolete| | --- Comment #124 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 94128 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=94128&action=edit Bug 23049: Update API Signed-off-by: Séverine QUEUNE <severine.queune@bulac.fr> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23049 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #94091|0 |1 is obsolete| | --- Comment #125 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 94129 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=94129&action=edit Bug 23049: More thorough param checking -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23049 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #94092|0 |1 is obsolete| | --- Comment #126 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 94130 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=94130&action=edit Bug 23049: (follow-up) VARCHAR(80) + ac -> account -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23049 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #94093|0 |1 is obsolete| | --- Comment #127 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 94131 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=94131&action=edit Bug 23049: (follow-up) Correction to includes -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23049 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #94111|0 |1 is obsolete| | --- Comment #128 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 94132 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=94132&action=edit Bug 23049: Add debit_type * Add account_debit_types table * Add ac_debit_types_branches table * Add account_debit_types defaults * Add Koha::Account::DebitType and Koha::Account::DebitTypes * Prevent deletion of defaults * Migrate MANUAL_INV values * Remove MANUAL_INV references * Migrate accounttype values Signed-off-by: Séverine QUEUNE <severine.queune@bulac.fr> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23049 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #94112|0 |1 is obsolete| | --- Comment #129 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 94133 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=94133&action=edit Bug 23049: Add CHECK constraint to accountlines Signed-off-by: Séverine QUEUNE <severine.queune@bulac.fr> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23049 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #94113|0 |1 is obsolete| | --- Comment #130 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 94134 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=94134&action=edit Bug 23049: Account types configuration - Admin page Test plan: 1) Go to admin home, note there is new Debit types page in Accounting section 2) Go to any other admin page and confirm there is link to Debit types in the admin menu as well 3) Go to Debit types page 4) You should see a datatable listing existing debit types, ensure they are working as expected. 5) Try to create, edit and delete some debit types. Note: Some debit types cannot be deleted as they are needed for koha functionality. Signed-off-by: Séverine QUEUNE <severine.queune@bulac.fr> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23049 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #94114|0 |1 is obsolete| | --- Comment #131 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 94135 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=94135&action=edit Bug 23049: Filter out system types by default Test Plan 1) Navigate to the debit types management page added in previous patches 2) Note that system types are now filtered out by default 3) Click on the new unfilter button to include system types 4) Signoff Signed-off-by: Séverine QUEUNE <severine.queune@bulac.fr> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23049 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #94115|0 |1 is obsolete| | --- Comment #132 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 94136 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=94136&action=edit Bug 23049: Update maninvoice to reference debit types Test plan: 1) Naviage to a patron record and select the accounts > manual invoice tab 2) Add some manual invoices and confirm they are working as expected 3) Signoff Signed-off-by: Séverine QUEUNE <severine.queune@bulac.fr> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23049 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #94116|0 |1 is obsolete| | --- Comment #133 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 94137 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=94137&action=edit Bug 23049: Add tests Test plan: prove t/db_dependent/Koha/Account/DebitType.t prove t/db_dependent/Koha/Account/DebitTypes.t Signed-off-by: Séverine QUEUNE <severine.queune@bulac.fr> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23049 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #94117|0 |1 is obsolete| | --- Comment #134 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 94138 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=94138&action=edit Bug 23049: Update existing code to use debit_type * Update C4::Accounts::chargelostitem * Update C4::Accounts::manualinvoice * Update C4::Circulation::_FixOverduesOnReturn * Update C4::Circulation::_FixAccountForLostAndReturned * Update C4::Overdues::UpdateFine * Update C4::Overdues::GetFine * Update C4::Overdues::GetOverduesForBranch * Update Koha::Account->pay * Update Koha::Account->add_debit * Update Koha::Account->non_issues_charges * Update Koha::Account::Line->apply * Update Koha::Account::Line->adjust * Update controller scripts * Update reports scripts * Update tests Test Plan 1) Run the test suit and ensure everything still passes 2) Test reports/cash_register_stats still works 3) Test that adding manual invoices still works 4) Test that making payments still works 5) Test that lost item fee handling still works 6) Test that invoice printing still works 7) Test that the sco still works Signed-off-by: Séverine QUEUNE <severine.queune@bulac.fr> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23049 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #94118|0 |1 is obsolete| | --- Comment #135 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 94139 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=94139&action=edit Bug 23049: Update debit_type_code 'Res' to 'RESERVE' This patch updates all cases where debit_type_code was 'Res' to 'RESERVE' which is more informative and consistent with the new style guidelines. The patch also ensure all calls to add_debit with a type or 'reserve' now pass the capitalised code instead. Signed-off-by: Séverine QUEUNE <severine.queune@bulac.fr> Capitalise reserve -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23049 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #94119|0 |1 is obsolete| | --- Comment #136 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 94140 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=94140&action=edit Bug 23049: Capitalise type passed to add_debit for `rent` Signed-off-by: Séverine QUEUNE <severine.queune@bulac.fr> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23049 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #94120|0 |1 is obsolete| | --- Comment #137 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 94141 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=94141&action=edit Bug 23049: Update 'PF' to 'PROCESSING' for consistency Signed-off-by: Séverine QUEUNE <severine.queune@bulac.fr> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23049 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #94121|0 |1 is obsolete| | --- Comment #138 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 94142 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=94142&action=edit Bug 23049: Capitalise type passed to add_debit for `account` Signed-off-by: Séverine QUEUNE <severine.queune@bulac.fr> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23049 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #94122|0 |1 is obsolete| | --- Comment #139 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 94143 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=94143&action=edit Bug 23049: Update 'HE' to 'RESERVE_EXPIRED' for consistency This patch updates all cases where debit_type_code was 'HE' to 'RESERVE_EXPIRED' which is more informative and consistent with the new style guidelines. Signed-off-by: Séverine QUEUNE <severine.queune@bulac.fr> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23049 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #94123|0 |1 is obsolete| | --- Comment #140 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 94144 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=94144&action=edit Bug 23049: Capitalise type passed to add_debit for lost_item Signed-off-by: Séverine QUEUNE <severine.queune@bulac.fr> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23049 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #94124|0 |1 is obsolete| | --- Comment #141 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 94145 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=94145&action=edit Bug 23049: Remove manual_debit as it's never called Signed-off-by: Séverine QUEUNE <severine.queune@bulac.fr> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23049 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #94125|0 |1 is obsolete| | --- Comment #142 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 94146 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=94146&action=edit Bug 23049: Capitalise type passed to add_debit for `overdue` Signed-off-by: Séverine QUEUNE <severine.queune@bulac.fr> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23049 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #94126|0 |1 is obsolete| | --- Comment #143 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 94147 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=94147&action=edit Bug 23049: Update 'N' to 'NEW_CARD' for consistency Signed-off-by: Séverine QUEUNE <severine.queune@bulac.fr> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23049 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #94127|0 |1 is obsolete| | --- Comment #144 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 94148 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=94148&action=edit Bug 23049: Drop type lookup as it's now a foreign key Signed-off-by: Séverine QUEUNE <severine.queune@bulac.fr> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23049 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #94128|0 |1 is obsolete| | --- Comment #145 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 94149 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=94149&action=edit Bug 23049: Update API Signed-off-by: Séverine QUEUNE <severine.queune@bulac.fr> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23049 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #94129|0 |1 is obsolete| | --- Comment #146 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 94150 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=94150&action=edit Bug 23049: More thorough param checking -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23049 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #94130|0 |1 is obsolete| | --- Comment #147 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 94151 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=94151&action=edit Bug 23049: (follow-up) VARCHAR(80) + ac -> account -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23049 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #94131|0 |1 is obsolete| | --- Comment #148 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 94152 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=94152&action=edit Bug 23049: (follow-up) Correction to includes -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23049 --- Comment #149 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 94165 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=94165&action=edit Bug 23049: (follow-up) Handle unexpected types -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23049 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA --- Comment #150 from Kyle M Hall <kyle@bywatersolutions.com> --- DEV atomic update: bug_23049_debit.perl DBD::mysql::db do failed: Table 'koha_kohadev.account_credit_types' doesn't exist [for Statement " INSERT IGNORE INTO account_credit_types ( code, description, can_be_added_manually, default_amount, is_system ) SELECT SUBSTR(accounttype, 1, 80), "Unexpected type found during upgrade", 1, NULL, 0 FROM accountlines WHERE amount > 0 "] at (eval 1419) line 109. Upgrade to XXX done (Bug 23049 - Add account debit_types) -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23049 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #94132|0 |1 is obsolete| | --- Comment #151 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 94307 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=94307&action=edit Bug 23049: Add debit_type * Add account_debit_types table * Add ac_debit_types_branches table * Add account_debit_types defaults * Add Koha::Account::DebitType and Koha::Account::DebitTypes * Prevent deletion of defaults * Migrate MANUAL_INV values * Remove MANUAL_INV references * Migrate accounttype values Signed-off-by: Séverine QUEUNE <severine.queune@bulac.fr> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23049 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #94133|0 |1 is obsolete| | --- Comment #152 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 94308 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=94308&action=edit Bug 23049: Add CHECK constraint to accountlines Signed-off-by: Séverine QUEUNE <severine.queune@bulac.fr> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23049 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #94134|0 |1 is obsolete| | --- Comment #153 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 94309 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=94309&action=edit Bug 23049: Account types configuration - Admin page Test plan: 1) Go to admin home, note there is new Debit types page in Accounting section 2) Go to any other admin page and confirm there is link to Debit types in the admin menu as well 3) Go to Debit types page 4) You should see a datatable listing existing debit types, ensure they are working as expected. 5) Try to create, edit and delete some debit types. Note: Some debit types cannot be deleted as they are needed for koha functionality. Signed-off-by: Séverine QUEUNE <severine.queune@bulac.fr> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23049 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #94135|0 |1 is obsolete| | --- Comment #154 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 94310 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=94310&action=edit Bug 23049: Filter out system types by default Test Plan 1) Navigate to the debit types management page added in previous patches 2) Note that system types are now filtered out by default 3) Click on the new unfilter button to include system types 4) Signoff Signed-off-by: Séverine QUEUNE <severine.queune@bulac.fr> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23049 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #94136|0 |1 is obsolete| | --- Comment #155 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 94311 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=94311&action=edit Bug 23049: Update maninvoice to reference debit types Test plan: 1) Naviage to a patron record and select the accounts > manual invoice tab 2) Add some manual invoices and confirm they are working as expected 3) Signoff Signed-off-by: Séverine QUEUNE <severine.queune@bulac.fr> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23049 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #94137|0 |1 is obsolete| | --- Comment #156 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 94312 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=94312&action=edit Bug 23049: Add tests Test plan: prove t/db_dependent/Koha/Account/DebitType.t prove t/db_dependent/Koha/Account/DebitTypes.t Signed-off-by: Séverine QUEUNE <severine.queune@bulac.fr> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23049 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #94138|0 |1 is obsolete| | --- Comment #157 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 94313 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=94313&action=edit Bug 23049: Update existing code to use debit_type * Update C4::Accounts::chargelostitem * Update C4::Accounts::manualinvoice * Update C4::Circulation::_FixOverduesOnReturn * Update C4::Circulation::_FixAccountForLostAndReturned * Update C4::Overdues::UpdateFine * Update C4::Overdues::GetFine * Update C4::Overdues::GetOverduesForBranch * Update Koha::Account->pay * Update Koha::Account->add_debit * Update Koha::Account->non_issues_charges * Update Koha::Account::Line->apply * Update Koha::Account::Line->adjust * Update controller scripts * Update reports scripts * Update tests Test Plan 1) Run the test suit and ensure everything still passes 2) Test reports/cash_register_stats still works 3) Test that adding manual invoices still works 4) Test that making payments still works 5) Test that lost item fee handling still works 6) Test that invoice printing still works 7) Test that the sco still works Signed-off-by: Séverine QUEUNE <severine.queune@bulac.fr> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23049 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #94139|0 |1 is obsolete| | --- Comment #158 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 94314 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=94314&action=edit Bug 23049: Update debit_type_code 'Res' to 'RESERVE' This patch updates all cases where debit_type_code was 'Res' to 'RESERVE' which is more informative and consistent with the new style guidelines. The patch also ensure all calls to add_debit with a type or 'reserve' now pass the capitalised code instead. Signed-off-by: Séverine QUEUNE <severine.queune@bulac.fr> Capitalise reserve -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23049 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #94140|0 |1 is obsolete| | --- Comment #159 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 94315 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=94315&action=edit Bug 23049: Capitalise type passed to add_debit for `rent` Signed-off-by: Séverine QUEUNE <severine.queune@bulac.fr> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23049 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #94141|0 |1 is obsolete| | --- Comment #160 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 94316 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=94316&action=edit Bug 23049: Update 'PF' to 'PROCESSING' for consistency Signed-off-by: Séverine QUEUNE <severine.queune@bulac.fr> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23049 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #94142|0 |1 is obsolete| | --- Comment #161 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 94317 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=94317&action=edit Bug 23049: Capitalise type passed to add_debit for `account` Signed-off-by: Séverine QUEUNE <severine.queune@bulac.fr> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23049 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #94143|0 |1 is obsolete| | --- Comment #162 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 94318 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=94318&action=edit Bug 23049: Update 'HE' to 'RESERVE_EXPIRED' for consistency This patch updates all cases where debit_type_code was 'HE' to 'RESERVE_EXPIRED' which is more informative and consistent with the new style guidelines. Signed-off-by: Séverine QUEUNE <severine.queune@bulac.fr> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23049 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #94144|0 |1 is obsolete| | --- Comment #163 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 94319 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=94319&action=edit Bug 23049: Capitalise type passed to add_debit for lost_item Signed-off-by: Séverine QUEUNE <severine.queune@bulac.fr> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23049 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #94145|0 |1 is obsolete| | --- Comment #164 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 94320 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=94320&action=edit Bug 23049: Remove manual_debit as it's never called Signed-off-by: Séverine QUEUNE <severine.queune@bulac.fr> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23049 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #94146|0 |1 is obsolete| | --- Comment #165 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 94321 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=94321&action=edit Bug 23049: Capitalise type passed to add_debit for `overdue` Signed-off-by: Séverine QUEUNE <severine.queune@bulac.fr> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23049 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #94147|0 |1 is obsolete| | --- Comment #166 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 94323 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=94323&action=edit Bug 23049: Update 'N' to 'NEW_CARD' for consistency Signed-off-by: Séverine QUEUNE <severine.queune@bulac.fr> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23049 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #94148|0 |1 is obsolete| | --- Comment #167 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 94324 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=94324&action=edit Bug 23049: Drop type lookup as it's now a foreign key Signed-off-by: Séverine QUEUNE <severine.queune@bulac.fr> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23049 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #94149|0 |1 is obsolete| | --- Comment #168 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 94325 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=94325&action=edit Bug 23049: Update API Signed-off-by: Séverine QUEUNE <severine.queune@bulac.fr> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23049 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #94150|0 |1 is obsolete| | --- Comment #169 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 94326 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=94326&action=edit Bug 23049: More thorough param checking -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23049 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #94151|0 |1 is obsolete| | --- Comment #170 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 94327 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=94327&action=edit Bug 23049: (follow-up) VARCHAR(80) + ac -> account -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23049 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #94152|0 |1 is obsolete| | --- Comment #171 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 94328 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=94328&action=edit Bug 23049: (follow-up) Correction to includes -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23049 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #94165|0 |1 is obsolete| | --- Comment #172 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 94329 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=94329&action=edit Bug 23049: (follow-up) Handle unexpected types -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23049 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #94307|0 |1 is obsolete| | --- Comment #173 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 94331 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=94331&action=edit Bug 23049: Add debit_type * Add account_debit_types table * Add ac_debit_types_branches table * Add account_debit_types defaults * Add Koha::Account::DebitType and Koha::Account::DebitTypes * Prevent deletion of defaults * Migrate MANUAL_INV values * Remove MANUAL_INV references * Migrate accounttype values Signed-off-by: Séverine QUEUNE <severine.queune@bulac.fr> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23049 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #94308|0 |1 is obsolete| | --- Comment #174 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 94332 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=94332&action=edit Bug 23049: Add CHECK constraint to accountlines Signed-off-by: Séverine QUEUNE <severine.queune@bulac.fr> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23049 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #94309|0 |1 is obsolete| | --- Comment #175 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 94333 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=94333&action=edit Bug 23049: Account types configuration - Admin page Test plan: 1) Go to admin home, note there is new Debit types page in Accounting section 2) Go to any other admin page and confirm there is link to Debit types in the admin menu as well 3) Go to Debit types page 4) You should see a datatable listing existing debit types, ensure they are working as expected. 5) Try to create, edit and delete some debit types. Note: Some debit types cannot be deleted as they are needed for koha functionality. Signed-off-by: Séverine QUEUNE <severine.queune@bulac.fr> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23049 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #94310|0 |1 is obsolete| | --- Comment #176 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 94334 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=94334&action=edit Bug 23049: Filter out system types by default Test Plan 1) Navigate to the debit types management page added in previous patches 2) Note that system types are now filtered out by default 3) Click on the new unfilter button to include system types 4) Signoff Signed-off-by: Séverine QUEUNE <severine.queune@bulac.fr> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23049 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #94311|0 |1 is obsolete| | --- Comment #177 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 94335 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=94335&action=edit Bug 23049: Update maninvoice to reference debit types Test plan: 1) Naviage to a patron record and select the accounts > manual invoice tab 2) Add some manual invoices and confirm they are working as expected 3) Signoff Signed-off-by: Séverine QUEUNE <severine.queune@bulac.fr> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23049 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #94312|0 |1 is obsolete| | --- Comment #178 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 94336 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=94336&action=edit Bug 23049: Add tests Test plan: prove t/db_dependent/Koha/Account/DebitType.t prove t/db_dependent/Koha/Account/DebitTypes.t Signed-off-by: Séverine QUEUNE <severine.queune@bulac.fr> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23049 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #94313|0 |1 is obsolete| | --- Comment #179 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 94337 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=94337&action=edit Bug 23049: Update existing code to use debit_type * Update C4::Accounts::chargelostitem * Update C4::Accounts::manualinvoice * Update C4::Circulation::_FixOverduesOnReturn * Update C4::Circulation::_FixAccountForLostAndReturned * Update C4::Overdues::UpdateFine * Update C4::Overdues::GetFine * Update C4::Overdues::GetOverduesForBranch * Update Koha::Account->pay * Update Koha::Account->add_debit * Update Koha::Account->non_issues_charges * Update Koha::Account::Line->apply * Update Koha::Account::Line->adjust * Update controller scripts * Update reports scripts * Update tests Test Plan 1) Run the test suit and ensure everything still passes 2) Test reports/cash_register_stats still works 3) Test that adding manual invoices still works 4) Test that making payments still works 5) Test that lost item fee handling still works 6) Test that invoice printing still works 7) Test that the sco still works Signed-off-by: Séverine QUEUNE <severine.queune@bulac.fr> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23049 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #94314|0 |1 is obsolete| | --- Comment #180 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 94338 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=94338&action=edit Bug 23049: Update debit_type_code 'Res' to 'RESERVE' This patch updates all cases where debit_type_code was 'Res' to 'RESERVE' which is more informative and consistent with the new style guidelines. The patch also ensure all calls to add_debit with a type or 'reserve' now pass the capitalised code instead. Signed-off-by: Séverine QUEUNE <severine.queune@bulac.fr> Capitalise reserve -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23049 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #94315|0 |1 is obsolete| | --- Comment #181 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 94339 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=94339&action=edit Bug 23049: Capitalise type passed to add_debit for `rent` Signed-off-by: Séverine QUEUNE <severine.queune@bulac.fr> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23049 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #94316|0 |1 is obsolete| | --- Comment #182 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 94340 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=94340&action=edit Bug 23049: Update 'PF' to 'PROCESSING' for consistency Signed-off-by: Séverine QUEUNE <severine.queune@bulac.fr> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23049 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #94317|0 |1 is obsolete| | --- Comment #183 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 94341 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=94341&action=edit Bug 23049: Capitalise type passed to add_debit for `account` Signed-off-by: Séverine QUEUNE <severine.queune@bulac.fr> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23049 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #94318|0 |1 is obsolete| | --- Comment #184 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 94342 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=94342&action=edit Bug 23049: Update 'HE' to 'RESERVE_EXPIRED' for consistency This patch updates all cases where debit_type_code was 'HE' to 'RESERVE_EXPIRED' which is more informative and consistent with the new style guidelines. Signed-off-by: Séverine QUEUNE <severine.queune@bulac.fr> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23049 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #94319|0 |1 is obsolete| | --- Comment #185 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 94343 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=94343&action=edit Bug 23049: Capitalise type passed to add_debit for lost_item Signed-off-by: Séverine QUEUNE <severine.queune@bulac.fr> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23049 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #94320|0 |1 is obsolete| | --- Comment #186 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 94344 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=94344&action=edit Bug 23049: Remove manual_debit as it's never called Signed-off-by: Séverine QUEUNE <severine.queune@bulac.fr> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23049 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #94321|0 |1 is obsolete| | --- Comment #187 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 94345 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=94345&action=edit Bug 23049: Capitalise type passed to add_debit for `overdue` Signed-off-by: Séverine QUEUNE <severine.queune@bulac.fr> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23049 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #94323|0 |1 is obsolete| | --- Comment #188 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 94346 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=94346&action=edit Bug 23049: Update 'N' to 'NEW_CARD' for consistency Signed-off-by: Séverine QUEUNE <severine.queune@bulac.fr> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23049 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #94324|0 |1 is obsolete| | --- Comment #189 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 94347 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=94347&action=edit Bug 23049: Drop type lookup as it's now a foreign key Signed-off-by: Séverine QUEUNE <severine.queune@bulac.fr> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23049 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #94325|0 |1 is obsolete| | --- Comment #190 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 94348 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=94348&action=edit Bug 23049: Update API Signed-off-by: Séverine QUEUNE <severine.queune@bulac.fr> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23049 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #94326|0 |1 is obsolete| | --- Comment #191 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 94349 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=94349&action=edit Bug 23049: More thorough param checking -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23049 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #94327|0 |1 is obsolete| | --- Comment #192 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 94350 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=94350&action=edit Bug 23049: (follow-up) VARCHAR(80) + ac -> account -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23049 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #94328|0 |1 is obsolete| | --- Comment #193 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 94351 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=94351&action=edit Bug 23049: (follow-up) Correction to includes -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23049 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #94329|0 |1 is obsolete| | --- Comment #194 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 94352 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=94352&action=edit Bug 23049: (follow-up) Handle unexpected types -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23049 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Signed Off --- Comment #195 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- (In reply to Kyle M Hall from comment #150)
DEV atomic update: bug_23049_debit.perl DBD::mysql::db do failed: Table 'koha_kohadev.account_credit_types' doesn't exist [for Statement " INSERT IGNORE INTO account_credit_types ( code, description, can_be_added_manually, default_amount, is_system ) SELECT SUBSTR(accounttype, 1, 80), "Unexpected type found during upgrade", 1, NULL, 0 FROM accountlines WHERE amount > 0 "] at (eval 1419) line 109. Upgrade to XXX done (Bug 23049 - Add account debit_types)
Rebase mistake.. should be better now :) -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23049 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- URL| |https://github.com/PTFS-Eur | |ope/koha/tree/bug_23049_inv -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23049 --- Comment #196 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- I've pushed a public branch to keep this rebased rather than throw yet more patches in here: https://github.com/PTFS-Europe/koha/tree/bug_23049_inv -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23049 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #94331|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23049 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #94332|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23049 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #94333|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23049 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #94334|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23049 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #94335|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23049 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #94336|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23049 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #94337|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23049 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #94338|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23049 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #94339|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23049 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #94340|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23049 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #94341|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23049 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #94342|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23049 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #94343|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23049 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #94344|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23049 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #94345|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23049 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #94346|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23049 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #94347|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23049 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #94348|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23049 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #94349|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23049 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #94350|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23049 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #94351|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23049 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #94352|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23049 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|m.de.rooy@rijksmuseum.nl |kyle@bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23049 --- Comment #197 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|m.de.rooy@rijksmuseum.nl |kyle@bywatersolutions.com Whats happening here ? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23049 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|kyle@bywatersolutions.com |m.de.rooy@rijksmuseum.nl -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23049 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |BLOCKED --- Comment #198 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- Still working on this one, Martin. Dont change QA contact without communication please, especially within such a short time frame. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23049 --- Comment #199 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- Tested on top of commit 480434bbf4a32750c5e47a3600b6a386d9732296 with your branch. Thanks for your hard work. I have noted comments 64 and 85 (thx Kyle). I made my preference clear, and continued on the current stand. Comments below are in order of time noted, not priority. User experience: During startup of admin/debit_types.pl I am seeing the 15 records for a short moment and end up with 3 records (filtered). It would be nice to see them all and only allow editing of the non-system types ? Same when saving a record (no blocker, but does not look good). When you do not want to show the records, do not fetch them at all? I saw that I now have a debit type F (Unexpected type found during upgrade). Obviously this had to do with old fines stuff. I understand that bug 22521 should have dealt with those, but somehow I still had such a record in accountlines. I am wondering if this will happen to more people and if we should anticipate on that by giving this F another description than unexpected ;) $dbh->do( qq{ INSERT IGNORE INTO account_debit_types ( code, description, can_be_added_manually, default_amount, is_system ) SELECT SUBSTR(accounttype, 1, 80), "Unexpected type found during upgrade", 1, NULL, 0 FROM accountlines WHERE amount > 0 } ); No need for the SUBSTR anymore. Please add a DISTINCT accounttype to this query to eliminate a lof of ignored inserts. And a question: If this type is unexpected, why do we enable Add manually ? sub UpdateFine You touch the following line, obviously only changing the type codes. But this is a condition for finding the overdues. Why type M in the first place, and why not yet another debit code? debit_type_code => [ 'OVERDUE', 'M' ], This needs fixing somehow but I agree that it should be done on its own report.. sub GetFine + WHERE debit_type_code LIKE 'OVERDUE' Shouldnt that be = ? flexability [a.o. :) ] No, not so flexible. sub adjust - my $account_type = $self->accounttype; [..] + my $debit_type_code = $self->debit_type_code; As I understand, the only allowed code is now overdue so debit. But this change does not look very solid to me. Hopefully, we will not adjust too much ;) Copier Fees Database: | Copier Fees | Copier Fees | 1 | 0.250000 | 0 | -INSERT INTO `authorised_values` (category, authorised_value, lib) VALUES ('MANUAL_INV','Copier Fees','.25'); git grep 'Copier Fees' installer/data/mysql/es-ES/optional/auth_val.sql:INSERT INTO `authorised_values` (category, authorised_value, lib) VALUES ('MANUAL_INV','Copier Fees','.25'); Oops, you should remove that one above. Since we previously installed Copier Fees as a manual invoice, I think you should do now too. So add it too account_debit_types.sql. And Copier Fees should also have a new code. Now the description and code are the same. It is inconsistent with the other debit types. You also changed lots of other codes, or not? Does this hold for some other debit types too that were formerly hardcoded? Stuff like sundry etc. ? Which actually is a horrible category.. + [%- SWITCH account.debit_type_code -%] + [%- CASE 'ACCOUNT' -%]Account creation fee + [%- CASE 'ACCOUNT_RENEW' -%]Account renewal fee + [%- CASE 'LOST' -%]Lost item + [%- CASE 'M' -%]Sundry + [%- CASE 'NEW_CARD' -%]New card + [%- CASE 'OVERDUE' -%]Fine + [%- CASE 'PROCESSING' -%]Lost item processing fee + [%- CASE 'RENT' -%]Rental fee + [%- CASE 'RENT_DAILY' -%]Daily rental fee + [%- CASE 'RENT_RENEW' -%]Renewal of rental item + [%- CASE 'RENT_DAILY_RENEW' -%]Rewewal of daily rental item + [%- CASE 'RESERVE' -%]Hold fee + [%- CASE 'RESERVE_EXPIRED' -%]Hold waiting too long + [%- CASE -%][% account.debit_type.description | html %] + [%- END -%] Note that koha-tmpl/intranet-tmpl/prog/en/includes/accounts.inc contains debit code M for sundry while account_debit_types.sql install M as Manual fee ! This is a BLOCKER. Please correct. At the credit side, I am seeing code FORW (and FOR and W and WO !) and having doubts about it, leaving it outside the scope for now.. Submitting another comment for the failing tests. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23049 --- Comment #200 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- [FAIL] t/db_dependent/Accounts.t [OK] t/db_dependent/Circulation.t [OK] t/db_dependent/Circulation/NoIssuesChargeGuarantees.t [OK] t/db_dependent/Circulation/Returns.t [OK] t/db_dependent/Circulation/issue.t [FAIL] t/db_dependent/Koha/Account.t [OK] t/db_dependent/Circulation/issue.t [OK] t/db_dependent/Koha/Account/DebitType.t [OK] t/db_dependent/Koha/Account/DebitTypes.t [FAIL] t/db_dependent/Koha/Account/Lines.t [OK] t/db_dependent/Koha/Patron.t [OK] t/db_dependent/Reserves.t [OK] t/db_dependent/SIP/Transaction.t [FAIL] t/db_dependent/api/v1/patrons_accounts.t t/db_dependent/api/v1/patrons_accounts.t .. DBD::mysql::st execute failed: Cannot add or update a child row: a foreign key constraint fails (`koha_master`.`accountlines`, CONSTRAINT `accountlines_ibfk_debit_type` FOREIGN KEY (`debit_type_code`) REFERENCES `account_debit_types` (`code`) ON UPDATE CASCADE) [for Statement "INSERT INTO `accountlines` ( `amount`, `amountoutstanding`, `borrowernumber`, `branchcode`, `date`, `debit_type_code`, `description`, `interface`, `manager_id`) VALUES ( ?, ?, ?, ?, NOW(), ?, ?, ?, ? )" with ParamValues: 0=50, 1=50, 2=2930, 3='wfeFkt_9', 4='N', 5='A description', 6='test', 7=2930] at /usr/share/perl5/DBIx/Class/Storage/DBI.pm line 1836. => Looks like the description is copied to the debit code ? The other tests stumble over: DBIx::Class::Storage::DBI::_dbh_execute(): CONSTRAINT `accountlines_check_type` failed for `koha_master`.`accountlines` at /usr/share/koha/Koha/Object.pm line 156 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23049 --- Comment #201 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- I saw that I still had data that conflicted with accounttype IS NOT NULL OR debit_type_code IS NOT NULL; But when I removed that data and ran Accounts.t again, it still fails. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23049 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|BLOCKED |Failed QA --- Comment #202 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- (In reply to Marcel de Rooy from comment #201)
I saw that I still had data that conflicted with accounttype IS NOT NULL OR debit_type_code IS NOT NULL;
But when I removed that data and ran Accounts.t again, it still fails.
So, we should make sure that at upgrade time we no longer have data that does not meet the new constraint. And still something wrong in the test ?? I leave it here for now. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23049 --- Comment #203 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- (In reply to Marcel de Rooy from comment #199)
Tested on top of commit 480434bbf4a32750c5e47a3600b6a386d9732296 with your branch.
Thanks for your hard work. I have noted comments 64 and 85 (thx Kyle). I made my preference clear, and continued on the current stand.
Comments below are in order of time noted, not priority.
User experience: During startup of admin/debit_types.pl I am seeing the 15 records for a short moment and end up with 3 records (filtered).
I agree, I not a fan of the "flash of unstyled content" effect this has but as yet I've not managed to work around it.. I'll have another try.
It would be nice to see them all and only allow editing of the non-system types ?
This is actually how I had it originally but updated the approach after feedback from Nick and Severine. Perhaps just sorted the system and archived ones to the bottom would be the best approach.. though I liked them being interleaved so one could see why you could not create a new type with a code that matched a system debit type.
Same when saving a record (no blocker, but does not look good). When you do not want to show the records, do not fetch them at all? I saw that I now have a debit type F (Unexpected type found during upgrade).
I will take a look at adding some additional handling into the db update to catch more cases of unrecognised types.. 'F' is obviously missed in certain cases in previous bugs and should be caught and converted to proper 'OVERDUE' types in my opinion. (I'm going to apply the patchset to a number of clones of customers from various versions and try to spot some patterns to see what other types may be being missed).
Obviously this had to do with old fines stuff. I understand that bug 22521 should have dealt with those, but somehow I still had such a record in accountlines. I am wondering if this will happen to more people and if we should anticipate on that by giving this F another description than unexpected ;)
$dbh->do( qq{ INSERT IGNORE INTO account_debit_types ( code, description, can_be_added_manually, default_amount, is_system ) SELECT SUBSTR(accounttype, 1, 80), "Unexpected type found during upgrade", 1, NULL, 0 FROM accountlines WHERE amount > 0 } ); No need for the SUBSTR anymore. Please add a DISTINCT accounttype to this query to eliminate a lof of ignored inserts.
Good catch, I'll update the update statement
And a question: If this type is unexpected, why do we enable Add manually ?
Also a good catch, thanks :).
sub UpdateFine You touch the following line, obviously only changing the type codes. But this is a condition for finding the overdues. Why type M in the first place, and why not yet another debit code? debit_type_code => [ 'OVERDUE', 'M' ], This needs fixing somehow but I agree that it should be done on its own report..
Totally agree, I've never been entirely sure why 'M' was in that list and have been slowly working towards removing it by clarifying it's use in bugs like this.
sub GetFine + WHERE debit_type_code LIKE 'OVERDUE' Shouldnt that be = ?
Also agree, I remember coming accross that one and thinking the same but forgetting to actually change it. Thanks :). (I think historically it comes from when fines were 'F' and 'FU' so it was a `LIKE "F%"`.)
flexability [a.o. :) ] No, not so flexible.
sub adjust - my $account_type = $self->accounttype; [..] + my $debit_type_code = $self->debit_type_code; As I understand, the only allowed code is now overdue so debit. But this change does not look very solid to me. Hopefully, we will not adjust too much ;)
Not sure I follow.. I'll double check the code but I believe it checks against 'OVERDUE' + 'UNRETURNED' (mix of type + status)
Copier Fees Database: | Copier Fees | Copier Fees | 1 | 0.250000 | 0 | -INSERT INTO `authorised_values` (category, authorised_value, lib) VALUES ('MANUAL_INV','Copier Fees','.25'); git grep 'Copier Fees' installer/data/mysql/es-ES/optional/auth_val.sql:INSERT INTO `authorised_values` (category, authorised_value, lib) VALUES ('MANUAL_INV','Copier Fees','.25'); Oops, you should remove that one above. Since we previously installed Copier Fees as a manual invoice, I think you should do now too. So add it too account_debit_types.sql. And Copier Fees should also have a new code. Now the description and code are the same. It is inconsistent with the other debit types. You also changed lots of other codes, or not?
I spotted that one this morning too, it certainly needs cleaning up here :).
Does this hold for some other debit types too that were formerly hardcoded? Stuff like sundry etc. ? Which actually is a horrible category.. + [%- SWITCH account.debit_type_code -%] + [%- CASE 'ACCOUNT' -%]Account creation fee + [%- CASE 'ACCOUNT_RENEW' -%]Account renewal fee + [%- CASE 'LOST' -%]Lost item + [%- CASE 'M' -%]Sundry + [%- CASE 'NEW_CARD' -%]New card + [%- CASE 'OVERDUE' -%]Fine + [%- CASE 'PROCESSING' -%]Lost item processing fee + [%- CASE 'RENT' -%]Rental fee + [%- CASE 'RENT_DAILY' -%]Daily rental fee + [%- CASE 'RENT_RENEW' -%]Renewal of rental item + [%- CASE 'RENT_DAILY_RENEW' -%]Rewewal of daily rental item + [%- CASE 'RESERVE' -%]Hold fee + [%- CASE 'RESERVE_EXPIRED' -%]Hold waiting too long + [%- CASE -%][% account.debit_type.description | html %] + [%- END -%] Note that koha-tmpl/intranet-tmpl/prog/en/includes/accounts.inc contains debit code M for sundry while account_debit_types.sql install M as Manual fee ! This is a BLOCKER. Please correct.
Good catch :)
At the credit side, I am seeing code FORW (and FOR and W and WO !) and having doubts about it, leaving it outside the scope for now..
I've submitted a bug for the conversion of credit type accounttypes now too which should take care of those.. Keeping them separate for now in an attempt to not drown QA in one superbug ;).
Submitting another comment for the failing tests.
Thanks :) -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23049 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Signed Off --- Comment #204 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Rebased and pushed addition QA followups to the github branch. I'm unable to replicate your test failures at the moment and have tried with 6 different datasets... sorry but I'm going to struggle to fix that one without being able to replicate it :(. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23049 --- Comment #205 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- (In reply to Martin Renvoize from comment #204)
Rebased and pushed addition QA followups to the github branch.
I'm unable to replicate your test failures at the moment and have tried with 6 different datasets... sorry but I'm going to struggle to fix that one without being able to replicate it :(.
OK Coming back to it soon -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23049 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |BLOCKED --- Comment #206 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- Revisiting -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23049 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|BLOCKED |Failed QA --- Comment #207 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- (Minor) If you archive a debit type, you should probably be no longer allowed to create a manual invoice with that type. (Minor) UPDATE accountlines SET accounttype = ? WHERE accounttype = ? => Hope you dont have too many clashes on the prefix here ;) The algorithm now just assumes that it should be the first one found. But hard to solve.. (Minor) UPDATE accountlines SET accounttype = 'MANUAL' WHERE accounttype = 'M' => How do you know that you are not moving sundry to manual fee here? Or is that okay (did we manage to get rid of it completely) ? (Major) t/db_dependent/api/v1/patrons_accounts.t not ok 5 - 200 OK # Failed test '200 OK' # at t/db_dependent/api/v1/patrons_accounts.t line 95. # got: '500' # expected: '200' not ok 6 - exact match for JSON Pointer "" # Failed test 'exact match for JSON Pointer ""' # at t/db_dependent/api/v1/patrons_accounts.t line 95. # Structures begin differing at: # $got->{balance} = Does not exist # $expected->{balance} = '100.01' not ok 11 - 200 OK # Failed test '200 OK' # at t/db_dependent/api/v1/patrons_accounts.t line 139. # got: '500' # expected: '200' not ok 12 - exact match for JSON Pointer "" # Failed test 'exact match for JSON Pointer ""' # at t/db_dependent/api/v1/patrons_accounts.t line 139. # Structures begin differing at: # $got->{outstanding_debits} = Does not exist # $expected->{outstanding_debits} = HASH(0x55d12cacfd80) => Some other tests with API calls do pass. (Major) Three other tests still fail. Related to new constraint on type check. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23049 --- Comment #208 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- (In reply to Marcel de Rooy from comment #207)
(Minor) If you archive a debit type, you should probably be no longer allowed to create a manual invoice with that type.
Corrected on the branch now.
(Minor) UPDATE accountlines SET accounttype = ? WHERE accounttype = ? => Hope you dont have too many clashes on the prefix here ;) The algorithm now just assumes that it should be the first one found. But hard to solve..
Agreed, I did think about this but when I looked at out customer base I couldn't find any cases in real life so i decided this was better than leaving the mess.
(Minor) UPDATE accountlines SET accounttype = 'MANUAL' WHERE accounttype = 'M' => How do you know that you are not moving sundry to manual fee here? Or is that okay (did we manage to get rid of it completely) ?
I believe this is resolved in previous bugs already. the two accounttypes were merged.
(Major) t/db_dependent/api/v1/patrons_accounts.t not ok 5 - 200 OK # Failed test '200 OK' # at t/db_dependent/api/v1/patrons_accounts.t line 95. # got: '500' # expected: '200' not ok 6 - exact match for JSON Pointer "" # Failed test 'exact match for JSON Pointer ""' # at t/db_dependent/api/v1/patrons_accounts.t line 95. # Structures begin differing at: # $got->{balance} = Does not exist # $expected->{balance} = '100.01' not ok 11 - 200 OK # Failed test '200 OK' # at t/db_dependent/api/v1/patrons_accounts.t line 139. # got: '500' # expected: '200' not ok 12 - exact match for JSON Pointer "" # Failed test 'exact match for JSON Pointer ""' # at t/db_dependent/api/v1/patrons_accounts.t line 139. # Structures begin differing at: # $got->{outstanding_debits} = Does not exist # $expected->{outstanding_debits} = HASH(0x55d12cacfd80) => Some other tests with API calls do pass.
Looking into this one at the moment.
(Major) Three other tests still fail. Related to new constraint on type check.
I can't replicate these failures still :( -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23049 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Signed Off --- Comment #209 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Fixed the API test now on the pushed branch. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23049 --- Comment #210 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- t/db_dependent/api/v1/patrons_accounts.t .. ok All tests successful. Hopeful ! Hang on -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23049 --- Comment #211 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- [OK] t/db_dependent/Koha/Account/Offsets.t | 7 ++++++- [OK] t/db_dependent/Members.t | 15 ++++++++------ t/db_dependent/Accounts.t (Wstat: 65280 Tests: 31 Failed: 10) Failed tests: 12-14, 17-22, 31 # Failed test 'The 'charges' attribute should be correctly filled (bug 17836)' # at t/db_dependent/ILSDI_Services.t line 230. # got: '0.00' # expected: '10.00' # Looks like you failed 1 test of 5. t/db_dependent/ILSDI_Services.t .. 3/9 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23049 --- Comment #212 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- Koha/Schema/Result/AccountDebitType.pm | 12 ++++- Koha/Schema/Result/Accountline.pm | 6 +-- admin/debit_types.pl | 43 +++++++++------- => Imo we should not mix schema changes with regular codebase changes. Do we have a rule for that? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23049 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA --- Comment #213 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- [FAIL] t/db_dependent/Accounts.t [FAIL] t/db_dependent/Koha/Account.t [FAIL] t/db_dependent/Koha/Account/Lines.t [1] Comment on the first failure in Accounts.t ok 14 - outstanding_debits returns a list of Koha::Account::Line objects in list context DBD::mysql::st execute failed: CONSTRAINT `accountlines_check_type` failed for `koha_master`.`accountlines` [for Statement "INSERT INTO `accountlines` ( `amountoutstanding`, `borrowernumber`, `interface`) VALUES ( ?, ?, ? )" with ParamValues: 0=-2, 1=102, 2='commandline'] at /usr/share/perl5/DBIx/Class/Storage/DBI.pm line 1836. # Looks like you planned 22 tests but ran 14. not ok 2 - outstanding_debits() tests # Failed test 'outstanding_debits() tests' # at t/db_dependent/Koha/Account.t line 113. Coming from: # create a pathological credit with amountoutstanding > 0 (BZ 14591) Koha::Account::Line->new({ borrowernumber => $patron_4->id, amount => -3, amountoutstanding => 3, interface => 'commandline' })->store(); => This statement obviously fails, since we do not set accounttype or debittype. I am inclined to think that we should start without the type check constraint. Pretty sure that we did not catch all occurrences in code where an account line is added without one of the two types. [2] The first problem in Lines.t t/db_dependent/Koha/Account/Lines.t .. 8/9 DBD::mysql::st execute failed: CONSTRAINT `accountlines_check_type` failed for `koha_master`.`accountlines` [for Statement "INSERT INTO `accountlines` ( `amount`, `amountoutstanding`, `borrowernumber`, `interface`) VALUES ( ?, ?, ?, ? )" with ParamValues: 0=10, 1=10, 2='115', 3='commandline'] at /usr/share/perl5/DBIx/Class/Storage/DBI.pm line 1836. # No tests run! # Failed test 'No tests run for subtest "void() tests"' # at t/db_dependent/Koha/Account/Lines.t line 591. What about: my $line1 = Koha::Account::Line->new({ borrowernumber => $borrower->borrowernumber, amount => 10, amountoutstanding => 10, interface => 'commandline' })->store(); Here another insert that should fail because of the new constraint. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23049 --- Comment #214 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- And I am still a bit worried that we did not complete resolve the amount<0 or amount=0 cases in the upgrade.. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23049 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Signed Off --- Comment #215 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- OK, I've now grepped the codebase for INSERT INTO `accountlines` Koha::Account::Line->new Koha::Schema::Result::Accountline->new and corrected all cases.. I confident in saying these were only used in tests at this point and those have now been corrected. Putting back to Signed off.. thanks for all your efforts Marcel.. I think we might finally be there now :) -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23049 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA --- Comment #216 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- DBD::mysql::st execute failed: CONSTRAINT `accountlines_check_type` failed for `koha_master`.`accountlines` [for Statement "INSERT INTO accountlines ( borrowernumber, amountoutstanding, date, description, interface, accounttype, debit_type_code ) VALUES ( ?, ?, (select date_sub(CURRENT_DATE, INTERVAL ? DAY) ), ?, ?, ?, ? )" with ParamValues: 0='117', 1=undef, 2=6, 3='purge_zero_balance_fees should delete NULL balance fees with date after threshold day', 4='commandline', 5=undef, 6=undef] at t/db_dependent/Accounts.t line 143. 5 and 6 are both undef BOOM -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23049 --- Comment #217 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- t/db_dependent/Accounts.t (Wstat: 768 Tests: 33 Failed: 3) Failed tests: 12-14 t/db_dependent/ILSDI_Services.t .. ok All tests successful. t/db_dependent/Koha/Account/Offsets.t .. ok All tests successful. t/db_dependent/Members.t .. ok All tests successful. prove t/db_dependent/Koha/Account.t t/db_dependent/Koha/Account.t .. 3/11 DBD::mysql::st execute failed: Cannot add or update a child row: a foreign key constraint fails (`koha_master`.`accountlines`, CONSTRAINT `accountlines_ibfk_debit_type` FOREIGN KEY (`debit_type_code`) REFERENCES `account_debit_types` (`code`) ON UPDATE CASCADE) [for Statement "INSERT INTO `accountlines` ( `amount`, `amountoutstanding`, `borrowernumber`, `branchcode`, `date`, `debit_type_code`, `description`, `interface`, `issue_id`, `itemnumber`, `manager_id`, `note`, `payment_type`) VALUES ( ?, ?, ?, ?, NOW(), ?, ?, ?, ?, ?, ?, ?, ? )" with ParamValues: 0=5, 1=5, 2=169, 3='X8YVxu', 4='failure', 5='type validation failure', 6='commandline', 7=undef, 8=undef, 9=169, 10='this should fail anyway', 11=undef] at /usr/share/perl5/DBIx/Class/Storage/DBI.pm line 1836. t/db_dependent/Koha/Account.t .. ok All tests successful. => Please check for me if this exception was intended (it seems). Should we catch the warning instead ? t/db_dependent/Koha/Account/Lines.t .. ok All tests successful. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23049 --- Comment #218 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Hmm, The exception is intended and is in fact caught and rethrown within Koha::Account.pm.. not sure why it results in noise in the test though.. it should be hidden by the 'throws_ok' call.. Investigating. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23049 --- Comment #219 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- (In reply to Martin Renvoize from comment #218)
Hmm,
The exception is intended and is in fact caught and rethrown within Koha::Account.pm.. not sure why it results in noise in the test though.. it should be hidden by the 'throws_ok' call..
Investigating.
my $schema = Koha::Database->new->schema; $schema->storage->dbh->{PrintError} = 0; Might do it in Koha/Account.t Please try -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23049 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Signed Off --- Comment #220 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Pushed again... I managed at least to get this all running under MariaDB 10.2.27 and see the check constraint in action myself. Turns out one cannot use a ternary the way I tried to inside an execute call. All tests should now pass, the warning should now be suppressed and the db update now also handles the '0' case. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23049 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |BLOCKED --- Comment #221 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- (In reply to Martin Renvoize from comment #220)
I managed at least to get this all running under MariaDB 10.2.27 and see the check constraint in action myself. Turns out one cannot use a ternary the way I tried to inside an execute call.
I think that you are mistaken. You used the wrong conditions in the ternary: - $sth->execute($borrower->borrowernumber, $data->{amount}, $data->{days_ago}, $data->{description}, 'commandline', $data->{amount} > 0 ? 'W' : undef, $data->{amount} >= 0 ? undef : 'OVERDUE' ); + $sth->execute($borrower->borrowernumber, $data->{amount}, $data->{days_ago}, $data->{description}, 'commandline', $data->{amount} < 0 ? 'W' : undef, $data->{amount} < 0 ? undef : 'OVERDUE' ); This should work. Note the differences between >0 and <0 but also between >=0 and <0. Credit is negative ! I would suggest to remove patch 34. Coming back here soon. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23049 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Medium patch Status|BLOCKED |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23049 --- Comment #222 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- Created attachment 94648 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=94648&action=edit Bug 23049: [LAST PATCH ONLY] (QA follow-up) Catch '0' case debits Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23049 --- Comment #223 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- (In reply to Marcel de Rooy from comment #221)
(In reply to Martin Renvoize from comment #220)
I managed at least to get this all running under MariaDB 10.2.27 and see the check constraint in action myself. Turns out one cannot use a ternary the way I tried to inside an execute call.
I think that you are mistaken. You used the wrong conditions in the ternary:
- $sth->execute($borrower->borrowernumber, $data->{amount}, $data->{days_ago}, $data->{description}, 'commandline', $data->{amount} > 0 ? 'W' : undef, $data->{amount} >= 0 ? undef : 'OVERDUE' ); + $sth->execute($borrower->borrowernumber, $data->{amount}, $data->{days_ago}, $data->{description}, 'commandline', $data->{amount} < 0 ? 'W' : undef, $data->{amount} < 0 ? undef : 'OVERDUE' );
This should work. Note the differences between >0 and <0 but also between
=0 and <0. Credit is negative ! I would suggest to remove patch 34. Coming back here soon.
We keep the new code. Only adjust the commit message. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23049 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |19.11.00 released in| | Status|Passed QA |Pushed to master -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23049 --- Comment #224 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Nice work! Pushed to master for 19.11.00 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23049 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Text to go in the| |This patchset moves the release notes| |'MANUAL_INV' authorized | |values into their own table | |and adds in interface into | |the administration pages to | |allow addition and | |modification of such | |account types. | | | |This serves | |as the foundation for | |enhancing the accounts | |system and leads to clearer | |code and more consistent | |data via database-level | |constraints. | | | |Note: Reports | |will need to be updated to | |look in the new | |debit_type_code field for | |accountlines of type | |'debit' and use the updated | |coded values. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23049 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks|23354 | Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23354 [Bug 23354] Add a 'Pay' screen to allow anonymous payments in a POS fashion -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23049 --- Comment #225 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- *** Bug 23636 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23049 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks|23636 | Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23636 [Bug 23636] MANUAL_INV values should be able to have a code, a description, and a price. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23049 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also|https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=17702 | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23049 Michal Denar <black23@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |black23@gmail.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23049 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks|17702 | Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17702 [Bug 17702] Create configuration for account types -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23049 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Text to go in the|This patchset moves the |This patchset moves the release notes|'MANUAL_INV' authorized |`MANUAL_INV` authorized |values into their own table |values into their own table |and adds in interface into |and adds an interface into |the administration pages to |the administration pages to |allow addition and |allow the addition and |modification of such |modification of such |account types. |account types. | | |This serves |This serves |as the foundation for |as the foundation for |enhancing the accounts |enhancing the accounts |system and leads to clearer |system and leads to clearer |code and more consistent |code and more consistent |data via database-level |data via database-level |constraints. |constraints. | | |Note: Reports |**Reports |will need to be updated to |note**: Reports will need |look in the new |to be updated to look in |debit_type_code field for |the new debit_type_code |accountlines of type |field for accountlines of |'debit' and use the updated |type 'debit' and use the |coded values. |updated coded values. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23049 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |24241 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24241 [Bug 24241] Description missing for subpermission manage_accounts -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23049 Andrew Fuerste-Henry <andrew@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |andrew@bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23049 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |24316 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24316 [Bug 24316] Fix non-English web installers by removing obsolete authorised value MANUAL_INV -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23049 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |lucas@bywatersolutions.com --- Comment #226 from Lucas Gass <lucas@bywatersolutions.com> --- enchancment wont be backported to 19.05.x series -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23049 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to master |Pushed to stable -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23049 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to stable |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23049 Bug 23049 depends on bug 23321, which changed state. Bug 23321 Summary: Add 'cash registers' to the accounts system https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23321 What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to master |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23049 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |24542 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24542 [Bug 24542] Checkout page - Can't locate object method "search" via package "Koha::Account::DebitTypes" -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23049 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |24532 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24532 [Bug 24532] Some account types are converted to debits when they shouldn't be -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23049 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |25010 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25010 [Bug 25010] Fix typo in debit type description: rewewal -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23049 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |26398 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26398 [Bug 26398] Credit type on creating a manual credit is not translatable -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23049 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks|23046 | Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23046 [Bug 23046] Add tax handling to accounts -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org