[Bug 6696] New: New category button broken when no categories defined
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6696 Bug #: 6696 Summary: New category button broken when no categories defined Classification: Unclassified Change sponsored?: --- Product: Koha Version: master Platform: All URL: /cgi-bin/koha/admin/categorie.pl OS/Version: All Status: NEW Severity: minor Priority: P5 Component: Templates AssignedTo: oleonard@myacpl.org ReportedBy: katrin.fischer@bsz-bw.de QAContact: koha-bugs@lists.koha-community.org Created attachment 4923 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=4923 screenshot The button 'New category' appears only as link when I have no patron categories defined in administration. Once I have defined a first category the buttons shows up as normal. -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6696 --- Comment #1 from Katrin Fischer <katrin.fischer@bsz-bw.de> 2011-08-10 11:23:19 UTC --- javascript error probably related to the problem: table.tBodies[0] is undefined error source line: [Bei diesem Fehler anhalten] (function($){$.extend({tablesorter:new...g Zebra widget",time);}}});})(jQuery);... -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6696 --- Comment #2 from Owen Leonard <oleonard@myacpl.org> 2011-08-10 15:47:58 UTC --- Created attachment 4949 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=4949 Proposed fix The javascript tablesorter will trigger an error if we try to apply it to a table with no <tbody>. That error prevented the YUI button script to complete properly, hence the broken button. This patch hides the table in cases where there are no categories and displays an error message instead. -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6696 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Priority|P5 |PATCH-Sent Status|NEW |ASSIGNED Patch Status|--- |Needs Signoff -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6696 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #4949|0 |1 is obsolete| | --- Comment #3 from Katrin Fischer <katrin.fischer@bsz-bw.de> 2011-08-11 17:45:48 UTC --- Created attachment 4971 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=4971 [SIGNED-OFF] Fix for Bug 6696, New category button broken when no categories defined The javascript tablesorter will trigger an error if we try to apply it to a table with no <tbody>. That error prevented the YUI button script to complete properly, hence the broken button. This patch hides the table in cases where there are no categories and displays an error message instead. Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de> - Deleted all patron categories and checked button was broken - Applied patch and checked again - button shows up - Nice: There is a note now that you have to create categories -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6696 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch Status|Needs Signoff |Signed Off -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6696 Ian Walls <ian.walls@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |ian.walls@bywatersolutions. | |com Patch Status|Signed Off |Passed QA --- Comment #4 from Ian Walls <ian.walls@bywatersolutions.com> 2011-08-27 13:24:37 UTC --- Template only change, easy to read, marking as Passed QA -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6696 Chris Cormack <chris@bigballofwax.co.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |chris@bigballofwax.co.nz Patch Status|Passed QA |Patch Pushed --- Comment #5 from Chris Cormack <chris@bigballofwax.co.nz> 2011-08-28 07:40:28 UTC --- Pushed please test -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6696 --- Comment #6 from Chris Nighswonger <cnighswonger@foundations.edu> 2011-10-26 18:02:23 UTC --- The fix for this bug was published in the 3.4.5 release. If you were the reporter of this bug, please take time to verify the fix and update the status of this bug report accordingly. If the bug is fixed to your satisfaction, please close this report. -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6696 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Priority|PATCH-Sent (DO NOT USE) |P5 - low Status|Pushed to Master |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org