[Bug 35467] New: NewsLog should be renamed
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35467 Bug ID: 35467 Summary: NewsLog should be renamed Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Architecture, internals, and plumbing Assignee: koha-bugs@lists.koha-community.org Reporter: lucas@bywatersolutions.com QA Contact: testopia@bugs.koha-community.org The system preference NewsLog should indicate that it logs changes from news, html customizations, or pages. It should be renamed accordingly. AdditionalContentsLog ? -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35467 --- Comment #1 from Andrew Fuerste-Henry <andrew@bywatersolutions.com> --- Created attachment 185119 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=185119&action=edit Bug 35467: Rename NewsLog system preference to AdditionalContent To test: 1 - confirm whether or not NewsLog is enabled on your system 2 - apply patch, updatedatabase, restart_all 3 - search system preferences, confirm you now have AdditionalContentLog rather than NewsLog and that the new description is accurate 4 - confitm AdditionalContentLog shows the value you previously had for NewsLog 5 - go to Tools > Log Viewer 6 - confirm the checkbox here is labeled "Additional Content", that it correctly reflects the syspref value, and that it links to the syspref 7 - with AdditionalContentLog enabled, created/edit/delete news, HTML customizations, and pages. confirm they log 8 - with AdditionalContentLog disabled, created/edit/delete news, HTML customizations, and pages. confirm they don't log -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35467 --- Comment #2 from Andrew Fuerste-Henry <andrew@bywatersolutions.com> --- Created attachment 185120 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=185120&action=edit Bug 35467: atomicupdate to change NewsLog to AdditionalContentLog -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35467 Andrew Fuerste-Henry <andrew@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |andrew@bywatersolutions.com Assignee|koha-bugs@lists.koha-commun |andrew@bywatersolutions.com |ity.org | Status|NEW |Needs Signoff -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35467 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off Patch complexity|--- |Small patch -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35467 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #185119|0 |1 is obsolete| | Attachment #185120|0 |1 is obsolete| | --- Comment #3 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 185122 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=185122&action=edit Bug 35467: Rename NewsLog system preference to AdditionalContent To test: 1 - confirm whether or not NewsLog is enabled on your system 2 - apply patch, updatedatabase, restart_all 3 - search system preferences, confirm you now have AdditionalContentLog rather than NewsLog and that the new description is accurate 4 - confitm AdditionalContentLog shows the value you previously had for NewsLog 5 - go to Tools > Log Viewer 6 - confirm the checkbox here is labeled "Additional Content", that it correctly reflects the syspref value, and that it links to the syspref 7 - with AdditionalContentLog enabled, created/edit/delete news, HTML customizations, and pages. confirm they log 8 - with AdditionalContentLog disabled, created/edit/delete news, HTML customizations, and pages. confirm they don't log Signed-off-by: Owen Leonard <oleonard@myacpl.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35467 --- Comment #4 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 185123 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=185123&action=edit Bug 35467: atomicupdate to change NewsLog to AdditionalContentLog Signed-off-by: Owen Leonard <oleonard@myacpl.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35467 Pedro Amorim <pedro.amorim@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia@bugs.koha-communit |pedro.amorim@openfifth.co.u |y.org |k CC| |pedro.amorim@openfifth.co.u | |k -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35467 Pedro Amorim <pedro.amorim@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA --- Comment #5 from Pedro Amorim <pedro.amorim@openfifth.co.uk> --- 1) QA script not happy: [FAIL] installer/data/mysql/atomicupdate/bug_35467_AdditionalContentLog.pl FAIL file_permissions File must have the exec flag 2) Typo here: changes to HTML customizations, news entires, news entries* 3) Minor observation: Should we call it AdditionalContentsLog (plural)? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35467 --- Comment #6 from Andrew Fuerste-Henry <andrew@bywatersolutions.com> --- (In reply to Pedro Amorim from comment #5)
3) Minor observation: Should we call it AdditionalContentsLog (plural)?
I wondered about this. In the staff interface, if you go to any of these tools the page says "Additional content: Pages" or "Additional content: News." So I followed that, but don't have strong feelings. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35467 Andrew Fuerste-Henry <andrew@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35467 Andrew Fuerste-Henry <andrew@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #185123|0 |1 is obsolete| | --- Comment #7 from Andrew Fuerste-Henry <andrew@bywatersolutions.com> --- Created attachment 185127 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=185127&action=edit Bug 35467: atomicupdate to rename NewsLog to AdditionalContentLog Now executable! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35467 --- Comment #8 from Andrew Fuerste-Henry <andrew@bywatersolutions.com> --- Created attachment 185128 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=185128&action=edit Bug 35467L (QA followup): Spelling correction in syspref -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35467 Andrew Fuerste-Henry <andrew@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #185123|1 |0 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35467 Pedro Amorim <pedro.amorim@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35467 Pedro Amorim <pedro.amorim@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35467 Pedro Amorim <pedro.amorim@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #185122|0 |1 is obsolete| | --- Comment #9 from Pedro Amorim <pedro.amorim@openfifth.co.uk> --- Created attachment 185129 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=185129&action=edit Bug 35467: Rename NewsLog system preference to AdditionalContent To test: 1 - confirm whether or not NewsLog is enabled on your system 2 - apply patch, updatedatabase, restart_all 3 - search system preferences, confirm you now have AdditionalContentLog rather than NewsLog and that the new description is accurate 4 - confitm AdditionalContentLog shows the value you previously had for NewsLog 5 - go to Tools > Log Viewer 6 - confirm the checkbox here is labeled "Additional Content", that it correctly reflects the syspref value, and that it links to the syspref 7 - with AdditionalContentLog enabled, created/edit/delete news, HTML customizations, and pages. confirm they log 8 - with AdditionalContentLog disabled, created/edit/delete news, HTML customizations, and pages. confirm they don't log Signed-off-by: Owen Leonard <oleonard@myacpl.org> Signed-off-by: Pedro Amorim <pedro.amorim@openfifth.co.uk> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35467 Pedro Amorim <pedro.amorim@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #185123|0 |1 is obsolete| | --- Comment #10 from Pedro Amorim <pedro.amorim@openfifth.co.uk> --- Created attachment 185130 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=185130&action=edit Bug 35467: atomicupdate to change NewsLog to AdditionalContentLog Signed-off-by: Owen Leonard <oleonard@myacpl.org> Signed-off-by: Pedro Amorim <pedro.amorim@openfifth.co.uk> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35467 Pedro Amorim <pedro.amorim@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #185127|0 |1 is obsolete| | --- Comment #11 from Pedro Amorim <pedro.amorim@openfifth.co.uk> --- Created attachment 185131 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=185131&action=edit Bug 35467: atomicupdate to rename NewsLog to AdditionalContentLog Now executable! Signed-off-by: Pedro Amorim <pedro.amorim@openfifth.co.uk> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35467 --- Comment #12 from Pedro Amorim <pedro.amorim@openfifth.co.uk> --- Created attachment 185132 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=185132&action=edit Bug 35467: (QA follow-up): Spelling correction in syspref PA amendded: Commit title Signed-off-by: Pedro Amorim <pedro.amorim@openfifth.co.uk> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35467 Pedro Amorim <pedro.amorim@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #185128|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35467 Lucas Gass (lukeg) <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to main Version(s)| |25.11.00 released in| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35467 --- Comment #13 from Lucas Gass (lukeg) <lucas@bywatersolutions.com> --- Nice work everyone! Pushed to main for 25.11 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35467 Paul Derscheid <paul.derscheid@lmscloud.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)|25.11.00 |25.11.00,25.05.04 released in| | Status|Pushed to main |Pushed to stable -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35467 --- Comment #14 from Paul Derscheid <paul.derscheid@lmscloud.de> --- Nice work everyone! Pushed to 25.05.x -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35467 Baptiste Wojtkowski (bwoj) <baptiste.wojtkowski@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |baptiste.wojtkowski@biblibr | |e.com Status|Pushed to stable |Needs documenting --- Comment #15 from Baptiste Wojtkowski (bwoj) <baptiste.wojtkowski@biblibre.com> --- Change in Syspref, not backported in LTS -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35467 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Text to go in the| |This renames the NewsLog release notes| |system preference to | |AdditionalContentLog, | |including the description. CC| |david@davidnind.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35467 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Text to go in the|This renames the NewsLog |This renames the NewsLog release notes|system preference to |system preference to |AdditionalContentLog, |AdditionalContentLog, and |including the description. |updates the system | |preference description and | |the log viewer tool. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35467 Caroline Cyr La Rose <caroline.cyr-la-rose@inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |caroline.cyr-la-rose@inlibr | |o.com Documentation| |https://gitlab.com/koha-com submission| |munity/koha-manual/-/merge_ | |requests/1139 Status|Needs documenting |RESOLVED Documentation| |Caroline Cyr La Rose contact| | Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org