[Bug 38108] New: Staff interface holdings table - table navigation only shows when "Show filters" is selected
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38108 Bug ID: 38108 Summary: Staff interface holdings table - table navigation only shows when "Show filters" is selected Change sponsored?: --- Product: Koha Version: Main Hardware: All OS: All Status: NEW Severity: major Priority: P5 - low Component: Staff interface Assignee: koha-bugs@lists.koha-community.org Reporter: david@davidnind.com QA Contact: testopia@bugs.koha-community.org CC: gmcharlt@gmail.com In current main (October 2024), the holdings table for a record in the staff interface does not show the standard DataTable navigation elements until "Show filters" is clicked. I think that the standard table navigation elements should be shown by default. To replicate: 1. Go to a record in the staff interface with multiple items (for example record 146, The definitive guide to Catalyst : writing extensible, scalable, and maintainable Perl-based Web applications <staffinterfaceurl>/cgi-bin/koha/catalogue/detail.pl?biblionumber=146). 2. In the holdings table section, note that you have to click on "Show filters" for the standard table navigation elements to display: Showing 1 to 4 of 4 entries ------------------------------------- Show 20 entries First Previous Next Last Search: _______ Clear filter .... Other notes: 1. Behavour for previous versions - note that before 24.05.00 and bug 33568, all items were shown without any pagination, even for hundreds of items: . 24.05.00: navigation only shown once "Show filters" is clicked . 23.11.06: partial table navigation "Showing 1 of 1 entries Search______ Clear filter" . 23.05.14: the same as 23.11.06 2. Bug 33568 - Use the REST API to display items on the staff biblio detail view: totally rewrote the display of the items table -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38108 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |38071 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38071 [Bug 38071] "Clear filter" on catalogue details page always disabled -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38108 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=38110 -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38108 Jonathan Druart <jonathan.druart@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart@gmail.com --- Comment #1 from Jonathan Druart <jonathan.druart@gmail.com> --- It is displayed if needed. The idea here is to keep the UI as minimal as possible. If length is 20 and you have <= 20 items, the pagination won't be displayed. If you have more, the pagination will be displayed even if "Show filters" is not clicked. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38108 Aleisha Amohia <aleisha@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |aleisha@catalyst.net.nz Depends on| |33568 --- Comment #2 from Aleisha Amohia <aleisha@catalyst.net.nz> --- It would be good to have the option to show filters by default - this setting could be stored in localStorage (similar to how Koha can remember to show checkouts by default) Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33568 [Bug 33568] Use the REST API to display items on the staff biblio detail view -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38108 Lucas Gass (lukeg) <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |lucas@bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38108 --- Comment #3 from Lucas Gass (lukeg) <lucas@bywatersolutions.com> --- (In reply to Jonathan Druart from comment #1)
It is displayed if needed.
The idea here is to keep the UI as minimal as possible. If length is 20 and you have <= 20 items, the pagination won't be displayed.
If you have more, the pagination will be displayed even if "Show filters" is not clicked.
They display if needed, I don't think we need anything else. What would be the use case for showing filters that don't do anything? -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38108 Lucas Gass (lukeg) <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Severity|major |normal -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38108 Bug 38108 depends on bug 38071, which changed state. Bug 38071 Summary: "Clear filter" on catalogue details page always disabled https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38071 What |Removed |Added ---------------------------------------------------------------------------- Status|Needs documenting |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38108 Miranda Nero <mnero@oslri.net> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |mnero@oslri.net --- Comment #4 from Miranda Nero <mnero@oslri.net> --- We have our items set to display 50 items per page to get as many libraries showing on the first page as possible without bogging down the loading time. We use the search box to narrow down those items quickly by barcode, for example, rather than visually search to find it. We would appreciate the option to have the filters show by default even when there are less than 50 items. It makes sense for the page navigation to only show when useful, but the search box should be separate. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38108 --- Comment #5 from Jonathan Druart <jonathan.druart@gmail.com> --- (In reply to Miranda Nero from comment #4)
We have our items set to display 50 items per page to get as many libraries showing on the first page as possible without bogging down the loading time. We use the search box to narrow down those items quickly by barcode, for example, rather than visually search to find it. We would appreciate the option to have the filters show by default even when there are less than 50 items. It makes sense for the page navigation to only show when useful, but the search box should be separate.
How do you do that? In Javascript? The main "Search" box is displayed (in last in 'main') even if all items are displayed. Which version are you using? -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38108 --- Comment #6 from Miranda Nero <mnero@oslri.net> --- (In reply to Jonathan Druart from comment #5)
How do you do that? In Javascript?
The main "Search" box is displayed (in last in 'main') even if all items are displayed. Which version are you using?
We changed the "Default display length" to 50 in the otherholdings_table settings. The search box only shows for us on bibs that have 51+ items in the other holdings tab. I just did a little more testing and narrowed down the behavior even more to this happening if your logged in library does not have any holdings. When the "Other holdings" tab is the only tab showing and there are 50 or fewer items in it, the search bar disappears. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38108 --- Comment #7 from Jonathan Druart <jonathan.druart@gmail.com> --- (In reply to Miranda Nero from comment #6)
(In reply to Jonathan Druart from comment #5)
How do you do that? In Javascript?
The main "Search" box is displayed (in last in 'main') even if all items are displayed. Which version are you using?
We changed the "Default display length" to 50 in the otherholdings_table settings. The search box only shows for us on bibs that have 51+ items in the other holdings tab. I just did a little more testing and narrowed down the behavior even more to this happening if your logged in library does not have any holdings. When the "Other holdings" tab is the only tab showing and there are 50 or fewer items in it, the search bar disappears.
Seems to work for me on "main": https://snipboard.io/AW8Jgo.jpg -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38108 --- Comment #8 from Miranda Nero <mnero@oslri.net> --- (In reply to Jonathan Druart from comment #7)
(In reply to Miranda Nero from comment #6)
(In reply to Jonathan Druart from comment #5)
How do you do that? In Javascript?
The main "Search" box is displayed (in last in 'main') even if all items are displayed. Which version are you using?
We changed the "Default display length" to 50 in the otherholdings_table settings. The search box only shows for us on bibs that have 51+ items in the other holdings tab. I just did a little more testing and narrowed down the behavior even more to this happening if your logged in library does not have any holdings. When the "Other holdings" tab is the only tab showing and there are 50 or fewer items in it, the search bar disappears.
Seems to work for me on "main": https://snipboard.io/AW8Jgo.jpg
Strange - here's what I see on our main site: https://snipboard.io/L7M9Ch.jpg -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38108 Lisette Scheer <lisette@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |lisette@bywatersolutions.co | |m --- Comment #9 from Lisette Scheer <lisette@bywatersolutions.com> --- This also means the "clear filter" link doesn't show, though there is an x in the search box that works to clear it, it only shows while you're in the box or hovering. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38108 Rebecca Coert <rcoert@arlingtonva.us> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |rcoert@arlingtonva.us -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38108 --- Comment #10 from Lucas Gass (lukeg) <lucas@bywatersolutions.com> --- Whatever is done here should be done on top of Bug 37334. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38108 Lucas Gass (lukeg) <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |37334 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37334 [Bug 37334] Cannot filter holdings table by status -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38108 --- Comment #11 from Lucas Gass (lukeg) <lucas@bywatersolutions.com> --- (In reply to Aleisha Amohia from comment #2)
It would be good to have the option to show filters by default - this setting could be stored in localStorage (similar to how Koha can remember to show checkouts by default)
In this case I think I prefer a system preference because localStorage would be cleared on logout which might be annoying for staff. The 'checkouss by default' that you mention is controlled via sys pref, AlwaysLoadCheckoutsTable -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38108 Lucas Gass (lukeg) <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Trivial patch Status|NEW |Needs Signoff -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38108 --- Comment #12 from Lucas Gass (lukeg) <lucas@bywatersolutions.com> --- Created attachment 178638 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=178638&action=edit Bug 38108: Add system preference AlwaysShowHoldingsTableFilters -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38108 --- Comment #13 from Lucas Gass (lukeg) <lucas@bywatersolutions.com> --- Created attachment 178639 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=178639&action=edit Bug 38108: Add ability to show/hide table filters via system preference To test: 1. APPLY PATCH, updatedatabase, restart_all 2. Search for the 'AlwaysShowHoldingsTableFilters' system preference. It should be set to 'Don't'. 3. Without changing the system preference, go to a record detail page. 4. The filters should not show by default. 5. Make sure that toggling the Hide filters/Show filters button still work as expected. 6. Set 'AlwaysShowHoldingsTableFilters' to 'Do'. 7. Now the filters should show by default when you load the table. 8. Make sure that toggling the Hide filters/Show filters button still work as expected. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38108 Lucas Gass (lukeg) <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Text to go in the| |This patch adds a new release notes| |system preference called | |'AlwaysShowHoldingsTableFil | |ters'. This system | |preference allows staff to | |control the behavior of the | |filters on the items detail | |page. It can be set to | |either always show the | |filters by default or to | |never show the filters by | |default. Assignee|koha-bugs@lists.koha-commun |lucas@bywatersolutions.com |ity.org | -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38108 Lucas Gass (lukeg) <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on|37334 | Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37334 [Bug 37334] Cannot filter holdings table by status -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38108 --- Comment #14 from Lucas Gass (lukeg) <lucas@bywatersolutions.com> --- (In reply to Lucas Gass (lukeg) from comment #10)
Whatever is done here should be done on top of Bug 37334.
This doesn't conflict with Bug 37334 so I am removing that dependency. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38108 Andrew Fuerste-Henry <andrew@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38108 Andrew Fuerste-Henry <andrew@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #178638|0 |1 is obsolete| | --- Comment #15 from Andrew Fuerste-Henry <andrew@bywatersolutions.com> --- Created attachment 178691 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=178691&action=edit Bug 38108: Add system preference AlwaysShowHoldingsTableFilters Signed-off-by: Rebecca Coert <rcoert@arlingtonva.us> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38108 Andrew Fuerste-Henry <andrew@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #178639|0 |1 is obsolete| | --- Comment #16 from Andrew Fuerste-Henry <andrew@bywatersolutions.com> --- Created attachment 178692 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=178692&action=edit Bug 38108: Add ability to show/hide table filters via system preference To test: 1. APPLY PATCH, updatedatabase, restart_all 2. Search for the 'AlwaysShowHoldingsTableFilters' system preference. It should be set to 'Don't'. 3. Without changing the system preference, go to a record detail page. 4. The filters should not show by default. 5. Make sure that toggling the Hide filters/Show filters button still work as expected. 6. Set 'AlwaysShowHoldingsTableFilters' to 'Do'. 7. Now the filters should show by default when you load the table. 8. Make sure that toggling the Hide filters/Show filters button still work as expected. Signed-off-by: Rebecca Coert <rcoert@arlingtonva.us> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38108 Emily Lamancusa (emlam) <emily.lamancusa@montgomerycountymd.gov> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #178691|0 |1 is obsolete| | --- Comment #17 from Emily Lamancusa (emlam) <emily.lamancusa@montgomerycountymd.gov> --- Created attachment 178694 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=178694&action=edit Bug 38108: Add system preference AlwaysShowHoldingsTableFilters Signed-off-by: Rebecca Coert <rcoert@arlingtonva.us> Signed-off-by: Emily Lamancusa <emily.lamancusa@montgomerycountymd.gov> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38108 Emily Lamancusa (emlam) <emily.lamancusa@montgomerycountymd.gov> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #178692|0 |1 is obsolete| | --- Comment #18 from Emily Lamancusa (emlam) <emily.lamancusa@montgomerycountymd.gov> --- Created attachment 178695 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=178695&action=edit Bug 38108: Add ability to show/hide table filters via system preference To test: 1. APPLY PATCH, updatedatabase, restart_all 2. Search for the 'AlwaysShowHoldingsTableFilters' system preference. It should be set to 'Don't'. 3. Without changing the system preference, go to a record detail page. 4. The filters should not show by default. 5. Make sure that toggling the Hide filters/Show filters button still work as expected. 6. Set 'AlwaysShowHoldingsTableFilters' to 'Do'. 7. Now the filters should show by default when you load the table. 8. Make sure that toggling the Hide filters/Show filters button still work as expected. Signed-off-by: Rebecca Coert <rcoert@arlingtonva.us> Signed-off-by: Emily Lamancusa <emily.lamancusa@montgomerycountymd.gov> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38108 --- Comment #19 from Emily Lamancusa (emlam) <emily.lamancusa@montgomerycountymd.gov> --- Created attachment 178696 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=178696&action=edit Bug 38108: (QA follow-up) Use say_success in dbrev Use say_success instead of say when outputting a line that the system preference was added successfully Signed-off-by: Emily Lamancusa <emily.lamancusa@montgomerycountymd.gov> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38108 Emily Lamancusa (emlam) <emily.lamancusa@montgomerycountymd.gov> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA QA Contact|testopia@bugs.koha-communit |emily.lamancusa@montgomeryc |y.org |ountymd.gov CC| |emily.lamancusa@montgomeryc | |ountymd.gov --- Comment #20 from Emily Lamancusa (emlam) <emily.lamancusa@montgomerycountymd.gov> --- Nice quality of life enhancement, thanks Lucas! Passing QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38108 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |oleonard@myacpl.org --- Comment #21 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- It's kind of funny that first we remove the pref to show the filters and now we reintroduce it again? Can't find the old bug now, but this rings a bell.. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38108 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords| |release-notes-needed Summary|Staff interface holdings |Make display of table |table - table navigation |filters in staff interface |only shows when "Show |holdings table configurable |filters" is selected | --- Comment #22 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Amended system preference description to mention staff interface. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38108 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |25.05.00 released in| | Status|Passed QA |Pushed to main -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38108 --- Comment #23 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Pushed for 25.05! Well done everyone, thank you! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38108 Lucas Gass (lukeg) <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords| |rel_24_11_candidate -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38108 --- Comment #24 from Lucas Gass (lukeg) <lucas@bywatersolutions.com> --- Can this be backported to 24.11? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38108 --- Comment #25 from Jonathan Druart <jonathan.druart@gmail.com> --- (In reply to Katrin Fischer from comment #21)
It's kind of funny that first we remove the pref to show the filters and now we reintroduce it again? Can't find the old bug now, but this rings a bell..
I don't remember we had a syspref. (In reply to Lucas Gass (lukeg) from comment #11)
(In reply to Aleisha Amohia from comment #2)
It would be good to have the option to show filters by default - this setting could be stored in localStorage (similar to how Koha can remember to show checkouts by default)
In this case I think I prefer a system preference because localStorage would be cleared on logout which might be annoying for staff.
But I don't understand the use case here, could you explain please? If there is no pagination does it still makes sense to display them?
The 'checkouss by default' that you mention is controlled via sys pref, AlwaysLoadCheckoutsTable
Controlled by a syspref for the default behaviour, but then is stored in localStorage (The "Always show checkouts automatically" checkbox). -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38108 --- Comment #26 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- I think the question was about displaying the filters and if you set "per page" to a higher value, you will still want to see the filters, not necessarily the paging. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38108 --- Comment #27 from Lucas Gass (lukeg) <lucas@bywatersolutions.com> ---
But I don't understand the use case here, could you explain please?
If there is no pagination does it still makes sense to display them?
I think pagination controls is only part of this. From my understanding staff wanted to have the ability to see the other controls by default. The filters for home/holding library, collection, etc without having to click 'Show filters' each time. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38108 --- Comment #28 from Jonathan Druart <jonathan.druart@gmail.com> --- Created attachment 179171 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=179171&action=edit Bug 38108: Add Cypress tests -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38108 Jonathan Druart <jonathan.druart@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords| |additional_work_needed Status|Pushed to main |Passed QA --- Comment #29 from Jonathan Druart <jonathan.druart@gmail.com> --- I am really not convinced by this change. And don't think it should be driven by a syspref. However any changes made to this page must be covered by tests please. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38108 --- Comment #30 from Jonathan Druart <jonathan.druart@gmail.com> --- (In reply to Jonathan Druart from comment #29)
I am really not convinced by this change. And don't think it should be driven by a syspref.
However any changes made to this page must be covered by tests please.
Tests that I have added in the previous patch, I am not asking anything (for this time :D). -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38108 Jonathan Druart <jonathan.druart@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |39315 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39315 [Bug 39315] Missing tests for KohaTable search on coded value's description -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38108 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords|additional_work_needed, | |release-notes-needed | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38108 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to main -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38108 --- Comment #31 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Pushed for 25.05! Well done everyone, thank you! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38108 Paul Derscheid <paul.derscheid@lmscloud.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)|25.05.00 |25.05.00,24.11.03 released in| | Status|Pushed to main |Pushed to stable -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38108 --- Comment #32 from Paul Derscheid <paul.derscheid@lmscloud.de> --- Nice work everyone! Pushed to 24.11.x for 24.11.03 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38108 Paul Derscheid <paul.derscheid@lmscloud.de> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |paul.derscheid@lmscloud.de Keywords|rel_24_11_candidate | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38108 Bug 38108 depends on bug 33568, which changed state. Bug 33568 Summary: Use the REST API to display items on the staff biblio detail view https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33568 What |Removed |Added ---------------------------------------------------------------------------- Status|Needs documenting |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38108 Caroline Cyr La Rose <caroline.cyr-la-rose@inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Documentation| |https://gitlab.com/koha-com submission| |munity/koha-manual/-/merge_ | |requests/1140 Documentation| |Caroline Cyr La Rose contact| | CC| |caroline.cyr-la-rose@inlibr | |o.com --- Comment #33 from Caroline Cyr La Rose <caroline.cyr-la-rose@inlibro.com> --- Added to the manual. Can we assume this is not going to make it to 24.05? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38108 --- Comment #34 from Lucas Gass (lukeg) <lucas@bywatersolutions.com> --- (In reply to Caroline Cyr La Rose from comment #33)
Added to the manual. Can we assume this is not going to make it to 24.05?
Yes, safe to assume that. As of the 26.05 cycle 24.05 is no longer supported. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38108 Caroline Cyr La Rose <caroline.cyr-la-rose@inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to stable |Needs documenting -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38108 Caroline Cyr La Rose <caroline.cyr-la-rose@inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |FIXED Status|Needs documenting |RESOLVED --- Comment #35 from Caroline Cyr La Rose <caroline.cyr-la-rose@inlibro.com> --- Just fiddling with the statuses to get my docs point :P -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org