[Bug 24953] New: Minor corrections to hold ratios report sidebar
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24953 Bug ID: 24953 Summary: Minor corrections to hold ratios report sidebar Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: ASSIGNED Severity: enhancement Priority: P5 - low Component: Hold requests Assignee: oleonard@myacpl.org Reporter: oleonard@myacpl.org QA Contact: testopia@bugs.koha-community.org CC: gmcharlt@gmail.com, katrin.fischer@bsz-bw.de, koha-bugs@lists.koha-community.org, nick@bywatersolutions.com, testopia@bugs.koha-community.org Depends on: 24907 Addressing this comment from Bug 24907: (In reply to Katrin Fischer from comment #4)
Wondering if on a separate report we could reformat the checkboxes: [checkbox] Text
And maybe: Include instead of included?
Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24907 [Bug 24907] Optionally exclude suspended holds from holds ratio report -- You are receiving this mail because: You are on the CC list for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24953 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff Patch complexity|--- |Small patch -- You are receiving this mail because: You are on the CC list for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24953 --- Comment #1 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 101435 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=101435&action=edit Bug 24953: Minor corrections to hold ratios report sidebar This patch makes some minor corrections to the sidebar form on the hold ratios report page: - Correct markup errors - Change the text of labels from "included" to "include" - Move checkboxes to the left of labels To test, apply the patch and rebuild the staff client CSS (https://wiki.koha-community.org/wiki/Working_with_SCSS_in_the_OPAC_and_staff...) - Go to Circulation -> Hold ratios - In the sidebar, confirm that the labels "Include ordered" and "Include suspended" appear to the right of their associated checkboxes. - Validate the source of the page. There should be no errors. -- You are receiving this mail because: You are on the CC list for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24953 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. You are on the CC list for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24953 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #101435|0 |1 is obsolete| | --- Comment #2 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 101455 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=101455&action=edit Bug 24953: Minor corrections to hold ratios report sidebar This patch makes some minor corrections to the sidebar form on the hold ratios report page: - Correct markup errors - Change the text of labels from "included" to "include" - Move checkboxes to the left of labels To test, apply the patch and rebuild the staff client CSS (https://wiki.koha-community.org/wiki/Working_with_SCSS_in_the_OPAC_and_staff...) - Go to Circulation -> Hold ratios - In the sidebar, confirm that the labels "Include ordered" and "Include suspended" appear to the right of their associated checkboxes. - Validate the source of the page. There should be no errors. -- You are receiving this mail because: You are on the CC list for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24953 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA --- Comment #3 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Treating this as a follow-up for bug 24907 - thx Owen! Btw... the filters on the funds page look a bit ill-formatted too ;) http://localhost:8081/cgi-bin/koha/admin/aqbudgets.pl -- You are receiving this mail because: You are on the CC list for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24953 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |20.05.00 released in| | Status|Passed QA |Pushed to master -- You are receiving this mail because: You are on the CC list for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24953 --- Comment #4 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Nice work everyone! Pushed to master for 20.05 -- You are receiving this mail because: You are watching all bug changes. You are on the CC list for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24953 Joy Nelson <joy@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |joy@bywatersolutions.com --- Comment #5 from Joy Nelson <joy@bywatersolutions.com> --- enhancement not backported to 19.11.x -- You are receiving this mail because: You are watching all bug changes. You are on the CC list for the bug.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org