[Bug 13362] New: translate script creates dirs on update
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13362 Bug ID: 13362 Summary: translate script creates dirs on update Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: I18N/L10N Assignee: koha-bugs@lists.koha-community.org Reporter: bgkriegel@gmail.com QA Contact: testopia@bugs.koha-community.org CC: frederic@tamil.fr If you do "./translate update xx-YY', it creates an unnecessary dir 'xx-YY' on opac and staff themes -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13362 --- Comment #1 from Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> --- Created attachment 34019 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=34019&action=edit Bug 13362: translate script creates dirs on update A dir creation was uncommented (by me), the effect is create a lang dir on 'update', which is no needed. To test: 1) Update translation files for a uninstalled language (cd misc/translator; ./translate update xx-YY) 2) Check new dirs koha-tmpl/opac-tmpl/bootstrap/xx-YY/ koha-tmpl/intranet-tmpl/prog/xx-YY/ koha-tmpl/intranet-tmpl/prog/en/modules/help/xx-YY/ 3) Clean all git clean -f -d 4) Apply the patch 5) Repeat 1) (i.e. update) 6) Check no new dirs this time -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13362 Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff Patch complexity|--- |Trivial patch Assignee|koha-bugs@lists.koha-commun |bgkriegel@gmail.com |ity.org | Severity|normal |minor -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13362 Frédéric Demians <frederic@tamil.fr> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13362 Frédéric Demians <frederic@tamil.fr> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #34019|0 |1 is obsolete| | --- Comment #2 from Frédéric Demians <frederic@tamil.fr> --- Created attachment 34020 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=34020&action=edit Bug 13362: translate script creates dirs on update A dir creation was uncommented (by me), the effect is create a lang dir on 'update', which is no needed. To test: 1) Update translation files for a uninstalled language (cd misc/translator; ./translate update xx-YY) 2) Check new dirs koha-tmpl/opac-tmpl/bootstrap/xx-YY/ koha-tmpl/intranet-tmpl/prog/xx-YY/ koha-tmpl/intranet-tmpl/prog/en/modules/help/xx-YY/ 3) Clean all git clean -f -d 4) Apply the patch 5) Repeat 1) (i.e. update) 6) Check no new dirs this time Signed-off-by: Frederic Demians <f.demians@tamil.fr> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13362 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13362 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #34020|0 |1 is obsolete| | --- Comment #3 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 34378 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=34378&action=edit [PASSED QA] Bug 13362: translate script creates dirs on update A dir creation was uncommented (by me), the effect is create a lang dir on 'update', which is no needed. To test: 1) Update translation files for a uninstalled language (cd misc/translator; ./translate update xx-YY) 2) Check new dirs koha-tmpl/opac-tmpl/bootstrap/xx-YY/ koha-tmpl/intranet-tmpl/prog/xx-YY/ koha-tmpl/intranet-tmpl/prog/en/modules/help/xx-YY/ 3) Clean all git clean -f -d 4) Apply the patch 5) Repeat 1) (i.e. update) 6) Check no new dirs this time Signed-off-by: Frederic Demians <f.demians@tamil.fr> Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de> Tested according to test plan, works as described. Passes tests and QA script. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13362 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |tomascohen@gmail.com --- Comment #4 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Patch pushed to master. Good catch Bernardo! -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13362 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master Version|master |3.18 -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13362 Chris Cormack <chris@bigballofwax.co.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |Pushed to Stable CC| |chris@bigballofwax.co.nz --- Comment #5 from Chris Cormack <chris@bigballofwax.co.nz> --- Pushed to 3.18.x will be in 3.18.2 -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon@bugs.koha-community.org